From 913e2b35ca5ab900242aafab8bd697cb51e1a833 Mon Sep 17 00:00:00 2001 From: Good627 <193092356+Good627@users.noreply.github.com> Date: Tue, 17 Nov 2026 09:54:30 +0200 Subject: [PATCH 1/8] feat: add /eden cycle leaderboard, lifetime stats, and cycle conclusion notices --- .../edenmod/textures/gui/cycle/medal_1.png | Bin 0 -> 5115 bytes .../edenmod/textures/gui/cycle/medal_2.png | Bin 0 -> 3296 bytes .../edenmod/textures/gui/cycle/medal_3.png | Bin 0 -> 5049 bytes src/tel/eden/mod/EdenModClient.java | 237 ++++++- .../eden/mod/chat/DiscordChatFormatter.java | 45 ++ src/tel/eden/mod/gui/BridgeConfigScreen.java | 4 + src/tel/eden/mod/gui/EdenMenuScreen.java | 11 +- .../eden/mod/gui/PromotionCycleScreen.java | 651 ++++++++++++++++++ .../eden/mod/net/BridgeWebSocketClient.java | 113 +++ .../eden/mod/net/CycleLeaderboardData.java | 135 ++++ src/tel/eden/mod/net/OutboundPolicy.java | 2 +- .../eden/mod/net/CycleLeaderboardTest.java | 100 +++ test/tel/eden/mod/net/OutboundPolicyTest.java | 2 +- 13 files changed, 1289 insertions(+), 11 deletions(-) create mode 100644 resources/assets/edenmod/textures/gui/cycle/medal_1.png create mode 100644 resources/assets/edenmod/textures/gui/cycle/medal_2.png create mode 100644 resources/assets/edenmod/textures/gui/cycle/medal_3.png create mode 100644 src/tel/eden/mod/gui/PromotionCycleScreen.java create mode 100644 src/tel/eden/mod/net/CycleLeaderboardData.java create mode 100644 test/tel/eden/mod/net/CycleLeaderboardTest.java diff --git a/resources/assets/edenmod/textures/gui/cycle/medal_1.png b/resources/assets/edenmod/textures/gui/cycle/medal_1.png new file mode 100644 index 0000000000000000000000000000000000000000..8b90fcc43f9b9e9e164c629e55b846cf38811751 GIT binary patch literal 5115 zcmV1dt?^gp8O>CS2Bg22ms0_4pa2$> z#S@QfLqjTKFjhyOpUdz2pZoqZMd5QO$`$W>&J_@2F%i`vqH8214MMneilKNQuo!SNQ=D`c&VY4M3 zZfuFMMsykRUK;WC?3DPo_3iO2h}%(d{^2LSw@_QRr?71yGG2!(-2pm&fXRV6u3P7J)n##f3zI{J zzu3Q%W(n`yasd-dfpcTdRoy9Ubd38cN(T?HiFpG5t{k_=xfB#1UBh)-)=>UWI|zo! z+9n!05X!^J(Ce{eqG)5B}fb!V}b3RI(yAF8l|HVXV97BMb!rO(qVL=%b8W3 zk}ijAWO2lEegMgSP7QK68)qQ1+^rqndgcZU*#U5F?KZz|a>~Sb9I!f`3Gr6FJ${Ze z;=$T*EDdo%i$^!&;reOuW_4ctcz$j?17ZW>yDf3S5|5bi_^JHt`0?zFxPe-%YvOPH z#;>i*&h2_Uv@-G&n0L_5YIMD&tLs#B$W7T#0ZZgD(8>a??17zy8Z3l5U2R!ZlKC}D zK2REPCxdpLt04GHvI$}n`1PT)Ib~7vGCReDpP{M`u@p6#t?`d)gxP$Q167B=U-%Xo zun5%1I7qdwYqYGh95yiIVW#eBbYa>=a+hN}OEhd`Nq12lM_qfmR^Y8gp=etVx*}oS z7qSAh*GQ@Kc(-6uX%_1l!)lZc^C(+lW8{A_PpLXA4r{tIj+!?#UBGKY@m<053%~_( zR5a;K1^j4&>N#^%pd#1+m9|vIfs!;DQjH-JOasc!x~@^J$3yq;eKIa}+NmaZ!!@rX z=n~B=Iv$H;QbzY`NYJ53elNd^p;z&RelY##J0HTiz{JP~wr<_3UJx#D@x_<0*qTi_ zeRBUp==eATe3pPm%MSaSRicp6GxyXNX{rMdH6cdC08G$y8abQJx&Ut#H@tUsM9K52 z03S&(RyI=0avH)EbcTq`6Lm$@3a`L;jnO4mTe6s=luP#n43%kOol7PvE|KTtlb`fY=26f^1xUZNDM~Fb0a!k zw05FS_5nA%@5cDCKm91KESZ1&J_c1us2NIa$*Uvi^47%V?)=0Zz5OelOkO~bQB}eQ zHX6K!+K6N8MTWK>Wpu|yC^di`+(I?iA;e25xd=Nv$k-{DQrVIR?%v78FTPMc&p|Ly zmL&}_CT$4WC@Rchsy50V8RMw={SR{{KRDA$d6ojHj%$}^+6TR^jKlF-t&%NKES-0$a{9$MpG@1rg1@8Ro z57OkYfB%22O?eBFLMd3{Vg6$n zr7@^$ZKXkak@@rOUewbx$z+;)bFR-3Bh8Ov*oW^**h#!=-0 z(FC^T^VqpbVyl~iows%DU`3%PscpOvYLU_#a&rY}+lvblARB=qY@ikvXu93R5HZ1` z{4CYbW_<1$@Q#6@oJvj5UfjuIJ5Z*;dSaqhd&8@)`k|;P`MG!eG!x_FTzJ+QoVu|N zW{h2*xe1pQj5Z!*FmGd|oE1#3HRI=TcFeF@W2BPsCBh~uikYR zhR6qg`B^RT+Me=Yn&}LA>P`?O@Q$Y$ORi+a# zwa3tA4>8oRmEgrwX*S;sS;oQn53_lE6V(&{O|3ge%PZ>YJhIs3Hn33Dbq9O*@^Po}|KI-B99zDqT_LO^mNYK0#3oQ>%{g1ksiV zOQL7nSRF7@4222uTAi|(p%zCNv^7H2!J8%v9HNV+$wu%Q)|CvogEZUiR6Pdg)?Wdp zAJ|2l^X$L-i&S6#GiFVP%U@rirMai1!>d`Uh8aBfO@x?3?Jd;eFi3QlgR1SJik~H) z_RQXWCqpH4w_VBTx$nn>IVyh}Rdpm$>Y|wDrb{7S%0RV^SbG~;D4Blh_i4B}qdF-QQ%^A(^oN7O&gb*i9cqL4l!}EF~!6b8>vD_G$zM2rQs=6CEuk24dFg zS(WgEc!G)OY!2gQ5^zeoRsxtMEkb46C@nxMBn(lf)7!cVWHGLqL9@qm(MLY=k$C;} z*Qb9UIrJpWFhk|;CoFxAs(lwx;F`%$rX^dzp7s)qA7w0Vgy!p^kOtpSDuWB|Blm}x zJFti1+h3wmZ8+kYt(p`=N7&&0h8UL^#7XHS*e|_T6fM@Lbc0$Y%Wn0EmP~WQyC(R+ zdrv30?Tr1{XJek_f=$$#DZuwDGOGmIwlFLZ%YE25MHXj{CLxL166mRoQ-qCVrNE`Lmg93W-F;S{R*6VFl%83IO|;!5sO$-J zK9y<;9o?$t1?=%$v^;_$wY=}%fmSm-_Jyxde!IoQ`Ec56bOLhO<~O41O|*Fn196Br zG|(FpF>@@m|CMGr&GaLmXLxamsH7q)31nz(h|v&DPNIr}Y+k@o@BO{XxwkE4+qmM^ z6lbJ05OqL8a=seqLtS{9nS@(OJvm05~BlGV3B{Zurao@MwE zlq$hIO7Na$En;&+>9%n&&M^@i7#>NSv6ysJ8ZBo23`U#GewjcOa^>hXI=R9zib*VT zb@L*2H5VU!uL|j)w3jG8#^6~m#m{63<>|tKA57I=)CXx*|3;2%t^-DM=2gGis|99u za^&v!lJ{{zqDG{87ufqIBQ<)%r6+I=w_r!lYAf68$Eqw)GjG zK)W?ftR&DKLd)vq^vw`TolYS=az6#}AU-Uc>mUfqL{0&g| z2~we+w?TJMF~j+@Q9dWC1L)c`HGdc*8&@^R6(I@r>s6%fT#dyDE(+rsfRAsnHKUrO;on4nTPJhho-_F7N{uKYBvoWk}kDD?zZ)D`j^ z=@IncuaJSg81igu5Na(Y%f8N1TP?Xozgk-_1vn(a%czoAb{9hzqYr}sqqwY)jA%SD z$hDFR7gDVdQmdnP?{~ARV*&1&B>};7jR2}%VD2~ER=XWmod!+wC&}VIUVIsF=4asa z0~FoAN>-qS-7yQ~jW?0U32+6Sg@2%ybx~6EP{TyY6w3>h6SK=LqW;Du$1TT#W75n0 zy}&2bnv^|K5J~u#tkKH?J(m=$a=fBfqW~j^o7Pxo&X+i~K)ZM%K}3^HQ~7}R10X+g z`k_YFoJ!nYh$>-pl?#g?lU@}@j5zfKO)8^(<)J8v-lglGaj6OANva)&q7CX0-pBNe z)NDD1lGfe=bV|WJ-yEEnz}oY%}?n#TAQ>Q{yS-=f24% zgkG07N$I@C3Q+y3ObX1PGh!T}GUuQ+9ip1qNj~>5&83a7`AP_uD&B%olQ!r z%hamd7|Vvpt2)lO6h~Hr2JG=%v}4B(-um{RP3-mG-S&9~!W^&u!JLf~(&P|?C$wOI z`XhMPg`(3hTYGIUC2g=imo_*)LAz>Vq>iW!F%pLH%`%y>h?b$~hDn=W-tcsOj53`3r2?s1nH` z8`GI*zWpDG1|LWysZJZ{Vf5a;%4jy8^Wx+YK6plh!jNIT!)R%wfiWg2)ywSMa;lX5 zYI_XtOE8KSC0cGdKL1}c{NCs0$yHA2Z(mJ_x}vU1&kd@eaB9}ie5$bJ8=c*^ryqw7Ea|v z8Fi0huAa(vX`~IiqhQ9Vm@s5@8?Ju6XhDIh9MzH|rq!Wa6tH7H}wW4qz2kHb5*{0J|-;)>_C zIqIb+pd5}I=eN^Unt|{LHcdP2>-GN=%9RawabWGg-v#nsA5V)zKaIc?_b_{KkNpZ(7^7J9Dg`Fg@?j0T?o{MullkU0 ziuOS22(Ogo>93WNs}4ivDVB7`6<05DxKDJ*VvqFU!uREz;AEEJWV%zSUST5X%Qsl6 zwaKbSWnd&VdzN#6__W~mxJ>#jBgV90O)XmXRnSd+gXO5X7GKg`Ck5=LdnH@Je|m)w1{g6;n;JwW+3$zs`I&*OV3r0LpMfW(;X+qb`PMrDBn zdgXh93A^_PqE?a|%jvRzIW`#bFiNTCD8ky!1U@ec(5W6iR#Nxgx?;mCx;jt0kE%*t dlXYF={{y9SJ3{}9CT0Kt002ovPDHLkV1kwt=(_*_ literal 0 HcmV?d00001 diff --git a/resources/assets/edenmod/textures/gui/cycle/medal_2.png b/resources/assets/edenmod/textures/gui/cycle/medal_2.png new file mode 100644 index 0000000000000000000000000000000000000000..90ba183f3d4f83423237fa12cf3823b93d166342 GIT binary patch literal 3296 zcmV<63?K7}P)({TB{Vj?jb8#NtIj6MO0$tN+E?Gm@c_$4U?MoU_s-~bzL}ruFt&R z)lNk5@BP`MxckRxNwkQ$E<>#ParT-RvQ%RiA83;*z<>{pxqJEbnm_Q!VW_Ch!CV4 zTs}Sm+ezTssXX5N?LUxr1N`Q9zeX;VLC5MgxGh6aaNyXsQL)os^uf2Y_}A}GA#>aV z^7YyIx=Fw^P``r|EI$FC-T{Ceam6<147{9&A@@9xOhUD{BPiIeQFj=g%Ar*!u_WQb z^8qUgr`(;Z0mnkSvkaNBuTgL4dQRpfG?Jc!cDn;(`DR2`7QWW-b3Po0;tM#T11q#K zrg8{70%OQhxdgOwp@%JmDGN|G@_`TAcF;cFiAg7m_R$esvd9<|8CMUe`b`y^G@%%> z080Yw`r{5X<;Jmj^JaKn9(HKKMh1hEF8T)hkjka;%I<%H+~8i1tN1Sk()5FoNb`ZxH>f*sM;O#&)J=wzUx5P931 z3Zw!B9crjZoBmdqobvBv7*&b^Py?XQKnz~L8ZGZ!L05ra{OL!S2*$Bxb2maikAVNk zkf0g;=f;p%0sej97``}o(Wr%+0=%0hlxXN0bt5NN85_=oi@fq+1x@f=4V6hkg$}d{ zd$Y(}Sq$rblVbH8q*v^LfS%Q((&b-h1ywQ2=zVS&1c!mn;k~uy*ZQ zB$G)jUc4CR&Yd&FkBp3%1gabc2M4Fs4g{Q|ySp0}EbQC=w?-@#4PgLxoDz^qrOd82 zH#g&(Z@z)+x@8L)TI;eYZBb$@3yB27s0D_hp`oc#hPlce*JnQ-mLe<#XSBjOk%!3y%%tv3l}aJ+rd6! zAouRwtG<&AQ0jjLIxfDowG|gHUNkmgU|^tF&@A*Vj*~X_r@aseL!_V@vma_fs6Ztk zq2Gp~Q?*X;$Rm$L$BrE{yT~#*cPcL4LqkJG0uCNLXuN<}cJ8V`#;jVk3M*EuF#VP; zU21Fy+xh#VMT?M5r%nHkjt)#rOw?uly4DG}Yb1t?6)~kKPfkuwy+CUt){F&&Aoihn z^KU`|API(~5624H+S-bYEf8N9s9H{jxVx{v{yH9f@IkY120jE&cev~E!;Fm^H<~`& zJ%W8nFd+n!X^aXbaEgPHAu7Vd6H3WL4?R>o8QQdI)BK(c-Mo3zESSNL7%MSSyi3%_ zXYMrnu#KWDR$T}Z29RmoT@n{R{SnBVEiEnPee^5@=dKp28l5NMFTC)A5m6RBmn~an zetYNbcg#KAmY&7{?tE8Qm+8+t8Ny2#z+*P5fT#o|hD4De*REYNbHsBAN)MTI^ypD@ z-?wj{kqVCc@WT&PLnYv&k3KSsVTp^nO(N*;Db801ubMs`OFN3h2?MxmBvSM`ZUi}B zTzc4-#FGhf080bQeuly6v|-i*4?JMzdFiE>@a30ZR!T~B3=l&^&XX7}n8b4-WQ3Vi z>!R=GB?gig`;a;D(;N~i#*=o1;!V|xtAQ|@5DDTqd5^rK;SBI&qD>q)aKI!w+}*8P zw@zac7q@!#YO}cI%a@zK-+lL8Lts4Zl^}^bN|hp^k|7Gn99~3cXQ!F-W10-j4h4zrQSFgaPrinr@dWN%Z#i8g6)= zr|QOlY$jVIE|baJqMxOpsESC6%j4g|B=PwI$q_^?$dF2;NYsFKBCc8uQ2~F3s!lDK zjhS;nJYuYPEam`Zsc8(L_`m=D`z8>%@4ov?%F7+5xDzW^t}IFbMV||#fn!@wPmgKm zZZW(iu3o)rq~Pq?vnG3_nlKF}o_zAjTh>EQL8j3a%eYE+zG?}`X0yfGowz{}J-H+V zmN1xOBo811MJ;FxBtjH78ULnet{*~ zzABvmi4BmpO6Yn`#D&V2VBDOkGJF4W2MS0-?UXKGT<}EZdj|FkPNcShY?dVqDH(&4&@2cL`XtW{uI|O`A3u zv8Mjgc*QNaWNVV?5wi22efF6dCwT$!_~VZo36ise`8-UqDjh(J&P#NiscT%<Pap7?!oUIO;bqF?M|B zQ8~x4#AUu1a}(IGVME1LUcR3mg0_Wo@^5CSY^x?G(3K95N(>`95=g@*^*rVT1VuYu z;v!SHNIo;0G=Wg7GO8j(&15giNrV(em=lQVNwit%XY_h5ogRMp;bM*Nt+(DX;!+zXx5=+S;;gau*s}!GKjsZJ&?!2W@jY(8k%&4^cOQX5<&*ZZj-opEl?1DrmhRY@q^OR$nkcNWJ|_KZc&Zf)s+sA@)vi3 zB1gi7AQ5TF3JJ;o8RX1{+bv%54dUaEKc1F6$tG080IT8=GZ?0F=l%7Xd!~2QBVN#z z4q)cSfQ5QT_xIw9FB*47DPYD&@E))EQC(;R=UPsqYB4qtw?=|5U%qS%su0gZnP;AP z#^e((zx*=Rty^c-wSD{c#xh{z#*K#U>2x}h(;7LkA>#3V+-)&Mo~gn~j3?MU3oH${A=LU3lchB$PXep#D*68@3HitnE-^aVS*=nI`UC@>-TO#^l?(PR4 zd|(Wd#0>F|A(%Ue0WG_bSO7!U${a#cXbF2I_h1Y{@CZGfPS-?(MvaifhIjdhK?vtF zZGrTW@R;qTVQV~cr1;Zi@|n6W)gw7ml!8jF#1nN*yZCKiJgnuS4<9}}t=cPkU1|&B zk|Bi^w(Z!l!-#pj5ftF6@$ zN2b#OrLAaZI(CLSI<{ziAY$VKMFIp-8bT71+z|4(_vSv%Ip6sndw16Q&bhffo15hF zSTo-}=X{U-?Y;Ke|Mg#M?Q1wex%uXs{k7L#OBjapdhYt`uji_(t};(`?UG9_@ee%k zz`WWs#&G1wk*93$cqBa02lG5U2Ge_LyHfb)IFv!Z~W zI9mrh0LB8z?0LNWw&ka{gvCLe&v_i;Az{dxD;aoe7KCYpS+u9 zv&jXURuflqaE@w`GHv>~|Dk`mLZuF2jodxGDL+=!af3@Bl@{7q3$f}lAPhqCN=(0j5z~Q4dOtmkhg-M$i!Xemn&rjU{WtqrOx=%j&id2vE@Ge&aX5vUAKr_PhS`40dl|d; zo47geuUfoV&F1%Ak6H0*TIn>)HebMiGngFGyvf#kchNFKEXhW>@9(YvVn`k{&p8GR zMiG%eKxPNYeT|B((l@*sXLE&ssb)&-LiUGCi7G?5z7@DICUhxzR|_3)ATO9Mh8Zu0 zNlnbMwqe@mSQlb!A1*qJx?qWILe?U5Q#>=G9G@6YrG#gB>NWab@kW+i`c8%xH8}nB zCD<^>h^`Gx?cPm%^Z>C-x%DHj*T-J_!7nf!4zm1$3(2bkv&{*@9f26wcB9^`VbC@(`<4cw!h-O_?2WYVT^!^zZGsb;?bs@Gm%i!1c3=w+Vr3 zsR!|ddarRQq3L}Wo5`uWDdGj0Di+29dh+FO-R^(yx8DYKl2spjn83lx^BUCp9YImW z1ePK#cy!xdBA;{TKV1W(_d@O=ia|I-@#uo~FP1NxvV$zJ0%qtZB~lj{ZT|*|t#bIVW2P>yAtp>`AQCANVt%VM_CgDxvgi%zkf*2jm}}NrW@^v&oj=cRoHHz<4l(&{XYTJ z^HKq$qoaOua*})QxtrBzpF!OiioDRkF7#!9XT1zkX+G`FjP}GDkGH)gZy9fT?z;D0 z-<;`i?z!ih7mNaKxZ$&W>QkTO;#aId6-;z2B!AE7vLq8X~ zkKsZ#UUU+2!7v$3q0?W^vSyFumt=md8bxkAPDXD$f$(f}C0+^!BUX=7$z7 zLdI%bL2TNrUbTYEWlSF!Q*-xf$~^^yI#3aZV{rKhg>~v3L|v0pp2?$43i)M?dW?3v z%}qDmWS*A_uwuf-mZZkyT=LQleEZg~Dcv30wU@|=0tyAe^5v2qJ7xim<;$>*KJ8WE z1B%)*28Nbt7D?UZv83wrCmcR_@PPl`cfYIOZ~4-fh@u{#InG^u3Hksn1AN?p%7-E9}>%~eSPz#V= zh-G*#zx*;r7LSl;IcwLiCv^qh2Beu|$*MJUY)pOe8Po?C>tpS9`?*hvnbNE2fRc2A zI55P0eK0l!wF*I+5CjpfC@5rYdoS59%?|reY#lx4T#hv{Q5fkVZnLJY(&4L~AkL{v zmb5)V)^1aDm&8f;pA(cDZ~UBp|NF0I?Wz@Q`{@seB&F>VimbzTZv6)T^Odh_R##Nx zgMxRwWFbXG87^o$f%RCID;QQ?fh`iklZY40d>`1fX@hSJ^>O~DP5kC% zmlN26SG{}_fy?>qr>|3U9v&QE#o!1=xIG2Vd(Pc>o<84Lx`c3`feS;TdIR#5>G9G< zCapGsm!;x}`s>i?(3zScZ6{<|PVNgTl?ns>4GIU_e(_6^%<%cI-pXUmglgXqcijFx zv!E8R?dQKx(_Xdm3|{f_P4p}5cT|@<@4AQnp*oA!oy+1i>$*<}KzJ&(GUhM(YD7yL zM7iy9T!U+Ml}D(33H zzMDPMDK){Kd5WF)6T;t|n5$Lu_jywKXaP0vNs@#lX=!Ch)^6csP&pl!llWY#$yU~Y z7CR*Za*{hHkamNBj@(~}smt8RGLZWvL6U1hHY*C+z98`hHjJso6@qGC8C&>g*$WsC z&GB(Q{wE(GE*#gq|7w!7U0(Et{=Pm2hZkYOh@sVI>4Mv~MPyfft~ww z0B?TZyIHn&6($Hd@bFF7pX<`X$mDZOXkhPj-DIMeJh})CoW*kEtvM3C-C{ihMBA3&s)|C4P zcxv?uxd2)%CM=-pyeg?AO$OVg!$PN>cLZ@n?rJnbxfe{@S{MsB_}F2;dd-WpAeuKH zBbc5hJ$i_VUv6dW;2}+7l;NsVR29=aYt`AfT1;ihVxl1Aw$J~Y4*KCeyU8>{Dof}y zNr(P=nIQe=f4HGkVAA2;?|c^$I!at2;erw;39Gxxr^_C#8)wTcH!|L8a@a+@=Bf|) zO07<(-7=@l0xFdXopzhJB1A??)v2bbjh8S*dee>Rh0qk9!GR&g1VQRb5D`Q*raEn! zMXGez5|oEA)Cc-VtykcS9MqkqPN46U0BEjgAStHSg%5eVxZPIsD7C^kcO_|LC0)Ys2T&%Z#Gu<3$dA?@TeMwY_J2;&F$ z^W!`2(7{}=aRa`{1r-$##Um^~^9%*Nu|tQ{{oVQfA24xfoWdI>W~LaQp5P-N{;(=m zxPV|zCV^928t(ElS13XF`IaAHUBN_9;gTz_CW`BHk{NRfLD0>9t7I9m%V>`up*cB4 zP&gVA0$WIpCk;`S7g?)ox7salTLH5;=!Ugc0WBIHB1#=;((XozURj>h45ucJl6G2z zCLrq)9ZeWntII&ehDxTam9Sc&) z>Lj!~ZO!uLVz*I9JIm>0IccW@L5Op%Ji1;%imBp03!%b+)!%bP6rk_6;ylZxq)FE9 z^Fq8%xf`@|+LW0P-38844I);rT}LN?;WcZz#v*!k^f&ss=+&F4Sg+P01fn+FU~phW zxx~btM^tIz1$6pC;r)dU2wN6F^?Ppu^s6i$NuS6&B3vNbYEHb85FXD>JxrOK&hDL) zwV4DVoxpaR6Ob%XD#%>P z?vFXJ>mi-Rv3-xyN>c5(40`{818TzUc8kw^<}>OVJF-j=H`}wkrI%$)-x+_DHq{KpyL;+$=xzlwo>slyvRH>2Y zo={TBz1%|&49gtrvIQw>6jIArkj<nm1y>fGRhRYW3xZ@6XKk^9GYL)A*yG{{aGD+nF-!n$nVZrfc;AXcE*^L=}a2CvkJ-Y|2`f9DMTk%c!AUut=5-jF+iRbT0FbiqIdLijHg-w zrnmMa*>T!(OwnZRhBj~hgDaJpjqQF|EkoR5A+uGDSvs;*Ks-8_o`XmI;?0#|UN=WxD+YVmmvZn+4<~v=s?#fR!DbCcsL> zBApE^K@<|lkt$1!JC-D;m1l&pS)x!>Acs_dR2|CRvBj0 zn902Yq?$J{%uLU83oZ-A0}ynTIzRY8T#}(S*xyXiMBBky!bCZ}nR zj_THkOD}u1y1ak=mz%Zoq8L%YQ_aJnLx*T3iMqj0eBu)tWs0J6i6Odo2|rlA?i@9q zJ8%0I1Evg|WLJ&sGZrPyB~Pcu0({p*jiD0>>50irRjW6>B_ffWR&*33%Y6W98FOED zoQOS_XvyGv=3g#F*+DL*SXP{I(-=~nhy}|CEgEi=+ja`5)lQc%ohx7SO1}8%hEGW zQ^KJ!!Q*-%yGP`+APXRpAV>#L!*O6eU2(p1ek@wSN7yG8nlnu;l7G%cySF^@#=ch^7x!SrQN#7gGsB zGGU|v)cObD=rr?@a9(%oIHiy;rRp|==ID&l3rWgI2qKmt$|+7@IN`jX=;na3T7^aHR%4SHJekJx zJ9g|O2m%HM251b{W?7o>d_jDXmtS~M*-Cev&t11ls^-#}F80XTMQ5H)J8~?_Vf*b{ z6j-GUXGPg+4JVcq4d<@_P34nHTDm$wB@j%P{k=I!niGXm%=Dyru7pKI!d)?PEpt7A z`INwRj0Z^mFex&exLNtfiypXzhKj`h0}eT_pDjB79WPx2OCtx%zI@o=a}5Jx69^aKR}NFl?~3df>zd1E-`%O z8Tin5myYGZAKs-_7DbjK$Z16(SG?`db@TX`@4`^gc~%rqihz-X>S0ZzFsC6}neHkJ zC88?X`zD_`Nr>k1%VI~jjqcnR$`HE@FS1Pgj7CNNQ%tthNU;$uu1MA?$P9gw1@MOH zj-lxXWiJWOdUg0`Kl`cw$(=u9>hNK9KfF_Y@(14XI%3n&jn7Mm`gLchptCH}`p9BM z?j9DDXGJN3puJ6zmc*qD3=Ob<&kk&1lwOO496EG_%(W@nmK*-#zbH(|%Px5>sR_9D zFaGp|$6+{0dGP1=`|~!vM0bR2|N70i$;apzDRy-;px@fMo1i^G zQ<^O@mNz0ctUZfbVQC&2*Z&>rRgV-J#1lv&br$WVfE1FXEh70JqM*T#@7bnwSQL=i z4k43Ve#INqYQFlluRXsuNyT##GQtfuZ#aV+KlEqH3^Pq#KaqXUt?M6id7A0-kkkzq zzv&vL!caF$NWde$Ar;VhKJF9DWrtXIcc(DH#P%~2*QggsiTu58E3+$0X~$%4vaL*d zJ87+Xj&3)%RN9XtHCZQC@-*^~Lu)vWNm=?$-6&_4bj&Vo6}W6GTH P00000NkvXXu0mjf&G^nx literal 0 HcmV?d00001 diff --git a/src/tel/eden/mod/EdenModClient.java b/src/tel/eden/mod/EdenModClient.java index f986b70..93e07c7 100644 --- a/src/tel/eden/mod/EdenModClient.java +++ b/src/tel/eden/mod/EdenModClient.java @@ -246,6 +246,8 @@ public boolean isFullMember() { /** Guild-only commands are hidden from travelers; an unverified player keeps them, as before. */ private final java.util.function.Predicate guildOnly = source -> !isTraveler(); + /** Member-only commands (events/cycle leaderboards) are hidden from travelers AND observers. */ + private final java.util.function.Predicate fullMemberOnly = source -> isFullMember(); /** In-game guild rank last reported by the backend, or empty if unknown. */ public String liveGuildRank() { @@ -292,6 +294,22 @@ public boolean onWynncraft() { private volatile String longEventError = ""; private volatile long longEventErrorAtMs; private final java.util.concurrent.atomic.AtomicInteger longEventGeneration = new java.util.concurrent.atomic.AtomicInteger(); + private volatile tel.eden.mod.net.CycleLeaderboardData.CycleSnapshot knownCycleLeaderboard; + private volatile String cycleLeaderboardError = ""; + private volatile long cycleLeaderboardErrorAtMs; + private final java.util.concurrent.atomic.AtomicInteger cycleLeaderboardGeneration = new java.util.concurrent.atomic.AtomicInteger(); + private volatile tel.eden.mod.net.CycleLeaderboardData.LifetimeSnapshot knownLifetimeLeaderboard; + private volatile String lifetimeLeaderboardError = ""; + private volatile long lifetimeLeaderboardErrorAtMs; + private final java.util.concurrent.atomic.AtomicInteger lifetimeLeaderboardGeneration = new java.util.concurrent.atomic.AtomicInteger(); + private final java.util.Map concludedCyclesByCode = new java.util.concurrent.ConcurrentHashMap<>(); + private volatile String pendingCyclePrintCode; + private final java.util.concurrent.atomic.AtomicLong cycleRequestSeq = new java.util.concurrent.atomic.AtomicLong(); + private final java.util.concurrent.atomic.AtomicLong cycleRequestPendingId = new java.util.concurrent.atomic.AtomicLong(); + private final java.util.concurrent.atomic.AtomicLong lifetimeRequestSeq = new java.util.concurrent.atomic.AtomicLong(); + private final java.util.concurrent.atomic.AtomicLong lifetimeRequestPendingId = new java.util.concurrent.atomic.AtomicLong(); + private volatile long lastCycleQueryAtMs; + private volatile long lastLifetimeQueryAtMs; // GitHub update check: run once per game session; the prompt offers a one-click // download (applied on game close) and a link to the release page. private final UpdateChecker updateChecker = new UpdateChecker(); @@ -573,6 +591,36 @@ public int longEventGeneration() { return longEventGeneration.get(); } + /** Latest promotion-cycle leaderboard snapshot, or {@code null} before first reply. */ + public tel.eden.mod.net.CycleLeaderboardData.CycleSnapshot knownCycleLeaderboard() { + return knownCycleLeaderboard; + } + + /** Last cycle leaderboard error if it arrived within the past 5 seconds, else {@code ""}. */ + public String recentCycleLeaderboardError() { + return System.currentTimeMillis() - cycleLeaderboardErrorAtMs < 5_000L ? cycleLeaderboardError : ""; + } + + /** Bumped on every cycle leaderboard snapshot or error update. */ + public int cycleLeaderboardGeneration() { + return cycleLeaderboardGeneration.get(); + } + + /** Latest lifetime/interval leaderboard snapshot, or {@code null} before first reply. */ + public tel.eden.mod.net.CycleLeaderboardData.LifetimeSnapshot knownLifetimeLeaderboard() { + return knownLifetimeLeaderboard; + } + + /** Last lifetime leaderboard error if it arrived within the past 5 seconds, else {@code ""}. */ + public String recentLifetimeLeaderboardError() { + return System.currentTimeMillis() - lifetimeLeaderboardErrorAtMs < 5_000L ? lifetimeLeaderboardError : ""; + } + + /** Bumped on every lifetime leaderboard snapshot or error update. */ + public int lifetimeLeaderboardGeneration() { + return lifetimeLeaderboardGeneration.get(); + } + /** The guild reward helper (rank lookups + gifting). */ public GuildRewards guildRewards() { return guildRewards; @@ -811,6 +859,8 @@ public void release() { tel.eden.mod.war.eco.TerritoryGuideController.reset(); guildAllyManager.requestCancel(); eventRewardsPendingId.set(0); + cycleRequestPendingId.set(0); + lifetimeRequestPendingId.set(0); // Connect if applicable; the backend reports link/membership standing via // authOk (handleAuthStatus), which drives any "please link" prompt. evaluateGating(client); @@ -847,7 +897,7 @@ public void release() { }).then(ClientCommandManager.literal("download").executes(ctx -> { updateDownload(ctx.getSource()); return 1; - }))).then(buildGiftCommand()).then(buildDeductCommand()).then(buildAllyCommand()).then(buildEventCommand()).then(ClientCommandManager.literal("logscan").requires(guildOnly).executes(ctx -> scanLog(ctx.getSource()))).then(ClientCommandManager.literal("dump").requires(guildOnly).then(ClientCommandManager.argument("member", StringArgumentType.word()).suggests(this::suggestMembers).executes(ctx -> dumpEmeralds(ctx.getSource(), StringArgumentType.getString(ctx, "member"))))).then(ClientCommandManager.literal("wars").requires(guildOnly).executes(ctx -> { + }))).then(buildGiftCommand()).then(buildDeductCommand()).then(buildAllyCommand()).then(buildEventCommand()).then(buildCycleCommand()).then(ClientCommandManager.literal("logscan").requires(guildOnly).executes(ctx -> scanLog(ctx.getSource()))).then(ClientCommandManager.literal("dump").requires(guildOnly).then(ClientCommandManager.argument("member", StringArgumentType.word()).suggests(this::suggestMembers).executes(ctx -> dumpEmeralds(ctx.getSource(), StringArgumentType.getString(ctx, "member"))))).then(ClientCommandManager.literal("wars").requires(guildOnly).executes(ctx -> { requestWarCounts(ctx.getSource(), 7); return 1; }).then(ClientCommandManager.argument("days", com.mojang.brigadier.arguments.IntegerArgumentType.integer(1, 365)).executes(ctx -> { @@ -1468,6 +1518,65 @@ public void onLongEventRewards(int pendingLe, String error) { display(() -> DiscordChatFormatter.systemLine("Pending event rewards: " + pendingLe + " LE", ChatFormatting.GOLD)); } + @Override + public void onCycleLeaderboard(tel.eden.mod.net.CycleLeaderboardData.CycleSnapshot snapshot) { + cycleRequestPendingId.set(0); + if (!isFullMember()) { + return; + } + if (snapshot.error() != null && !snapshot.error().isEmpty()) { + String err = snapshot.error(); + cycleLeaderboardError = err; + cycleLeaderboardErrorAtMs = System.currentTimeMillis(); + cycleLeaderboardGeneration.incrementAndGet(); + String pendingCode = pendingCyclePrintCode; + if (pendingCode != null) { + pendingCyclePrintCode = null; + display(() -> DiscordChatFormatter.systemLine(err, ChatFormatting.RED)); + } + return; + } + cycleLeaderboardError = ""; + cycleLeaderboardErrorAtMs = 0L; + knownCycleLeaderboard = snapshot; + cycleLeaderboardGeneration.incrementAndGet(); + String pendingCode = pendingCyclePrintCode; + if (pendingCode != null && (pendingCode.isEmpty() || pendingCode.equals(snapshot.cycleCode()))) { + pendingCyclePrintCode = null; + tel.eden.mod.net.CycleLeaderboardData.ConcludedCycleSummary derived = tel.eden.mod.net.CycleLeaderboardData.summaryFromSnapshot(snapshot); + display(() -> DiscordChatFormatter.formatCyclePrint(derived)); + } + } + + @Override + public void onLifetimeLeaderboard(tel.eden.mod.net.CycleLeaderboardData.LifetimeSnapshot snapshot) { + lifetimeRequestPendingId.set(0); + if (!isFullMember()) { + return; + } + if (snapshot.error() != null && !snapshot.error().isEmpty()) { + lifetimeLeaderboardError = snapshot.error(); + lifetimeLeaderboardErrorAtMs = System.currentTimeMillis(); + lifetimeLeaderboardGeneration.incrementAndGet(); + return; + } + lifetimeLeaderboardError = ""; + lifetimeLeaderboardErrorAtMs = 0L; + knownLifetimeLeaderboard = snapshot; + lifetimeLeaderboardGeneration.incrementAndGet(); + } + + @Override + public void onCycleConcluded(tel.eden.mod.net.CycleLeaderboardData.ConcludedCycleSummary summary) { + if (!isFullMember()) { + return; + } + if (summary.cycleCode() != null && !summary.cycleCode().isEmpty()) { + concludedCyclesByCode.put(summary.cycleCode(), summary); + } + display(() -> DiscordChatFormatter.cycleConcluded(summary.cycleCode())); + } + @Override public void onAuthStatus(boolean linked, boolean member, boolean traveler, String guildRank, String discordRank) { handleAuthStatus(linked, member, traveler, guildRank, discordRank); @@ -1830,6 +1939,111 @@ private void requestEventRewards(FabricClientCommandSource source) { }, 5, TimeUnit.SECONDS); } + private LiteralArgumentBuilder buildCycleCommand() { + return ClientCommandManager.literal("cycle").requires(fullMemberOnly).executes(ctx -> openCycleGui(null)).then(ClientCommandManager.literal("view").executes(ctx -> openCycleGui(null)).then(ClientCommandManager.argument("cycle", StringArgumentType.word()).executes(ctx -> openCycleGui(StringArgumentType.getString(ctx, "cycle"))))).then(ClientCommandManager.literal("print").executes(ctx -> printCycleSummary(ctx.getSource(), null)).then(ClientCommandManager.argument("cycle", StringArgumentType.word()).executes(ctx -> printCycleSummary(ctx.getSource(), StringArgumentType.getString(ctx, "cycle"))))); + } + + private int openCycleGui(String cycleCode) { + if (!isFullMember()) { + return 0; + } + Minecraft mc = Minecraft.getInstance(); + mc.execute(() -> mc.setScreen(new tel.eden.mod.gui.PromotionCycleScreen(mc.screen, this, cycleCode))); + return 1; + } + + private int printCycleSummary(FabricClientCommandSource source, String cycleCode) { + if (!isFullMember()) { + return 0; + } + String trimmed = (cycleCode != null && !cycleCode.isBlank()) ? cycleCode.trim() : ""; + tel.eden.mod.net.CycleLeaderboardData.ConcludedCycleSummary cached = !trimmed.isEmpty() ? concludedCyclesByCode.get(trimmed) : null; + if (cached != null) { + source.sendFeedback(DiscordChatFormatter.formatCyclePrint(cached)); + return 1; + } + tel.eden.mod.net.CycleLeaderboardData.CycleSnapshot snap = knownCycleLeaderboard; + if (snap != null && snap.error().isEmpty() && (trimmed.isEmpty() || trimmed.equals(snap.cycleCode()))) { + source.sendFeedback(DiscordChatFormatter.formatCyclePrint(tel.eden.mod.net.CycleLeaderboardData.summaryFromSnapshot(snap))); + return 1; + } + pendingCyclePrintCode = trimmed; + requestCycleLeaderboard(trimmed); + return 1; + } + + /** Request promotion cycle leaderboard data (current if null/blank) with 1s query cooldown and 5s timeout. */ + public void requestCycleLeaderboard(String cycleCode) { + if (!isFullMember()) { + cycleLeaderboardError = "Failed to fetch cycle leaderboard"; + cycleLeaderboardErrorAtMs = System.currentTimeMillis(); + cycleLeaderboardGeneration.incrementAndGet(); + return; + } + BridgeWebSocketClient current = socket; + if (current == null || !current.isConnected()) { + cycleLeaderboardError = "Failed to fetch cycle leaderboard"; + cycleLeaderboardErrorAtMs = System.currentTimeMillis(); + cycleLeaderboardGeneration.incrementAndGet(); + return; + } + long nowMs = System.currentTimeMillis(); + if (nowMs - lastCycleQueryAtMs < 1_000L && knownCycleLeaderboard != null) { + return; + } + lastCycleQueryAtMs = nowMs; + cycleLeaderboardError = ""; + cycleLeaderboardErrorAtMs = 0L; + long id = cycleRequestSeq.incrementAndGet(); + cycleRequestPendingId.set(id); + current.sendCycleLeaderboardRequest(cycleCode); + partyCommandExecutor.schedule(() -> { + if (cycleRequestPendingId.compareAndSet(id, 0)) { + cycleLeaderboardError = "Failed to fetch cycle leaderboard"; + cycleLeaderboardErrorAtMs = System.currentTimeMillis(); + cycleLeaderboardGeneration.incrementAndGet(); + if (pendingCyclePrintCode != null) { + pendingCyclePrintCode = null; + display(() -> DiscordChatFormatter.systemLine("Failed to fetch cycle leaderboard", ChatFormatting.RED)); + } + } + }, 5, TimeUnit.SECONDS); + } + + /** Request lifetime or interval Raids/Wars leaderboards with 1s query cooldown and 5s timeout. */ + public void requestLifetimeLeaderboard(Double fromDays, Double toDays) { + if (!isFullMember()) { + lifetimeLeaderboardError = "Failed to fetch leaderboard stats"; + lifetimeLeaderboardErrorAtMs = System.currentTimeMillis(); + lifetimeLeaderboardGeneration.incrementAndGet(); + return; + } + BridgeWebSocketClient current = socket; + if (current == null || !current.isConnected()) { + lifetimeLeaderboardError = "Failed to fetch leaderboard stats"; + lifetimeLeaderboardErrorAtMs = System.currentTimeMillis(); + lifetimeLeaderboardGeneration.incrementAndGet(); + return; + } + long nowMs = System.currentTimeMillis(); + if (nowMs - lastLifetimeQueryAtMs < 1_000L && knownLifetimeLeaderboard != null) { + return; + } + lastLifetimeQueryAtMs = nowMs; + lifetimeLeaderboardError = ""; + lifetimeLeaderboardErrorAtMs = 0L; + long id = lifetimeRequestSeq.incrementAndGet(); + lifetimeRequestPendingId.set(id); + current.sendLifetimeLeaderboardRequest(fromDays, toDays); + partyCommandExecutor.schedule(() -> { + if (lifetimeRequestPendingId.compareAndSet(id, 0)) { + lifetimeLeaderboardError = "Failed to fetch leaderboard stats"; + lifetimeLeaderboardErrorAtMs = System.currentTimeMillis(); + lifetimeLeaderboardGeneration.incrementAndGet(); + } + }, 5, TimeUnit.SECONDS); + } + private CompletableFuture suggestMembers(CommandContext context, SuggestionsBuilder builder) { String remaining = builder.getRemaining().toLowerCase(Locale.ROOT); for (String name : guildRewards.memberNames()) { @@ -2726,9 +2940,9 @@ private int handleTravelerReplyCommand(String messageId) { private record HelpEntry(String command, String description) { } - private static final java.util.Set GUILD_ONLY_COMMANDS = java.util.Set.of("online", "wars", "event", "aspects", "emeralds", "warpay", "rewards", "gift", "dump", "deduct", "ally", "reply", "logscan"); + private static final java.util.Set GUILD_ONLY_COMMANDS = java.util.Set.of("online", "wars", "event", "cycle", "aspects", "emeralds", "warpay", "rewards", "gift", "dump", "deduct", "ally", "reply", "logscan"); - private static final List HELP_ENTRIES = List.of(new HelpEntry("/eden config", "open the config screen"), new HelpEntry("/eden online", "who's connected to the bridge"), new HelpEntry("/eden mail ", "leave a member a message for their next login"), new HelpEntry("/eden cf", "flip a coin"), new HelpEntry("/eden diceroll", "roll a die"), new HelpEntry("/eden tc ", "chat with travelers and members (alias /e)"), new HelpEntry("/eden wars [days]", "guild war counts (same as Discord)"), new HelpEntry("/eden emojis", "open the chat emote picker"), new HelpEntry("/eden event", "open the event missions screen"), new HelpEntry("/eden event rewards", "check your pending event LE"), new HelpEntry("/eden party", "list open parties (click to join)"), new HelpEntry("/eden party create [note]", "open a raid party"), new HelpEntry("/eden party join ", "join a party"), new HelpEntry("/eden party leave [id]", "leave your party"), new HelpEntry("/eden party disband", "disband your hosted party"), new HelpEntry("/eden anni [note]", "open an Annihilation party (2-10)"), new HelpEntry("/eden command alias", "open the command alias editor"), new HelpEntry("/eden command keybind", "open the command keybind editor"), new HelpEntry("/eden update", "check for a pending update"), new HelpEntry("/eden update download", "download the update now (applies on exit)"), new HelpEntry("/eden aspects pending", "members' pending aspects — Chiefs only"), new HelpEntry("/eden gift ", "gift guild rewards — Chiefs only"), new HelpEntry("/eden dump ", "gift all guild-bank emeralds to a member — Chiefs only"), new HelpEntry("/eden deduct ", "deduct a payout from pending rewards — Chiefs only"), new HelpEntry("/eden ally view", "view guild ally activity (most inactive to active)"), new HelpEntry("/eden ally add ", "add a guild ally — Strategist+ only"), new HelpEntry("/eden ally remove ", "remove a guild ally — Strategist+ only"), new HelpEntry("/eden rewards", "check your pending aspects/emeralds/warpay and opt-out status"), new HelpEntry("/eden aspects optout [true|false]", "opt out of or into receiving aspects"), new HelpEntry("/eden emeralds optout [true|false]", "opt out of or into receiving emeralds"), new HelpEntry("/eden warpay optout [true|false]", "opt out of or into receiving warpay"), new HelpEntry("/eden help", "this help screen")); + private static final List HELP_ENTRIES = List.of(new HelpEntry("/eden config", "open the config screen"), new HelpEntry("/eden online", "who's connected to the bridge"), new HelpEntry("/eden mail ", "leave a member a message for their next login"), new HelpEntry("/eden cf", "flip a coin"), new HelpEntry("/eden diceroll", "roll a die"), new HelpEntry("/eden tc ", "chat with travelers and members (alias /e)"), new HelpEntry("/eden wars [days]", "guild war counts (same as Discord)"), new HelpEntry("/eden emojis", "open the chat emote picker"), new HelpEntry("/eden event", "open the event missions screen"), new HelpEntry("/eden event rewards", "check your pending event LE"), new HelpEntry("/eden cycle", "open the promotion cycle leaderboard"), new HelpEntry("/eden party", "list open parties (click to join)"), new HelpEntry("/eden party create [note]", "open a raid party"), new HelpEntry("/eden party join ", "join a party"), new HelpEntry("/eden party leave [id]", "leave your party"), new HelpEntry("/eden party disband", "disband your hosted party"), new HelpEntry("/eden anni [note]", "open an Annihilation party (2-10)"), new HelpEntry("/eden command alias", "open the command alias editor"), new HelpEntry("/eden command keybind", "open the command keybind editor"), new HelpEntry("/eden update", "check for a pending update"), new HelpEntry("/eden update download", "download the update now (applies on exit)"), new HelpEntry("/eden aspects pending", "members' pending aspects — Chiefs only"), new HelpEntry("/eden gift ", "gift guild rewards — Chiefs only"), new HelpEntry("/eden dump ", "gift all guild-bank emeralds to a member — Chiefs only"), new HelpEntry("/eden deduct ", "deduct a payout from pending rewards — Chiefs only"), new HelpEntry("/eden ally view", "view guild ally activity (most inactive to active)"), new HelpEntry("/eden ally add ", "add a guild ally — Strategist+ only"), new HelpEntry("/eden ally remove ", "remove a guild ally — Strategist+ only"), new HelpEntry("/eden rewards", "check your pending aspects/emeralds/warpay and opt-out status"), new HelpEntry("/eden aspects optout [true|false]", "opt out of or into receiving aspects"), new HelpEntry("/eden emeralds optout [true|false]", "opt out of or into receiving emeralds"), new HelpEntry("/eden warpay optout [true|false]", "opt out of or into receiving warpay"), new HelpEntry("/eden help", "this help screen")); private static final class TrackedCommandKeybind { private final String input; @@ -2767,7 +2981,8 @@ private void setDown(boolean down) { private void showHelp(FabricClientCommandSource source) { MutableComponent help = Component.literal("EdenMod — in-game commands:").withStyle(net.minecraft.ChatFormatting.GREEN); for (HelpEntry entry : HELP_ENTRIES) { - if (isTraveler() && GUILD_ONLY_COMMANDS.contains(entry.command().split(" ")[1])) { + String cmd = entry.command().split(" ")[1]; + if (("cycle".equals(cmd) && !isFullMember()) || (isTraveler() && GUILD_ONLY_COMMANDS.contains(cmd))) { continue; } help.append(helpLine(entry.command(), entry.description())); @@ -2991,6 +3206,20 @@ private synchronized void disconnect() { longEventGeneration.set(0); longEventError = ""; longEventErrorAtMs = 0L; + cycleRequestPendingId.set(0); + lifetimeRequestPendingId.set(0); + knownCycleLeaderboard = null; + cycleLeaderboardGeneration.set(0); + cycleLeaderboardError = ""; + cycleLeaderboardErrorAtMs = 0L; + knownLifetimeLeaderboard = null; + lifetimeLeaderboardGeneration.set(0); + lifetimeLeaderboardError = ""; + lifetimeLeaderboardErrorAtMs = 0L; + concludedCyclesByCode.clear(); + pendingCyclePrintCode = null; + lastCycleQueryAtMs = 0L; + lastLifetimeQueryAtMs = 0L; tel.eden.mod.chat.ImagePreviewManager.clear(); // Before the socket goes: an outstanding deduct must not outlive the session that // made it, or it resurfaces at the next connect naming a player from another diff --git a/src/tel/eden/mod/chat/DiscordChatFormatter.java b/src/tel/eden/mod/chat/DiscordChatFormatter.java index 8f07a05..63412d1 100644 --- a/src/tel/eden/mod/chat/DiscordChatFormatter.java +++ b/src/tel/eden/mod/chat/DiscordChatFormatter.java @@ -119,6 +119,51 @@ public static Component updateAvailable(String version, String pageUrl) { return line; } + /** "The promotion cycle has concluded! [Print] [View]" for in-game guild members only. */ + public static Component cycleConcluded(String cycleCode) { + String arg = (cycleCode != null && !cycleCode.isBlank()) ? " " + cycleCode.trim() : ""; + Style print = Style.EMPTY.withColor(ChatFormatting.AQUA).withUnderlined(true).withClickEvent(new ClickEvent.RunCommand("/eden cycle print" + arg)).withHoverEvent(new HoverEvent.ShowText(Component.literal("Print top cycle results to chat"))); + Style view = Style.EMPTY.withColor(ChatFormatting.GREEN).withUnderlined(true).withClickEvent(new ClickEvent.RunCommand("/eden cycle view" + arg)).withHoverEvent(new HoverEvent.ShowText(Component.literal("Open the promotion cycle leaderboard"))); + return Component.empty().append(prefix(SHIELD)).append(Component.literal("The promotion cycle has concluded! ").withStyle(ChatFormatting.GOLD)).append(Component.literal("[Print]").setStyle(print)).append(Component.literal(" ")).append(Component.literal("[View]").setStyle(view)); + } + + /** Format concluded cycle summary (top 3 raids, top 1 wars, top 3 raffle, totals) for [Print]. */ + public static Component formatCyclePrint(tel.eden.mod.net.CycleLeaderboardData.ConcludedCycleSummary summary) { + MutableComponent out = Component.empty().append(prefix(SHIELD)); + String title = (summary.cycleCode() != null && !summary.cycleCode().isBlank()) ? "Promotion Cycle " + summary.cycleCode() + " Results:" : "Promotion Cycle Results:"; + out.append(Component.literal(title).withStyle(ChatFormatting.GOLD, ChatFormatting.BOLD)); + out.append(Component.literal("\n Top 3 Raids:").withStyle(ChatFormatting.AQUA)); + List topRaids = summary.topRaids().stream().filter(e -> e.count() > 0 && e.rank() <= 3).limit(3).toList(); + if (topRaids.isEmpty()) { + out.append(Component.literal("\n None").withStyle(ChatFormatting.GRAY)); + } else { + for (tel.eden.mod.net.CycleLeaderboardData.LeaderboardEntry e : topRaids) { + out.append(Component.literal("\n #" + e.rank() + " " + e.name()).withStyle(ChatFormatting.WHITE)).append(Component.literal(" — " + e.count() + " raids").withStyle(ChatFormatting.GRAY)); + } + } + out.append(Component.literal("\n Top 1 Wars:").withStyle(ChatFormatting.RED)); + List topWars = summary.topWars().stream().filter(e -> e.count() > 0 && e.rank() == 1).limit(3).toList(); + if (topWars.isEmpty()) { + out.append(Component.literal("\n None").withStyle(ChatFormatting.GRAY)); + } else { + for (tel.eden.mod.net.CycleLeaderboardData.LeaderboardEntry e : topWars) { + out.append(Component.literal("\n #" + e.rank() + " " + e.name()).withStyle(ChatFormatting.WHITE)).append(Component.literal(" — " + e.count() + " wars").withStyle(ChatFormatting.GRAY)); + } + } + out.append(Component.literal("\n Top 3 Raffle:").withStyle(ChatFormatting.LIGHT_PURPLE)); + List winners = summary.raffleWinners().subList(0, Math.min(3, summary.raffleWinners().size())); + if (winners.isEmpty()) { + out.append(Component.literal("\n None").withStyle(ChatFormatting.GRAY)); + } else { + for (int i = 0; i < winners.size(); i++) { + tel.eden.mod.net.CycleLeaderboardData.RaffleWinner w = winners.get(i); + out.append(Component.literal("\n #" + (i + 1) + " " + w.name()).withStyle(ChatFormatting.WHITE)).append(Component.literal(" — " + w.tickets() + " tickets (" + w.raids() + " raids)").withStyle(ChatFormatting.GRAY)); + } + } + out.append(Component.literal("\n Totals: ").withStyle(ChatFormatting.GOLD)).append(Component.literal(summary.totalRaids() + " raids | " + summary.totalWars() + " wars | " + summary.totalTickets() + " tickets").withStyle(ChatFormatting.YELLOW)); + return out; + } + /** A green/gold/red client-side notice line with the guild shield prefix. */ public static Component systemLine(String text, ChatFormatting color) { return Component.empty().append(prefix(SHIELD)).append(Component.literal(text).withStyle(color)); diff --git a/src/tel/eden/mod/gui/BridgeConfigScreen.java b/src/tel/eden/mod/gui/BridgeConfigScreen.java index dda7e88..bc6fa21 100644 --- a/src/tel/eden/mod/gui/BridgeConfigScreen.java +++ b/src/tel/eden/mod/gui/BridgeConfigScreen.java @@ -119,6 +119,10 @@ protected void init() { if (!traveler) { addToggleRow(Category.GENERAL, "Discord Bridge Messages", () -> config.discordBridgeMessages, v -> config.discordBridgeMessages = v, "On", "Off", true); } + if (mod.isFullMember()) { + addButtonRow(Category.GENERAL, "Promotion cycle", () -> Component.literal("Open..."), () -> this.minecraft.setScreen(new PromotionCycleScreen(this, mod)), () -> { + }); + } addToggleRow(Category.GENERAL, "Traveler chat", () -> config.travelerChat, v -> { config.travelerChat = v; EdenModClient.syncTravelerPrefs(config); diff --git a/src/tel/eden/mod/gui/EdenMenuScreen.java b/src/tel/eden/mod/gui/EdenMenuScreen.java index 07db757..8f979da 100644 --- a/src/tel/eden/mod/gui/EdenMenuScreen.java +++ b/src/tel/eden/mod/gui/EdenMenuScreen.java @@ -17,9 +17,9 @@ public class EdenMenuScreen extends EdenScreen { private static final int BASE_CONTENT_WIDTH = 200; private static final int BUTTON_HEIGHT = 20; private static final int BUTTON_SPACING = 24; - private static final int BUTTON_COUNT = 8; - // Event and Payouts are guild-only. - private static final int TRAVELER_HIDDEN_BUTTONS = 2; + private static final int BUTTON_COUNT = 9; + // Event, Promotion cycle, and Payouts are hidden from travelers. + private static final int TRAVELER_HIDDEN_BUTTONS = 3; private static final int LOGO_WIDTH = 128; private static final int LOGO_GAP = 20; private static final int CONTENT_MARGIN = 12; @@ -67,6 +67,7 @@ protected void init() { } this.minecraft.setScreen(new LongEventScreen(this, mod)); }).bounds(metrics.buttonX, metrics.startY + (metrics.buttonPitch * slot++), metrics.buttonWidth, metrics.buttonHeight).build()); + this.addRenderableWidget(Button.builder(Component.literal("Promotion cycle"), button -> this.minecraft.setScreen(new PromotionCycleScreen(this, EdenModClient.instance()))).bounds(metrics.buttonX, metrics.startY + (metrics.buttonPitch * slot++), metrics.buttonWidth, metrics.buttonHeight).build()); } this.addRenderableWidget(Button.builder(Component.literal("Create Party"), button -> { @@ -213,8 +214,8 @@ private static boolean isMember() { private static int buttonCount() { int count = isTraveler() ? BUTTON_COUNT - TRAVELER_HIDDEN_BUTTONS : BUTTON_COUNT; - // Event is member-only; a traveler already has it counted in TRAVELER_HIDDEN_BUTTONS. - return !isTraveler() && !isMember() ? count - 1 : count; + // Event and Promotion cycle are full-member-only; observers lack both as well. + return !isTraveler() && !isMember() ? count - 2 : count; } private int bottomSafeMargin() { diff --git a/src/tel/eden/mod/gui/PromotionCycleScreen.java b/src/tel/eden/mod/gui/PromotionCycleScreen.java new file mode 100644 index 0000000..bc9fcc1 --- /dev/null +++ b/src/tel/eden/mod/gui/PromotionCycleScreen.java @@ -0,0 +1,651 @@ +package tel.eden.mod.gui; + +import java.util.List; +import java.util.UUID; +import net.minecraft.ChatFormatting; +import net.minecraft.client.gui.GuiGraphics; +import net.minecraft.client.gui.components.Button; +import net.minecraft.client.gui.components.EditBox; +import net.minecraft.client.gui.components.PlayerFaceRenderer; +import net.minecraft.client.gui.screens.Screen; +import net.minecraft.client.input.CharacterEvent; +import net.minecraft.client.input.KeyEvent; +import net.minecraft.client.input.MouseButtonEvent; +import net.minecraft.client.renderer.RenderPipelines; +import net.minecraft.network.chat.Component; +import net.minecraft.resources.Identifier; +import net.minecraft.world.entity.player.PlayerSkin; +import tel.eden.mod.EdenModClient; +import tel.eden.mod.net.CycleLeaderboardData; +import tel.eden.mod.util.PlayerSkinResolver; + +/** Promotion Cycle (& Archive) and Lifetime leaderboard screen for full guild members. */ +public class PromotionCycleScreen extends EdenReferenceScreen { + private static final int BASE_PANEL_WIDTH = 468; + private static final int BASE_PANEL_HEIGHT = 272; + + private static final int LEFT_COL_X = 12; + private static final int RIGHT_COL_X = 240; + private static final int COL_WIDTH = 208; + private static final int SCROLLBAR_OFFSET = 210; + private static final int SCROLLBAR_WIDTH = 6; + private static final int VISIBLE_ROWS = 8; + private static final int ROW_PITCH = 17; + private static final int ROW_HEIGHT = 15; + private static final int ZERO_ROW_OVERLAY = 0x44CC2222; + private static final int ROW_FILL = 0x44282828; + + private static final Identifier[] MEDAL_TEXTURES = {Identifier.fromNamespaceAndPath("edenmod", "textures/gui/cycle/medal_1.png"), Identifier.fromNamespaceAndPath("edenmod", "textures/gui/cycle/medal_2.png"), Identifier.fromNamespaceAndPath("edenmod", "textures/gui/cycle/medal_3.png"),}; + + private enum Tab { + CYCLE, LIFETIME + } + + private final EdenModClient mod; + private final String initialCycleCode; + private EdenPanelLayout layout; + + private Tab activeTab = Tab.CYCLE; + private boolean archiveOpen; + private boolean showFinishes; + private boolean initialRequestSent; + private boolean lifetimeRequested; + private String selectedCycleCode; + + private EditBox fromBox; + private EditBox toBox; + private String fromDraft = ""; + private String toDraft = ""; + private String validationError = ""; + + private Button cycleTabButton; + private Button lifetimeTabButton; + private Button archiveButton; + private Button prevCycleButton; + private Button nextCycleButton; + private Button applyIntervalButton; + private Button resetIntervalButton; + private Button finishesToggleButton; + + private int raidsScroll; + private int warsScroll; + private int draggingPane; + private int seenCycleGen = -1; + private int seenLifetimeGen = -1; + + public PromotionCycleScreen(Screen parent, EdenModClient mod) { + this(parent, mod, null); + } + + public PromotionCycleScreen(Screen parent, EdenModClient mod, String initialCycleCode) { + super(Component.literal("Promotion Cycle"), parent); + this.mod = mod; + this.initialCycleCode = (initialCycleCode != null && !initialCycleCode.isBlank()) ? initialCycleCode.trim() : null; + this.selectedCycleCode = this.initialCycleCode; + this.archiveOpen = this.initialCycleCode != null; + } + + @Override + protected void init() { + super.init(); + layout = centeredLayout(BASE_PANEL_WIDTH, BASE_PANEL_HEIGHT); + + if (fromBox != null) { + fromDraft = fromBox.getValue(); + } + if (toBox != null) { + toDraft = toBox.getValue(); + } + + this.clearWidgets(); + + cycleTabButton = Button.builder(Component.literal("Promotion Cycle"), b -> switchTab(Tab.CYCLE)).bounds(layout.x(12), layout.y(24), layout.w(110), layout.h(18)).build(); + lifetimeTabButton = Button.builder(Component.literal("Lifetime"), b -> switchTab(Tab.LIFETIME)).bounds(layout.x(126), layout.y(24), layout.w(80), layout.h(18)).build(); + this.addRenderableWidget(cycleTabButton); + this.addRenderableWidget(lifetimeTabButton); + + Button closeButton = Button.builder(Component.literal("Close"), b -> onClose()).bounds(layout.x(BASE_PANEL_WIDTH - 62), layout.y(8), layout.w(50), layout.h(16)).build(); + this.addRenderableWidget(closeButton); + + // Cycle tab controls + prevCycleButton = Button.builder(Component.literal("< Previous"), b -> navigateArchive(-1)).bounds(layout.x(226), layout.y(BASE_PANEL_HEIGHT - 26), layout.w(68), layout.h(18)).build(); + nextCycleButton = Button.builder(Component.literal("Next >"), b -> navigateArchive(1)).bounds(layout.x(298), layout.y(BASE_PANEL_HEIGHT - 26), layout.w(56), layout.h(18)).build(); + archiveButton = Button.builder(Component.literal("Cycle Archive"), b -> toggleArchive()).bounds(layout.x(BASE_PANEL_WIDTH - 108), layout.y(BASE_PANEL_HEIGHT - 26), layout.w(96), layout.h(18)).build(); + this.addRenderableWidget(prevCycleButton); + this.addRenderableWidget(nextCycleButton); + this.addRenderableWidget(archiveButton); + + // Lifetime tab controls + fromBox = new EditBox(this.font, layout.x(42), layout.y(48), layout.w(78), layout.h(18), Component.literal("From days ago")); + fromBox.setHint(Component.literal("-# days ago").withStyle(ChatFormatting.GRAY)); + fromBox.setMaxLength(16); + fromBox.setValue(fromDraft); + + toBox = new EditBox(this.font, layout.x(146), layout.y(48), layout.w(78), layout.h(18), Component.literal("To days ago")); + toBox.setHint(Component.literal("-# days ago").withStyle(ChatFormatting.GRAY)); + toBox.setMaxLength(16); + toBox.setValue(toDraft); + + applyIntervalButton = Button.builder(Component.literal("Apply"), b -> applyInterval()).bounds(layout.x(230), layout.y(48), layout.w(46), layout.h(18)).build(); + resetIntervalButton = Button.builder(Component.literal("Reset"), b -> resetInterval()).bounds(layout.x(280), layout.y(48), layout.w(46), layout.h(18)).build(); + finishesToggleButton = Button.builder(Component.literal("Cycle Finishes"), b -> toggleFinishes()).bounds(layout.x(BASE_PANEL_WIDTH - 118), layout.y(48), layout.w(106), layout.h(18)).build(); + + this.addRenderableWidget(fromBox); + this.addRenderableWidget(toBox); + this.addRenderableWidget(applyIntervalButton); + this.addRenderableWidget(resetIntervalButton); + this.addRenderableWidget(finishesToggleButton); + + if (!initialRequestSent && mod != null) { + initialRequestSent = true; + seenCycleGen = mod.cycleLeaderboardGeneration(); + seenLifetimeGen = mod.lifetimeLeaderboardGeneration(); + mod.requestCycleLeaderboard(selectedCycleCode); + } + syncControlState(); + } + + @Override + public void tick() { + super.tick(); + if (mod == null) { + return; + } + int cycleGen = mod.cycleLeaderboardGeneration(); + if (seenCycleGen != cycleGen) { + seenCycleGen = cycleGen; + raidsScroll = 0; + warsScroll = 0; + CycleLeaderboardData.CycleSnapshot snap = mod.knownCycleLeaderboard(); + if (snap != null && !snap.cycleCode().isEmpty() && snap.error().isEmpty()) { + selectedCycleCode = snap.cycleCode(); + } + syncControlState(); + } + int lifeGen = mod.lifetimeLeaderboardGeneration(); + if (seenLifetimeGen != lifeGen) { + seenLifetimeGen = lifeGen; + raidsScroll = 0; + warsScroll = 0; + syncControlState(); + } + } + + private void switchTab(Tab tab) { + if (activeTab == tab) { + return; + } + activeTab = tab; + raidsScroll = 0; + warsScroll = 0; + validationError = ""; + if (tab == Tab.LIFETIME && !lifetimeRequested && mod != null) { + lifetimeRequested = true; + mod.requestLifetimeLeaderboard(null, null); + } + syncControlState(); + } + + private void toggleArchive() { + archiveOpen = !archiveOpen; + syncControlState(); + } + + private void navigateArchive(int step) { + if (mod == null) { + return; + } + CycleLeaderboardData.CycleSnapshot snap = mod.knownCycleLeaderboard(); + if (snap == null || snap.cycles().isEmpty()) { + return; + } + List cycles = snap.cycles(); + int idx = currentCycleIndex(cycles, snap.cycleCode()); + if (idx < 0) { + return; + } + int target = idx + step; + if (target >= 0 && target < cycles.size()) { + selectedCycleCode = cycles.get(target); + mod.requestCycleLeaderboard(selectedCycleCode); + syncControlState(); + } + } + + private void applyInterval() { + CycleLeaderboardData.IntervalDays parsed = CycleLeaderboardData.parseIntervalDays(fromBox.getValue(), toBox.getValue()); + if (parsed == null) { + validationError = "Invalid interval: positive days required, From > To"; + return; + } + validationError = ""; + if (mod != null) { + mod.requestLifetimeLeaderboard(parsed.fromDays(), parsed.toDays()); + } + } + + private void resetInterval() { + fromBox.setValue(""); + toBox.setValue(""); + validationError = ""; + if (mod != null) { + mod.requestLifetimeLeaderboard(null, null); + } + } + + private void toggleFinishes() { + showFinishes = !showFinishes; + raidsScroll = 0; + warsScroll = 0; + syncControlState(); + } + + private void syncControlState() { + boolean isCycle = activeTab == Tab.CYCLE; + cycleTabButton.active = !isCycle; + lifetimeTabButton.active = isCycle; + + archiveButton.visible = isCycle; + prevCycleButton.visible = isCycle && archiveOpen; + nextCycleButton.visible = isCycle && archiveOpen; + + if (isCycle && archiveOpen) { + CycleLeaderboardData.CycleSnapshot snap = mod != null ? mod.knownCycleLeaderboard() : null; + List cycles = snap != null ? snap.cycles() : List.of(); + String activeCode = snap != null ? snap.cycleCode() : ""; + int idx = currentCycleIndex(cycles, activeCode); + prevCycleButton.active = idx > 0; + nextCycleButton.active = idx >= 0 && idx < cycles.size() - 1; + } else { + prevCycleButton.active = false; + nextCycleButton.active = false; + } + + fromBox.visible = !isCycle; + toBox.visible = !isCycle; + applyIntervalButton.visible = !isCycle; + resetIntervalButton.visible = !isCycle; + finishesToggleButton.visible = !isCycle; + finishesToggleButton.setMessage(Component.literal(showFinishes ? "Counts View" : "Cycle Finishes")); + } + + private int currentCycleIndex(List cycles, String activeCode) { + if (cycles == null || cycles.isEmpty()) { + return -1; + } + String code = (activeCode != null && !activeCode.isEmpty()) ? activeCode : selectedCycleCode; + if (code == null || code.isEmpty()) { + return cycles.size() - 1; + } + return cycles.indexOf(code); + } + + @Override + public void render(GuiGraphics g, int mouseX, int mouseY, float delta) { + int scaledMouseX = scaledMouseX(mouseX); + int scaledMouseY = scaledMouseY(mouseY); + + pushReferencePose(g); + layout.drawPanel(g); + + if (activeTab == Tab.CYCLE) { + renderCycleTab(g); + } else { + renderLifetimeTab(g); + } + + super.render(g, scaledMouseX, scaledMouseY, delta); + String heading = activeTab == Tab.CYCLE ? "Promotion Cycle" : "Lifetime Stats"; + g.drawCenteredString(this.font, heading, layout.centerX(), layout.y(10), 0xFFFFFFFF); + popReferencePose(g); + } + + private void renderCycleTab(GuiGraphics g) { + CycleLeaderboardData.CycleSnapshot snap = mod != null ? mod.knownCycleLeaderboard() : null; + String err = mod != null ? mod.recentCycleLeaderboardError() : ""; + + String cycleHeader = (snap != null && !snap.cycleCode().isEmpty()) ? "Cycle " + snap.cycleCode() : "Loading..."; + g.drawString(this.font, cycleHeader, layout.x(220), layout.y(29), 0xFFFFCC55); + + if (!err.isEmpty()) { + g.drawCenteredString(this.font, err, layout.centerX(), layout.y(126), 0xFFFF5555); + return; + } + if (snap == null) { + g.drawCenteredString(this.font, "Loading cycle leaderboard...", layout.centerX(), layout.y(126), 0xFFAAAAAA); + return; + } + + int listTopOffset = listTopOffset(); + g.drawCenteredString(this.font, "Raids", layout.x(LEFT_COL_X + COL_WIDTH / 2), layout.y(listTopOffset - 12), 0xFF55FFFF); + g.drawCenteredString(this.font, "Wars", layout.x(RIGHT_COL_X + COL_WIDTH / 2), layout.y(listTopOffset - 12), 0xFFFF5555); + + renderEntryList(g, LEFT_COL_X, listTopOffset, snap.raids(), raidsScroll, true, true); + renderEntryList(g, RIGHT_COL_X, listTopOffset, snap.wars(), warsScroll, true, true); + + int footerY = layout.y(BASE_PANEL_HEIGHT - 44); + String totals = "Totals: " + snap.totalRaids() + " raids | " + snap.totalWars() + " wars | " + snap.totalTickets() + " tickets"; + g.drawString(this.font, totals, layout.x(12), footerY, 0xFFFFD966); + if (!snap.raffleWinners().isEmpty()) { + StringBuilder raffle = new StringBuilder("Raffle Top 3: "); + List top = snap.raffleWinners().subList(0, Math.min(3, snap.raffleWinners().size())); + for (int i = 0; i < top.size(); i++) { + if (i > 0) { + raffle.append(", "); + } + raffle.append("#").append(i + 1).append(" ").append(top.get(i).name()).append(" (").append(top.get(i).tickets()).append(")"); + } + g.drawString(this.font, trimToWidth(raffle.toString(), layout.w(320)), layout.x(12), footerY + layout.h(12), 0xFFD5A6FF); + } + } + + private void renderLifetimeTab(GuiGraphics g) { + g.drawString(this.font, "From:", layout.x(12), layout.y(53), 0xFFCCCCCC); + g.drawString(this.font, "To:", layout.x(126), layout.y(53), 0xFFCCCCCC); + if (!validationError.isEmpty()) { + g.drawString(this.font, validationError, layout.x(12), layout.y(70), 0xFFFF5555); + } + + CycleLeaderboardData.LifetimeSnapshot snap = mod != null ? mod.knownLifetimeLeaderboard() : null; + String err = mod != null ? mod.recentLifetimeLeaderboardError() : ""; + if (!err.isEmpty()) { + g.drawCenteredString(this.font, err, layout.centerX(), layout.y(140), 0xFFFF5555); + return; + } + if (snap == null) { + g.drawCenteredString(this.font, "Loading leaderboard stats...", layout.centerX(), layout.y(140), 0xFFAAAAAA); + return; + } + + int listTopOffset = listTopOffset(); + if (showFinishes) { + g.drawCenteredString(this.font, "Raids Finishes", layout.x(LEFT_COL_X + COL_WIDTH / 2), layout.y(listTopOffset - 12), 0xFF55FFFF); + g.drawCenteredString(this.font, "Wars Finishes", layout.x(RIGHT_COL_X + COL_WIDTH / 2), layout.y(listTopOffset - 12), 0xFFFF5555); + renderPodiumList(g, LEFT_COL_X, listTopOffset, snap.raidFinishes(), raidsScroll); + renderPodiumList(g, RIGHT_COL_X, listTopOffset, snap.warFinishes(), warsScroll); + return; + } + + String subtitle = snap.hasInterval() ? " (Filtered: no medals)" : ""; + g.drawCenteredString(this.font, "Raids" + subtitle, layout.x(LEFT_COL_X + COL_WIDTH / 2), layout.y(listTopOffset - 12), 0xFF55FFFF); + g.drawCenteredString(this.font, "Wars" + subtitle, layout.x(RIGHT_COL_X + COL_WIDTH / 2), layout.y(listTopOffset - 12), 0xFFFF5555); + + boolean showMedals = !snap.hasInterval(); + renderEntryList(g, LEFT_COL_X, listTopOffset, snap.raids(), raidsScroll, showMedals, false); + renderEntryList(g, RIGHT_COL_X, listTopOffset, snap.wars(), warsScroll, showMedals, false); + } + + private void renderEntryList(GuiGraphics g, int baseColX, int baseTopY, List entries, int scrollOffset, boolean showMedals, boolean showDelta) { + int x = layout.x(baseColX); + int top = layout.y(baseTopY); + int width = layout.w(COL_WIDTH); + int height = layout.h(VISIBLE_ROWS * ROW_PITCH + 4); + g.fill(x, top, x + width, top + height, 0x22000000); + + int total = entries.size(); + int clamped = clampOffset(scrollOffset, total); + for (int vis = 0; vis < VISIBLE_ROWS; vis++) { + int idx = clamped + vis; + if (idx >= total) { + break; + } + CycleLeaderboardData.LeaderboardEntry entry = entries.get(idx); + int rowY = layout.y(baseTopY + 2 + vis * ROW_PITCH); + int rowH = layout.h(ROW_HEIGHT); + g.fill(x + layout.w(2), rowY, x + width - layout.w(2), rowY + rowH, entry.count() <= 0 ? ZERO_ROW_OVERLAY : ROW_FILL); + + int cursorX = x + layout.w(4); + if (showDelta) { + Integer deltaVal = entry.delta(); + String deltaText = deltaVal == null || deltaVal == 0 ? "-" : (deltaVal > 0 ? "+" + deltaVal : String.valueOf(deltaVal)); + int deltaColor = deltaVal == null || deltaVal == 0 ? 0xFF888888 : (deltaVal > 0 ? 0xFF55FF55 : 0xFFFF5555); + g.drawString(this.font, deltaText, cursorX, rowY + layout.h(4), deltaColor); + cursorX += layout.w(22); + } + + if (this.minecraft != null) { + PlayerSkin skin = PlayerSkinResolver.skinFor(this.minecraft, parseUuid(entry.uuid()), entry.name()); + if (skin != null) { + PlayerFaceRenderer.draw(g, skin, cursorX, rowY + layout.h(2), layout.w(10)); + } + } + cursorX += layout.w(13); + + int rankColor = switch (entry.rank()) { + case 1 -> 0xFFFFD700; + case 2 -> 0xFFC0C0C0; + case 3 -> 0xFFCD7F32; + default -> 0xFFAAAAAA; + }; + String rankStr = "#" + entry.rank(); + g.drawString(this.font, rankStr, cursorX, rowY + layout.h(4), entry.count() <= 0 ? 0xFFCCCCCC : rankColor); + cursorX += layout.w(20); + + int medal = CycleLeaderboardData.medalForEntry(entry, showMedals); + if (medal >= 1 && medal <= 3) { + drawTexture(g, MEDAL_TEXTURES[medal - 1], cursorX, rowY + layout.h(2), layout.w(11), layout.h(11)); + cursorX += layout.w(13); + } + + String countText = String.valueOf(entry.count()); + int countWidth = this.font.width(countText); + int countX = x + width - layout.w(6) - countWidth; + int maxNameW = Math.max(layout.w(24), countX - cursorX - layout.w(4)); + int textColor = entry.count() <= 0 ? 0xFFDDDDDD : 0xFFFFFFFF; + g.drawString(this.font, trimToWidth(entry.name(), maxNameW), cursorX, rowY + layout.h(4), textColor); + g.drawString(this.font, countText, countX, rowY + layout.h(4), textColor); + } + + layout.drawScrollbar(g, layout.x(baseColX + SCROLLBAR_OFFSET), top, layout.w(SCROLLBAR_WIDTH), height, VISIBLE_ROWS, total, clamped); + } + + private void renderPodiumList(GuiGraphics g, int baseColX, int baseTopY, List entries, int scrollOffset) { + int x = layout.x(baseColX); + int top = layout.y(baseTopY); + int width = layout.w(COL_WIDTH); + int height = layout.h(VISIBLE_ROWS * ROW_PITCH + 4); + g.fill(x, top, x + width, top + height, 0x22000000); + + int total = entries.size(); + int clamped = clampOffset(scrollOffset, total); + for (int vis = 0; vis < VISIBLE_ROWS; vis++) { + int idx = clamped + vis; + if (idx >= total) { + break; + } + CycleLeaderboardData.PodiumEntry entry = entries.get(idx); + int rowY = layout.y(baseTopY + 2 + vis * ROW_PITCH); + int rowH = layout.h(ROW_HEIGHT); + g.fill(x + layout.w(2), rowY, x + width - layout.w(2), rowY + rowH, ROW_FILL); + + int cursorX = x + layout.w(4); + if (this.minecraft != null) { + PlayerSkin skin = PlayerSkinResolver.skinFor(this.minecraft, parseUuid(entry.uuid()), entry.name()); + if (skin != null) { + PlayerFaceRenderer.draw(g, skin, cursorX, rowY + layout.h(2), layout.w(10)); + } + } + cursorX += layout.w(13); + + int statsStart = x + width - layout.w(88); + int maxNameW = Math.max(layout.w(24), statsStart - cursorX - layout.w(4)); + g.drawString(this.font, trimToWidth(entry.name(), maxNameW), cursorX, rowY + layout.h(4), 0xFFFFFFFF); + + int[] counts = {entry.first(), entry.second(), entry.third()}; + for (int m = 0; m < 3; m++) { + int slotX = statsStart + m * layout.w(28); + drawTexture(g, MEDAL_TEXTURES[m], slotX, rowY + layout.h(3), layout.w(9), layout.h(9)); + g.drawString(this.font, String.valueOf(counts[m]), slotX + layout.w(11), rowY + layout.h(4), 0xFFEFEFEF); + } + } + + layout.drawScrollbar(g, layout.x(baseColX + SCROLLBAR_OFFSET), top, layout.w(SCROLLBAR_WIDTH), height, VISIBLE_ROWS, total, clamped); + } + + private int listTopOffset() { + return activeTab == Tab.CYCLE ? 62 : 84; + } + + private List leftEntries() { + if (mod == null) { + return List.of(); + } + if (activeTab == Tab.CYCLE) { + CycleLeaderboardData.CycleSnapshot snap = mod.knownCycleLeaderboard(); + return snap != null ? snap.raids() : List.of(); + } + CycleLeaderboardData.LifetimeSnapshot snap = mod.knownLifetimeLeaderboard(); + if (snap == null) { + return List.of(); + } + return showFinishes ? snap.raidFinishes() : snap.raids(); + } + + private List rightEntries() { + if (mod == null) { + return List.of(); + } + if (activeTab == Tab.CYCLE) { + CycleLeaderboardData.CycleSnapshot snap = mod.knownCycleLeaderboard(); + return snap != null ? snap.wars() : List.of(); + } + CycleLeaderboardData.LifetimeSnapshot snap = mod.knownLifetimeLeaderboard(); + if (snap == null) { + return List.of(); + } + return showFinishes ? snap.warFinishes() : snap.wars(); + } + + private int clampOffset(int offset, int total) { + int max = Math.max(0, total - VISIBLE_ROWS); + return Math.clamp(offset, 0, max); + } + + private static UUID parseUuid(String raw) { + if (raw == null || raw.isBlank()) { + return null; + } + try { + return UUID.fromString(raw.trim()); + } catch (IllegalArgumentException e) { + return null; + } + } + + private String trimToWidth(String text, int width) { + if (this.font.width(text) <= width) { + return text; + } + return this.font.plainSubstrByWidth(text, Math.max(0, width - this.font.width("..."))) + "..."; + } + + private static void drawTexture(GuiGraphics g, Identifier id, int x, int y, int w, int h) { + if (id == null || w <= 0 || h <= 0) { + return; + } + g.pose().pushMatrix(); + g.pose().translate(x, y); + g.pose().scale(w / 64.0f, h / 64.0f); + g.blit(RenderPipelines.GUI_TEXTURED, id, 0, 0, 0.0f, 0.0f, 64, 64, 64, 64); + g.pose().popMatrix(); + } + + private boolean isInPane(double scaledX, double scaledY, int baseColX) { + int left = layout.x(baseColX); + int top = layout.y(listTopOffset()); + int right = left + layout.w(COL_WIDTH + SCROLLBAR_WIDTH + 4); + int bottom = top + layout.h(VISIBLE_ROWS * ROW_PITCH + 4); + return scaledX >= left && scaledX <= right && scaledY >= top && scaledY <= bottom; + } + + private boolean isOverScrollbar(double scaledX, double scaledY, int baseColX) { + int sbX = layout.x(baseColX + SCROLLBAR_OFFSET); + int top = layout.y(listTopOffset()); + int bottom = top + layout.h(VISIBLE_ROWS * ROW_PITCH + 4); + return scaledX >= sbX && scaledX <= sbX + layout.w(SCROLLBAR_WIDTH) && scaledY >= top && scaledY <= bottom; + } + + private void updateScrollFromMouse(double scaledY, int pane) { + int top = layout.y(listTopOffset()); + int height = layout.h(VISIBLE_ROWS * ROW_PITCH + 4); + int total = pane == 1 ? leftEntries().size() : rightEntries().size(); + int maxOffset = Math.max(0, total - VISIBLE_ROWS); + float ratio = Math.clamp((float) ((scaledY - top) / Math.max(1, height)), 0.0f, 1.0f); + int target = Math.round(ratio * maxOffset); + if (pane == 1) { + raidsScroll = target; + } else { + warsScroll = target; + } + } + + @Override + public boolean mouseClicked(MouseButtonEvent event, boolean doubleClick) { + MouseButtonEvent scaled = rescale(event); + if (scaled.button() == 0) { + if (isOverScrollbar(scaled.x(), scaled.y(), LEFT_COL_X)) { + draggingPane = 1; + updateScrollFromMouse(scaled.y(), 1); + return true; + } + if (isOverScrollbar(scaled.x(), scaled.y(), RIGHT_COL_X)) { + draggingPane = 2; + updateScrollFromMouse(scaled.y(), 2); + return true; + } + } + return super.mouseClicked(scaled, doubleClick); + } + + @Override + public boolean mouseReleased(MouseButtonEvent event) { + draggingPane = 0; + return super.mouseReleased(rescale(event)); + } + + @Override + public boolean mouseDragged(MouseButtonEvent event, double d, double e) { + MouseButtonEvent scaled = rescale(event); + if (draggingPane != 0) { + updateScrollFromMouse(scaled.y(), draggingPane); + return true; + } + return super.mouseDragged(scaled, d, e); + } + + @Override + public boolean mouseScrolled(double mouseX, double mouseY, double scrollX, double scrollY) { + double sx = mouseX / uiScale; + double sy = mouseY / uiScale; + int step = scrollY > 0 ? -1 : 1; + if (isInPane(sx, sy, LEFT_COL_X)) { + raidsScroll = clampOffset(raidsScroll + step, leftEntries().size()); + return true; + } + if (isInPane(sx, sy, RIGHT_COL_X)) { + warsScroll = clampOffset(warsScroll + step, rightEntries().size()); + return true; + } + return super.mouseScrolled(sx, sy, scrollX, scrollY); + } + + @Override + public boolean keyPressed(KeyEvent event) { + if (activeTab == Tab.LIFETIME) { + if (fromBox.keyPressed(event) || toBox.keyPressed(event)) { + return true; + } + } + return super.keyPressed(event); + } + + @Override + public boolean charTyped(CharacterEvent event) { + if (activeTab == Tab.LIFETIME) { + if (fromBox.charTyped(event) || toBox.charTyped(event)) { + return true; + } + } + return super.charTyped(event); + } +} diff --git a/src/tel/eden/mod/net/BridgeWebSocketClient.java b/src/tel/eden/mod/net/BridgeWebSocketClient.java index 2a623bc..0699961 100644 --- a/src/tel/eden/mod/net/BridgeWebSocketClient.java +++ b/src/tel/eden/mod/net/BridgeWebSocketClient.java @@ -222,6 +222,18 @@ default void onLongEventRewards(int pendingLe, String error) { /** A traveler-chat line from the game or Discord side. */ default void onTravelerChat(String author, String content, String source, String color, String replyTo, String replyExcerpt, String messageId) { } + + /** Promotion cycle leaderboard snapshot (current or archived cycle). */ + default void onCycleLeaderboard(CycleLeaderboardData.CycleSnapshot snapshot) { + } + + /** Lifetime or custom-interval leaderboard snapshot with cycle podium finishes. */ + default void onLifetimeLeaderboard(CycleLeaderboardData.LifetimeSnapshot snapshot) { + } + + /** Broadcast sent when a promotion cycle finishes and finalizes. */ + default void onCycleConcluded(CycleLeaderboardData.ConcludedCycleSummary summary) { + } } /** @@ -1066,6 +1078,37 @@ public void sendLongEventStateRequest() { sendType("longEventStateRequest"); } + /** Request a promotion-cycle leaderboard snapshot (null/blank means current cycle). */ + public void sendCycleLeaderboardRequest(String cycleCode) { + WebSocket current = socket; + if (current == null) { + return; + } + JsonObject obj = new JsonObject(); + obj.addProperty("type", "cycleLeaderboardRequest"); + if (cycleCode != null && !cycleCode.isBlank()) { + obj.addProperty("cycleCode", cycleCode.trim()); + } + enqueueSend(current, obj); + } + + /** Request lifetime (or custom day-interval) Raids/Wars leaderboards and cycle finishes. */ + public void sendLifetimeLeaderboardRequest(Double fromDays, Double toDays) { + WebSocket current = socket; + if (current == null) { + return; + } + JsonObject obj = new JsonObject(); + obj.addProperty("type", "lifetimeLeaderboardRequest"); + if (fromDays != null) { + obj.addProperty("fromDays", fromDays); + } + if (toDays != null) { + obj.addProperty("toDays", toDays); + } + enqueueSend(current, obj); + } + /** Ask the backend to reroll a long-event mission slot ({@code "daily"}, {@code "weekly"}, or {@code "repeatable"}). */ public void sendLongEventReroll(String slot) { sendLongEventReroll(slot, false); @@ -1561,6 +1604,9 @@ private void handlePayload(String payload) { sink.onLongEventState(state, state.isSnapshot()); } case "longEventRewards" -> sink.onLongEventRewards(getInt(obj, "pendingLe", 0), get(obj, "error")); + case "cycleLeaderboardReply" -> sink.onCycleLeaderboard(parseCycleSnapshot(obj)); + case "lifetimeLeaderboardReply" -> sink.onLifetimeLeaderboard(parseLifetimeSnapshot(obj)); + case "cycleConcluded" -> sink.onCycleConcluded(parseConcludedCycleSummary(obj)); case "authChallenge" -> handleAuthChallenge(get(obj, "serverId")); case "authOk" -> { authenticated = true; @@ -1914,4 +1960,71 @@ static LongEventState parseLongEventState(JsonObject obj) { } return new LongEventState(getBool(obj, "active"), getLong(obj, "endsAtMs", 0L), getInt(obj, "pendingLe", 0), getInt(obj, "rerollCost", 0), getInt(obj, "triviaPoints", 0), getBool(obj, "repeatSlot2Active"), get(obj, "error"), slots, masters, specialSlots); } + + private static Integer getOptionalInt(JsonObject obj, String key) { + return obj.has(key) && !obj.get(key).isJsonNull() ? obj.get(key).getAsInt() : null; + } + + private static Double getOptionalDouble(JsonObject obj, String key) { + return obj.has(key) && !obj.get(key).isJsonNull() ? obj.get(key).getAsDouble() : null; + } + + private static java.util.List parseLeaderboardEntries(JsonObject obj, String key) { + java.util.List out = new java.util.ArrayList<>(); + if (obj.has(key) && obj.get(key).isJsonArray()) { + for (var element : obj.get(key).getAsJsonArray()) { + if (element.isJsonObject()) { + JsonObject row = element.getAsJsonObject(); + out.add(new CycleLeaderboardData.LeaderboardEntry(get(row, "uuid"), get(row, "name"), getInt(row, "count", 0), getInt(row, "rank", 0), getOptionalInt(row, "delta"))); + } + } + } + return CycleLeaderboardData.rankEntries(out); + } + + private static java.util.List parsePodiumEntries(JsonObject obj, String key) { + java.util.List out = new java.util.ArrayList<>(); + if (obj.has(key) && obj.get(key).isJsonArray()) { + for (var element : obj.get(key).getAsJsonArray()) { + if (element.isJsonObject()) { + JsonObject row = element.getAsJsonObject(); + out.add(new CycleLeaderboardData.PodiumEntry(get(row, "uuid"), get(row, "name"), getInt(row, "first", 0), getInt(row, "second", 0), getInt(row, "third", 0))); + } + } + } + return java.util.List.copyOf(out); + } + + private static java.util.List parseRaffleWinners(JsonObject obj) { + java.util.List out = new java.util.ArrayList<>(); + if (obj.has("raffleWinners") && obj.get("raffleWinners").isJsonArray()) { + for (var element : obj.get("raffleWinners").getAsJsonArray()) { + if (element.isJsonObject() && out.size() < 3) { + JsonObject row = element.getAsJsonObject(); + out.add(new CycleLeaderboardData.RaffleWinner(get(row, "name"), getInt(row, "tickets", 0), getInt(row, "raids", 0))); + } + } + } + return java.util.List.copyOf(out); + } + + static CycleLeaderboardData.CycleSnapshot parseCycleSnapshot(JsonObject obj) { + String error = obj.has("error") && !obj.get("error").isJsonNull() ? get(obj, "error") : ""; + if (!error.isEmpty()) { + return CycleLeaderboardData.CycleSnapshot.error(error); + } + return new CycleLeaderboardData.CycleSnapshot(get(obj, "cycleCode"), getStringArray(obj, "cycles"), parseLeaderboardEntries(obj, "raids"), parseLeaderboardEntries(obj, "wars"), parseRaffleWinners(obj), getInt(obj, "totalRaids", 0), getInt(obj, "totalWars", 0), getInt(obj, "totalTickets", 0), ""); + } + + static CycleLeaderboardData.LifetimeSnapshot parseLifetimeSnapshot(JsonObject obj) { + String error = obj.has("error") && !obj.get("error").isJsonNull() ? get(obj, "error") : ""; + if (!error.isEmpty()) { + return CycleLeaderboardData.LifetimeSnapshot.error(error); + } + return new CycleLeaderboardData.LifetimeSnapshot(getBool(obj, "hasInterval"), getOptionalDouble(obj, "fromDays"), getOptionalDouble(obj, "toDays"), parseLeaderboardEntries(obj, "raids"), parseLeaderboardEntries(obj, "wars"), parsePodiumEntries(obj, "raidFinishes"), parsePodiumEntries(obj, "warFinishes"), ""); + } + + static CycleLeaderboardData.ConcludedCycleSummary parseConcludedCycleSummary(JsonObject obj) { + return new CycleLeaderboardData.ConcludedCycleSummary(get(obj, "cycleCode"), parseLeaderboardEntries(obj, "topRaids"), parseLeaderboardEntries(obj, "topWars"), parseRaffleWinners(obj), getInt(obj, "totalRaids", 0), getInt(obj, "totalWars", 0), getInt(obj, "totalTickets", 0)); + } } diff --git a/src/tel/eden/mod/net/CycleLeaderboardData.java b/src/tel/eden/mod/net/CycleLeaderboardData.java new file mode 100644 index 0000000..819a0ab --- /dev/null +++ b/src/tel/eden/mod/net/CycleLeaderboardData.java @@ -0,0 +1,135 @@ +package tel.eden.mod.net; + +import java.util.ArrayList; +import java.util.Comparator; +import java.util.List; +import java.util.regex.Pattern; + +/** Models and ranking/interval validation helpers for Promotion Cycle and Lifetime leaderboards. */ +public final class CycleLeaderboardData { + private static final Pattern POSITIVE_NUMBER = Pattern.compile("^\\d+(?:\\.\\d+)?$"); + + private CycleLeaderboardData() { + } + + /** One ranked player row on either the cycle or lifetime leaderboard. */ + public record LeaderboardEntry(String uuid, String name, int count, int rank, Integer delta) { + } + + /** Lifetime cycle podium finishes (number of #1, #2, and #3 finishes across past cycles). */ + public record PodiumEntry(String uuid, String name, int first, int second, int third) { + } + + /** One promotion-cycle raffle winner (only top 3 are shown publicly). */ + public record RaffleWinner(String name, int tickets, int raids) { + } + + /** Validated custom day-interval bounds (`toDays == 0.0` means right now). */ + public record IntervalDays(double fromDays, double toDays) { + } + + /** Snapshot returned by {@code cycleLeaderboardReply}. */ + public record CycleSnapshot(String cycleCode, List cycles, List raids, List wars, List raffleWinners, int totalRaids, int totalWars, int totalTickets, String error) { + public static CycleSnapshot error(String message) { + return new CycleSnapshot("", List.of(), List.of(), List.of(), List.of(), 0, 0, 0, message); + } + } + + /** Snapshot returned by {@code lifetimeLeaderboardReply}. */ + public record LifetimeSnapshot(boolean hasInterval, Double fromDays, Double toDays, List raids, List wars, List raidFinishes, List warFinishes, String error) { + public static LifetimeSnapshot error(String message) { + return new LifetimeSnapshot(false, null, null, List.of(), List.of(), List.of(), List.of(), message); + } + } + + /** Broadcast payload sent to guild members when a promotion cycle concludes. */ + public record ConcludedCycleSummary(String cycleCode, List topRaids, List topWars, List raffleWinners, int totalRaids, int totalWars, int totalTickets) { + } + + /** Derive a printable concluded-cycle summary from any fetched cycle snapshot. */ + public static ConcludedCycleSummary summaryFromSnapshot(CycleSnapshot snap) { + List topRaids = snap.raids().stream().filter(e -> e.count() > 0 && e.rank() <= 3).toList(); + List topWars = snap.wars().stream().filter(e -> e.count() > 0 && e.rank() == 1).toList(); + List winners = snap.raffleWinners().subList(0, Math.min(3, snap.raffleWinners().size())); + return new ConcludedCycleSummary(snap.cycleCode(), topRaids, topWars, winners, snap.totalRaids(), snap.totalWars(), snap.totalTickets()); + } + + /** + * Sort entries descending by count (zeros at the bottom) and apply Standard Competition + * Ranking ({@code 1, 2, 2, 4}) so tied players share the same position. + */ + public static List rankEntries(List raw) { + if (raw == null || raw.isEmpty()) { + return List.of(); + } + List sorted = new ArrayList<>(raw); + sorted.sort(Comparator.comparingInt(LeaderboardEntry::count).reversed().thenComparing(e -> e.name().toLowerCase(java.util.Locale.ROOT))); + List out = new ArrayList<>(sorted.size()); + int prevCount = Integer.MIN_VALUE; + int prevRank = 0; + for (int i = 0; i < sorted.size(); i++) { + LeaderboardEntry entry = sorted.get(i); + int rank = (i > 0 && entry.count() == prevCount) ? prevRank : (i + 1); + prevCount = entry.count(); + prevRank = rank; + out.add(new LeaderboardEntry(entry.uuid(), entry.name(), entry.count(), rank, entry.delta())); + } + return List.copyOf(out); + } + + /** + * Return medal index ({@code 1}, {@code 2}, or {@code 3}) for {@code entry}, or {@code 0} for + * no medal (zero count, rank below 3, or interval-filtered leaderboards where medals are hidden). + */ + public static int medalForEntry(LeaderboardEntry entry, boolean showMedals) { + if (!showMedals || entry == null || entry.count() <= 0) { + return 0; + } + int rank = entry.rank(); + return rank >= 1 && rank <= 3 ? rank : 0; + } + + /** + * Parse user-entered interval fields ({@code From} and optional {@code To} days ago). + * Only positive integers/decimals are accepted; empty {@code To} means now ({@code 0.0}), + * and {@code From} must be strictly greater than {@code To}. Returns {@code null} on invalid input. + */ + public static IntervalDays parseIntervalDays(String fromRaw, String toRaw) { + if (fromRaw == null) { + return null; + } + String fromTrim = fromRaw.trim(); + if (fromTrim.isEmpty() || !POSITIVE_NUMBER.matcher(fromTrim).matches()) { + return null; + } + double fromVal; + try { + fromVal = Double.parseDouble(fromTrim); + } catch (NumberFormatException e) { + return null; + } + if (!Double.isFinite(fromVal) || fromVal <= 0.0) { + return null; + } + + double toVal = 0.0; + if (toRaw != null && !toRaw.trim().isEmpty()) { + String toTrim = toRaw.trim(); + if (!POSITIVE_NUMBER.matcher(toTrim).matches()) { + return null; + } + try { + toVal = Double.parseDouble(toTrim); + } catch (NumberFormatException e) { + return null; + } + if (!Double.isFinite(toVal) || toVal <= 0.0) { + return null; + } + } + if (fromVal <= toVal) { + return null; + } + return new IntervalDays(fromVal, toVal); + } +} diff --git a/src/tel/eden/mod/net/OutboundPolicy.java b/src/tel/eden/mod/net/OutboundPolicy.java index 8935800..7f154f0 100644 --- a/src/tel/eden/mod/net/OutboundPolicy.java +++ b/src/tel/eden/mod/net/OutboundPolicy.java @@ -27,7 +27,7 @@ public static Standing of(boolean linked, boolean member, boolean traveler) { private OutboundPolicy() { } - private static final Set GUILD_ONLY_INBOUND = Set.of("warBoard", "discordMessage", "loginNotice", "logoutNotice", "onlineList"); + private static final Set GUILD_ONLY_INBOUND = Set.of("warBoard", "discordMessage", "loginNotice", "logoutNotice", "onlineList", "cycleLeaderboardReply", "lifetimeLeaderboardReply", "cycleConcluded"); /** Defence in depth: the server never sends these to a traveler, so drop them if one arrives. */ public static boolean inboundAllowed(Standing standing, String type) { diff --git a/test/tel/eden/mod/net/CycleLeaderboardTest.java b/test/tel/eden/mod/net/CycleLeaderboardTest.java new file mode 100644 index 0000000..71146f3 --- /dev/null +++ b/test/tel/eden/mod/net/CycleLeaderboardTest.java @@ -0,0 +1,100 @@ +package tel.eden.mod.net; + +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertFalse; +import static org.junit.jupiter.api.Assertions.assertNotNull; +import static org.junit.jupiter.api.Assertions.assertNull; +import static org.junit.jupiter.api.Assertions.assertTrue; + +import com.google.gson.JsonParser; +import java.util.List; +import net.minecraft.network.chat.Component; +import org.junit.jupiter.api.Test; +import tel.eden.mod.chat.DiscordChatFormatter; + +class CycleLeaderboardTest { + @Test + void standardCompetitionRankingAndZeros() { + List ranked = CycleLeaderboardData.rankEntries(List.of(new CycleLeaderboardData.LeaderboardEntry("u2", "Bob", 10, 0, 1), new CycleLeaderboardData.LeaderboardEntry("u3", "Carol", 0, 0, null), new CycleLeaderboardData.LeaderboardEntry("u1", "Alice", 10, 0, 0), new CycleLeaderboardData.LeaderboardEntry("u4", "Dave", 5, 0, -2))); + assertEquals(4, ranked.size()); + assertEquals("Alice", ranked.get(0).name()); + assertEquals(1, ranked.get(0).rank()); + assertEquals("Bob", ranked.get(1).name()); + assertEquals(1, ranked.get(1).rank()); + assertEquals("Dave", ranked.get(2).name()); + assertEquals(3, ranked.get(2).rank()); + assertEquals("Carol", ranked.get(3).name()); + assertEquals(4, ranked.get(3).rank()); + assertEquals(0, ranked.get(3).count()); + + assertEquals(1, CycleLeaderboardData.medalForEntry(ranked.get(0), true)); + assertEquals(1, CycleLeaderboardData.medalForEntry(ranked.get(1), true)); + assertEquals(3, CycleLeaderboardData.medalForEntry(ranked.get(2), true)); + assertEquals(0, CycleLeaderboardData.medalForEntry(ranked.get(3), true)); + assertEquals(0, CycleLeaderboardData.medalForEntry(ranked.get(0), false)); + } + + @Test + void intervalValidation() { + CycleLeaderboardData.IntervalDays openEnded = CycleLeaderboardData.parseIntervalDays("14.5", ""); + assertNotNull(openEnded); + assertEquals(14.5, openEnded.fromDays(), 1e-9); + assertEquals(0.0, openEnded.toDays(), 1e-9); + + CycleLeaderboardData.IntervalDays bounded = CycleLeaderboardData.parseIntervalDays("30", "7.25"); + assertNotNull(bounded); + assertEquals(30.0, bounded.fromDays(), 1e-9); + assertEquals(7.25, bounded.toDays(), 1e-9); + + assertNull(CycleLeaderboardData.parseIntervalDays("", "")); + assertNull(CycleLeaderboardData.parseIntervalDays("-5", "")); + assertNull(CycleLeaderboardData.parseIntervalDays("0", "")); + assertNull(CycleLeaderboardData.parseIntervalDays("5", "-1")); + assertNull(CycleLeaderboardData.parseIntervalDays("5", "5")); + assertNull(CycleLeaderboardData.parseIntervalDays("3", "7")); + assertNull(CycleLeaderboardData.parseIntervalDays("abc", "")); + } + + @Test + void cycleConcludedAndPrintFormattingCapRaffleToThree() { + Component announcement = DiscordChatFormatter.cycleConcluded("2604A"); + String text = announcement.getString(); + assertTrue(text.contains("The promotion cycle has concluded!")); + assertTrue(text.contains("[Print]")); + assertTrue(text.contains("[View]")); + + CycleLeaderboardData.ConcludedCycleSummary summary = new CycleLeaderboardData.ConcludedCycleSummary("2604A", List.of(new CycleLeaderboardData.LeaderboardEntry("u1", "Alice", 40, 1, null), new CycleLeaderboardData.LeaderboardEntry("u2", "Bob", 35, 2, null), new CycleLeaderboardData.LeaderboardEntry("u3", "Carol", 30, 3, null), new CycleLeaderboardData.LeaderboardEntry("u4", "Dave", 20, 4, null)), List.of(new CycleLeaderboardData.LeaderboardEntry("u2", "Bob", 55, 1, null)), List.of(new CycleLeaderboardData.RaffleWinner("Alice", 8, 40), new CycleLeaderboardData.RaffleWinner("Bob", 7, 35), new CycleLeaderboardData.RaffleWinner("Carol", 6, 30), new CycleLeaderboardData.RaffleWinner("Dave", 4, 20)), 125, 55, 25); + String printed = DiscordChatFormatter.formatCyclePrint(summary).getString(); + assertTrue(printed.contains("Top 3 Raids:")); + assertTrue(printed.contains("Alice")); + assertTrue(printed.contains("Carol")); + assertTrue(printed.contains("Top 1 Wars:")); + assertTrue(printed.contains("Top 3 Raffle:")); + assertFalse(printed.contains("Dave")); + assertTrue(printed.contains("125 raids | 55 wars | 25 tickets")); + } + + @Test + void outboundBlocksObserversAndTravelersFromCycleRequests() { + for (String type : List.of("cycleLeaderboardRequest", "lifetimeLeaderboardRequest")) { + assertFalse(OutboundPolicy.allowed(OutboundPolicy.Standing.UNKNOWN, type)); + assertFalse(OutboundPolicy.allowed(OutboundPolicy.Standing.NOT_LINKED, type)); + assertFalse(OutboundPolicy.allowed(OutboundPolicy.Standing.NOT_MEMBER, type)); + assertFalse(OutboundPolicy.allowed(OutboundPolicy.Standing.TRAVELER, type)); + assertTrue(OutboundPolicy.allowed(OutboundPolicy.Standing.FULL, type)); + } + for (String reply : List.of("cycleLeaderboardReply", "lifetimeLeaderboardReply", "cycleConcluded")) { + assertFalse(OutboundPolicy.inboundAllowed(OutboundPolicy.Standing.TRAVELER, reply)); + assertTrue(OutboundPolicy.inboundAllowed(OutboundPolicy.Standing.FULL, reply)); + } + } + + @Test + void jsonParsersPreserveErrorStrings() { + var cycleErr = BridgeWebSocketClient.parseCycleSnapshot(JsonParser.parseString("{\"type\":\"cycleLeaderboardReply\",\"error\":\"Failed to fetch cycle leaderboard\"}").getAsJsonObject()); + assertEquals("Failed to fetch cycle leaderboard", cycleErr.error()); + + var lifeErr = BridgeWebSocketClient.parseLifetimeSnapshot(JsonParser.parseString("{\"type\":\"lifetimeLeaderboardReply\",\"error\":\"Failed to fetch leaderboard stats\"}").getAsJsonObject()); + assertEquals("Failed to fetch leaderboard stats", lifeErr.error()); + } +} diff --git a/test/tel/eden/mod/net/OutboundPolicyTest.java b/test/tel/eden/mod/net/OutboundPolicyTest.java index 07a1c18..00d524e 100644 --- a/test/tel/eden/mod/net/OutboundPolicyTest.java +++ b/test/tel/eden/mod/net/OutboundPolicyTest.java @@ -21,7 +21,7 @@ class OutboundPolicyTest { // Every type BWSC sends that a traveler must NOT be able to send. A new send* type that is // in neither set fails classifiesEveryTypeBwscCanSend until someone decides. - private static final Set GUILD_ONLY = Set.of("allyActivityRequest", "annihilation", "aspectGiveawayRequest", "aspectsPendingRequest", "bankEvent", "emeraldsPendingRequest", "giftLockAcquire", "giftLockRelease", "guildAlliances", "guildAnnounce", "guildEvent", "guildLogSnapshot", "guildManageStatus", "guildReward", "guildStorage", "itemCard", "login", "longEventMysteryGuess", "longEventReroll", "longEventRewardsRequest", "longEventStateRequest", "onlineRequest", "radianceCast", "radianceGroup", "raidCompletion", "rankChange", "rewardDeductRequest", "rewardOptOutRequest", "rewardStatusRequest", "territoryDefended", "warAttended", "warCountsRequest", "warDefense", "warGoing", "warGoingInside", "warQueued", "warTimerEnded", "wynnMessage"); + private static final Set GUILD_ONLY = Set.of("allyActivityRequest", "annihilation", "aspectGiveawayRequest", "aspectsPendingRequest", "bankEvent", "cycleLeaderboardRequest", "emeraldsPendingRequest", "giftLockAcquire", "giftLockRelease", "guildAlliances", "guildAnnounce", "guildEvent", "guildLogSnapshot", "guildManageStatus", "guildReward", "guildStorage", "itemCard", "lifetimeLeaderboardRequest", "login", "longEventMysteryGuess", "longEventReroll", "longEventRewardsRequest", "longEventStateRequest", "onlineRequest", "radianceCast", "radianceGroup", "raidCompletion", "rankChange", "rewardDeductRequest", "rewardOptOutRequest", "rewardStatusRequest", "territoryDefended", "warAttended", "warCountsRequest", "warDefense", "warGoing", "warGoingInside", "warQueued", "warTimerEnded", "wynnMessage"); @Test void travelerGetsExactlyTheAllowlist() { From 0269bffbe3158c00ba61b6badb41a82f13f0996a Mon Sep 17 00:00:00 2001 From: Good627 <193092356+Good627@users.noreply.github.com> Date: Wed, 18 Nov 2026 00:29:21 +0200 Subject: [PATCH 2/8] fix: replace 1st-3rd medal icons and debounce rapid cycle/lifetime requests --- .../edenmod/textures/gui/cycle/medal_1.png | Bin 5115 -> 4012 bytes .../edenmod/textures/gui/cycle/medal_2.png | Bin 3296 -> 4101 bytes .../edenmod/textures/gui/cycle/medal_3.png | Bin 5049 -> 4493 bytes src/tel/eden/mod/EdenModClient.java | 120 +++++++++++------- .../eden/mod/gui/PromotionCycleScreen.java | 9 +- 5 files changed, 82 insertions(+), 47 deletions(-) diff --git a/resources/assets/edenmod/textures/gui/cycle/medal_1.png b/resources/assets/edenmod/textures/gui/cycle/medal_1.png index 8b90fcc43f9b9e9e164c629e55b846cf38811751..0bd05072e65e8e6ac7e2203b36bd0d5e22213e84 100644 GIT binary patch literal 4012 zcmV;d4^!}oP)% z3yfuVUB^HF*LlpH=g!V<*=^~Tt}TxR<=G%&Nb!-VL>^tmKpJC^tOk`35)i0J)M#Ri zpctf40wF3@g9KVY+p4wD3JFROupqcC-AA`Oubulium8jR&+Ohit-I~q>CASu-{j1_ zbMF8A-@o7g`+FS0Ch@-ay)V4~1Al}IigEDb7d)3c@4Qp61_$wH>v1U zDRW|ut-_O2)-`e}LzI%tCCDkyihr0{a&l=X%03~tJWOEP&y3xM9ILR0!YG{R^P$12W|*+i<1o(oY?Ge8T+HRnYAsU~>kLyuF~p@y))LAOsJ$b}Qq<>H@lqk3puFiPa9_Hc%sIZhb}yfwJs6Dl z6sBZ#>BI%)^PTT_Pq_IbA07Vx?|beinJYnNs6V+4`<$1e9JFfadQB}1(!y7|il02T z28^el#@+${A0c^)LyS}SmQUOg&?&O&@v+}}7rUwgjX+7s`)_oUM8#X;I!4{Eq=7XMS+AXAo;(J#+ z5(i!j(%=0A;fH=WYD~oPeKc=;K4L;5yN;I}y^L?1hR)nbUcD5|c0BKxta#JZ=xCL9 z-A~OVA}I9RehmAS+gZvbbJno$t9vLi!F12_qU*k&&)#{P*l{Je5z|SB#=7AS@Y%z7 zC$I{H@B}OIi6d_`PC=*xnO2nElg-W<^}?sUH14L|K!JKja?yN*t^ z2tu*&;3-bk5AbwgQcJ!dcCoNpuvBN*{m&qsjoN%2-S2%DVRm6W+*d2ou#d?za1Rv+ z4(&!PY3jsr&Hk(S$1RRSuuYiVyDvEJkwWliS1W!xJBDu(9@_VEra$@_LRRC%4AVdN zEV?HbnGB08>Wpi@b&%O=k)Rg1>G$5kn{WJuVV%c*>if97cLEy(uQ~x=TfTzjPD47V z>8+d;m)I%LB~2=X=;6znm5!pHLY_K0x@zazgaM{mV0XVnRT;kS&@CAC=W*G^w(C%@(y*=CCg_~VMJ%o>^j3lu}WG7vIbUF1GASQ>Qmd*ZMIDWHsZ~P z4~L^){AUVphz!s@`v++J8jYD__kaE?$ckQQFd^qIIm>iWqqSyXVS$C+BirH3xBr7F zsmR2DH@*A!dHs=J-1hzob^t$n_=a%jzub*)YDB&Ob&bU#Y!8zyP-X$$Z;*8~ta^xS zf~IL&Q?_bG)?AfXQZYp(mnk1y*^$2Lov0MqL6PBtgre83t`dUAbg*uK?ync~N&K4= z2q>dzoJGo!TI$#oYX_uclsnQlW^mlT0on5L2&ELg?f`0wjNO&vt>jvNl|1X%DYN1IxWjtA9uGZqiZoFiIB1DR?)@d>-hcOjE=!L8__%(6)YdXSHBW@Ac6~6EgO7`UfAJxIrU+D zG`~XHuglEQQ%IpG zqucmAFen@j|LhA8oL~@DfvLZQ@+l!%XPPbS0-_vX)I6MJiYzx4BS=A32Sh3maXX(yl?hTGV+#5a9dfQlSpzD7IztwER3`ce(oq?C z2D&9i{})tykz*Rp`mui8vv*&x)|2Ns3w!2SeE2A`pWt(g@BT8rJ~=FFxIkof|6V$W zUyDyua_MMp{T#{a>ZUs9dT%B86K&iesZtOfq*`o6Vl;wjUh&L|Z~aDt<-eJtifWqW^e%^4Hflu-8z1 z63@rC)IZG*prMEHb2za^unv(4qLEzV<4|d1T^ry(>?C-*Zq1Y_lISnkzz?2G9$=yjs|S#xB&s0kB|fHdY!%TVXaqtXC#yOnb_#)` zQjrrV@ELxKZez_(AU}f4o{fknfLVp$aV{##t>p`~eg|^|A9YDHi4rw-@Y_gpDr!7j zvqEUSO;4f@2!3Sm3;A@U*pD|3DW1{xt8Hk^@dux+yV-(AxhrV0YfyCn(YO=E^crTFA435DW>#+6N z{SH3*3S1w(dIx@2PNU;sM%&xR3~yhd&DHHd`^hp>T|>|(MsrbF>Iq0$d(|(j4V<>ljf| zBc&naXJXbdb?&exrotwuL=7)l$kr<)x)sj);T6IZL3g4opj|>SyBC``?VBngiozHW zY!R=!CJo1uw2jRfWB9_`qb$ej1U<2eX?j?_hTVT9lg~XwOzIH6Pc!)zv_D8lmJs4N zW$|s&bP-=qp~HR9jJj0({arM6K;D|yqqREY6>tB8CD!}`p*+LB>#pPGzqsq-hR5$* zeHzlmgouDKntJ))*0Vz-Otj=RW&}vei8Dx(wyAPKMgQXE2$@s+7ozHCk~N<~loru? zO0($E9Jb*GOPGGyGTtZ!=P(}xx2;@B)^jwe=Vhn2787_v6JTTKCT7+(Z=ek&z z)mC2P{|;HLQG1K@2}Tr%T2Nr zpW@cHC{)Ya7hnB5)12|M^mR<19pwl6L6@f6y|mKgCagc3 zE)!|gpQyIB)8*}9@wZ!0pgZGvEjao6o39Qm1flG5^>iSgq1 z{iW~ic>e?!0kiY_f^`=J~$7>y)JGRz;o)bKw_^Wh`H SsrP3900001dt?^gp8O>CS2Bg22ms0_4pa2$> z#S@QfLqjTKFjhyOpUdz2pZoqZMd5QO$`$W>&J_@2F%i`vqH8214MMneilKNQuo!SNQ=D`c&VY4M3 zZfuFMMsykRUK;WC?3DPo_3iO2h}%(d{^2LSw@_QRr?71yGG2!(-2pm&fXRV6u3P7J)n##f3zI{J zzu3Q%W(n`yasd-dfpcTdRoy9Ubd38cN(T?HiFpG5t{k_=xfB#1UBh)-)=>UWI|zo! z+9n!05X!^J(Ce{eqG)5B}fb!V}b3RI(yAF8l|HVXV97BMb!rO(qVL=%b8W3 zk}ijAWO2lEegMgSP7QK68)qQ1+^rqndgcZU*#U5F?KZz|a>~Sb9I!f`3Gr6FJ${Ze z;=$T*EDdo%i$^!&;reOuW_4ctcz$j?17ZW>yDf3S5|5bi_^JHt`0?zFxPe-%YvOPH z#;>i*&h2_Uv@-G&n0L_5YIMD&tLs#B$W7T#0ZZgD(8>a??17zy8Z3l5U2R!ZlKC}D zK2REPCxdpLt04GHvI$}n`1PT)Ib~7vGCReDpP{M`u@p6#t?`d)gxP$Q167B=U-%Xo zun5%1I7qdwYqYGh95yiIVW#eBbYa>=a+hN}OEhd`Nq12lM_qfmR^Y8gp=etVx*}oS z7qSAh*GQ@Kc(-6uX%_1l!)lZc^C(+lW8{A_PpLXA4r{tIj+!?#UBGKY@m<053%~_( zR5a;K1^j4&>N#^%pd#1+m9|vIfs!;DQjH-JOasc!x~@^J$3yq;eKIa}+NmaZ!!@rX z=n~B=Iv$H;QbzY`NYJ53elNd^p;z&RelY##J0HTiz{JP~wr<_3UJx#D@x_<0*qTi_ zeRBUp==eATe3pPm%MSaSRicp6GxyXNX{rMdH6cdC08G$y8abQJx&Ut#H@tUsM9K52 z03S&(RyI=0avH)EbcTq`6Lm$@3a`L;jnO4mTe6s=luP#n43%kOol7PvE|KTtlb`fY=26f^1xUZNDM~Fb0a!k zw05FS_5nA%@5cDCKm91KESZ1&J_c1us2NIa$*Uvi^47%V?)=0Zz5OelOkO~bQB}eQ zHX6K!+K6N8MTWK>Wpu|yC^di`+(I?iA;e25xd=Nv$k-{DQrVIR?%v78FTPMc&p|Ly zmL&}_CT$4WC@Rchsy50V8RMw={SR{{KRDA$d6ojHj%$}^+6TR^jKlF-t&%NKES-0$a{9$MpG@1rg1@8Ro z57OkYfB%22O?eBFLMd3{Vg6$n zr7@^$ZKXkak@@rOUewbx$z+;)bFR-3Bh8Ov*oW^**h#!=-0 z(FC^T^VqpbVyl~iows%DU`3%PscpOvYLU_#a&rY}+lvblARB=qY@ikvXu93R5HZ1` z{4CYbW_<1$@Q#6@oJvj5UfjuIJ5Z*;dSaqhd&8@)`k|;P`MG!eG!x_FTzJ+QoVu|N zW{h2*xe1pQj5Z!*FmGd|oE1#3HRI=TcFeF@W2BPsCBh~uikYR zhR6qg`B^RT+Me=Yn&}LA>P`?O@Q$Y$ORi+a# zwa3tA4>8oRmEgrwX*S;sS;oQn53_lE6V(&{O|3ge%PZ>YJhIs3Hn33Dbq9O*@^Po}|KI-B99zDqT_LO^mNYK0#3oQ>%{g1ksiV zOQL7nSRF7@4222uTAi|(p%zCNv^7H2!J8%v9HNV+$wu%Q)|CvogEZUiR6Pdg)?Wdp zAJ|2l^X$L-i&S6#GiFVP%U@rirMai1!>d`Uh8aBfO@x?3?Jd;eFi3QlgR1SJik~H) z_RQXWCqpH4w_VBTx$nn>IVyh}Rdpm$>Y|wDrb{7S%0RV^SbG~;D4Blh_i4B}qdF-QQ%^A(^oN7O&gb*i9cqL4l!}EF~!6b8>vD_G$zM2rQs=6CEuk24dFg zS(WgEc!G)OY!2gQ5^zeoRsxtMEkb46C@nxMBn(lf)7!cVWHGLqL9@qm(MLY=k$C;} z*Qb9UIrJpWFhk|;CoFxAs(lwx;F`%$rX^dzp7s)qA7w0Vgy!p^kOtpSDuWB|Blm}x zJFti1+h3wmZ8+kYt(p`=N7&&0h8UL^#7XHS*e|_T6fM@Lbc0$Y%Wn0EmP~WQyC(R+ zdrv30?Tr1{XJek_f=$$#DZuwDGOGmIwlFLZ%YE25MHXj{CLxL166mRoQ-qCVrNE`Lmg93W-F;S{R*6VFl%83IO|;!5sO$-J zK9y<;9o?$t1?=%$v^;_$wY=}%fmSm-_Jyxde!IoQ`Ec56bOLhO<~O41O|*Fn196Br zG|(FpF>@@m|CMGr&GaLmXLxamsH7q)31nz(h|v&DPNIr}Y+k@o@BO{XxwkE4+qmM^ z6lbJ05OqL8a=seqLtS{9nS@(OJvm05~BlGV3B{Zurao@MwE zlq$hIO7Na$En;&+>9%n&&M^@i7#>NSv6ysJ8ZBo23`U#GewjcOa^>hXI=R9zib*VT zb@L*2H5VU!uL|j)w3jG8#^6~m#m{63<>|tKA57I=)CXx*|3;2%t^-DM=2gGis|99u za^&v!lJ{{zqDG{87ufqIBQ<)%r6+I=w_r!lYAf68$Eqw)GjG zK)W?ftR&DKLd)vq^vw`TolYS=az6#}AU-Uc>mUfqL{0&g| z2~we+w?TJMF~j+@Q9dWC1L)c`HGdc*8&@^R6(I@r>s6%fT#dyDE(+rsfRAsnHKUrO;on4nTPJhho-_F7N{uKYBvoWk}kDD?zZ)D`j^ z=@IncuaJSg81igu5Na(Y%f8N1TP?Xozgk-_1vn(a%czoAb{9hzqYr}sqqwY)jA%SD z$hDFR7gDVdQmdnP?{~ARV*&1&B>};7jR2}%VD2~ER=XWmod!+wC&}VIUVIsF=4asa z0~FoAN>-qS-7yQ~jW?0U32+6Sg@2%ybx~6EP{TyY6w3>h6SK=LqW;Du$1TT#W75n0 zy}&2bnv^|K5J~u#tkKH?J(m=$a=fBfqW~j^o7Pxo&X+i~K)ZM%K}3^HQ~7}R10X+g z`k_YFoJ!nYh$>-pl?#g?lU@}@j5zfKO)8^(<)J8v-lglGaj6OANva)&q7CX0-pBNe z)NDD1lGfe=bV|WJ-yEEnz}oY%}?n#TAQ>Q{yS-=f24% zgkG07N$I@C3Q+y3ObX1PGh!T}GUuQ+9ip1qNj~>5&83a7`AP_uD&B%olQ!r z%hamd7|Vvpt2)lO6h~Hr2JG=%v}4B(-um{RP3-mG-S&9~!W^&u!JLf~(&P|?C$wOI z`XhMPg`(3hTYGIUC2g=imo_*)LAz>Vq>iW!F%pLH%`%y>h?b$~hDn=W-tcsOj53`3r2?s1nH` z8`GI*zWpDG1|LWysZJZ{Vf5a;%4jy8^Wx+YK6plh!jNIT!)R%wfiWg2)ywSMa;lX5 zYI_XtOE8KSC0cGdKL1}c{NCs0$yHA2Z(mJ_x}vU1&kd@eaB9}ie5$bJ8=c*^ryqw7Ea|v z8Fi0huAa(vX`~IiqhQ9Vm@s5@8?Ju6XhDIh9MzH|rq!Wa6tH7H}wW4qz2kHb5*{0J|-;)>_C zIqIb+pd5}I=eN^Unt|{LHcdP2>-GN=%9RawabWGg-v#nsA5V)zKaIc?_b_{KkNpZ(7^7J9Dg`Fg@?j0T?o{MullkU0 ziuOS22(Ogo>93WNs}4ivDVB7`6<05DxKDJ*VvqFU!uREz;AEEJWV%zSUST5X%Qsl6 zwaKbSWnd&VdzN#6__W~mxJ>#jBgV90O)XmXRnSd+gXO5X7GKg`Ck5=LdnH@Je|m)w1{g6;n;JwW+3$zs`I&*OV3r0LpMfW(;X+qb`PMrDBn zdgXh93A^_PqE?a|%jvRzIW`#bFiNTCD8ky!1U@ec(5W6iR#Nxgx?;mCx;jt0kE%*t dlXYF={{y9SJ3{}9CT0Kt002ovPDHLkV1kwt=(_*_ diff --git a/resources/assets/edenmod/textures/gui/cycle/medal_2.png b/resources/assets/edenmod/textures/gui/cycle/medal_2.png index 90ba183f3d4f83423237fa12cf3823b93d166342..a91f1b6f3aea40bf51da5b70414df8854525a25a 100644 GIT binary patch literal 4101 zcmV+g5c=% zdyHSjb;m#RxcB~E>)*Z&i*1a}%REX#Nf7}O0!`FNeYi;lk&2Rvq%HKHwrQ&>kJ2`6 zN>mjTN~JbY8~R8a0YRv$s;W&ZC=@Cbl9EzhCYXoq^_pGVyZd|I$IMhS>;3(HCZ_Bz zy9U)?>B`=@bLY;SJLk+f-*bL~72*rOdz-uS&O5{Zb7$YQzqAge6xUvRE%$x%?*wbW z_U+riXwy%ST9}CzogBHixx$YIvX#5 z@y0<)s*a7f5X&>di%X+zNGgoQEe>zmj){gTk8EM8vZmc1(44%Oj!KypHBMtLs8k%s zXswY+(z}k9x00a|ZuRfbYnj--&7+u4{{zS-+Sa&aRPo?VV^ke9as1?cDgVB|g|H>= z+ViiBPJF93wIj3p-%ujI{u`fhU;C@ClanE>p?%ZeP|F(3M-zPgXKTD?v;W|hd8HV? zW3l&K{M0|eKmHch6iCvI-vR%hAUVY$R@3?3d+&AL2z82rU-|L_v|9z~@B}+XhPnC^ zpQTy0OyxOOo?Ar;fyi^7d8Nf|4?Nf#oT-xwL1GuV=l0L{o_+s$6a3#y$( zT%VkBNt#l;HpJfgh0H(OX5JZGT;n6}R$Q?qMpGhBDrE1vX8AE5|MFMJ($`q*yv(Sc z=(Xq0k$w2xh>Jc9iNm3J-`Q1gjuET5>uJlA2j{}3O|rwp-+QR{?AD!^^O43PT@tGi-QnJI&Plr6oJf~&u5Y$=>PY=5mMF3! z1FcDHh85uC2(g+$iXkwPvdPJkBfV#BR9)*bShE1m+iJkMbV2(C@rsP#1y`HB4RQG@~-J zwexAQouO)d=`F`Dr%%H$O4hAWSC(#jma=SNO-d9gw1P|+3N=bn9HP_eK)HmmRiyC7 z(Nd1qYu2ov3Jl_!8$a!yc>F&xk!Dh6oH;(!yZ7AmQ5x|ix@clblhhA9Ow%PKUX4cU zOigXZsxhK`fkzGrO1e!~4)K*=`xrO<+{f2_zJd+FPk-n~-NR45M8jFMi->6UZ$@=g z(WYBiYBr@6CseE<4Z)qox{OGaurTeCG{<-iSdfm7x%}`pcs}w7PTJKc$pp zdio&M$`EO~x&UXj?^+iO*EhSQ9I?32B8p1LNQAI;_wL<%^-q_Wq?N+Evq}lJZQD-T zwSfodbUIk&g7cIl33CVcy|a$N`tUf-<~)^3CH(CtYV(42qlsB1OQR78CrGmb=LA`n z1uh_Mw<(oMwupwnsL0x`7&sl3bEA_ilYt$zNw=kVym{|2Jy-FGGeX*e{u z$oHP!|EA+D2S)yj8|e^*<%8G!5RvSkAjX)`&)b&Ki7mbM-9PbT+ zyMs0TN%;k!ilE0UfnSif_MY_gJHYz_ub05GTKRu>?AXz3-?VA%)Vo+|$KU(?FS$GJ zxHIGh3XyT>;C>P#Plui*`*hH8G3~(px#cdH>&Y^Ub&TKm#iZ zj?Nui@c@!j9FkKUdZPyR41FRU^O@v@eFxsOzZ90|W@f0>5=@p-PKNlI4_-zo5;$Xc z`uj7at%0Cw0Q>hZV4OpU)%hD6DuAUFmZ8<^Fki%P+TRL^Yk+84Iu8F?WWEt3-pPrPLX(*kj1P@HBWj403}d~K zM`?|r+g%Eqz0fyA0CDUo3qPq8>3Nylf%epucTd|`nTKGu*FVq6g`+Ty5c)1d5MiA6 zA2MQHr63{C7Z9E$_RbELSd}R09N!Rj5|Xlt!|`__fTf&u>@1$JTAwcS; zlH2b7RtR_op@=Dr;GxI%kef!J&`sgnPmHsF_*y=B>n`Fb0$t*7|L8Z};(-^4%T;c^ z`BVJ%t)CZb5 zAb3|8l=H&yda%T(dUf#b@REV;_xIj$Y8*qdjY(syPJ;UAaPsLMWs*6G%et!$?=%~P5Y+g*-bkHG&+kWW zw}0bN4m54pF+${Mp^*N|u22BW;qcX0?CQ0D_r+=C%ll9=_GbF+^8}?|NC*M_umvtI z6PrA2*X65|cSy8CJ4YmR&{5Czd;Rsr51N9)c5%W4GS!b65`Oj6L2r@CMu==w#BTKEOrTAUx}N zV~q7jtst`|RH+S=2nC~R2SVkyO$Ds~`oggDoUM#+8X}hP(xCt> z&^L}5mhGEIm`EbD6r|3Vya`01a3bg2^Uq|mzLa3`>hs8V`;5@+;rXyrtnnv>I>`cX zHf&?Bm(E#S6fs&aF^|s)CXQ)+q`rkT#+!ETgrAqDZNFFVg!L zWl5uxQLiRcDjFpf#@7!u``f*d354TOB~kf+%r}PYj{0!$k?v3U#p}9Ggdm zkXee09CekF+Y(jp)^_Ka+Hx9^_bAmkS*PHo&SE$M{VrH9=(jwAj45l!#XGkjcLv+n z8Mza~an5NaiabUQcx+wQA&L_&*tumX!(=UwKJh%w_Ufa(H=RDGI3%Yy^#679mA%jQ zHg%)baJw$J1Y2JoNlhv6Hvp%LwFhp5vkyi7|nC z5B`8HKt?#Jc=UzYUjG;V=iB_pH}1g3n?fLU@YQ}Q{daEt%-RL;dN*|L@ZrGy8=0dc zg+lfs#N{AmH5jZC8_Xa0if>^}@cdGfEs-Iw;{rm#^f6?49wOGlbWmz_c0#YTqo07E zP?E%Ch0oCVEN;=O;9l+GU%v(f0;A%X4~r z_rA<)vrS6nD%NPO+BV9G5XY9QFTdp2@#%Q+rTy%Ac?PXZ*>x^& zHn53ga`Rby@>92|wZPoWEJ{?-%CgYv z(#ajE^EO2C{DH$X8vXhpUpM5VJ#Y2@^2=Z7wO{_;OS$*Y|K#MR$6E*XkYy%tcCQJ= z-uXPFwXN%hSiWuZ!0`;3<6q$oV!09rpP^J4=eh46LInb(z#IH<(g=mq5r-N%h3kjR z!YM?SQQQk#v8l&kfN(>xj z2DGpCRyq_{_>G;JI@kWOrBY^PJ;KjUJz_B?s?!r_Y1f5RbVCXL^)D&bo!YMpP%3)V0dh5 zRU}?k9^;fe?Ho~cW=dW9yxLZJv}`$&N~}4s>F>OH!wCfcH4eRDRWttg)j_f?K?g`j_cR2 zm;Eh@B6D#b-Z`hV*8*MBXf8lUfL-Q?!hS?n1aOUkjR+wS%rcjnVo<0UBz}EE_{{5f6iWj<2B>er{6?#0Ayxc zOyI(bEUf!MC%*Ue8srx*!4JDu6n~Et;M+D%Up$XwW-0#st2cnr+N3~NJJ9!i^Wv`b zS~PnRT9OHPNgF{JA_@XH$Z;=W>m1ymjgQDA0nB1H!hfU>zs1M6GYTgazzHXicWodH zp|u4|J8;7$ES^{ml`2Sw0&KgS2+j=(HRAi*wnryEJq*&j`>&58P{4-uccaPi0Lw;T zC(+`h@ad6ZWLp*f@{?C!LF3MKT{wTP&%EE&PDJtV{n?|q`^R^p#cjgUyFyr*5PlfK z3Pbdd41eJ3(J{1U+wkgh2d6|SSNr;PtrMgW!X0zrc^;BFLQVr#%101rSfNG``pAS? zTuFQmB$9v&gp&%kWfkY}!aQIBo}Iy9)CV0V5st4yK*MM32r!`>xNwkQ$E<>#ParT- zRvQ%RiA83;*z<>{pxqJEbnm_Q!VW_Ch!CV4Tz@`30^3R8+NnI={Ov!GcLV(9cfUq1 zl|jeqHn=TAP;lVbwo$RuU-ZGZv-sEVPa$*M1M>CR`MOEKG*G{T6f8dhpWXq09dX4r z=nTA^havYokW50gw<9Rnu2FXwp30$BC$S{q!t((u3a8wis{zMCyR!_Lv9D2Y=z31( zB!4uLo`ZI~17rDSL{=8Q*6?#a9EaiyIH3b8v@xb~2s;8}$Wplkv~r<`ErclxP&V>` z58HOoKHiB*CyVyc5nQs!7!(;-52*T06`M4n7_tCM0_^(Z4m9P)v3c`mcwQcMXu(DX zgOe`$2K$i8rSZz{e}de3;+KzM+t0f&GJomd;#Xf833%hDhX7aM;NRcIQ#+ri`+7AR zfTY(1C=Xr`AhJUGH~7ke9nscJ0xCr4WT2uDdE1)`qyhyUYN$w?{#KZr^6z9ARf+*n z1EA1A3|_w)E$>`GSAk#r=|`9d#<68{H$p#;fd9ylpc(z=#*kM5{(ayWzBqW%sDFi< z0=%0hlxXN0bt5NN85_=oi@fq+1x@f=4V6hkg$}d{d$Y(}Sq$rb>$+tN8Gl;qvMFs* zVk`@Z1jDEWhM}RMsaz(e*N)?uD{ceC4)BWGgn}JtD6B?K9t6QOk^U}1)pN3EpM5rx zx*f%uYOsF&dL!Pf_r=9L{wz#lzCgVfaGnbnE*RUvK4KvE?%k`tlMGPme+4=&zO}U# z7cX8kHeq03pjgl>^ev8)Hh=b~y$}dPq@WtJA8J9UKqVld--e-6wNCKJBacMKjvX_* z$TB&1DlXnbLqkRa4jw#cyntAC?y5k>tXj1SD^{#9{gy6WYHSGG`TL?pi;zyIP5+LL z4opl;)Mfp;)(N<4B!-I>F{LO^PEJm}Kx-q`j0J=s_Mv$5Z$bhf34ey95624H+S-bY zEf8N9s9H{jxVx{v{yH9f@IkY120jE&cev~E!;Fm^H<~`&J%W8nFd+n!X^aXbaEgPH zAu7Vd6H3WL4?R>o8QQdI)BK(c-Mo3zESSNL7%MSSyi3%_XYMrnu#KWDR$T}Z29Rmo zT@n{R{SnBVEiEnPeSh>U1m~_6sv4aq;V-=Kf)P;`J(n$8W`29;?RU&Q-Ikul0PcKO zSC{F}I~l@D7{FsTs(`2jC5A+iA=j>5Gjqgq2}%!{boA&^bKkdbpOFfV`|!gLRYN7< zqmMo^i(!e2x=kYJ?SB*q6kU3332S1IvDf z!RfSN)&mbbVCH%0rI+yKmtR&&N_7knLqyJ#7%rH^b0K7enN;hd@8%^2k{A1sIq}mR z5-P@%c7@_i)rzZuFq#kv;y8Jayrba^@MEG)95`^mBs$#Pty{NFV-gp)di83vxaG^2 zo4?f0r9k&ZkH-a^ndpD8g6)=r|QOlY$jVIE|baJ zqMxOpsESC6%j4g|B=PwI$q_^?$dF2;NYsFKBCc8uQ2~F3s!lDKjhS;nJYuYPEam`Z zsc8(L_`m=D`z8>%@4ov?%F7+5xDzW^t}IFbMV||#fn!@wPmgKmZZW(iu3o)rq~Pq? zvnG3_ntw12CZ2rq$y?S#PeG>970b9vcfM)~$Y!&}+MT#T5k0vi1eP$EV;3nLvt@^jdfJ7p}&tQvx3!zM1NgNHH zFn>S-p}xL8)0e3%+n5J1U7k-^wN4;nT+U$4hY_2130SjcjnUyvn>HD-rvB1+#VxpG zYm(^^vh$yP_L&(cc>(eG=LMlNr zju-0*oHKrQI1|K(a&9rMVnpYyAfgJ3q<_((o>Pap7?!oUIO;bqF?M|BQ8~x4#AUu1 za}(IGVME1LUcR3mg0_Wo@^5CSY^x?G(3K95N(>`95=g@*^*rVT1VuYu;v!SHNIo;0 zG=Wg7GO8j(&15giNrV(em=lQVNwit%XY_h5ogRMp;bM*Nt+(DX;oqmi>nl$UycDgckaBUO^PfmiIJgu_Utikwi=pr zh4dFQHxfby$ZnIkcr8#6f2OVr!GH0C($dKBc93LC#z<~ajoa0g4v_K}cYz{D!i69a zX~_x+$^RMT%!b=7Uh)m%% zdyF4fb;m#VF*CpCKAhN&?WB%loF+V4+7JnaP*Tztpf)I>1=5rvpe+?dYX7X7&{QQ< zg$lJqh!9k0=>wEd`he01+N8XimH?trLP8)3kjL6yd%e5A$IRThkLupvZ*40W@Gf5B zHpd!yc78K==AJqCobUObGlG+p>#n;lyzAY!upSWvUUSW>xap>w1RIc@J9Y61NC$$~uVA*7>eYP8Rf{^sy_SrURE*L{3gAxMjmvuJ(n zy!A@f&KS8NO15y`Lj&GQw9W`PLgtXhQfP(G6*LMT>UG^iujgcAhXj{X6n!e~2x6jW zVJynG(Hg89AoUC~K4@6M1;<9E8jn$9g={I>zD32DyePp9$%}%fiZ>TDH24~Fsn&fD zy`Gbmk_eeo)(hy)8CWaRabuS_W44d81=7v3qKDKoi-Z-yVZY2qW!%ac$U}&kz*e(` z)+nPM_G!--9B>bz&g$SQ$m?zN%6X8Bo2!6v28D6-vss?|-UFy&a{Rg7i+Stw@4!io za)IBxb2pDidqwcIPu|X%TegK-C}aq%EbafU>+|}z{9$stmotp{?&&<(b5<* z#Hd=m$QVCw#zn0QIfYb2#2k+vepS_J>M;IY^-h;2lb?s5j z2O%Mp2sOiE|1J*oA56!c@Vw{Mw?b$j62e3w-D;_fQvOvZl?&=Uu|f zF1-@z0@hltx#pTv9|ohm=GR|+bl{!4_J;9z5}OAXEFivl4=w3gb%xiz_?_%hKZ(!- zM*a|=wVp;oOXb{t^FLC0kCKz2T!>~^V_d-nR~xpyWR#A_U!Sx0g%l>kYssg+ax0%c zcn6uuQKezwZjCTGLBOt`xR9%V`IQ^O8k!A?R34$CqXVrSI%~)TNKt@_Z?sDjy7&-d z^N2jtI6tPAv+1@Wn8`$i#5tD$j1($`*>pSzgtH)2jI#*Qp->XUkZ3f58RCwTik9E- zG}!Q!=bgKk!RllQ%J&hJmSBI2-`Uz1l9@8*XPq}0#?p&$GKlbtZ0hD zGjql{4DTKwvp%`1*`c?vC!d5CCAvINex2F2pf&|7j|#G-F16i8KPdY1ea@cCsg0xE zS-zVJVb1L4 zldrRAA*t#iZ+qMCaqSylm&UVRa@Fl;VOlv>40!mhU7CB&W*ADk?S{vmcvPHLQJ_Y% zygI}vi|{pBJx`{<79%hXgb|IlWcdntrJ>$IunjsCSZ9zzL+If|Cv8Etpxt7ts8Dv6 zG8fd@5}~z<$m23PH6l;dKxJ9u1vK%^whdLbN~b8%^^i~$C|XDv7_ZDB`>PalNAP-u zakD?=7Cu;{2#BE5CUJhz zx6iI{KA|w+X1Mpz$I+cLk=`Gq%j7F``A>JN`07Xi@70Zg|~0 zc=H>6=afIMU=!rr-TT7gp#?gl`wA zdcb4JoxtS{Eq50C4}Eo0o>gzgpw>I`dP`N-e@Q+UNy zSDd~}pyA4Ek%~l%Q~J+@ywsTlF*vN*M_>T$Z|=$ z=q9ImaPcv5T3JA^H$yoZq4O5YgKCNvBZrVNpGhhyB6o4p;=F@m7FAZH(R4=Rp&l$V z)9;+B$L5qNz&D01bMr(Fud-7GIDrTX)yhy2w68;As^EN0-Y<}Y5h3`=4_O;e_S7$d z>#w^ZRMljnGto4)pva5#pnm$W@s027!X;-qj9=eF2dVhjLnWw?CcO5bS#VeskF8dS ztcWBbZ-4tAZ+ISJqZj_jxqHKCG*0^$J@ZHS*t_1rST?9e(BzY01A+P*_hY{FajKJW zf*ygNVzbCMo_oa`2|^QORKO(jbVA`w#d*K*dURAqfH(g3Z}9dTZ}{P6gT@I;JK1+K zr}h#fBps2H#l@N?5mLI_oTQ#*@Tf^p#6^-@Os5?w@#zrWd#tn5{~L6kq1DFyq2B0) z`_9>hF%t@U_tqZu(i4QXAS7yfG6^pvc3k79Z}0nw%vCY@yFM!Xco8Ri;vc-_kHS0O`7c|Chg@+nS`V_RzOjyz|3& z-9v{FE}VRd;etT=2Cp)s;izsnGRTn;*Pq}V?yB=vSu+x8gFS!d3q^;$Pd(-@oF#C@lND&WPsqNxM5^a?(wwmm89S85+a)_ zEcwbJ`rreMl%$Lo0eKK~oh2I_LL}^QnkhgEi4ZY_*~I>wNPP6-S{=gyYvm>xogvp<$i1hr9vNAo$PRgf&pf%x zuuZ)7JMSGSFye1ySGG~?*Vq7%%)_0TS((HWw2STP|# zBD9?-Ege8gfzBf8%Lq!R`bbQRYS}{hNU?PwG-+JnJ!NBPs*2bjF`CWLQl%}y=%>sH zdYeL+?QV(51HP4U!I|^Z z3=4r29&1CQ)7RXU%-XnCk3Bzkb;=83zVYZ6zR3QCJ4uoDsYik$g+J>&j+_<)>c%2U zgLf4{JI2umM5k{R#z!lin5jtrrfN)WN=5-7x)=Y5JT zKt>k83zQE8JHW@uD}@t=+$)@w6jD;l7#kvM6j_6b4~UA;)5%7EB2_kNda^D>f>?jb zOv6BTI5%%7eV?2_k*Q<}>U2;*Ltw{6ml9^rCX=2l?=uV*UzaGAbLp#og+h5`OXC+; z`OlAjj7-Ti`Q?FUIG&n%OtW`IB`AcH%s=Y|6ub6NgqqbRWB;e#&x(o8&at!@D@*>V zQ-Jf6KEBwTkZUN;eh#74$GMsYMd2MmchWNM?$}D^N@OggcKWG8#6Ypg_J4Q_q2|c{|RC=BSLnJ zz0LC&%Ok=Qm|~t`;~+)=ePXUKVtd!D(3g_!@fulCh8)x!E-R>F;dPo5{2-!#;1Obn zNU??a^Y)~epKFOJ&OnNqvZ`oJ>8e3vna$wvH||9>W$N&<#cYZKHsanVNi^u*z8|Ly zZR$`mw=|@^@&)3HE^FxE8Qa*vc^W97*PmhbqMt!EL#*tAh-j^#b=;!t`G!@~X7S7a zK^8`+P*4YpiIw08l%6aCW}f*XdO~A##^5uz!NS+6BS=aoD5TtY6Xu#op5`KXnu|Eu z6R-RI8^Zf|@WruH!gfm4(1yVU*S1II}R9}<_prjVn* zO(%3hiHCK-i^vyB)Cm}$I99Z(C`wAo(Rd1?Hz^8iZ5&lgV{(`U<&3=Ooz7_oKFlmTk+ih4S%rlz0kIN=DRZeJv%@Dnw zlbx1?xF{pL6Dz@M>}`;~PSlY`J%-N!kS!b5%;+p&bk&#O}dWG7|c#uj+^2lnc4on%6`aLeQ08aPG~i~}uQkw1EnRaKI?0^jJgu6>hH+M2n@8S2P< zSlT=Ha5&#e#}DaTvIh!L}M~5L~i- z`$nh1h80jtOEvY#F>x7rPp99d8OQF9$Oc8rbqqtB#t+fPCE((OrHFN1D^PYhx)V@S zF7KF|NT0y@c1~+tQy!Nr89ks^br`e;%$qG~Nffco_J^&2%P+euWqVP!DbH7r98PcE zEl1jGYKB9T2f`dWsyC@Qj0@Ts(Aob&E@_Xg40~Eh@Ol7C)&h z#|RZ07g7x@zCtvypphZnkb3g7X8^9nE~f*HSV fK);qgZ?^m|ojpe%f)EqC00000NkvXXu0mjf1DU%S literal 5049 zcmV;q6GrTbP)ftF6@$ zN2b#OrLAaZI(CLSI<{ziAY$VKMFIp-8bT71+z|4(_vSv%Ip6sndw16Q&bhffo15hF zSTo-}=X{U-?Y;Ke|Mg#M?Q1wex%uXs{k7L#OBjapdhYt`uji_(t};(`?UG9_@ee%k zz`WWs#&G1wk*93$cqBa02lG5U2Ge_LyHfb)IFv!Z~W zI9mrh0LB8z?0LNWw&ka{gvCLe&v_i;Az{dxD;aoe7KCYpS+u9 zv&jXURuflqaE@w`GHv>~|Dk`mLZuF2jodxGDL+=!af3@Bl@{7q3$f}lAPhqCN=(0j5z~Q4dOtmkhg-M$i!Xemn&rjU{WtqrOx=%j&id2vE@Ge&aX5vUAKr_PhS`40dl|d; zo47geuUfoV&F1%Ak6H0*TIn>)HebMiGngFGyvf#kchNFKEXhW>@9(YvVn`k{&p8GR zMiG%eKxPNYeT|B((l@*sXLE&ssb)&-LiUGCi7G?5z7@DICUhxzR|_3)ATO9Mh8Zu0 zNlnbMwqe@mSQlb!A1*qJx?qWILe?U5Q#>=G9G@6YrG#gB>NWab@kW+i`c8%xH8}nB zCD<^>h^`Gx?cPm%^Z>C-x%DHj*T-J_!7nf!4zm1$3(2bkv&{*@9f26wcB9^`VbC@(`<4cw!h-O_?2WYVT^!^zZGsb;?bs@Gm%i!1c3=w+Vr3 zsR!|ddarRQq3L}Wo5`uWDdGj0Di+29dh+FO-R^(yx8DYKl2spjn83lx^BUCp9YImW z1ePK#cy!xdBA;{TKV1W(_d@O=ia|I-@#uo~FP1NxvV$zJ0%qtZB~lj{ZT|*|t#bIVW2P>yAtp>`AQCANVt%VM_CgDxvgi%zkf*2jm}}NrW@^v&oj=cRoHHz<4l(&{XYTJ z^HKq$qoaOua*})QxtrBzpF!OiioDRkF7#!9XT1zkX+G`FjP}GDkGH)gZy9fT?z;D0 z-<;`i?z!ih7mNaKxZ$&W>QkTO;#aId6-;z2B!AE7vLq8X~ zkKsZ#UUU+2!7v$3q0?W^vSyFumt=md8bxkAPDXD$f$(f}C0+^!BUX=7$z7 zLdI%bL2TNrUbTYEWlSF!Q*-xf$~^^yI#3aZV{rKhg>~v3L|v0pp2?$43i)M?dW?3v z%}qDmWS*A_uwuf-mZZkyT=LQleEZg~Dcv30wU@|=0tyAe^5v2qJ7xim<;$>*KJ8WE z1B%)*28Nbt7D?UZv83wrCmcR_@PPl`cfYIOZ~4-fh@u{#InG^u3Hksn1AN?p%7-E9}>%~eSPz#V= zh-G*#zx*;r7LSl;IcwLiCv^qh2Beu|$*MJUY)pOe8Po?C>tpS9`?*hvnbNE2fRc2A zI55P0eK0l!wF*I+5CjpfC@5rYdoS59%?|reY#lx4T#hv{Q5fkVZnLJY(&4L~AkL{v zmb5)V)^1aDm&8f;pA(cDZ~UBp|NF0I?Wz@Q`{@seB&F>VimbzTZv6)T^Odh_R##Nx zgMxRwWFbXG87^o$f%RCID;QQ?fh`iklZY40d>`1fX@hSJ^>O~DP5kC% zmlN26SG{}_fy?>qr>|3U9v&QE#o!1=xIG2Vd(Pc>o<84Lx`c3`feS;TdIR#5>G9G< zCapGsm!;x}`s>i?(3zScZ6{<|PVNgTl?ns>4GIU_e(_6^%<%cI-pXUmglgXqcijFx zv!E8R?dQKx(_Xdm3|{f_P4p}5cT|@<@4AQnp*oA!oy+1i>$*<}KzJ&(GUhM(YD7yL zM7iy9T!U+Ml}D(33H zzMDPMDK){Kd5WF)6T;t|n5$Lu_jywKXaP0vNs@#lX=!Ch)^6csP&pl!llWY#$yU~Y z7CR*Za*{hHkamNBj@(~}smt8RGLZWvL6U1hHY*C+z98`hHjJso6@qGC8C&>g*$WsC z&GB(Q{wE(GE*#gq|7w!7U0(Et{=Pm2hZkYOh@sVI>4Mv~MPyfft~ww z0B?TZyIHn&6($Hd@bFF7pX<`X$mDZOXkhPj-DIMeJh})CoW*kEtvM3C-C{ihMBA3&s)|C4P zcxv?uxd2)%CM=-pyeg?AO$OVg!$PN>cLZ@n?rJnbxfe{@S{MsB_}F2;dd-WpAeuKH zBbc5hJ$i_VUv6dW;2}+7l;NsVR29=aYt`AfT1;ihVxl1Aw$J~Y4*KCeyU8>{Dof}y zNr(P=nIQe=f4HGkVAA2;?|c^$I!at2;erw;39Gxxr^_C#8)wTcH!|L8a@a+@=Bf|) zO07<(-7=@l0xFdXopzhJB1A??)v2bbjh8S*dee>Rh0qk9!GR&g1VQRb5D`Q*raEn! zMXGez5|oEA)Cc-VtykcS9MqkqPN46U0BEjgAStHSg%5eVxZPIsD7C^kcO_|LC0)Ys2T&%Z#Gu<3$dA?@TeMwY_J2;&F$ z^W!`2(7{}=aRa`{1r-$##Um^~^9%*Nu|tQ{{oVQfA24xfoWdI>W~LaQp5P-N{;(=m zxPV|zCV^928t(ElS13XF`IaAHUBN_9;gTz_CW`BHk{NRfLD0>9t7I9m%V>`up*cB4 zP&gVA0$WIpCk;`S7g?)ox7salTLH5;=!Ugc0WBIHB1#=;((XozURj>h45ucJl6G2z zCLrq)9ZeWntII&ehDxTam9Sc&) z>Lj!~ZO!uLVz*I9JIm>0IccW@L5Op%Ji1;%imBp03!%b+)!%bP6rk_6;ylZxq)FE9 z^Fq8%xf`@|+LW0P-38844I);rT}LN?;WcZz#v*!k^f&ss=+&F4Sg+P01fn+FU~phW zxx~btM^tIz1$6pC;r)dU2wN6F^?Ppu^s6i$NuS6&B3vNbYEHb85FXD>JxrOK&hDL) zwV4DVoxpaR6Ob%XD#%>P z?vFXJ>mi-Rv3-xyN>c5(40`{818TzUc8kw^<}>OVJF-j=H`}wkrI%$)-x+_DHq{KpyL;+$=xzlwo>slyvRH>2Y zo={TBz1%|&49gtrvIQw>6jIArkj<nm1y>fGRhRYW3xZ@6XKk^9GYL)A*yG{{aGD+nF-!n$nVZrfc;AXcE*^L=}a2CvkJ-Y|2`f9DMTk%c!AUut=5-jF+iRbT0FbiqIdLijHg-w zrnmMa*>T!(OwnZRhBj~hgDaJpjqQF|EkoR5A+uGDSvs;*Ks-8_o`XmI;?0#|UN=WxD+YVmmvZn+4<~v=s?#fR!DbCcsL> zBApE^K@<|lkt$1!JC-D;m1l&pS)x!>Acs_dR2|CRvBj0 zn902Yq?$J{%uLU83oZ-A0}ynTIzRY8T#}(S*xyXiMBBky!bCZ}nR zj_THkOD}u1y1ak=mz%Zoq8L%YQ_aJnLx*T3iMqj0eBu)tWs0J6i6Odo2|rlA?i@9q zJ8%0I1Evg|WLJ&sGZrPyB~Pcu0({p*jiD0>>50irRjW6>B_ffWR&*33%Y6W98FOED zoQOS_XvyGv=3g#F*+DL*SXP{I(-=~nhy}|CEgEi=+ja`5)lQc%ohx7SO1}8%hEGW zQ^KJ!!Q*-%yGP`+APXRpAV>#L!*O6eU2(p1ek@wSN7yG8nlnu;l7G%cySF^@#=ch^7x!SrQN#7gGsB zGGU|v)cObD=rr?@a9(%oIHiy;rRp|==ID&l3rWgI2qKmt$|+7@IN`jX=;na3T7^aHR%4SHJekJx zJ9g|O2m%HM251b{W?7o>d_jDXmtS~M*-Cev&t11ls^-#}F80XTMQ5H)J8~?_Vf*b{ z6j-GUXGPg+4JVcq4d<@_P34nHTDm$wB@j%P{k=I!niGXm%=Dyru7pKI!d)?PEpt7A z`INwRj0Z^mFex&exLNtfiypXzhKj`h0}eT_pDjB79WPx2OCtx%zI@o=a}5Jx69^aKR}NFl?~3df>zd1E-`%O z8Tin5myYGZAKs-_7DbjK$Z16(SG?`db@TX`@4`^gc~%rqihz-X>S0ZzFsC6}neHkJ zC88?X`zD_`Nr>k1%VI~jjqcnR$`HE@FS1Pgj7CNNQ%tthNU;$uu1MA?$P9gw1@MOH zj-lxXWiJWOdUg0`Kl`cw$(=u9>hNK9KfF_Y@(14XI%3n&jn7Mm`gLchptCH}`p9BM z?j9DDXGJN3puJ6zmc*qD3=Ob<&kk&1lwOO496EG_%(W@nmK*-#zbH(|%Px5>sR_9D zFaGp|$6+{0dGP1=`|~!vM0bR2|N70i$;apzDRy-;px@fMo1i^G zQ<^O@mNz0ctUZfbVQC&2*Z&>rRgV-J#1lv&br$WVfE1FXEh70JqM*T#@7bnwSQL=i z4k43Ve#INqYQFlluRXsuNyT##GQtfuZ#aV+KlEqH3^Pq#KaqXUt?M6id7A0-kkkzq zzv&vL!caF$NWde$Ar;VhKJF9DWrtXIcc(DH#P%~2*QggsiTu58E3+$0X~$%4vaL*d zJ87+Xj&3)%RN9XtHCZQC@-*^~Lu)vWNm=?$-6&_4bj&Vo6}W6GTH P00000NkvXXu0mjf&G^nx diff --git a/src/tel/eden/mod/EdenModClient.java b/src/tel/eden/mod/EdenModClient.java index 93e07c7..935a487 100644 --- a/src/tel/eden/mod/EdenModClient.java +++ b/src/tel/eden/mod/EdenModClient.java @@ -1967,83 +1967,113 @@ private int printCycleSummary(FabricClientCommandSource source, String cycleCode source.sendFeedback(DiscordChatFormatter.formatCyclePrint(tel.eden.mod.net.CycleLeaderboardData.summaryFromSnapshot(snap))); return 1; } - pendingCyclePrintCode = trimmed; - requestCycleLeaderboard(trimmed); + requestCycleLeaderboard(trimmed, true); return 1; } - /** Request promotion cycle leaderboard data (current if null/blank) with 1s query cooldown and 5s timeout. */ + /** Request promotion cycle leaderboard data (current if null/blank), debounced safely above server throttle. */ public void requestCycleLeaderboard(String cycleCode) { - if (!isFullMember()) { - cycleLeaderboardError = "Failed to fetch cycle leaderboard"; - cycleLeaderboardErrorAtMs = System.currentTimeMillis(); - cycleLeaderboardGeneration.incrementAndGet(); + requestCycleLeaderboard(cycleCode, false); + } + + private void requestCycleLeaderboard(String cycleCode, boolean forPrint) { + long seq = cycleRequestSeq.incrementAndGet(); + pendingCyclePrintCode = forPrint ? (cycleCode != null ? cycleCode.trim() : "") : null; + BridgeWebSocketClient current = socket; + if (!isFullMember() || current == null || !current.isConnected()) { + failCycleLeaderboardRequest(); return; } - BridgeWebSocketClient current = socket; - if (current == null || !current.isConnected()) { - cycleLeaderboardError = "Failed to fetch cycle leaderboard"; - cycleLeaderboardErrorAtMs = System.currentTimeMillis(); - cycleLeaderboardGeneration.incrementAndGet(); + long delayMs = knownCycleLeaderboard == null ? 0L : Math.max(0L, (lastCycleQueryAtMs + 950L) - System.currentTimeMillis()); + if (delayMs == 0L) { + dispatchCycleLeaderboardRequest(cycleCode, seq); return; } - long nowMs = System.currentTimeMillis(); - if (nowMs - lastCycleQueryAtMs < 1_000L && knownCycleLeaderboard != null) { + partyCommandExecutor.schedule(() -> { + if (cycleRequestSeq.get() == seq) { + dispatchCycleLeaderboardRequest(cycleCode, seq); + } + }, delayMs, TimeUnit.MILLISECONDS); + } + + private void dispatchCycleLeaderboardRequest(String cycleCode, long seq) { + BridgeWebSocketClient current = socket; + if (!isFullMember() || current == null || !current.isConnected()) { + if (cycleRequestSeq.get() == seq) { + failCycleLeaderboardRequest(); + } return; } - lastCycleQueryAtMs = nowMs; + cycleRequestPendingId.set(seq); + lastCycleQueryAtMs = System.currentTimeMillis(); cycleLeaderboardError = ""; cycleLeaderboardErrorAtMs = 0L; - long id = cycleRequestSeq.incrementAndGet(); - cycleRequestPendingId.set(id); current.sendCycleLeaderboardRequest(cycleCode); partyCommandExecutor.schedule(() -> { - if (cycleRequestPendingId.compareAndSet(id, 0)) { - cycleLeaderboardError = "Failed to fetch cycle leaderboard"; - cycleLeaderboardErrorAtMs = System.currentTimeMillis(); - cycleLeaderboardGeneration.incrementAndGet(); - if (pendingCyclePrintCode != null) { - pendingCyclePrintCode = null; - display(() -> DiscordChatFormatter.systemLine("Failed to fetch cycle leaderboard", ChatFormatting.RED)); - } + if (cycleRequestPendingId.compareAndSet(seq, 0)) { + failCycleLeaderboardRequest(); } }, 5, TimeUnit.SECONDS); } - /** Request lifetime or interval Raids/Wars leaderboards with 1s query cooldown and 5s timeout. */ + private void failCycleLeaderboardRequest() { + cycleRequestPendingId.set(0); + cycleLeaderboardError = "Failed to fetch cycle leaderboard"; + cycleLeaderboardErrorAtMs = System.currentTimeMillis(); + cycleLeaderboardGeneration.incrementAndGet(); + if (pendingCyclePrintCode != null) { + pendingCyclePrintCode = null; + display(() -> DiscordChatFormatter.systemLine("Failed to fetch cycle leaderboard", ChatFormatting.RED)); + } + } + + /** Request lifetime or interval Raids/Wars leaderboards, debounced safely above server throttle. */ public void requestLifetimeLeaderboard(Double fromDays, Double toDays) { - if (!isFullMember()) { - lifetimeLeaderboardError = "Failed to fetch leaderboard stats"; - lifetimeLeaderboardErrorAtMs = System.currentTimeMillis(); - lifetimeLeaderboardGeneration.incrementAndGet(); + long seq = lifetimeRequestSeq.incrementAndGet(); + BridgeWebSocketClient current = socket; + if (!isFullMember() || current == null || !current.isConnected()) { + failLifetimeLeaderboardRequest(); return; } - BridgeWebSocketClient current = socket; - if (current == null || !current.isConnected()) { - lifetimeLeaderboardError = "Failed to fetch leaderboard stats"; - lifetimeLeaderboardErrorAtMs = System.currentTimeMillis(); - lifetimeLeaderboardGeneration.incrementAndGet(); + long delayMs = knownLifetimeLeaderboard == null ? 0L : Math.max(0L, (lastLifetimeQueryAtMs + 950L) - System.currentTimeMillis()); + if (delayMs == 0L) { + dispatchLifetimeLeaderboardRequest(fromDays, toDays, seq); return; } - long nowMs = System.currentTimeMillis(); - if (nowMs - lastLifetimeQueryAtMs < 1_000L && knownLifetimeLeaderboard != null) { + partyCommandExecutor.schedule(() -> { + if (lifetimeRequestSeq.get() == seq) { + dispatchLifetimeLeaderboardRequest(fromDays, toDays, seq); + } + }, delayMs, TimeUnit.MILLISECONDS); + } + + private void dispatchLifetimeLeaderboardRequest(Double fromDays, Double toDays, long seq) { + BridgeWebSocketClient current = socket; + if (!isFullMember() || current == null || !current.isConnected()) { + if (lifetimeRequestSeq.get() == seq) { + failLifetimeLeaderboardRequest(); + } return; } - lastLifetimeQueryAtMs = nowMs; + lifetimeRequestPendingId.set(seq); + lastLifetimeQueryAtMs = System.currentTimeMillis(); lifetimeLeaderboardError = ""; lifetimeLeaderboardErrorAtMs = 0L; - long id = lifetimeRequestSeq.incrementAndGet(); - lifetimeRequestPendingId.set(id); current.sendLifetimeLeaderboardRequest(fromDays, toDays); partyCommandExecutor.schedule(() -> { - if (lifetimeRequestPendingId.compareAndSet(id, 0)) { - lifetimeLeaderboardError = "Failed to fetch leaderboard stats"; - lifetimeLeaderboardErrorAtMs = System.currentTimeMillis(); - lifetimeLeaderboardGeneration.incrementAndGet(); + if (lifetimeRequestPendingId.compareAndSet(seq, 0)) { + failLifetimeLeaderboardRequest(); } }, 5, TimeUnit.SECONDS); } + private void failLifetimeLeaderboardRequest() { + lifetimeRequestPendingId.set(0); + lifetimeLeaderboardError = "Failed to fetch leaderboard stats"; + lifetimeLeaderboardErrorAtMs = System.currentTimeMillis(); + lifetimeLeaderboardGeneration.incrementAndGet(); + } + private CompletableFuture suggestMembers(CommandContext context, SuggestionsBuilder builder) { String remaining = builder.getRemaining().toLowerCase(Locale.ROOT); for (String name : guildRewards.memberNames()) { @@ -3206,7 +3236,9 @@ private synchronized void disconnect() { longEventGeneration.set(0); longEventError = ""; longEventErrorAtMs = 0L; + cycleRequestSeq.incrementAndGet(); cycleRequestPendingId.set(0); + lifetimeRequestSeq.incrementAndGet(); lifetimeRequestPendingId.set(0); knownCycleLeaderboard = null; cycleLeaderboardGeneration.set(0); diff --git a/src/tel/eden/mod/gui/PromotionCycleScreen.java b/src/tel/eden/mod/gui/PromotionCycleScreen.java index bc9fcc1..7edacff 100644 --- a/src/tel/eden/mod/gui/PromotionCycleScreen.java +++ b/src/tel/eden/mod/gui/PromotionCycleScreen.java @@ -157,7 +157,9 @@ public void tick() { raidsScroll = 0; warsScroll = 0; CycleLeaderboardData.CycleSnapshot snap = mod.knownCycleLeaderboard(); - if (snap != null && !snap.cycleCode().isEmpty() && snap.error().isEmpty()) { + if (!mod.recentCycleLeaderboardError().isEmpty()) { + selectedCycleCode = (snap != null && !snap.cycleCode().isEmpty()) ? snap.cycleCode() : null; + } else if (snap != null && !snap.cycleCode().isEmpty() && snap.error().isEmpty()) { selectedCycleCode = snap.cycleCode(); } syncControlState(); @@ -200,7 +202,8 @@ private void navigateArchive(int step) { return; } List cycles = snap.cycles(); - int idx = currentCycleIndex(cycles, snap.cycleCode()); + String currentCode = (selectedCycleCode != null && !selectedCycleCode.isEmpty()) ? selectedCycleCode : snap.cycleCode(); + int idx = currentCycleIndex(cycles, currentCode); if (idx < 0) { return; } @@ -252,7 +255,7 @@ private void syncControlState() { if (isCycle && archiveOpen) { CycleLeaderboardData.CycleSnapshot snap = mod != null ? mod.knownCycleLeaderboard() : null; List cycles = snap != null ? snap.cycles() : List.of(); - String activeCode = snap != null ? snap.cycleCode() : ""; + String activeCode = (selectedCycleCode != null && !selectedCycleCode.isEmpty()) ? selectedCycleCode : (snap != null ? snap.cycleCode() : ""); int idx = currentCycleIndex(cycles, activeCode); prevCycleButton.active = idx > 0; nextCycleButton.active = idx >= 0 && idx < cycles.size() - 1; From 8e41c5e7eca3360024068fd3d25b690e40d9965f Mon Sep 17 00:00:00 2001 From: Good627 <193092356+Good627@users.noreply.github.com> Date: Wed, 18 Nov 2026 20:30:27 +0200 Subject: [PATCH 3/8] chore: add diagnostic error logging, raise leaderboard fetch timeout to 15s, bump to 1.6.7-beta.1 --- gradle.properties | 2 +- src/tel/eden/mod/EdenModClient.java | 61 ++++++++++++++----- .../eden/mod/net/BridgeWebSocketClient.java | 37 ++++++++--- 3 files changed, 78 insertions(+), 22 deletions(-) diff --git a/gradle.properties b/gradle.properties index b6e4c8a..5ac555b 100644 --- a/gradle.properties +++ b/gradle.properties @@ -8,7 +8,7 @@ loader_version=0.19.3 fabric_version=0.141.4+1.21.11 loom_version=1.17.8 -mod_version=1.6.6 +mod_version=1.6.7-beta.1 maven_group=tel.eden archives_base_name=edenmod modmenu_version=17.0.0 diff --git a/src/tel/eden/mod/EdenModClient.java b/src/tel/eden/mod/EdenModClient.java index 935a487..9751259 100644 --- a/src/tel/eden/mod/EdenModClient.java +++ b/src/tel/eden/mod/EdenModClient.java @@ -304,6 +304,7 @@ public boolean onWynncraft() { private final java.util.concurrent.atomic.AtomicInteger lifetimeLeaderboardGeneration = new java.util.concurrent.atomic.AtomicInteger(); private final java.util.Map concludedCyclesByCode = new java.util.concurrent.ConcurrentHashMap<>(); private volatile String pendingCyclePrintCode; + private static final long LEADERBOARD_TIMEOUT_SECONDS = 15L; private final java.util.concurrent.atomic.AtomicLong cycleRequestSeq = new java.util.concurrent.atomic.AtomicLong(); private final java.util.concurrent.atomic.AtomicLong cycleRequestPendingId = new java.util.concurrent.atomic.AtomicLong(); private final java.util.concurrent.atomic.AtomicLong lifetimeRequestSeq = new java.util.concurrent.atomic.AtomicLong(); @@ -596,9 +597,12 @@ public tel.eden.mod.net.CycleLeaderboardData.CycleSnapshot knownCycleLeaderboard return knownCycleLeaderboard; } - /** Last cycle leaderboard error if it arrived within the past 5 seconds, else {@code ""}. */ + /** Last cycle leaderboard error while no snapshot is loaded or within 30s, else {@code ""}. */ public String recentCycleLeaderboardError() { - return System.currentTimeMillis() - cycleLeaderboardErrorAtMs < 5_000L ? cycleLeaderboardError : ""; + if (cycleLeaderboardError.isEmpty()) { + return ""; + } + return (knownCycleLeaderboard == null || System.currentTimeMillis() - cycleLeaderboardErrorAtMs < 30_000L) ? cycleLeaderboardError : ""; } /** Bumped on every cycle leaderboard snapshot or error update. */ @@ -611,9 +615,12 @@ public tel.eden.mod.net.CycleLeaderboardData.LifetimeSnapshot knownLifetimeLeade return knownLifetimeLeaderboard; } - /** Last lifetime leaderboard error if it arrived within the past 5 seconds, else {@code ""}. */ + /** Last lifetime leaderboard error while no snapshot is loaded or within 30s, else {@code ""}. */ public String recentLifetimeLeaderboardError() { - return System.currentTimeMillis() - lifetimeLeaderboardErrorAtMs < 5_000L ? lifetimeLeaderboardError : ""; + if (lifetimeLeaderboardError.isEmpty()) { + return ""; + } + return (knownLifetimeLeaderboard == null || System.currentTimeMillis() - lifetimeLeaderboardErrorAtMs < 30_000L) ? lifetimeLeaderboardError : ""; } /** Bumped on every lifetime leaderboard snapshot or error update. */ @@ -1522,10 +1529,12 @@ public void onLongEventRewards(int pendingLe, String error) { public void onCycleLeaderboard(tel.eden.mod.net.CycleLeaderboardData.CycleSnapshot snapshot) { cycleRequestPendingId.set(0); if (!isFullMember()) { + LOGGER.warn("Ignoring cycleLeaderboardReply while bridgeStatus={}", bridgeStatus); return; } if (snapshot.error() != null && !snapshot.error().isEmpty()) { String err = snapshot.error(); + LOGGER.error("Cycle leaderboard reply returned error: {}", err); cycleLeaderboardError = err; cycleLeaderboardErrorAtMs = System.currentTimeMillis(); cycleLeaderboardGeneration.incrementAndGet(); @@ -1552,9 +1561,11 @@ public void onCycleLeaderboard(tel.eden.mod.net.CycleLeaderboardData.CycleSnapsh public void onLifetimeLeaderboard(tel.eden.mod.net.CycleLeaderboardData.LifetimeSnapshot snapshot) { lifetimeRequestPendingId.set(0); if (!isFullMember()) { + LOGGER.warn("Ignoring lifetimeLeaderboardReply while bridgeStatus={}", bridgeStatus); return; } if (snapshot.error() != null && !snapshot.error().isEmpty()) { + LOGGER.error("Lifetime leaderboard reply returned error: {}", snapshot.error()); lifetimeLeaderboardError = snapshot.error(); lifetimeLeaderboardErrorAtMs = System.currentTimeMillis(); lifetimeLeaderboardGeneration.incrementAndGet(); @@ -1981,6 +1992,7 @@ private void requestCycleLeaderboard(String cycleCode, boolean forPrint) { pendingCyclePrintCode = forPrint ? (cycleCode != null ? cycleCode.trim() : "") : null; BridgeWebSocketClient current = socket; if (!isFullMember() || current == null || !current.isConnected()) { + LOGGER.error("Cycle leaderboard request aborted before send (cycle={}, status={}, connected={})", cycleCode, bridgeStatus, current != null && current.isConnected()); failCycleLeaderboardRequest(); return; } @@ -1990,8 +2002,12 @@ private void requestCycleLeaderboard(String cycleCode, boolean forPrint) { return; } partyCommandExecutor.schedule(() -> { - if (cycleRequestSeq.get() == seq) { - dispatchCycleLeaderboardRequest(cycleCode, seq); + try { + if (cycleRequestSeq.get() == seq) { + dispatchCycleLeaderboardRequest(cycleCode, seq); + } + } catch (RuntimeException e) { + LOGGER.error("Scheduled cycle leaderboard dispatch failed (seq={}, cycle={})", seq, cycleCode, e); } }, delayMs, TimeUnit.MILLISECONDS); } @@ -2000,6 +2016,7 @@ private void dispatchCycleLeaderboardRequest(String cycleCode, long seq) { BridgeWebSocketClient current = socket; if (!isFullMember() || current == null || !current.isConnected()) { if (cycleRequestSeq.get() == seq) { + LOGGER.error("Cycle leaderboard deferred send aborted (seq={}, cycle={}, status={}, connected={})", seq, cycleCode, bridgeStatus, current != null && current.isConnected()); failCycleLeaderboardRequest(); } return; @@ -2010,10 +2027,15 @@ private void dispatchCycleLeaderboardRequest(String cycleCode, long seq) { cycleLeaderboardErrorAtMs = 0L; current.sendCycleLeaderboardRequest(cycleCode); partyCommandExecutor.schedule(() -> { - if (cycleRequestPendingId.compareAndSet(seq, 0)) { - failCycleLeaderboardRequest(); + try { + if (cycleRequestPendingId.compareAndSet(seq, 0)) { + LOGGER.error("Cycle leaderboard request timed out after {}s (seq={}, cycle={}, status={}, connected={}) — no reply from backend", LEADERBOARD_TIMEOUT_SECONDS, seq, cycleCode, bridgeStatus, socket != null && socket.isConnected()); + failCycleLeaderboardRequest(); + } + } catch (RuntimeException e) { + LOGGER.error("Cycle leaderboard timeout task failed (seq={}, cycle={})", seq, cycleCode, e); } - }, 5, TimeUnit.SECONDS); + }, LEADERBOARD_TIMEOUT_SECONDS, TimeUnit.SECONDS); } private void failCycleLeaderboardRequest() { @@ -2032,6 +2054,7 @@ public void requestLifetimeLeaderboard(Double fromDays, Double toDays) { long seq = lifetimeRequestSeq.incrementAndGet(); BridgeWebSocketClient current = socket; if (!isFullMember() || current == null || !current.isConnected()) { + LOGGER.error("Lifetime leaderboard request aborted before send (fromDays={}, toDays={}, status={}, connected={})", fromDays, toDays, bridgeStatus, current != null && current.isConnected()); failLifetimeLeaderboardRequest(); return; } @@ -2041,8 +2064,12 @@ public void requestLifetimeLeaderboard(Double fromDays, Double toDays) { return; } partyCommandExecutor.schedule(() -> { - if (lifetimeRequestSeq.get() == seq) { - dispatchLifetimeLeaderboardRequest(fromDays, toDays, seq); + try { + if (lifetimeRequestSeq.get() == seq) { + dispatchLifetimeLeaderboardRequest(fromDays, toDays, seq); + } + } catch (RuntimeException e) { + LOGGER.error("Scheduled lifetime leaderboard dispatch failed (seq={}, fromDays={}, toDays={})", seq, fromDays, toDays, e); } }, delayMs, TimeUnit.MILLISECONDS); } @@ -2051,6 +2078,7 @@ private void dispatchLifetimeLeaderboardRequest(Double fromDays, Double toDays, BridgeWebSocketClient current = socket; if (!isFullMember() || current == null || !current.isConnected()) { if (lifetimeRequestSeq.get() == seq) { + LOGGER.error("Lifetime leaderboard deferred send aborted (seq={}, fromDays={}, toDays={}, status={}, connected={})", seq, fromDays, toDays, bridgeStatus, current != null && current.isConnected()); failLifetimeLeaderboardRequest(); } return; @@ -2061,10 +2089,15 @@ private void dispatchLifetimeLeaderboardRequest(Double fromDays, Double toDays, lifetimeLeaderboardErrorAtMs = 0L; current.sendLifetimeLeaderboardRequest(fromDays, toDays); partyCommandExecutor.schedule(() -> { - if (lifetimeRequestPendingId.compareAndSet(seq, 0)) { - failLifetimeLeaderboardRequest(); + try { + if (lifetimeRequestPendingId.compareAndSet(seq, 0)) { + LOGGER.error("Lifetime leaderboard request timed out after {}s (seq={}, fromDays={}, toDays={}, status={}, connected={}) — no reply from backend", LEADERBOARD_TIMEOUT_SECONDS, seq, fromDays, toDays, bridgeStatus, socket != null && socket.isConnected()); + failLifetimeLeaderboardRequest(); + } + } catch (RuntimeException e) { + LOGGER.error("Lifetime leaderboard timeout task failed (seq={}, fromDays={}, toDays={})", seq, fromDays, toDays, e); } - }, 5, TimeUnit.SECONDS); + }, LEADERBOARD_TIMEOUT_SECONDS, TimeUnit.SECONDS); } private void failLifetimeLeaderboardRequest() { diff --git a/src/tel/eden/mod/net/BridgeWebSocketClient.java b/src/tel/eden/mod/net/BridgeWebSocketClient.java index 0699961..3adc184 100644 --- a/src/tel/eden/mod/net/BridgeWebSocketClient.java +++ b/src/tel/eden/mod/net/BridgeWebSocketClient.java @@ -338,11 +338,17 @@ public boolean isConnected() { * swallows a prior failure so one bad send can't wedge every send after it. */ private synchronized boolean enqueueSend(WebSocket ws, JsonObject obj) { - if (!OutboundPolicy.allowed(standing, get(obj, "type"))) { + String type = get(obj, "type"); + if (!OutboundPolicy.allowed(standing, type)) { + LOGGER.warn("Blocked outbound {} frame under standing={} (authenticated={})", type, standing, authenticated); return false; } String text = obj.toString(); - sendChain = sendChain.handle((v, ex) -> null).thenCompose(ignored -> ws.sendText(text, true)); + sendChain = sendChain.handle((v, ex) -> null).thenCompose(ignored -> ws.sendText(text, true)).whenComplete((v, err) -> { + if (err != null) { + LOGGER.error("Failed to send {} WebSocket frame: {}", type, err.toString(), err); + } + }); return true; } @@ -1082,8 +1088,11 @@ public void sendLongEventStateRequest() { public void sendCycleLeaderboardRequest(String cycleCode) { WebSocket current = socket; if (current == null) { + LOGGER.warn("Skipped cycleLeaderboardRequest (WebSocket disconnected)"); return; } + String target = (cycleCode != null && !cycleCode.isBlank()) ? cycleCode.trim() : ""; + LOGGER.info("Sending cycleLeaderboardRequest (cycle={})", target); JsonObject obj = new JsonObject(); obj.addProperty("type", "cycleLeaderboardRequest"); if (cycleCode != null && !cycleCode.isBlank()) { @@ -1096,8 +1105,10 @@ public void sendCycleLeaderboardRequest(String cycleCode) { public void sendLifetimeLeaderboardRequest(Double fromDays, Double toDays) { WebSocket current = socket; if (current == null) { + LOGGER.warn("Skipped lifetimeLeaderboardRequest (WebSocket disconnected)"); return; } + LOGGER.info("Sending lifetimeLeaderboardRequest (fromDays={}, toDays={})", fromDays, toDays); JsonObject obj = new JsonObject(); obj.addProperty("type", "lifetimeLeaderboardRequest"); if (fromDays != null) { @@ -1558,10 +1569,12 @@ public void onError(WebSocket webSocket, Throwable error) { private void handlePayload(String payload) { try { JsonObject obj = JsonParser.parseString(payload).getAsJsonObject(); - if (!OutboundPolicy.inboundAllowed(standing, get(obj, "type"))) { + String inboundType = get(obj, "type"); + if (!OutboundPolicy.inboundAllowed(standing, inboundType)) { + LOGGER.warn("Dropped inbound {} frame under standing={}", inboundType, standing); return; } - switch (get(obj, "type")) { + switch (inboundType) { case "discordMessage" -> sink.onDiscordMessage(get(obj, "author"), get(obj, "content"), get(obj, "replyTo"), get(obj, "replyExcerpt"), get(obj, "color"), get(obj, "messageId")); case "travelerChat" -> sink.onTravelerChat(cap(get(obj, "author"), 64), cap(get(obj, "content"), 512), get(obj, "source"), get(obj, "color"), cap(get(obj, "replyTo"), 64), cap(get(obj, "replyExcerpt"), 256), get(obj, "messageId").matches("[0-9]{1,20}") ? get(obj, "messageId") : ""); case "loginNotice" -> sink.onLoginNotice(get(obj, "username"), get(obj, "color")); @@ -1647,7 +1660,7 @@ private void handlePayload(String payload) { /* ignore unknown types */ } } } catch (RuntimeException e) { - LOGGER.debug("Ignoring malformed inbound payload", e); + LOGGER.error("Failed to handle inbound bridge payload: {}", e.toString(), e); } } @@ -1962,11 +1975,21 @@ static LongEventState parseLongEventState(JsonObject obj) { } private static Integer getOptionalInt(JsonObject obj, String key) { - return obj.has(key) && !obj.get(key).isJsonNull() ? obj.get(key).getAsInt() : null; + try { + return obj.has(key) && !obj.get(key).isJsonNull() ? obj.get(key).getAsInt() : null; + } catch (RuntimeException e) { + LOGGER.warn("Ignoring malformed integer field {}: {}", key, e.toString()); + return null; + } } private static Double getOptionalDouble(JsonObject obj, String key) { - return obj.has(key) && !obj.get(key).isJsonNull() ? obj.get(key).getAsDouble() : null; + try { + return obj.has(key) && !obj.get(key).isJsonNull() ? obj.get(key).getAsDouble() : null; + } catch (RuntimeException e) { + LOGGER.warn("Ignoring malformed double field {}: {}", key, e.toString()); + return null; + } } private static java.util.List parseLeaderboardEntries(JsonObject obj, String key) { From 23621a7d4bde0bb904bbe318e76ee9b2a063d46a Mon Sep 17 00:00:00 2001 From: Good627 <193092356+Good627@users.noreply.github.com> Date: Wed, 18 Nov 2026 22:08:56 +0200 Subject: [PATCH 4/8] Redesign /eden cycle screen full-screen with emerald theme and Eden logo (1.6.7-beta.2) --- gradle.properties | 2 +- .../eden/mod/gui/PromotionCycleScreen.java | 409 +++++++++++++----- 2 files changed, 294 insertions(+), 117 deletions(-) diff --git a/gradle.properties b/gradle.properties index 5ac555b..33f3534 100644 --- a/gradle.properties +++ b/gradle.properties @@ -8,7 +8,7 @@ loader_version=0.19.3 fabric_version=0.141.4+1.21.11 loom_version=1.17.8 -mod_version=1.6.7-beta.1 +mod_version=1.6.7-beta.2 maven_group=tel.eden archives_base_name=edenmod modmenu_version=17.0.0 diff --git a/src/tel/eden/mod/gui/PromotionCycleScreen.java b/src/tel/eden/mod/gui/PromotionCycleScreen.java index 7edacff..9e3ef37 100644 --- a/src/tel/eden/mod/gui/PromotionCycleScreen.java +++ b/src/tel/eden/mod/gui/PromotionCycleScreen.java @@ -24,18 +24,18 @@ public class PromotionCycleScreen extends EdenReferenceScreen { private static final int BASE_PANEL_WIDTH = 468; private static final int BASE_PANEL_HEIGHT = 272; - private static final int LEFT_COL_X = 12; + private static final int LEFT_COL_X = 14; private static final int RIGHT_COL_X = 240; private static final int COL_WIDTH = 208; private static final int SCROLLBAR_OFFSET = 210; private static final int SCROLLBAR_WIDTH = 6; private static final int VISIBLE_ROWS = 8; - private static final int ROW_PITCH = 17; - private static final int ROW_HEIGHT = 15; - private static final int ZERO_ROW_OVERLAY = 0x44CC2222; - private static final int ROW_FILL = 0x44282828; + private static final int ROW_PITCH = 18; + private static final int ROW_HEIGHT = 16; + private static final int ZERO_ROW_OVERLAY = 0x48CC2222; + private static final int ROW_FILL = 0x520F281A; - private static final Identifier[] MEDAL_TEXTURES = {Identifier.fromNamespaceAndPath("edenmod", "textures/gui/cycle/medal_1.png"), Identifier.fromNamespaceAndPath("edenmod", "textures/gui/cycle/medal_2.png"), Identifier.fromNamespaceAndPath("edenmod", "textures/gui/cycle/medal_3.png"),}; + private static final Identifier[] MEDAL_TEXTURES = {Identifier.fromNamespaceAndPath("edenmod", "textures/gui/cycle/medal_1.png"), Identifier.fromNamespaceAndPath("edenmod", "textures/gui/cycle/medal_2.png"), Identifier.fromNamespaceAndPath("edenmod", "textures/gui/cycle/medal_3.png"), Identifier.fromNamespaceAndPath("edenmod", "icon.png"),}; private enum Tab { CYCLE, LIFETIME @@ -89,6 +89,9 @@ public PromotionCycleScreen(Screen parent, EdenModClient mod, String initialCycl protected void init() { super.init(); layout = centeredLayout(BASE_PANEL_WIDTH, BASE_PANEL_HEIGHT); + uiScale = 1.0f; + virtualWidth = this.width; + virtualHeight = this.height; if (fromBox != null) { fromDraft = fromBox.getValue(); @@ -99,36 +102,40 @@ protected void init() { this.clearWidgets(); - cycleTabButton = Button.builder(Component.literal("Promotion Cycle"), b -> switchTab(Tab.CYCLE)).bounds(layout.x(12), layout.y(24), layout.w(110), layout.h(18)).build(); - lifetimeTabButton = Button.builder(Component.literal("Lifetime"), b -> switchTab(Tab.LIFETIME)).bounds(layout.x(126), layout.y(24), layout.w(80), layout.h(18)).build(); + int tabStartX = Math.max(198, (this.width - 196) / 2); + int tabY = 18; + cycleTabButton = Button.builder(Component.literal("Promotion Cycle"), b -> switchTab(Tab.CYCLE)).bounds(tabStartX, tabY, 112, 20).build(); + lifetimeTabButton = Button.builder(Component.literal("Lifetime"), b -> switchTab(Tab.LIFETIME)).bounds(tabStartX + 116, tabY, 80, 20).build(); this.addRenderableWidget(cycleTabButton); this.addRenderableWidget(lifetimeTabButton); - Button closeButton = Button.builder(Component.literal("Close"), b -> onClose()).bounds(layout.x(BASE_PANEL_WIDTH - 62), layout.y(8), layout.w(50), layout.h(16)).build(); + Button closeButton = Button.builder(Component.literal("Close"), b -> onClose()).bounds(this.width - 66, 18, 50, 20).build(); this.addRenderableWidget(closeButton); - // Cycle tab controls - prevCycleButton = Button.builder(Component.literal("< Previous"), b -> navigateArchive(-1)).bounds(layout.x(226), layout.y(BASE_PANEL_HEIGHT - 26), layout.w(68), layout.h(18)).build(); - nextCycleButton = Button.builder(Component.literal("Next >"), b -> navigateArchive(1)).bounds(layout.x(298), layout.y(BASE_PANEL_HEIGHT - 26), layout.w(56), layout.h(18)).build(); - archiveButton = Button.builder(Component.literal("Cycle Archive"), b -> toggleArchive()).bounds(layout.x(BASE_PANEL_WIDTH - 108), layout.y(BASE_PANEL_HEIGHT - 26), layout.w(96), layout.h(18)).build(); + // Cycle tab archive controls in full-width bottom-right footer + int archiveY = this.height - 30; + prevCycleButton = Button.builder(Component.literal("< Previous"), b -> navigateArchive(-1)).bounds(this.width - 246, archiveY, 70, 18).build(); + nextCycleButton = Button.builder(Component.literal("Next >"), b -> navigateArchive(1)).bounds(this.width - 172, archiveY, 58, 18).build(); + archiveButton = Button.builder(Component.literal("Cycle Archive"), b -> toggleArchive()).bounds(this.width - 110, archiveY, 94, 18).build(); this.addRenderableWidget(prevCycleButton); this.addRenderableWidget(nextCycleButton); this.addRenderableWidget(archiveButton); - // Lifetime tab controls - fromBox = new EditBox(this.font, layout.x(42), layout.y(48), layout.w(78), layout.h(18), Component.literal("From days ago")); + // Lifetime tab controls inside emerald filter bar + int filterY = 62; + fromBox = new EditBox(this.font, 48, filterY, 80, 18, Component.literal("From days ago")); fromBox.setHint(Component.literal("-# days ago").withStyle(ChatFormatting.GRAY)); fromBox.setMaxLength(16); fromBox.setValue(fromDraft); - toBox = new EditBox(this.font, layout.x(146), layout.y(48), layout.w(78), layout.h(18), Component.literal("To days ago")); + toBox = new EditBox(this.font, 154, filterY, 80, 18, Component.literal("To days ago")); toBox.setHint(Component.literal("-# days ago").withStyle(ChatFormatting.GRAY)); toBox.setMaxLength(16); toBox.setValue(toDraft); - applyIntervalButton = Button.builder(Component.literal("Apply"), b -> applyInterval()).bounds(layout.x(230), layout.y(48), layout.w(46), layout.h(18)).build(); - resetIntervalButton = Button.builder(Component.literal("Reset"), b -> resetInterval()).bounds(layout.x(280), layout.y(48), layout.w(46), layout.h(18)).build(); - finishesToggleButton = Button.builder(Component.literal("Cycle Finishes"), b -> toggleFinishes()).bounds(layout.x(BASE_PANEL_WIDTH - 118), layout.y(48), layout.w(106), layout.h(18)).build(); + applyIntervalButton = Button.builder(Component.literal("Apply"), b -> applyInterval()).bounds(240, filterY, 48, 18).build(); + resetIntervalButton = Button.builder(Component.literal("Reset"), b -> resetInterval()).bounds(292, filterY, 48, 18).build(); + finishesToggleButton = Button.builder(Component.literal("Cycle Finishes"), b -> toggleFinishes()).bounds(this.width - 126, filterY, 108, 18).build(); this.addRenderableWidget(fromBox); this.addRenderableWidget(toBox); @@ -289,7 +296,41 @@ public void render(GuiGraphics g, int mouseX, int mouseY, float delta) { int scaledMouseY = scaledMouseY(mouseY); pushReferencePose(g); - layout.drawPanel(g); + + // Full-screen layered emerald backdrop + g.fillGradient(0, 0, this.width, this.height, 0xF006150C, 0xF6030906); + g.fillGradient(0, 0, this.width, Math.min(this.height, 150), 0x5C1D7843, 0x0006150C); + g.fillGradient(0, Math.max(0, this.height - 96), this.width, this.height, 0x00030906, 0x8C020604); + g.fill(0, 0, this.width, 1, 0xFF287D4B); + g.fill(0, this.height - 1, this.width, this.height, 0xFF1A5734); + g.fill(0, 0, 1, this.height, 0xFF287D4B); + g.fill(this.width - 1, 0, this.width, this.height, 0xFF1A5734); + + // Shaded emerald top banner with framed Eden Logo crest + int headerRight = this.width - 8; + g.fillGradient(8, 6, headerRight, 52, 0xEB113821, 0xEB092113); + g.fill(8, 6, headerRight, 7, 0x6658F59F); + g.fill(8, 50, headerRight, 52, 0xFF2EA866); + g.fill(8, 52, headerRight, 55, 0x55000000); + g.fill(8, 6, 9, 52, 0xFF256D43); + g.fill(headerRight - 1, 6, headerRight, 52, 0xFF256D43); + + // Eden Logo emblem + g.fill(15, 9, 53, 47, 0xAA0C2818); + g.fill(15, 9, 53, 10, 0xFF47DB86); + g.fill(15, 46, 53, 47, 0xFF257A48); + g.fill(15, 9, 16, 47, 0xFF47DB86); + g.fill(52, 9, 53, 47, 0xFF257A48); + drawTexture(g, MEDAL_TEXTURES[3], 17, 11, 34, 34); + + String heading = activeTab == Tab.CYCLE ? "Eden Promotion Cycle" : "Eden Lifetime Stats"; + g.drawString(this.font, heading, 60, 15, 0xFF7BFFAE); + + // Active-tab glowing mint indicator underneath the selected tab button + int tabStartX = Math.max(198, (this.width - 196) / 2); + int activeIndX = activeTab == Tab.CYCLE ? tabStartX : (tabStartX + 116); + int activeIndW = activeTab == Tab.CYCLE ? 112 : 80; + g.fill(activeIndX + 4, 40, activeIndX + activeIndW - 4, 42, 0xFF56FF9F); if (activeTab == Tab.CYCLE) { renderCycleTab(g); @@ -298,8 +339,6 @@ public void render(GuiGraphics g, int mouseX, int mouseY, float delta) { } super.render(g, scaledMouseX, scaledMouseY, delta); - String heading = activeTab == Tab.CYCLE ? "Promotion Cycle" : "Lifetime Stats"; - g.drawCenteredString(this.font, heading, layout.centerX(), layout.y(10), 0xFFFFFFFF); popReferencePose(g); } @@ -307,28 +346,58 @@ private void renderCycleTab(GuiGraphics g) { CycleLeaderboardData.CycleSnapshot snap = mod != null ? mod.knownCycleLeaderboard() : null; String err = mod != null ? mod.recentCycleLeaderboardError() : ""; - String cycleHeader = (snap != null && !snap.cycleCode().isEmpty()) ? "Cycle " + snap.cycleCode() : "Loading..."; - g.drawString(this.font, cycleHeader, layout.x(220), layout.y(29), 0xFFFFCC55); + String cycleBadge; + if (snap != null && !snap.cycleCode().isEmpty()) { + List cycles = snap.cycles(); + boolean latest = cycles.isEmpty() || snap.cycleCode().equals(cycles.get(cycles.size() - 1)); + cycleBadge = "Cycle " + snap.cycleCode() + (latest ? " • Current" : " • Archive"); + } else { + cycleBadge = "Fetching cycle..."; + } + g.drawString(this.font, cycleBadge, 60, 29, 0xFFA8EBC2); + + // Bottom shaded footer card + int footerTop = this.height - 36; + int footerRight = this.width - 8; + g.fillGradient(8, footerTop, footerRight, this.height - 6, 0xEB0E2E1C, 0xEB07190F); + g.fill(8, footerTop, footerRight, footerTop + 1, 0xFF319A5D); + int centerY = this.height / 2; if (!err.isEmpty()) { - g.drawCenteredString(this.font, err, layout.centerX(), layout.y(126), 0xFFFF5555); + g.drawCenteredString(this.font, err, this.width / 2, centerY - 4, 0xFFFF6B6B); return; } if (snap == null) { - g.drawCenteredString(this.font, "Loading cycle leaderboard...", layout.centerX(), layout.y(126), 0xFFAAAAAA); + g.drawCenteredString(this.font, "Loading cycle leaderboard...", this.width / 2, centerY - 4, 0xFFA8EBC2); return; } - int listTopOffset = listTopOffset(); - g.drawCenteredString(this.font, "Raids", layout.x(LEFT_COL_X + COL_WIDTH / 2), layout.y(listTopOffset - 12), 0xFF55FFFF); - g.drawCenteredString(this.font, "Wars", layout.x(RIGHT_COL_X + COL_WIDTH / 2), layout.y(listTopOffset - 12), 0xFFFF5555); - - renderEntryList(g, LEFT_COL_X, listTopOffset, snap.raids(), raidsScroll, true, true); - renderEntryList(g, RIGHT_COL_X, listTopOffset, snap.wars(), warsScroll, true, true); - - int footerY = layout.y(BASE_PANEL_HEIGHT - 44); - String totals = "Totals: " + snap.totalRaids() + " raids | " + snap.totalWars() + " wars | " + snap.totalTickets() + " tickets"; - g.drawString(this.font, totals, layout.x(12), footerY, 0xFFFFD966); + int listTop = listTopOffset(); + int colW = Math.max(180, (this.width - 42) / 2); + int leftX = 14; + int rightX = 14 + colW + 14; + int hdrTop = listTop - 20; + + // Column Headers (shaded emerald & gold-emerald) + g.fillGradient(leftX, hdrTop, leftX + colW, listTop, 0xEE14472D, 0xEE0C2C1B); + g.fill(leftX, hdrTop, leftX + colW, hdrTop + 2, 0xFF42E695); + g.drawString(this.font, "Raids", leftX + 8, hdrTop + 6, 0xFF7CFFD1); + String rCount = snap.raids().size() + " players"; + g.drawString(this.font, rCount, leftX + colW - 8 - this.font.width(rCount), hdrTop + 6, 0xFF93D1AE); + + g.fillGradient(rightX, hdrTop, rightX + colW, listTop, 0xEE1A4223, 0xEE0F2916); + g.fill(rightX, hdrTop, rightX + colW, hdrTop + 2, 0xFFFFCA62); + g.drawString(this.font, "Wars", rightX + 8, hdrTop + 6, 0xFFFFD479); + String wCount = snap.wars().size() + " players"; + g.drawString(this.font, wCount, rightX + colW - 8 - this.font.width(wCount), hdrTop + 6, 0xFFD9C798); + + renderEntryList(g, LEFT_COL_X, listTop, snap.raids(), raidsScroll, true, true); + renderEntryList(g, RIGHT_COL_X, listTop, snap.wars(), warsScroll, true, true); + + int controlsLeft = archiveOpen ? (this.width - 256) : (this.width - 120); + int maxTextW = Math.max(80, controlsLeft - 24); + String totals = "Totals: " + snap.totalRaids() + " raids • " + snap.totalWars() + " wars • " + snap.totalTickets() + " tickets"; + g.drawString(this.font, trimToWidth(totals, maxTextW), 16, footerTop + 5, 0xFFFFE082); if (!snap.raffleWinners().isEmpty()) { StringBuilder raffle = new StringBuilder("Raffle Top 3: "); List top = snap.raffleWinners().subList(0, Math.min(3, snap.raffleWinners().size())); @@ -338,155 +407,251 @@ private void renderCycleTab(GuiGraphics g) { } raffle.append("#").append(i + 1).append(" ").append(top.get(i).name()).append(" (").append(top.get(i).tickets()).append(")"); } - g.drawString(this.font, trimToWidth(raffle.toString(), layout.w(320)), layout.x(12), footerY + layout.h(12), 0xFFD5A6FF); + g.drawString(this.font, trimToWidth(raffle.toString(), maxTextW), 16, footerTop + 17, 0xFFE2C6FF); } } private void renderLifetimeTab(GuiGraphics g) { - g.drawString(this.font, "From:", layout.x(12), layout.y(53), 0xFFCCCCCC); - g.drawString(this.font, "To:", layout.x(126), layout.y(53), 0xFFCCCCCC); + CycleLeaderboardData.LifetimeSnapshot snap = mod != null ? mod.knownLifetimeLeaderboard() : null; + String err = mod != null ? mod.recentLifetimeLeaderboardError() : ""; + + String sub = "All-Time Records"; + if (snap != null && snap.hasInterval()) { + String toLabel = (snap.toDays() == null || snap.toDays() <= 0.0) ? "now" : ("-" + snap.toDays() + "d"); + sub = "Filtered Window: -" + snap.fromDays() + "d to " + toLabel; + } + g.drawString(this.font, sub, 60, 29, 0xFFA8EBC2); + + // Shaded emerald filter bar + int barRight = this.width - 14; + g.fillGradient(14, 58, barRight, 84, 0xD80D2B1B, 0xD8081C11); + g.fill(14, 58, barRight, 59, 0xFF287549); + g.fill(14, 83, barRight, 84, 0xFF1D5937); + g.fill(14, 58, 15, 84, 0xFF236841); + g.fill(barRight - 1, 58, barRight, 84, 0xFF236841); + + g.drawString(this.font, "From:", 20, 67, 0xFFA8EBC2); + g.drawString(this.font, "To:", 134, 67, 0xFFA8EBC2); if (!validationError.isEmpty()) { - g.drawString(this.font, validationError, layout.x(12), layout.y(70), 0xFFFF5555); + g.drawString(this.font, trimToWidth(validationError, Math.max(80, this.width - 490)), 346, 67, 0xFFFF6B6B); } - CycleLeaderboardData.LifetimeSnapshot snap = mod != null ? mod.knownLifetimeLeaderboard() : null; - String err = mod != null ? mod.recentLifetimeLeaderboardError() : ""; + // Footer strip + int footerTop = this.height - 36; + g.fillGradient(8, footerTop, this.width - 8, this.height - 6, 0xEB0E2E1C, 0xEB07190F); + g.fill(8, footerTop, this.width - 8, footerTop + 1, 0xFF319A5D); + g.drawString(this.font, showFinishes ? "Cycle Finishes: cumulative #1 / #2 / #3 placements across concluded cycles" : (snap != null && snap.hasInterval() ? "Custom day interval active (medals disabled)" : "All-time cumulative completions"), 16, footerTop + 11, 0xFF8CD1A8); + + int centerY = this.height / 2 + 12; if (!err.isEmpty()) { - g.drawCenteredString(this.font, err, layout.centerX(), layout.y(140), 0xFFFF5555); + g.drawCenteredString(this.font, err, this.width / 2, centerY, 0xFFFF6B6B); return; } if (snap == null) { - g.drawCenteredString(this.font, "Loading leaderboard stats...", layout.centerX(), layout.y(140), 0xFFAAAAAA); + g.drawCenteredString(this.font, "Loading leaderboard stats...", this.width / 2, centerY, 0xFFA8EBC2); return; } - int listTopOffset = listTopOffset(); + int listTop = listTopOffset(); + int colW = Math.max(180, (this.width - 42) / 2); + int leftX = 14; + int rightX = 14 + colW + 14; + int hdrTop = listTop - 20; + if (showFinishes) { - g.drawCenteredString(this.font, "Raids Finishes", layout.x(LEFT_COL_X + COL_WIDTH / 2), layout.y(listTopOffset - 12), 0xFF55FFFF); - g.drawCenteredString(this.font, "Wars Finishes", layout.x(RIGHT_COL_X + COL_WIDTH / 2), layout.y(listTopOffset - 12), 0xFFFF5555); - renderPodiumList(g, LEFT_COL_X, listTopOffset, snap.raidFinishes(), raidsScroll); - renderPodiumList(g, RIGHT_COL_X, listTopOffset, snap.warFinishes(), warsScroll); + g.fillGradient(leftX, hdrTop, leftX + colW, listTop, 0xEE14472D, 0xEE0C2C1B); + g.fill(leftX, hdrTop, leftX + colW, hdrTop + 2, 0xFF42E695); + g.drawString(this.font, "Raids Cycle Finishes", leftX + 8, hdrTop + 6, 0xFF7CFFD1); + + g.fillGradient(rightX, hdrTop, rightX + colW, listTop, 0xEE1A4223, 0xEE0F2916); + g.fill(rightX, hdrTop, rightX + colW, hdrTop + 2, 0xFFFFCA62); + g.drawString(this.font, "Wars Cycle Finishes", rightX + 8, hdrTop + 6, 0xFFFFD479); + + renderPodiumList(g, LEFT_COL_X, listTop, snap.raidFinishes(), raidsScroll); + renderPodiumList(g, RIGHT_COL_X, listTop, snap.warFinishes(), warsScroll); return; } String subtitle = snap.hasInterval() ? " (Filtered: no medals)" : ""; - g.drawCenteredString(this.font, "Raids" + subtitle, layout.x(LEFT_COL_X + COL_WIDTH / 2), layout.y(listTopOffset - 12), 0xFF55FFFF); - g.drawCenteredString(this.font, "Wars" + subtitle, layout.x(RIGHT_COL_X + COL_WIDTH / 2), layout.y(listTopOffset - 12), 0xFFFF5555); + g.fillGradient(leftX, hdrTop, leftX + colW, listTop, 0xEE14472D, 0xEE0C2C1B); + g.fill(leftX, hdrTop, leftX + colW, hdrTop + 2, 0xFF42E695); + g.drawString(this.font, "Raids" + subtitle, leftX + 8, hdrTop + 6, 0xFF7CFFD1); + + g.fillGradient(rightX, hdrTop, rightX + colW, listTop, 0xEE1A4223, 0xEE0F2916); + g.fill(rightX, hdrTop, rightX + colW, hdrTop + 2, 0xFFFFCA62); + g.drawString(this.font, "Wars" + subtitle, rightX + 8, hdrTop + 6, 0xFFFFD479); boolean showMedals = !snap.hasInterval(); - renderEntryList(g, LEFT_COL_X, listTopOffset, snap.raids(), raidsScroll, showMedals, false); - renderEntryList(g, RIGHT_COL_X, listTopOffset, snap.wars(), warsScroll, showMedals, false); + renderEntryList(g, LEFT_COL_X, listTop, snap.raids(), raidsScroll, showMedals, false); + renderEntryList(g, RIGHT_COL_X, listTop, snap.wars(), warsScroll, showMedals, false); } private void renderEntryList(GuiGraphics g, int baseColX, int baseTopY, List entries, int scrollOffset, boolean showMedals, boolean showDelta) { - int x = layout.x(baseColX); - int top = layout.y(baseTopY); - int width = layout.w(COL_WIDTH); - int height = layout.h(VISIBLE_ROWS * ROW_PITCH + 4); - g.fill(x, top, x + width, top + height, 0x22000000); + int colW = Math.max(180, (this.width - 42) / 2); + int x = baseColX == LEFT_COL_X ? 14 : (14 + colW + 14); + int listW = colW - 8; + int bottomLimit = Math.max(baseTopY + ROW_PITCH * 4 + 4, this.height - 42); + int visRows = Math.max(4, (bottomLimit - baseTopY - 4) / ROW_PITCH); + int height = visRows * ROW_PITCH + 4; + + // Shaded card body + border + g.fill(x, baseTopY, x + colW, baseTopY + height, 0xB806140C); + g.fill(x, baseTopY, x + colW, baseTopY + 1, 0xFF246A43); + g.fill(x, baseTopY + height - 1, x + colW, baseTopY + height, 0xFF1A4F32); + g.fill(x, baseTopY, x + 1, baseTopY + height, 0xFF246A43); + g.fill(x + colW - 1, baseTopY, x + colW, baseTopY + height, 0xFF1A4F32); int total = entries.size(); int clamped = clampOffset(scrollOffset, total); - for (int vis = 0; vis < VISIBLE_ROWS; vis++) { + g.enableScissor(x + 1, baseTopY + 1, x + listW, baseTopY + height - 1); + for (int vis = 0; vis < visRows; vis++) { int idx = clamped + vis; if (idx >= total) { break; } CycleLeaderboardData.LeaderboardEntry entry = entries.get(idx); - int rowY = layout.y(baseTopY + 2 + vis * ROW_PITCH); - int rowH = layout.h(ROW_HEIGHT); - g.fill(x + layout.w(2), rowY, x + width - layout.w(2), rowY + rowH, entry.count() <= 0 ? ZERO_ROW_OVERLAY : ROW_FILL); + int rowY = baseTopY + 2 + vis * ROW_PITCH; + int rowBg; + int accentBar = 0; + if (entry.count() <= 0) { + rowBg = ZERO_ROW_OVERLAY; + accentBar = 0xFFFF5555; + } else if (entry.rank() == 1) { + rowBg = 0x623F330F; + accentBar = 0xFFFFD700; + } else if (entry.rank() == 2) { + rowBg = 0x52253633; + accentBar = 0xFFD4E0EA; + } else if (entry.rank() == 3) { + rowBg = 0x523B2616; + accentBar = 0xFFDE9151; + } else { + rowBg = (idx & 1) == 0 ? ROW_FILL : 0x3A0A1C12; + } + g.fill(x + 3, rowY, x + listW - 2, rowY + ROW_HEIGHT, rowBg); + if (accentBar != 0) { + g.fill(x + 3, rowY, x + 5, rowY + ROW_HEIGHT, accentBar); + } - int cursorX = x + layout.w(4); + int cursorX = x + 8; if (showDelta) { Integer deltaVal = entry.delta(); String deltaText = deltaVal == null || deltaVal == 0 ? "-" : (deltaVal > 0 ? "+" + deltaVal : String.valueOf(deltaVal)); - int deltaColor = deltaVal == null || deltaVal == 0 ? 0xFF888888 : (deltaVal > 0 ? 0xFF55FF55 : 0xFFFF5555); - g.drawString(this.font, deltaText, cursorX, rowY + layout.h(4), deltaColor); - cursorX += layout.w(22); + int deltaColor = deltaVal == null || deltaVal == 0 ? 0xFF729E84 : (deltaVal > 0 ? 0xFF55FF88 : 0xFFFF6B6B); + g.drawString(this.font, deltaText, cursorX, rowY + 4, deltaColor); + cursorX += 24; } if (this.minecraft != null) { PlayerSkin skin = PlayerSkinResolver.skinFor(this.minecraft, parseUuid(entry.uuid()), entry.name()); if (skin != null) { - PlayerFaceRenderer.draw(g, skin, cursorX, rowY + layout.h(2), layout.w(10)); + PlayerFaceRenderer.draw(g, skin, cursorX, rowY + 3, 10); } } - cursorX += layout.w(13); + cursorX += 14; int rankColor = switch (entry.rank()) { case 1 -> 0xFFFFD700; - case 2 -> 0xFFC0C0C0; - case 3 -> 0xFFCD7F32; - default -> 0xFFAAAAAA; + case 2 -> 0xFFD4E0EA; + case 3 -> 0xFFDE9151; + default -> 0xFF83B89A; }; String rankStr = "#" + entry.rank(); - g.drawString(this.font, rankStr, cursorX, rowY + layout.h(4), entry.count() <= 0 ? 0xFFCCCCCC : rankColor); - cursorX += layout.w(20); + g.drawString(this.font, rankStr, cursorX, rowY + 4, entry.count() <= 0 ? 0xFFCCCCCC : rankColor); + cursorX += 22; int medal = CycleLeaderboardData.medalForEntry(entry, showMedals); if (medal >= 1 && medal <= 3) { - drawTexture(g, MEDAL_TEXTURES[medal - 1], cursorX, rowY + layout.h(2), layout.w(11), layout.h(11)); - cursorX += layout.w(13); + drawTexture(g, MEDAL_TEXTURES[medal - 1], cursorX, rowY + 2, 12, 12); + cursorX += 15; } String countText = String.valueOf(entry.count()); int countWidth = this.font.width(countText); - int countX = x + width - layout.w(6) - countWidth; - int maxNameW = Math.max(layout.w(24), countX - cursorX - layout.w(4)); - int textColor = entry.count() <= 0 ? 0xFFDDDDDD : 0xFFFFFFFF; - g.drawString(this.font, trimToWidth(entry.name(), maxNameW), cursorX, rowY + layout.h(4), textColor); - g.drawString(this.font, countText, countX, rowY + layout.h(4), textColor); + int countX = x + listW - 8 - countWidth; + int maxNameW = Math.max(24, countX - cursorX - 6); + int textColor = entry.count() <= 0 ? 0xFFE0DDDD : 0xFFF2FFF7; + int countColor = entry.count() <= 0 ? 0xFFE0A0A0 : 0xFF98FFBF; + g.drawString(this.font, trimToWidth(entry.name(), maxNameW), cursorX, rowY + 4, textColor); + g.drawString(this.font, countText, countX, rowY + 4, countColor); } + g.disableScissor(); - layout.drawScrollbar(g, layout.x(baseColX + SCROLLBAR_OFFSET), top, layout.w(SCROLLBAR_WIDTH), height, VISIBLE_ROWS, total, clamped); + // Emerald custom scrollbar + int sbX = x + colW - SCROLLBAR_WIDTH - 2; + g.fill(sbX, baseTopY + 2, sbX + SCROLLBAR_WIDTH, baseTopY + height - 2, 0x44030D07); + if (total > visRows && total > 0) { + int sbH = height - 4; + int thumbH = Math.max(18, Math.round(sbH * (visRows / (float) total))); + int travel = Math.max(1, sbH - thumbH); + int thumbY = baseTopY + 2 + Math.round((clamped / (float) (total - visRows)) * travel); + g.fillGradient(sbX + 1, thumbY, sbX + SCROLLBAR_WIDTH - 1, thumbY + thumbH, 0xFF36BF72, 0xFF207A46); + g.fill(sbX + 1, thumbY, sbX + SCROLLBAR_WIDTH - 1, thumbY + 1, 0xFF8CFFBE); + } } private void renderPodiumList(GuiGraphics g, int baseColX, int baseTopY, List entries, int scrollOffset) { - int x = layout.x(baseColX); - int top = layout.y(baseTopY); - int width = layout.w(COL_WIDTH); - int height = layout.h(VISIBLE_ROWS * ROW_PITCH + 4); - g.fill(x, top, x + width, top + height, 0x22000000); + int colW = Math.max(180, (this.width - 42) / 2); + int x = baseColX == LEFT_COL_X ? 14 : (14 + colW + 14); + int listW = colW - 8; + int bottomLimit = Math.max(baseTopY + ROW_PITCH * 4 + 4, this.height - 42); + int visRows = Math.max(4, (bottomLimit - baseTopY - 4) / ROW_PITCH); + int height = visRows * ROW_PITCH + 4; + + g.fill(x, baseTopY, x + colW, baseTopY + height, 0xB806140C); + g.fill(x, baseTopY, x + colW, baseTopY + 1, 0xFF246A43); + g.fill(x, baseTopY + height - 1, x + colW, baseTopY + height, 0xFF1A4F32); + g.fill(x, baseTopY, x + 1, baseTopY + height, 0xFF246A43); + g.fill(x + colW - 1, baseTopY, x + colW, baseTopY + height, 0xFF1A4F32); int total = entries.size(); int clamped = clampOffset(scrollOffset, total); - for (int vis = 0; vis < VISIBLE_ROWS; vis++) { + g.enableScissor(x + 1, baseTopY + 1, x + listW, baseTopY + height - 1); + for (int vis = 0; vis < visRows; vis++) { int idx = clamped + vis; if (idx >= total) { break; } CycleLeaderboardData.PodiumEntry entry = entries.get(idx); - int rowY = layout.y(baseTopY + 2 + vis * ROW_PITCH); - int rowH = layout.h(ROW_HEIGHT); - g.fill(x + layout.w(2), rowY, x + width - layout.w(2), rowY + rowH, ROW_FILL); + int rowY = baseTopY + 2 + vis * ROW_PITCH; + g.fill(x + 3, rowY, x + listW - 2, rowY + ROW_HEIGHT, (idx & 1) == 0 ? ROW_FILL : 0x3A0A1C12); - int cursorX = x + layout.w(4); + int cursorX = x + 8; if (this.minecraft != null) { PlayerSkin skin = PlayerSkinResolver.skinFor(this.minecraft, parseUuid(entry.uuid()), entry.name()); if (skin != null) { - PlayerFaceRenderer.draw(g, skin, cursorX, rowY + layout.h(2), layout.w(10)); + PlayerFaceRenderer.draw(g, skin, cursorX, rowY + 3, 10); } } - cursorX += layout.w(13); + cursorX += 14; - int statsStart = x + width - layout.w(88); - int maxNameW = Math.max(layout.w(24), statsStart - cursorX - layout.w(4)); - g.drawString(this.font, trimToWidth(entry.name(), maxNameW), cursorX, rowY + layout.h(4), 0xFFFFFFFF); + int statsStart = x + listW - 96; + int maxNameW = Math.max(24, statsStart - cursorX - 6); + g.drawString(this.font, trimToWidth(entry.name(), maxNameW), cursorX, rowY + 4, 0xFFF2FFF7); int[] counts = {entry.first(), entry.second(), entry.third()}; for (int m = 0; m < 3; m++) { - int slotX = statsStart + m * layout.w(28); - drawTexture(g, MEDAL_TEXTURES[m], slotX, rowY + layout.h(3), layout.w(9), layout.h(9)); - g.drawString(this.font, String.valueOf(counts[m]), slotX + layout.w(11), rowY + layout.h(4), 0xFFEFEFEF); + int slotX = statsStart + m * 30; + drawTexture(g, MEDAL_TEXTURES[m], slotX, rowY + 3, 10, 10); + g.drawString(this.font, String.valueOf(counts[m]), slotX + 12, rowY + 4, 0xFF98FFBF); } } + g.disableScissor(); - layout.drawScrollbar(g, layout.x(baseColX + SCROLLBAR_OFFSET), top, layout.w(SCROLLBAR_WIDTH), height, VISIBLE_ROWS, total, clamped); + int sbX = x + colW - SCROLLBAR_WIDTH - 2; + g.fill(sbX, baseTopY + 2, sbX + SCROLLBAR_WIDTH, baseTopY + height - 2, 0x44030D07); + if (total > visRows && total > 0) { + int sbH = height - 4; + int thumbH = Math.max(18, Math.round(sbH * (visRows / (float) total))); + int travel = Math.max(1, sbH - thumbH); + int thumbY = baseTopY + 2 + Math.round((clamped / (float) (total - visRows)) * travel); + g.fillGradient(sbX + 1, thumbY, sbX + SCROLLBAR_WIDTH - 1, thumbY + thumbH, 0xFF36BF72, 0xFF207A46); + g.fill(sbX + 1, thumbY, sbX + SCROLLBAR_WIDTH - 1, thumbY + 1, 0xFF8CFFBE); + } } private int listTopOffset() { - return activeTab == Tab.CYCLE ? 62 : 84; + return activeTab == Tab.CYCLE ? 80 : 110; } private List leftEntries() { @@ -520,7 +685,10 @@ private List rightEntries() { } private int clampOffset(int offset, int total) { - int max = Math.max(0, total - VISIBLE_ROWS); + int top = listTopOffset(); + int bottomLimit = Math.max(top + ROW_PITCH * 4 + 4, this.height - 42); + int visRows = Math.max(4, (bottomLimit - top - 4) / ROW_PITCH); + int max = Math.max(0, total - visRows); return Math.clamp(offset, 0, max); } @@ -546,33 +714,42 @@ private static void drawTexture(GuiGraphics g, Identifier id, int x, int y, int if (id == null || w <= 0 || h <= 0) { return; } + int srcSize = id.getPath().endsWith("icon.png") ? 256 : 64; g.pose().pushMatrix(); g.pose().translate(x, y); - g.pose().scale(w / 64.0f, h / 64.0f); - g.blit(RenderPipelines.GUI_TEXTURED, id, 0, 0, 0.0f, 0.0f, 64, 64, 64, 64); + g.pose().scale(w / (float) srcSize, h / (float) srcSize); + g.blit(RenderPipelines.GUI_TEXTURED, id, 0, 0, 0.0f, 0.0f, srcSize, srcSize, srcSize, srcSize); g.pose().popMatrix(); } private boolean isInPane(double scaledX, double scaledY, int baseColX) { - int left = layout.x(baseColX); - int top = layout.y(listTopOffset()); - int right = left + layout.w(COL_WIDTH + SCROLLBAR_WIDTH + 4); - int bottom = top + layout.h(VISIBLE_ROWS * ROW_PITCH + 4); - return scaledX >= left && scaledX <= right && scaledY >= top && scaledY <= bottom; + int colW = Math.max(180, (this.width - 42) / 2); + int left = baseColX == LEFT_COL_X ? 14 : (14 + colW + 14); + int top = listTopOffset(); + int bottomLimit = Math.max(top + ROW_PITCH * 4 + 4, this.height - 42); + int visRows = Math.max(4, (bottomLimit - top - 4) / ROW_PITCH); + int bottom = top + visRows * ROW_PITCH + 4; + return scaledX >= left && scaledX <= left + colW && scaledY >= top && scaledY <= bottom; } private boolean isOverScrollbar(double scaledX, double scaledY, int baseColX) { - int sbX = layout.x(baseColX + SCROLLBAR_OFFSET); - int top = layout.y(listTopOffset()); - int bottom = top + layout.h(VISIBLE_ROWS * ROW_PITCH + 4); - return scaledX >= sbX && scaledX <= sbX + layout.w(SCROLLBAR_WIDTH) && scaledY >= top && scaledY <= bottom; + int colW = Math.max(180, (this.width - 42) / 2); + int colLeft = baseColX == LEFT_COL_X ? 14 : (14 + colW + 14); + int sbX = colLeft + colW - SCROLLBAR_WIDTH - 2; + int top = listTopOffset(); + int bottomLimit = Math.max(top + ROW_PITCH * 4 + 4, this.height - 42); + int visRows = Math.max(4, (bottomLimit - top - 4) / ROW_PITCH); + int bottom = top + visRows * ROW_PITCH + 4; + return scaledX >= sbX - 2 && scaledX <= sbX + SCROLLBAR_WIDTH + 2 && scaledY >= top && scaledY <= bottom; } private void updateScrollFromMouse(double scaledY, int pane) { - int top = layout.y(listTopOffset()); - int height = layout.h(VISIBLE_ROWS * ROW_PITCH + 4); + int top = listTopOffset(); + int bottomLimit = Math.max(top + ROW_PITCH * 4 + 4, this.height - 42); + int visRows = Math.max(4, (bottomLimit - top - 4) / ROW_PITCH); + int height = visRows * ROW_PITCH + 4; int total = pane == 1 ? leftEntries().size() : rightEntries().size(); - int maxOffset = Math.max(0, total - VISIBLE_ROWS); + int maxOffset = Math.max(0, total - visRows); float ratio = Math.clamp((float) ((scaledY - top) / Math.max(1, height)), 0.0f, 1.0f); int target = Math.round(ratio * maxOffset); if (pane == 1) { From ad82dac7a741ff36c844105f9ddd43ffeb812d12 Mon Sep 17 00:00:00 2001 From: Good627 <193092356+Good627@users.noreply.github.com> Date: Thu, 19 Nov 2026 01:07:11 +0200 Subject: [PATCH 5/8] Revert /eden cycle UI to classic full-screen panel with Eden pillar podiums and shared Mojang skin cache (1.6.7-beta.3) --- gradle.properties | 2 +- .../eden/mod/gui/PromotionCycleScreen.java | 573 ++++++++---------- src/tel/eden/mod/util/PlayerSkinResolver.java | 95 ++- src/tel/eden/mod/war/AttackTimerMenu.java | 77 +-- .../eden/mod/util/PlayerSkinResolverTest.java | 13 + 5 files changed, 353 insertions(+), 407 deletions(-) diff --git a/gradle.properties b/gradle.properties index 33f3534..21567c2 100644 --- a/gradle.properties +++ b/gradle.properties @@ -8,7 +8,7 @@ loader_version=0.19.3 fabric_version=0.141.4+1.21.11 loom_version=1.17.8 -mod_version=1.6.7-beta.2 +mod_version=1.6.7-beta.3 maven_group=tel.eden archives_base_name=edenmod modmenu_version=17.0.0 diff --git a/src/tel/eden/mod/gui/PromotionCycleScreen.java b/src/tel/eden/mod/gui/PromotionCycleScreen.java index 9e3ef37..6e7ec0c 100644 --- a/src/tel/eden/mod/gui/PromotionCycleScreen.java +++ b/src/tel/eden/mod/gui/PromotionCycleScreen.java @@ -1,7 +1,6 @@ package tel.eden.mod.gui; import java.util.List; -import java.util.UUID; import net.minecraft.ChatFormatting; import net.minecraft.client.gui.GuiGraphics; import net.minecraft.client.gui.components.Button; @@ -21,21 +20,19 @@ /** Promotion Cycle (& Archive) and Lifetime leaderboard screen for full guild members. */ public class PromotionCycleScreen extends EdenReferenceScreen { - private static final int BASE_PANEL_WIDTH = 468; - private static final int BASE_PANEL_HEIGHT = 272; - - private static final int LEFT_COL_X = 14; - private static final int RIGHT_COL_X = 240; - private static final int COL_WIDTH = 208; - private static final int SCROLLBAR_OFFSET = 210; + private static final int MARGIN_X = 12; + private static final int COL_GAP = 16; + private static final int SCROLLBAR_GAP = 2; private static final int SCROLLBAR_WIDTH = 6; - private static final int VISIBLE_ROWS = 8; - private static final int ROW_PITCH = 18; - private static final int ROW_HEIGHT = 16; - private static final int ZERO_ROW_OVERLAY = 0x48CC2222; - private static final int ROW_FILL = 0x520F281A; + private static final int ROW_PITCH = 17; + private static final int ROW_HEIGHT = 15; + private static final int PODIUM_CAP_WIDTH = 30; + private static final int PODIUM_HEAD_SIZE = 32; + private static final int ZERO_ROW_OVERLAY = 0x44CC2222; + private static final int ROW_FILL = 0x44282828; - private static final Identifier[] MEDAL_TEXTURES = {Identifier.fromNamespaceAndPath("edenmod", "textures/gui/cycle/medal_1.png"), Identifier.fromNamespaceAndPath("edenmod", "textures/gui/cycle/medal_2.png"), Identifier.fromNamespaceAndPath("edenmod", "textures/gui/cycle/medal_3.png"), Identifier.fromNamespaceAndPath("edenmod", "icon.png"),}; + private static final Identifier EDEN_ICON = Identifier.fromNamespaceAndPath("edenmod", "icon.png"); + private static final Identifier[] MEDAL_TEXTURES = {Identifier.fromNamespaceAndPath("edenmod", "textures/gui/cycle/medal_1.png"), Identifier.fromNamespaceAndPath("edenmod", "textures/gui/cycle/medal_2.png"), Identifier.fromNamespaceAndPath("edenmod", "textures/gui/cycle/medal_3.png"),}; private enum Tab { CYCLE, LIFETIME @@ -88,7 +85,7 @@ public PromotionCycleScreen(Screen parent, EdenModClient mod, String initialCycl @Override protected void init() { super.init(); - layout = centeredLayout(BASE_PANEL_WIDTH, BASE_PANEL_HEIGHT); + layout = centeredLayout(200, 120); uiScale = 1.0f; virtualWidth = this.width; virtualHeight = this.height; @@ -102,40 +99,37 @@ protected void init() { this.clearWidgets(); - int tabStartX = Math.max(198, (this.width - 196) / 2); - int tabY = 18; - cycleTabButton = Button.builder(Component.literal("Promotion Cycle"), b -> switchTab(Tab.CYCLE)).bounds(tabStartX, tabY, 112, 20).build(); - lifetimeTabButton = Button.builder(Component.literal("Lifetime"), b -> switchTab(Tab.LIFETIME)).bounds(tabStartX + 116, tabY, 80, 20).build(); + cycleTabButton = Button.builder(Component.literal("Promotion Cycle"), b -> switchTab(Tab.CYCLE)).bounds(12, 24, 110, 18).build(); + lifetimeTabButton = Button.builder(Component.literal("Lifetime"), b -> switchTab(Tab.LIFETIME)).bounds(126, 24, 80, 18).build(); this.addRenderableWidget(cycleTabButton); this.addRenderableWidget(lifetimeTabButton); - Button closeButton = Button.builder(Component.literal("Close"), b -> onClose()).bounds(this.width - 66, 18, 50, 20).build(); + int closeX = bottomCloseX(); + Button closeButton = Button.builder(Component.literal("Close"), b -> onClose()).bounds(closeX, this.height - 24, 100, 18).build(); this.addRenderableWidget(closeButton); - // Cycle tab archive controls in full-width bottom-right footer - int archiveY = this.height - 30; - prevCycleButton = Button.builder(Component.literal("< Previous"), b -> navigateArchive(-1)).bounds(this.width - 246, archiveY, 70, 18).build(); - nextCycleButton = Button.builder(Component.literal("Next >"), b -> navigateArchive(1)).bounds(this.width - 172, archiveY, 58, 18).build(); - archiveButton = Button.builder(Component.literal("Cycle Archive"), b -> toggleArchive()).bounds(this.width - 110, archiveY, 94, 18).build(); + // Cycle tab archive controls + prevCycleButton = Button.builder(Component.literal("< Previous"), b -> navigateArchive(-1)).bounds(this.width - 236, this.height - 24, 68, 18).build(); + nextCycleButton = Button.builder(Component.literal("Next >"), b -> navigateArchive(1)).bounds(this.width - 164, this.height - 24, 56, 18).build(); + archiveButton = Button.builder(Component.literal("Cycle Archive"), b -> toggleArchive()).bounds(this.width - 104, this.height - 24, 92, 18).build(); this.addRenderableWidget(prevCycleButton); this.addRenderableWidget(nextCycleButton); this.addRenderableWidget(archiveButton); - // Lifetime tab controls inside emerald filter bar - int filterY = 62; - fromBox = new EditBox(this.font, 48, filterY, 80, 18, Component.literal("From days ago")); + // Lifetime tab controls + fromBox = new EditBox(this.font, 42, 48, 78, 18, Component.literal("From days ago")); fromBox.setHint(Component.literal("-# days ago").withStyle(ChatFormatting.GRAY)); fromBox.setMaxLength(16); fromBox.setValue(fromDraft); - toBox = new EditBox(this.font, 154, filterY, 80, 18, Component.literal("To days ago")); + toBox = new EditBox(this.font, 146, 48, 78, 18, Component.literal("To days ago")); toBox.setHint(Component.literal("-# days ago").withStyle(ChatFormatting.GRAY)); toBox.setMaxLength(16); toBox.setValue(toDraft); - applyIntervalButton = Button.builder(Component.literal("Apply"), b -> applyInterval()).bounds(240, filterY, 48, 18).build(); - resetIntervalButton = Button.builder(Component.literal("Reset"), b -> resetInterval()).bounds(292, filterY, 48, 18).build(); - finishesToggleButton = Button.builder(Component.literal("Cycle Finishes"), b -> toggleFinishes()).bounds(this.width - 126, filterY, 108, 18).build(); + applyIntervalButton = Button.builder(Component.literal("Apply"), b -> applyInterval()).bounds(230, 48, 46, 18).build(); + resetIntervalButton = Button.builder(Component.literal("Reset"), b -> resetInterval()).bounds(280, 48, 46, 18).build(); + finishesToggleButton = Button.builder(Component.literal("Cycle Finishes"), b -> toggleFinishes()).bounds(this.width - 118, 48, 106, 18).build(); this.addRenderableWidget(fromBox); this.addRenderableWidget(toBox); @@ -292,45 +286,14 @@ private int currentCycleIndex(List cycles, String activeCode) { @Override public void render(GuiGraphics g, int mouseX, int mouseY, float delta) { + if (uiScale != 1.0f || virtualWidth != this.width || virtualHeight != this.height) { + init(); + } int scaledMouseX = scaledMouseX(mouseX); int scaledMouseY = scaledMouseY(mouseY); pushReferencePose(g); - - // Full-screen layered emerald backdrop - g.fillGradient(0, 0, this.width, this.height, 0xF006150C, 0xF6030906); - g.fillGradient(0, 0, this.width, Math.min(this.height, 150), 0x5C1D7843, 0x0006150C); - g.fillGradient(0, Math.max(0, this.height - 96), this.width, this.height, 0x00030906, 0x8C020604); - g.fill(0, 0, this.width, 1, 0xFF287D4B); - g.fill(0, this.height - 1, this.width, this.height, 0xFF1A5734); - g.fill(0, 0, 1, this.height, 0xFF287D4B); - g.fill(this.width - 1, 0, this.width, this.height, 0xFF1A5734); - - // Shaded emerald top banner with framed Eden Logo crest - int headerRight = this.width - 8; - g.fillGradient(8, 6, headerRight, 52, 0xEB113821, 0xEB092113); - g.fill(8, 6, headerRight, 7, 0x6658F59F); - g.fill(8, 50, headerRight, 52, 0xFF2EA866); - g.fill(8, 52, headerRight, 55, 0x55000000); - g.fill(8, 6, 9, 52, 0xFF256D43); - g.fill(headerRight - 1, 6, headerRight, 52, 0xFF256D43); - - // Eden Logo emblem - g.fill(15, 9, 53, 47, 0xAA0C2818); - g.fill(15, 9, 53, 10, 0xFF47DB86); - g.fill(15, 46, 53, 47, 0xFF257A48); - g.fill(15, 9, 16, 47, 0xFF47DB86); - g.fill(52, 9, 53, 47, 0xFF257A48); - drawTexture(g, MEDAL_TEXTURES[3], 17, 11, 34, 34); - - String heading = activeTab == Tab.CYCLE ? "Eden Promotion Cycle" : "Eden Lifetime Stats"; - g.drawString(this.font, heading, 60, 15, 0xFF7BFFAE); - - // Active-tab glowing mint indicator underneath the selected tab button - int tabStartX = Math.max(198, (this.width - 196) / 2); - int activeIndX = activeTab == Tab.CYCLE ? tabStartX : (tabStartX + 116); - int activeIndW = activeTab == Tab.CYCLE ? 112 : 80; - g.fill(activeIndX + 4, 40, activeIndX + activeIndW - 4, 42, 0xFF56FF9F); + EdenPanelLayout.drawPanel(g, 0, 0, this.width, this.height); if (activeTab == Tab.CYCLE) { renderCycleTab(g); @@ -339,6 +302,8 @@ public void render(GuiGraphics g, int mouseX, int mouseY, float delta) { } super.render(g, scaledMouseX, scaledMouseY, delta); + String heading = activeTab == Tab.CYCLE ? "Promotion Cycle" : "Lifetime Stats"; + g.drawCenteredString(this.font, heading, this.width / 2, 10, 0xFFFFFFFF); popReferencePose(g); } @@ -346,58 +311,29 @@ private void renderCycleTab(GuiGraphics g) { CycleLeaderboardData.CycleSnapshot snap = mod != null ? mod.knownCycleLeaderboard() : null; String err = mod != null ? mod.recentCycleLeaderboardError() : ""; - String cycleBadge; - if (snap != null && !snap.cycleCode().isEmpty()) { - List cycles = snap.cycles(); - boolean latest = cycles.isEmpty() || snap.cycleCode().equals(cycles.get(cycles.size() - 1)); - cycleBadge = "Cycle " + snap.cycleCode() + (latest ? " • Current" : " • Archive"); - } else { - cycleBadge = "Fetching cycle..."; - } - g.drawString(this.font, cycleBadge, 60, 29, 0xFFA8EBC2); + String cycleHeader = (snap != null && !snap.cycleCode().isEmpty()) ? "Cycle " + snap.cycleCode() : "Loading..."; + g.drawString(this.font, cycleHeader, 220, 29, 0xFFFFCC55); - // Bottom shaded footer card - int footerTop = this.height - 36; - int footerRight = this.width - 8; - g.fillGradient(8, footerTop, footerRight, this.height - 6, 0xEB0E2E1C, 0xEB07190F); - g.fill(8, footerTop, footerRight, footerTop + 1, 0xFF319A5D); - - int centerY = this.height / 2; if (!err.isEmpty()) { - g.drawCenteredString(this.font, err, this.width / 2, centerY - 4, 0xFFFF6B6B); + g.drawCenteredString(this.font, err, this.width / 2, this.height / 2, 0xFFFF5555); return; } if (snap == null) { - g.drawCenteredString(this.font, "Loading cycle leaderboard...", this.width / 2, centerY - 4, 0xFFA8EBC2); + g.drawCenteredString(this.font, "Loading cycle leaderboard...", this.width / 2, this.height / 2, 0xFFAAAAAA); return; } - int listTop = listTopOffset(); - int colW = Math.max(180, (this.width - 42) / 2); - int leftX = 14; - int rightX = 14 + colW + 14; - int hdrTop = listTop - 20; - - // Column Headers (shaded emerald & gold-emerald) - g.fillGradient(leftX, hdrTop, leftX + colW, listTop, 0xEE14472D, 0xEE0C2C1B); - g.fill(leftX, hdrTop, leftX + colW, hdrTop + 2, 0xFF42E695); - g.drawString(this.font, "Raids", leftX + 8, hdrTop + 6, 0xFF7CFFD1); - String rCount = snap.raids().size() + " players"; - g.drawString(this.font, rCount, leftX + colW - 8 - this.font.width(rCount), hdrTop + 6, 0xFF93D1AE); - - g.fillGradient(rightX, hdrTop, rightX + colW, listTop, 0xEE1A4223, 0xEE0F2916); - g.fill(rightX, hdrTop, rightX + colW, hdrTop + 2, 0xFFFFCA62); - g.drawString(this.font, "Wars", rightX + 8, hdrTop + 6, 0xFFFFD479); - String wCount = snap.wars().size() + " players"; - g.drawString(this.font, wCount, rightX + colW - 8 - this.font.width(wCount), hdrTop + 6, 0xFFD9C798); - - renderEntryList(g, LEFT_COL_X, listTop, snap.raids(), raidsScroll, true, true); - renderEntryList(g, RIGHT_COL_X, listTop, snap.wars(), warsScroll, true, true); - - int controlsLeft = archiveOpen ? (this.width - 256) : (this.width - 120); - int maxTextW = Math.max(80, controlsLeft - 24); - String totals = "Totals: " + snap.totalRaids() + " raids • " + snap.totalWars() + " wars • " + snap.totalTickets() + " tickets"; - g.drawString(this.font, trimToWidth(totals, maxTextW), 16, footerTop + 5, 0xFFFFE082); + int colW = colWidth(); + int titleY = titleY(); + g.drawCenteredString(this.font, "Raids", colX(true) + colW / 2, titleY, 0xFF55FFFF); + g.drawCenteredString(this.font, "Wars", colX(false) + colW / 2, titleY, 0xFFFF5555); + + renderEntryList(g, true, snap.raids(), raidsScroll, true, true); + renderEntryList(g, false, snap.wars(), warsScroll, true, true); + + int maxFooterW = Math.max(60, bottomCloseX() - 20); + String totals = "Totals: " + snap.totalRaids() + " raids | " + snap.totalWars() + " wars | " + snap.totalTickets() + " tickets"; + g.drawString(this.font, trimToWidth(totals, maxFooterW), 12, this.height - 36, 0xFFFFD966); if (!snap.raffleWinners().isEmpty()) { StringBuilder raffle = new StringBuilder("Raffle Top 3: "); List top = snap.raffleWinners().subList(0, Math.min(3, snap.raffleWinners().size())); @@ -407,103 +343,127 @@ private void renderCycleTab(GuiGraphics g) { } raffle.append("#").append(i + 1).append(" ").append(top.get(i).name()).append(" (").append(top.get(i).tickets()).append(")"); } - g.drawString(this.font, trimToWidth(raffle.toString(), maxTextW), 16, footerTop + 17, 0xFFE2C6FF); + g.drawString(this.font, trimToWidth(raffle.toString(), maxFooterW), 12, this.height - 24, 0xFFD5A6FF); } } private void renderLifetimeTab(GuiGraphics g) { - CycleLeaderboardData.LifetimeSnapshot snap = mod != null ? mod.knownLifetimeLeaderboard() : null; - String err = mod != null ? mod.recentLifetimeLeaderboardError() : ""; - - String sub = "All-Time Records"; - if (snap != null && snap.hasInterval()) { - String toLabel = (snap.toDays() == null || snap.toDays() <= 0.0) ? "now" : ("-" + snap.toDays() + "d"); - sub = "Filtered Window: -" + snap.fromDays() + "d to " + toLabel; - } - g.drawString(this.font, sub, 60, 29, 0xFFA8EBC2); - - // Shaded emerald filter bar - int barRight = this.width - 14; - g.fillGradient(14, 58, barRight, 84, 0xD80D2B1B, 0xD8081C11); - g.fill(14, 58, barRight, 59, 0xFF287549); - g.fill(14, 83, barRight, 84, 0xFF1D5937); - g.fill(14, 58, 15, 84, 0xFF236841); - g.fill(barRight - 1, 58, barRight, 84, 0xFF236841); - - g.drawString(this.font, "From:", 20, 67, 0xFFA8EBC2); - g.drawString(this.font, "To:", 134, 67, 0xFFA8EBC2); + g.drawString(this.font, "From:", 12, 53, 0xFFCCCCCC); + g.drawString(this.font, "To:", 126, 53, 0xFFCCCCCC); if (!validationError.isEmpty()) { - g.drawString(this.font, trimToWidth(validationError, Math.max(80, this.width - 490)), 346, 67, 0xFFFF6B6B); + int errMaxW = Math.max(40, (this.width - 126) - 332); + g.drawString(this.font, trimToWidth(validationError, errMaxW), 332, 53, 0xFFFF5555); } - // Footer strip - int footerTop = this.height - 36; - g.fillGradient(8, footerTop, this.width - 8, this.height - 6, 0xEB0E2E1C, 0xEB07190F); - g.fill(8, footerTop, this.width - 8, footerTop + 1, 0xFF319A5D); - g.drawString(this.font, showFinishes ? "Cycle Finishes: cumulative #1 / #2 / #3 placements across concluded cycles" : (snap != null && snap.hasInterval() ? "Custom day interval active (medals disabled)" : "All-time cumulative completions"), 16, footerTop + 11, 0xFF8CD1A8); - - int centerY = this.height / 2 + 12; + CycleLeaderboardData.LifetimeSnapshot snap = mod != null ? mod.knownLifetimeLeaderboard() : null; + String err = mod != null ? mod.recentLifetimeLeaderboardError() : ""; if (!err.isEmpty()) { - g.drawCenteredString(this.font, err, this.width / 2, centerY, 0xFFFF6B6B); + g.drawCenteredString(this.font, err, this.width / 2, this.height / 2 + 12, 0xFFFF5555); return; } if (snap == null) { - g.drawCenteredString(this.font, "Loading leaderboard stats...", this.width / 2, centerY, 0xFFA8EBC2); + g.drawCenteredString(this.font, "Loading leaderboard stats...", this.width / 2, this.height / 2 + 12, 0xFFAAAAAA); return; } - int listTop = listTopOffset(); - int colW = Math.max(180, (this.width - 42) / 2); - int leftX = 14; - int rightX = 14 + colW + 14; - int hdrTop = listTop - 20; + int colW = colWidth(); + int titleY = titleY(); + int leftCenter = colX(true) + colW / 2; + int rightCenter = colX(false) + colW / 2; if (showFinishes) { - g.fillGradient(leftX, hdrTop, leftX + colW, listTop, 0xEE14472D, 0xEE0C2C1B); - g.fill(leftX, hdrTop, leftX + colW, hdrTop + 2, 0xFF42E695); - g.drawString(this.font, "Raids Cycle Finishes", leftX + 8, hdrTop + 6, 0xFF7CFFD1); - - g.fillGradient(rightX, hdrTop, rightX + colW, listTop, 0xEE1A4223, 0xEE0F2916); - g.fill(rightX, hdrTop, rightX + colW, hdrTop + 2, 0xFFFFCA62); - g.drawString(this.font, "Wars Cycle Finishes", rightX + 8, hdrTop + 6, 0xFFFFD479); - - renderPodiumList(g, LEFT_COL_X, listTop, snap.raidFinishes(), raidsScroll); - renderPodiumList(g, RIGHT_COL_X, listTop, snap.warFinishes(), warsScroll); + g.drawCenteredString(this.font, "Raids Finishes", leftCenter, titleY, 0xFF55FFFF); + g.drawCenteredString(this.font, "Wars Finishes", rightCenter, titleY, 0xFFFF5555); + renderPodiumList(g, true, snap.raidFinishes(), raidsScroll); + renderPodiumList(g, false, snap.warFinishes(), warsScroll); return; } String subtitle = snap.hasInterval() ? " (Filtered: no medals)" : ""; - g.fillGradient(leftX, hdrTop, leftX + colW, listTop, 0xEE14472D, 0xEE0C2C1B); - g.fill(leftX, hdrTop, leftX + colW, hdrTop + 2, 0xFF42E695); - g.drawString(this.font, "Raids" + subtitle, leftX + 8, hdrTop + 6, 0xFF7CFFD1); - - g.fillGradient(rightX, hdrTop, rightX + colW, listTop, 0xEE1A4223, 0xEE0F2916); - g.fill(rightX, hdrTop, rightX + colW, hdrTop + 2, 0xFFFFCA62); - g.drawString(this.font, "Wars" + subtitle, rightX + 8, hdrTop + 6, 0xFFFFD479); + g.drawCenteredString(this.font, "Raids" + subtitle, leftCenter, titleY, 0xFF55FFFF); + g.drawCenteredString(this.font, "Wars" + subtitle, rightCenter, titleY, 0xFFFF5555); boolean showMedals = !snap.hasInterval(); - renderEntryList(g, LEFT_COL_X, listTop, snap.raids(), raidsScroll, showMedals, false); - renderEntryList(g, RIGHT_COL_X, listTop, snap.wars(), warsScroll, showMedals, false); + renderEntryList(g, true, snap.raids(), raidsScroll, showMedals, false); + renderEntryList(g, false, snap.wars(), warsScroll, showMedals, false); + } + + private void renderPodium(GuiGraphics g, int x, int colW, List rawEntries) { + int podiumTop = podiumTop(); + int podiumH = podiumHeight(); + g.fill(x, podiumTop, x + colW, podiumTop + podiumH, 0x22000000); + + int slotW = Math.clamp(colW / 3 - 4, 48, 96); + int cx1 = x + colW / 2; + int cx2 = cx1 - slotW; + int cx3 = cx1 + slotW; + int maxStandH = Math.max(70, podiumH - 54); + int h2 = Math.max(52, maxStandH * 76 / 100); + int h3 = Math.max(38, maxStandH * 56 / 100); + int baseLineY = podiumTop + podiumH - 4; + int lineLeft = Math.max(x + 4, cx2 - PODIUM_CAP_WIDTH / 2 - 8); + int lineRight = Math.min(x + colW - 4, cx3 + PODIUM_CAP_WIDTH / 2 + 8); + g.fill(lineLeft, baseLineY, lineRight, baseLineY + 2, 0xFF8E8E8E); + g.fill(lineLeft, baseLineY + 2, lineRight, baseLineY + 3, 0xFF1E1E1E); + + for (int slot = 0; slot < 3; slot++) { + int rank = slot == 0 ? 2 : (slot == 1 ? 1 : 3); + int cx = slot == 0 ? cx2 : (slot == 1 ? cx1 : cx3); + int standH = slot == 0 ? h2 : (slot == 1 ? maxStandH : h3); + int standTopY = baseLineY - standH; + drawPillar(g, cx, baseLineY, PODIUM_CAP_WIDTH, standH); + + int entryIdx = rank - 1; + if (entryIdx >= rawEntries.size()) { + continue; + } + String uuid = null; + String name = null; + String suffix = null; + Object item = rawEntries.get(entryIdx); + if (item instanceof CycleLeaderboardData.LeaderboardEntry e) { + if (e.count() <= 0) { + continue; + } + uuid = e.uuid(); + name = e.name(); + suffix = " (" + e.count() + ")"; + } else if (item instanceof CycleLeaderboardData.PodiumEntry p) { + uuid = p.uuid(); + name = p.name(); + suffix = " (" + p.first() + "/" + p.second() + "/" + p.third() + ")"; + } + if (name == null) { + continue; + } + + int headStartX = cx - PODIUM_HEAD_SIZE / 2; + int headY = standTopY - PODIUM_HEAD_SIZE - 2; + drawPlayerFace(g, uuid, name, headStartX, headY, PODIUM_HEAD_SIZE); + + int halfBound = switch (rank) { + case 2 -> Math.min(cx - x - 3, slotW - PODIUM_HEAD_SIZE / 2 - 3); + case 3 -> Math.min((x + colW) - cx - 3, slotW - PODIUM_HEAD_SIZE / 2 - 3); + default -> Math.min(colW / 2 - 4, (slotW + 28) / 2); + }; + int maxLabelW = Math.max(24, halfBound * 2); + int maxNameW = Math.max(12, maxLabelW - this.font.width(suffix)); + g.drawCenteredString(this.font, trimToWidth(name, maxNameW) + suffix, cx, standTopY - PODIUM_HEAD_SIZE - 12, 0xFFFFFFFF); + } } - private void renderEntryList(GuiGraphics g, int baseColX, int baseTopY, List entries, int scrollOffset, boolean showMedals, boolean showDelta) { - int colW = Math.max(180, (this.width - 42) / 2); - int x = baseColX == LEFT_COL_X ? 14 : (14 + colW + 14); - int listW = colW - 8; - int bottomLimit = Math.max(baseTopY + ROW_PITCH * 4 + 4, this.height - 42); - int visRows = Math.max(4, (bottomLimit - baseTopY - 4) / ROW_PITCH); - int height = visRows * ROW_PITCH + 4; + private void renderEntryList(GuiGraphics g, boolean left, List entries, int scrollOffset, boolean showMedals, boolean showDelta) { + int x = colX(left); + int colW = colWidth(); + renderPodium(g, x, colW, entries); - // Shaded card body + border - g.fill(x, baseTopY, x + colW, baseTopY + height, 0xB806140C); - g.fill(x, baseTopY, x + colW, baseTopY + 1, 0xFF246A43); - g.fill(x, baseTopY + height - 1, x + colW, baseTopY + height, 0xFF1A4F32); - g.fill(x, baseTopY, x + 1, baseTopY + height, 0xFF246A43); - g.fill(x + colW - 1, baseTopY, x + colW, baseTopY + height, 0xFF1A4F32); + int baseTopY = listTopOffset(); + int visRows = visibleRows(); + int height = visRows * ROW_PITCH + 4; + g.fill(x, baseTopY, x + colW, baseTopY + height, 0x22000000); int total = entries.size(); int clamped = clampOffset(scrollOffset, total); - g.enableScissor(x + 1, baseTopY + 1, x + listW, baseTopY + height - 1); for (int vis = 0; vis < visRows; vis++) { int idx = clamped + vis; if (idx >= total) { @@ -511,102 +471,60 @@ private void renderEntryList(GuiGraphics g, int baseColX, int baseTopY, List 0 ? "+" + deltaVal : String.valueOf(deltaVal)); - int deltaColor = deltaVal == null || deltaVal == 0 ? 0xFF729E84 : (deltaVal > 0 ? 0xFF55FF88 : 0xFFFF6B6B); + int deltaColor = deltaVal == null || deltaVal == 0 ? 0xFF888888 : (deltaVal > 0 ? 0xFF55FF55 : 0xFFFF5555); g.drawString(this.font, deltaText, cursorX, rowY + 4, deltaColor); - cursorX += 24; + cursorX += Math.max(22, this.font.width(deltaText) + 4); } - if (this.minecraft != null) { - PlayerSkin skin = PlayerSkinResolver.skinFor(this.minecraft, parseUuid(entry.uuid()), entry.name()); - if (skin != null) { - PlayerFaceRenderer.draw(g, skin, cursorX, rowY + 3, 10); - } - } - cursorX += 14; + drawPlayerFace(g, entry.uuid(), entry.name(), cursorX, rowY + 2, 10); + cursorX += 13; int rankColor = switch (entry.rank()) { case 1 -> 0xFFFFD700; - case 2 -> 0xFFD4E0EA; - case 3 -> 0xFFDE9151; - default -> 0xFF83B89A; + case 2 -> 0xFFC0C0C0; + case 3 -> 0xFFCD7F32; + default -> 0xFFAAAAAA; }; String rankStr = "#" + entry.rank(); g.drawString(this.font, rankStr, cursorX, rowY + 4, entry.count() <= 0 ? 0xFFCCCCCC : rankColor); - cursorX += 22; + cursorX += Math.max(28, this.font.width(rankStr) + 4); int medal = CycleLeaderboardData.medalForEntry(entry, showMedals); if (medal >= 1 && medal <= 3) { - drawTexture(g, MEDAL_TEXTURES[medal - 1], cursorX, rowY + 2, 12, 12); - cursorX += 15; + drawTexture(g, MEDAL_TEXTURES[medal - 1], cursorX, rowY + 2, 11, 11); + cursorX += 13; } String countText = String.valueOf(entry.count()); int countWidth = this.font.width(countText); - int countX = x + listW - 8 - countWidth; - int maxNameW = Math.max(24, countX - cursorX - 6); - int textColor = entry.count() <= 0 ? 0xFFE0DDDD : 0xFFF2FFF7; - int countColor = entry.count() <= 0 ? 0xFFE0A0A0 : 0xFF98FFBF; + int countX = x + colW - 6 - countWidth; + int maxNameW = Math.max(24, countX - cursorX - 4); + int textColor = entry.count() <= 0 ? 0xFFDDDDDD : 0xFFFFFFFF; g.drawString(this.font, trimToWidth(entry.name(), maxNameW), cursorX, rowY + 4, textColor); - g.drawString(this.font, countText, countX, rowY + 4, countColor); + g.drawString(this.font, countText, countX, rowY + 4, textColor); } - g.disableScissor(); - // Emerald custom scrollbar - int sbX = x + colW - SCROLLBAR_WIDTH - 2; - g.fill(sbX, baseTopY + 2, sbX + SCROLLBAR_WIDTH, baseTopY + height - 2, 0x44030D07); - if (total > visRows && total > 0) { - int sbH = height - 4; - int thumbH = Math.max(18, Math.round(sbH * (visRows / (float) total))); - int travel = Math.max(1, sbH - thumbH); - int thumbY = baseTopY + 2 + Math.round((clamped / (float) (total - visRows)) * travel); - g.fillGradient(sbX + 1, thumbY, sbX + SCROLLBAR_WIDTH - 1, thumbY + thumbH, 0xFF36BF72, 0xFF207A46); - g.fill(sbX + 1, thumbY, sbX + SCROLLBAR_WIDTH - 1, thumbY + 1, 0xFF8CFFBE); - } + layout.drawScrollbar(g, x + colW + SCROLLBAR_GAP, baseTopY, SCROLLBAR_WIDTH, height, visRows, total, clamped); } - private void renderPodiumList(GuiGraphics g, int baseColX, int baseTopY, List entries, int scrollOffset) { - int colW = Math.max(180, (this.width - 42) / 2); - int x = baseColX == LEFT_COL_X ? 14 : (14 + colW + 14); - int listW = colW - 8; - int bottomLimit = Math.max(baseTopY + ROW_PITCH * 4 + 4, this.height - 42); - int visRows = Math.max(4, (bottomLimit - baseTopY - 4) / ROW_PITCH); - int height = visRows * ROW_PITCH + 4; + private void renderPodiumList(GuiGraphics g, boolean left, List entries, int scrollOffset) { + int x = colX(left); + int colW = colWidth(); + renderPodium(g, x, colW, entries); - g.fill(x, baseTopY, x + colW, baseTopY + height, 0xB806140C); - g.fill(x, baseTopY, x + colW, baseTopY + 1, 0xFF246A43); - g.fill(x, baseTopY + height - 1, x + colW, baseTopY + height, 0xFF1A4F32); - g.fill(x, baseTopY, x + 1, baseTopY + height, 0xFF246A43); - g.fill(x + colW - 1, baseTopY, x + colW, baseTopY + height, 0xFF1A4F32); + int baseTopY = listTopOffset(); + int visRows = visibleRows(); + int height = visRows * ROW_PITCH + 4; + g.fill(x, baseTopY, x + colW, baseTopY + height, 0x22000000); int total = entries.size(); int clamped = clampOffset(scrollOffset, total); - g.enableScissor(x + 1, baseTopY + 1, x + listW, baseTopY + height - 1); for (int vis = 0; vis < visRows; vis++) { int idx = clamped + vis; if (idx >= total) { @@ -614,44 +532,78 @@ private void renderPodiumList(GuiGraphics g, int baseColX, int baseTopY, List visRows && total > 0) { - int sbH = height - 4; - int thumbH = Math.max(18, Math.round(sbH * (visRows / (float) total))); - int travel = Math.max(1, sbH - thumbH); - int thumbY = baseTopY + 2 + Math.round((clamped / (float) (total - visRows)) * travel); - g.fillGradient(sbX + 1, thumbY, sbX + SCROLLBAR_WIDTH - 1, thumbY + thumbH, 0xFF36BF72, 0xFF207A46); - g.fill(sbX + 1, thumbY, sbX + SCROLLBAR_WIDTH - 1, thumbY + 1, 0xFF8CFFBE); + layout.drawScrollbar(g, x + colW + SCROLLBAR_GAP, baseTopY, SCROLLBAR_WIDTH, height, visRows, total, clamped); + } + + private void drawPlayerFace(GuiGraphics g, String uuid, String name, int x, int y, int size) { + if (this.minecraft == null) { + return; + } + PlayerSkin skin = PlayerSkinResolver.skinForId(this.minecraft, uuid, name); + if (skin != null) { + PlayerFaceRenderer.draw(g, skin, x, y, size); } } + private int bottomCloseX() { + return Math.min(this.width / 2 - 50, Math.max(12, this.width - 344)); + } + + private int totalColWidth() { + return Math.max(200, (this.width - MARGIN_X * 2 - COL_GAP) / 2); + } + + private int colWidth() { + return totalColWidth() - SCROLLBAR_GAP - SCROLLBAR_WIDTH; + } + + private int colX(boolean left) { + return left ? MARGIN_X : (MARGIN_X + totalColWidth() + COL_GAP); + } + + private int titleY() { + return activeTab == Tab.CYCLE ? 46 : 70; + } + + private int podiumTop() { + return titleY() + 11; + } + + private int footerReserve() { + return activeTab == Tab.CYCLE ? 42 : 30; + } + + private int podiumHeight() { + int bottomLimit = Math.max(podiumTop() + 190, this.height - footerReserve()); + return Math.clamp((bottomLimit - podiumTop()) * 58 / 100, 126, 184); + } + private int listTopOffset() { - return activeTab == Tab.CYCLE ? 80 : 110; + return podiumTop() + podiumHeight() + 4; + } + + private int visibleRows() { + int top = listTopOffset(); + int listBottom = Math.max(top + ROW_PITCH * 4 + 4, this.height - footerReserve()); + return Math.max(4, (listBottom - top - 4) / ROW_PITCH); } private List leftEntries() { @@ -685,24 +637,10 @@ private List rightEntries() { } private int clampOffset(int offset, int total) { - int top = listTopOffset(); - int bottomLimit = Math.max(top + ROW_PITCH * 4 + 4, this.height - 42); - int visRows = Math.max(4, (bottomLimit - top - 4) / ROW_PITCH); - int max = Math.max(0, total - visRows); + int max = Math.max(0, total - visibleRows()); return Math.clamp(offset, 0, max); } - private static UUID parseUuid(String raw) { - if (raw == null || raw.isBlank()) { - return null; - } - try { - return UUID.fromString(raw.trim()); - } catch (IllegalArgumentException e) { - return null; - } - } - private String trimToWidth(String text, int width) { if (this.font.width(text) <= width) { return text; @@ -710,43 +648,54 @@ private String trimToWidth(String text, int width) { return this.font.plainSubstrByWidth(text, Math.max(0, width - this.font.width("..."))) + "..."; } + private static void drawPillar(GuiGraphics g, int centerX, int baseLineY, int capW, int standH) { + int evenCapW = capW & ~1; + int clampedH = Math.max(24, standH); + int capH = Math.min(clampedH - 6, Math.max(14, Math.round(evenCapW * 41f / 45f))); + int shaftW = Math.max(16, Math.round(evenCapW * 31f / 45f)) & ~1; + int shaftH = Math.max(4, clampedH - capH); + int standTopY = baseLineY - clampedH; + + g.blit(RenderPipelines.GUI_TEXTURED, EDEN_ICON, centerX - evenCapW / 2, standTopY, 18.0f, 13.0f, evenCapW, capH, 45, 41, 256, 256); + int segMaxH = Math.max(12, Math.round(60f * evenCapW / 45f)); + int drawn = 0; + while (drawn < shaftH) { + int segH = Math.min(shaftH - drawn, segMaxH); + int srcH = Math.clamp(Math.round(segH * 45f / evenCapW), 1, 60); + g.blit(RenderPipelines.GUI_TEXTURED, EDEN_ICON, centerX - shaftW / 2, standTopY + capH + drawn, 25.0f, 54.0f, shaftW, segH, 31, srcH, 256, 256); + drawn += segH; + } + g.fill(centerX - shaftW / 2 - 2, baseLineY - 2, centerX - shaftW / 2 + shaftW + 2, baseLineY - 1, 0xFF9E8FB2); + g.fill(centerX - shaftW / 2 - 2, baseLineY - 1, centerX - shaftW / 2 + shaftW + 2, baseLineY, 0xFF231F20); + } + private static void drawTexture(GuiGraphics g, Identifier id, int x, int y, int w, int h) { if (id == null || w <= 0 || h <= 0) { return; } - int srcSize = id.getPath().endsWith("icon.png") ? 256 : 64; g.pose().pushMatrix(); g.pose().translate(x, y); - g.pose().scale(w / (float) srcSize, h / (float) srcSize); - g.blit(RenderPipelines.GUI_TEXTURED, id, 0, 0, 0.0f, 0.0f, srcSize, srcSize, srcSize, srcSize); + g.pose().scale(w / 64.0f, h / 64.0f); + g.blit(RenderPipelines.GUI_TEXTURED, id, 0, 0, 0.0f, 0.0f, 64, 64, 64, 64); g.pose().popMatrix(); } - private boolean isInPane(double scaledX, double scaledY, int baseColX) { - int colW = Math.max(180, (this.width - 42) / 2); - int left = baseColX == LEFT_COL_X ? 14 : (14 + colW + 14); - int top = listTopOffset(); - int bottomLimit = Math.max(top + ROW_PITCH * 4 + 4, this.height - 42); - int visRows = Math.max(4, (bottomLimit - top - 4) / ROW_PITCH); - int bottom = top + visRows * ROW_PITCH + 4; - return scaledX >= left && scaledX <= left + colW && scaledY >= top && scaledY <= bottom; + private boolean isInPane(double scaledX, double scaledY, boolean leftPane) { + int left = colX(leftPane); + int bottom = listTopOffset() + visibleRows() * ROW_PITCH + 4; + return scaledX >= left && scaledX <= left + totalColWidth() + 4 && scaledY >= podiumTop() && scaledY <= bottom; } - private boolean isOverScrollbar(double scaledX, double scaledY, int baseColX) { - int colW = Math.max(180, (this.width - 42) / 2); - int colLeft = baseColX == LEFT_COL_X ? 14 : (14 + colW + 14); - int sbX = colLeft + colW - SCROLLBAR_WIDTH - 2; + private boolean isOverScrollbar(double scaledX, double scaledY, boolean leftPane) { + int sbX = colX(leftPane) + colWidth() + SCROLLBAR_GAP; int top = listTopOffset(); - int bottomLimit = Math.max(top + ROW_PITCH * 4 + 4, this.height - 42); - int visRows = Math.max(4, (bottomLimit - top - 4) / ROW_PITCH); - int bottom = top + visRows * ROW_PITCH + 4; + int bottom = top + visibleRows() * ROW_PITCH + 4; return scaledX >= sbX - 2 && scaledX <= sbX + SCROLLBAR_WIDTH + 2 && scaledY >= top && scaledY <= bottom; } private void updateScrollFromMouse(double scaledY, int pane) { int top = listTopOffset(); - int bottomLimit = Math.max(top + ROW_PITCH * 4 + 4, this.height - 42); - int visRows = Math.max(4, (bottomLimit - top - 4) / ROW_PITCH); + int visRows = visibleRows(); int height = visRows * ROW_PITCH + 4; int total = pane == 1 ? leftEntries().size() : rightEntries().size(); int maxOffset = Math.max(0, total - visRows); @@ -763,12 +712,12 @@ private void updateScrollFromMouse(double scaledY, int pane) { public boolean mouseClicked(MouseButtonEvent event, boolean doubleClick) { MouseButtonEvent scaled = rescale(event); if (scaled.button() == 0) { - if (isOverScrollbar(scaled.x(), scaled.y(), LEFT_COL_X)) { + if (isOverScrollbar(scaled.x(), scaled.y(), true)) { draggingPane = 1; updateScrollFromMouse(scaled.y(), 1); return true; } - if (isOverScrollbar(scaled.x(), scaled.y(), RIGHT_COL_X)) { + if (isOverScrollbar(scaled.x(), scaled.y(), false)) { draggingPane = 2; updateScrollFromMouse(scaled.y(), 2); return true; @@ -798,11 +747,11 @@ public boolean mouseScrolled(double mouseX, double mouseY, double scrollX, doubl double sx = mouseX / uiScale; double sy = mouseY / uiScale; int step = scrollY > 0 ? -1 : 1; - if (isInPane(sx, sy, LEFT_COL_X)) { + if (isInPane(sx, sy, true)) { raidsScroll = clampOffset(raidsScroll + step, leftEntries().size()); return true; } - if (isInPane(sx, sy, RIGHT_COL_X)) { + if (isInPane(sx, sy, false)) { warsScroll = clampOffset(warsScroll + step, rightEntries().size()); return true; } diff --git a/src/tel/eden/mod/util/PlayerSkinResolver.java b/src/tel/eden/mod/util/PlayerSkinResolver.java index ea907a8..3c47d88 100644 --- a/src/tel/eden/mod/util/PlayerSkinResolver.java +++ b/src/tel/eden/mod/util/PlayerSkinResolver.java @@ -1,24 +1,31 @@ package tel.eden.mod.util; +import com.mojang.authlib.GameProfile; import java.nio.charset.StandardCharsets; import java.util.Map; import java.util.UUID; import java.util.concurrent.ConcurrentHashMap; import java.util.concurrent.ExecutorService; import java.util.concurrent.Executors; +import java.util.regex.Pattern; import net.minecraft.client.Minecraft; import net.minecraft.client.multiplayer.PlayerInfo; import net.minecraft.client.resources.DefaultPlayerSkin; import net.minecraft.world.entity.player.PlayerSkin; +import tel.eden.mod.EdenLogger; /** - * Resolves player skins for HUDs and menus, serving from the local client player list - * or an off-thread Mojang profile cache, falling back to a Steve/Alex skin. + * Shared player skin resolver for HUDs and menus, checking the live player list (when textures are + * populated) then the shared Mojang-resolved cache, with an off-thread rate-limited session lookup. */ public final class PlayerSkinResolver { + private static final EdenLogger LOGGER = EdenLogger.get(); + private static final Pattern DASHLESS_UUID = Pattern.compile("(\\p{XDigit}{8})(\\p{XDigit}{4})(\\p{XDigit}{4})(\\p{XDigit}{4})(\\p{XDigit}{12})"); private static final Map RESOLVED_SKINS = new ConcurrentHashMap<>(); private static final Map SKIN_NEXT_ATTEMPT = new ConcurrentHashMap<>(); private static final long SKIN_RETRY_MS = 30_000L; + private static final long SKIN_FAIL_RETRY_MS = 10_000L; + private static final long WORKER_PACE_MS = 200L; private static final ExecutorService SKIN_WORKER = Executors.newSingleThreadExecutor(runnable -> { Thread thread = new Thread(runnable, "eden-skin-resolver"); thread.setDaemon(true); @@ -28,32 +35,70 @@ public final class PlayerSkinResolver { private PlayerSkinResolver() { } + /** Parse either a hyphenated or 32-char dashless UUID string, returning {@code null} if invalid. */ + public static UUID parseUuid(String raw) { + if (raw == null || raw.isBlank()) { + return null; + } + String trimmed = raw.trim(); + if (trimmed.length() == 32 && trimmed.indexOf('-') < 0) { + trimmed = DASHLESS_UUID.matcher(trimmed).replaceFirst("$1-$2-$3-$4-$5"); + } + try { + return UUID.fromString(trimmed); + } catch (IllegalArgumentException e) { + return null; + } + } + + /** Resolve a skin from a raw UUID string (optional) and fallback IGN. */ + public static PlayerSkin skinForId(Minecraft mc, String uuidStr, String name) { + return skinFor(mc, parseUuid(uuidStr), name); + } + + /** Resolve a skin by parsed UUID and fallback IGN. */ public static PlayerSkin skinFor(Minecraft mc, UUID uuid, String name) { if (uuid == null) { - if (name != null && !name.isBlank()) { - uuid = UUID.nameUUIDFromBytes(name.getBytes(StandardCharsets.UTF_8)); - } else { + if (name == null || name.isBlank()) { return DefaultPlayerSkin.getDefaultSkin(); } - } - if (mc != null && mc.getConnection() != null) { - PlayerInfo info = mc.getConnection().getPlayerInfo(uuid); - if (info == null && name != null && !name.isBlank()) { - info = mc.getConnection().getPlayerInfo(name); - } - if (info != null) { - return info.getSkin(); + PlayerSkin online = onlineSkin(mc, null, name); + if (online != null) { + return online; } + return DefaultPlayerSkin.get(UUID.nameUUIDFromBytes(name.getBytes(StandardCharsets.UTF_8))); + } + PlayerSkin online = onlineSkin(mc, uuid, name); + if (online != null) { + return online; } PlayerSkin resolved = RESOLVED_SKINS.get(uuid); if (resolved != null) { return resolved; } - fetchSkin(mc, uuid); + if (uuid.version() != 3) { + fetchSkin(mc, uuid, name); + } return DefaultPlayerSkin.get(uuid); } - private static void fetchSkin(Minecraft mc, UUID uuid) { + private static PlayerSkin onlineSkin(Minecraft mc, UUID uuid, String name) { + if (mc == null || mc.getConnection() == null) { + return null; + } + PlayerInfo info = uuid != null ? mc.getConnection().getPlayerInfo(uuid) : null; + if (info == null && name != null && !name.isBlank()) { + info = mc.getConnection().getPlayerInfo(name); + } + // Wynncraft cross-world tab/guild entries often omit texture properties; fall back to + // Mojang session lookup unless the live entry actually carries a texture property. + if (info != null && !info.getProfile().properties().get("textures").isEmpty()) { + return info.getSkin(); + } + return null; + } + + private static void fetchSkin(Minecraft mc, UUID uuid, String name) { if (mc == null) { return; } @@ -63,14 +108,26 @@ private static void fetchSkin(Minecraft mc, UUID uuid) { return; } SKIN_NEXT_ATTEMPT.put(uuid, now + SKIN_RETRY_MS); + LOGGER.debug("Resolving skin for {} ({})", name, uuid); SKIN_WORKER.submit(() -> { try { - var result = mc.services().sessionService().fetchProfile(uuid, false); - if (result != null) { - com.mojang.authlib.GameProfile profile = result.profile(); + // requireSecure=true avoids Yggdrasil's 6h negative cache when rate-limited (HTTP 429). + var result = mc.services().sessionService().fetchProfile(uuid, true); + if (result != null && result.profile() != null) { + GameProfile profile = result.profile(); mc.execute(() -> mc.getSkinManager().get(profile).thenAccept(skin -> skin.ifPresent(value -> RESOLVED_SKINS.put(uuid, value)))); + } else { + SKIN_NEXT_ATTEMPT.put(uuid, System.currentTimeMillis() + SKIN_FAIL_RETRY_MS); + } + } catch (RuntimeException e) { + LOGGER.debug("Skin fetch failed for {}", uuid, e); + SKIN_NEXT_ATTEMPT.put(uuid, System.currentTimeMillis() + SKIN_FAIL_RETRY_MS); + } finally { + try { + Thread.sleep(WORKER_PACE_MS); + } catch (InterruptedException ie) { + Thread.currentThread().interrupt(); } - } catch (Exception ignored) { } }); } diff --git a/src/tel/eden/mod/war/AttackTimerMenu.java b/src/tel/eden/mod/war/AttackTimerMenu.java index cbf4c4a..d6e73bb 100644 --- a/src/tel/eden/mod/war/AttackTimerMenu.java +++ b/src/tel/eden/mod/war/AttackTimerMenu.java @@ -1,15 +1,10 @@ package tel.eden.mod.war; -import com.mojang.authlib.GameProfile; -import java.nio.charset.StandardCharsets; import java.util.ArrayList; import java.util.HashMap; import java.util.List; import java.util.Map; import java.util.UUID; -import java.util.concurrent.ConcurrentHashMap; -import java.util.concurrent.ExecutorService; -import java.util.concurrent.Executors; import java.util.regex.Matcher; import java.util.regex.Pattern; import net.minecraft.client.Minecraft; @@ -17,7 +12,6 @@ import net.minecraft.client.gui.GuiGraphics; import net.minecraft.client.gui.components.PlayerFaceRenderer; import net.minecraft.client.multiplayer.PlayerInfo; -import net.minecraft.client.resources.DefaultPlayerSkin; import net.minecraft.core.BlockPos; import net.minecraft.world.entity.player.PlayerSkin; import net.minecraft.world.scores.DisplaySlot; @@ -26,7 +20,6 @@ import net.minecraft.world.scores.PlayerTeam; import net.minecraft.world.scores.Scoreboard; import org.lwjgl.glfw.GLFW; -import tel.eden.mod.EdenLogger; import tel.eden.mod.EdenModClient; import tel.eden.mod.chat.ChatText; import tel.eden.mod.config.BridgeConfig; @@ -38,6 +31,7 @@ import tel.eden.mod.net.WarBoardEntry; import tel.eden.mod.net.WarGoer; import tel.eden.mod.net.WarQueuer; +import tel.eden.mod.util.PlayerSkinResolver; /** * HUD list of upcoming territory attacks read from the scoreboard sidebar, each row @@ -863,79 +857,12 @@ private static String nameFor(Minecraft mc, String uuidStr, String fallbackName) return fallbackName; } - private static final EdenLogger LOGGER = EdenLogger.get(); - /** Skins resolved by uuid from Mojang, for goers not in our player list (cross-world). */ - private static final Map resolvedSkins = new ConcurrentHashMap<>(); - /** - * Earliest time (ms) each uuid may be (re)fetched. Set on every attempt so a failed or - * empty resolve backs off instead of re-submitting every frame; a success caches into - * {@link #resolvedSkins} and is served before this map is ever consulted again. - */ - private static final Map skinNextAttempt = new ConcurrentHashMap<>(); - private static final long SKIN_RETRY_MS = 30_000L; - private static final ExecutorService skinWorker = Executors.newSingleThreadExecutor(runnable -> { - Thread thread = new Thread(runnable, "eden-war-skins"); - thread.setDaemon(true); - return thread; - }); - - /** - * The skin to draw for a player head. A guildmate on our own world is in the player list with - * their skin already loaded (free). One on a different Wynncraft world instance - * (routine during a war rush) isn't in our list, so their profile carries no textures and - * the game would only give a default skin — we resolve those by uuid from Mojang in the - * background (cached), showing the default until it lands. - */ private static PlayerSkin skinFor(Minecraft mc, WarGoer goer) { return skinFor(mc, goer.uuid(), goer.name()); } private static PlayerSkin skinFor(Minecraft mc, String uuidStr, String fallbackName) { - UUID uuid; - try { - uuid = UUID.fromString(uuidStr); - } catch (IllegalArgumentException e) { - return DefaultPlayerSkin.get(UUID.nameUUIDFromBytes(fallbackName.getBytes(StandardCharsets.UTF_8))); - } - if (mc.getConnection() != null) { - PlayerInfo info = mc.getConnection().getPlayerInfo(uuid); - if (info != null) { - return info.getSkin(); - } - } - PlayerSkin resolved = resolvedSkins.get(uuid); - if (resolved != null) { - return resolved; - } - fetchSkin(mc, uuid, fallbackName); - return DefaultPlayerSkin.get(uuid); - } - - /** - * Resolve a goer's skin by uuid off-thread (Mojang session lookup → texture load), - * caching the result. Rate-limited per uuid ({@link #SKIN_RETRY_MS}) so a failed or - * empty resolve backs off instead of re-submitting every frame the head is drawn; a - * success caches the skin, which is then served before this method is called again. - */ - private static void fetchSkin(Minecraft mc, UUID uuid, String name) { - long now = System.currentTimeMillis(); - Long next = skinNextAttempt.get(uuid); - if (next != null && now < next) { - return; - } - skinNextAttempt.put(uuid, now + SKIN_RETRY_MS); - LOGGER.debug("Resolving war-head skin for {} ({}) — not in the player list", name, uuid); - skinWorker.submit(() -> { - try { - var result = mc.services().sessionService().fetchProfile(uuid, false); - if (result != null) { - GameProfile profile = result.profile(); - mc.execute(() -> mc.getSkinManager().get(profile).thenAccept(skin -> skin.ifPresent(value -> resolvedSkins.put(uuid, value)))); - } - } catch (RuntimeException e) { - LOGGER.debug("War-head skin fetch failed for {}", uuid, e); - } - }); + return PlayerSkinResolver.skinForId(mc, uuidStr, fallbackName); } /** diff --git a/test/tel/eden/mod/util/PlayerSkinResolverTest.java b/test/tel/eden/mod/util/PlayerSkinResolverTest.java index e46cba1..24e8e62 100644 --- a/test/tel/eden/mod/util/PlayerSkinResolverTest.java +++ b/test/tel/eden/mod/util/PlayerSkinResolverTest.java @@ -1,8 +1,11 @@ package tel.eden.mod.util; +import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertNotNull; +import static org.junit.jupiter.api.Assertions.assertNull; import static org.junit.jupiter.api.Assertions.assertSame; +import java.util.UUID; import net.minecraft.client.resources.DefaultPlayerSkin; import net.minecraft.world.entity.player.PlayerSkin; import org.junit.jupiter.api.Test; @@ -22,4 +25,14 @@ void returnsDefaultSkinImmediatelyWhenUuidAndNameAreAbsent() { PlayerSkin blankName = PlayerSkinResolver.skinFor(null, null, " "); assertSame(expected, blankName, "Must return DefaultPlayerSkin directly when name is blank"); } + + @Test + void parsesDashedAndDashlessUuids() { + UUID expected = UUID.fromString("387c49fd-f06c-47b7-97a6-b97a5ecc0bd3"); + assertEquals(expected, PlayerSkinResolver.parseUuid("387c49fd-f06c-47b7-97a6-b97a5ecc0bd3")); + assertEquals(expected, PlayerSkinResolver.parseUuid(" 387c49fdf06c47b797a6b97a5ecc0bd3 ")); + assertNull(PlayerSkinResolver.parseUuid("not-a-uuid")); + assertNull(PlayerSkinResolver.parseUuid("")); + assertNull(PlayerSkinResolver.parseUuid(null)); + } } From b2b6d9a52ce7b686ffa9ad910d4a21537477e640 Mon Sep 17 00:00:00 2001 From: Good627 <193092356+Good627@users.noreply.github.com> Date: Thu, 19 Nov 2026 03:50:58 +0200 Subject: [PATCH 6/8] fix(cycle): correlate requests, bounded responsive layout, safe skin cache reset, and <=2503A warning --- src/tel/eden/mod/EdenModClient.java | 157 +++++++++++++----- .../eden/mod/gui/PromotionCycleScreen.java | 148 ++++++++++------- .../eden/mod/net/BridgeWebSocketClient.java | 12 +- .../eden/mod/net/CycleLeaderboardData.java | 42 +++++ src/tel/eden/mod/util/PlayerSkinResolver.java | 49 +++++- .../eden/mod/net/CycleLeaderboardTest.java | 36 ++++ .../eden/mod/util/PlayerSkinResolverTest.java | 9 + 7 files changed, 341 insertions(+), 112 deletions(-) diff --git a/src/tel/eden/mod/EdenModClient.java b/src/tel/eden/mod/EdenModClient.java index 9751259..1d7a86e 100644 --- a/src/tel/eden/mod/EdenModClient.java +++ b/src/tel/eden/mod/EdenModClient.java @@ -303,12 +303,21 @@ public boolean onWynncraft() { private volatile long lifetimeLeaderboardErrorAtMs; private final java.util.concurrent.atomic.AtomicInteger lifetimeLeaderboardGeneration = new java.util.concurrent.atomic.AtomicInteger(); private final java.util.Map concludedCyclesByCode = new java.util.concurrent.ConcurrentHashMap<>(); + + private record LifetimeFilter(Double fromDays, Double toDays) { + } + private volatile String pendingCyclePrintCode; + private volatile String pendingCycleGuiCode; + private volatile LifetimeFilter pendingLifetimeFilter; private static final long LEADERBOARD_TIMEOUT_SECONDS = 15L; - private final java.util.concurrent.atomic.AtomicLong cycleRequestSeq = new java.util.concurrent.atomic.AtomicLong(); - private final java.util.concurrent.atomic.AtomicLong cycleRequestPendingId = new java.util.concurrent.atomic.AtomicLong(); + private final java.util.concurrent.atomic.AtomicLong cycleGuiSeq = new java.util.concurrent.atomic.AtomicLong(); + private final java.util.concurrent.atomic.AtomicLong cycleGuiPendingId = new java.util.concurrent.atomic.AtomicLong(); + private final java.util.concurrent.atomic.AtomicLong cyclePrintSeq = new java.util.concurrent.atomic.AtomicLong(); + private final java.util.concurrent.atomic.AtomicLong cyclePrintPendingId = new java.util.concurrent.atomic.AtomicLong(); private final java.util.concurrent.atomic.AtomicLong lifetimeRequestSeq = new java.util.concurrent.atomic.AtomicLong(); private final java.util.concurrent.atomic.AtomicLong lifetimeRequestPendingId = new java.util.concurrent.atomic.AtomicLong(); + private final Object cycleSendLock = new Object(); private volatile long lastCycleQueryAtMs; private volatile long lastLifetimeQueryAtMs; // GitHub update check: run once per game session; the prompt offers a one-click @@ -866,8 +875,6 @@ public void release() { tel.eden.mod.war.eco.TerritoryGuideController.reset(); guildAllyManager.requestCancel(); eventRewardsPendingId.set(0); - cycleRequestPendingId.set(0); - lifetimeRequestPendingId.set(0); // Connect if applicable; the backend reports link/membership standing via // authOk (handleAuthStatus), which drives any "please link" prompt. evaluateGating(client); @@ -1527,50 +1534,68 @@ public void onLongEventRewards(int pendingLe, String error) { @Override public void onCycleLeaderboard(tel.eden.mod.net.CycleLeaderboardData.CycleSnapshot snapshot) { - cycleRequestPendingId.set(0); if (!isFullMember()) { LOGGER.warn("Ignoring cycleLeaderboardReply while bridgeStatus={}", bridgeStatus); return; } if (snapshot.error() != null && !snapshot.error().isEmpty()) { + cycleGuiPendingId.set(0); + cyclePrintPendingId.set(0); + pendingCycleGuiCode = null; String err = snapshot.error(); LOGGER.error("Cycle leaderboard reply returned error: {}", err); cycleLeaderboardError = err; cycleLeaderboardErrorAtMs = System.currentTimeMillis(); cycleLeaderboardGeneration.incrementAndGet(); - String pendingCode = pendingCyclePrintCode; - if (pendingCode != null) { + if (pendingCyclePrintCode != null) { pendingCyclePrintCode = null; display(() -> DiscordChatFormatter.systemLine(err, ChatFormatting.RED)); } return; } - cycleLeaderboardError = ""; - cycleLeaderboardErrorAtMs = 0L; - knownCycleLeaderboard = snapshot; - cycleLeaderboardGeneration.incrementAndGet(); - String pendingCode = pendingCyclePrintCode; - if (pendingCode != null && (pendingCode.isEmpty() || pendingCode.equals(snapshot.cycleCode()))) { + String printTarget = pendingCyclePrintCode; + if (printTarget != null && tel.eden.mod.net.CycleLeaderboardData.matchesRequestedCycle(snapshot, printTarget)) { pendingCyclePrintCode = null; + cyclePrintPendingId.set(0); tel.eden.mod.net.CycleLeaderboardData.ConcludedCycleSummary derived = tel.eden.mod.net.CycleLeaderboardData.summaryFromSnapshot(snapshot); display(() -> DiscordChatFormatter.formatCyclePrint(derived)); } + String guiTarget = pendingCycleGuiCode; + if (guiTarget == null && cycleGuiPendingId.get() == 0 && knownCycleLeaderboard != null) { + return; + } + if (guiTarget != null && !tel.eden.mod.net.CycleLeaderboardData.matchesRequestedCycle(snapshot, guiTarget)) { + return; + } + cycleGuiPendingId.set(0); + pendingCycleGuiCode = null; + cycleLeaderboardError = ""; + cycleLeaderboardErrorAtMs = 0L; + knownCycleLeaderboard = snapshot; + cycleLeaderboardGeneration.incrementAndGet(); } @Override public void onLifetimeLeaderboard(tel.eden.mod.net.CycleLeaderboardData.LifetimeSnapshot snapshot) { - lifetimeRequestPendingId.set(0); if (!isFullMember()) { LOGGER.warn("Ignoring lifetimeLeaderboardReply while bridgeStatus={}", bridgeStatus); return; } if (snapshot.error() != null && !snapshot.error().isEmpty()) { + lifetimeRequestPendingId.set(0); + pendingLifetimeFilter = null; LOGGER.error("Lifetime leaderboard reply returned error: {}", snapshot.error()); lifetimeLeaderboardError = snapshot.error(); lifetimeLeaderboardErrorAtMs = System.currentTimeMillis(); lifetimeLeaderboardGeneration.incrementAndGet(); return; } + LifetimeFilter expected = pendingLifetimeFilter; + if (expected != null && !tel.eden.mod.net.CycleLeaderboardData.matchesRequestedInterval(snapshot, expected.fromDays(), expected.toDays())) { + return; + } + lifetimeRequestPendingId.set(0); + pendingLifetimeFilter = null; lifetimeLeaderboardError = ""; lifetimeLeaderboardErrorAtMs = 0L; knownLifetimeLeaderboard = snapshot; @@ -1974,7 +1999,7 @@ private int printCycleSummary(FabricClientCommandSource source, String cycleCode return 1; } tel.eden.mod.net.CycleLeaderboardData.CycleSnapshot snap = knownCycleLeaderboard; - if (snap != null && snap.error().isEmpty() && (trimmed.isEmpty() || trimmed.equals(snap.cycleCode()))) { + if (tel.eden.mod.net.CycleLeaderboardData.isHistoricalCycle(snap, trimmed)) { source.sendFeedback(DiscordChatFormatter.formatCyclePrint(tel.eden.mod.net.CycleLeaderboardData.summaryFromSnapshot(snap))); return 1; } @@ -1988,23 +2013,33 @@ public void requestCycleLeaderboard(String cycleCode) { } private void requestCycleLeaderboard(String cycleCode, boolean forPrint) { - long seq = cycleRequestSeq.incrementAndGet(); - pendingCyclePrintCode = forPrint ? (cycleCode != null ? cycleCode.trim() : "") : null; + String target = (cycleCode != null && !cycleCode.isBlank()) ? cycleCode.trim() : ""; + long seq = forPrint ? cyclePrintSeq.incrementAndGet() : cycleGuiSeq.incrementAndGet(); + if (forPrint) { + pendingCyclePrintCode = target; + } else { + pendingCycleGuiCode = target; + } BridgeWebSocketClient current = socket; if (!isFullMember() || current == null || !current.isConnected()) { - LOGGER.error("Cycle leaderboard request aborted before send (cycle={}, status={}, connected={})", cycleCode, bridgeStatus, current != null && current.isConnected()); - failCycleLeaderboardRequest(); + LOGGER.error("Cycle leaderboard request aborted before send (cycle={}, status={}, connected={})", target, bridgeStatus, current != null && current.isConnected()); + failCycleLeaderboardRequest(forPrint); return; } - long delayMs = knownCycleLeaderboard == null ? 0L : Math.max(0L, (lastCycleQueryAtMs + 950L) - System.currentTimeMillis()); + long delayMs = knownCycleLeaderboard == null && lastCycleQueryAtMs == 0L ? 0L : Math.max(0L, (lastCycleQueryAtMs + 950L) - System.currentTimeMillis()); if (delayMs == 0L) { - dispatchCycleLeaderboardRequest(cycleCode, seq); + dispatchCycleLeaderboardRequest(target, seq, forPrint); return; } + scheduleCycleLeaderboardDispatch(target, seq, forPrint, delayMs); + } + + private void scheduleCycleLeaderboardDispatch(String cycleCode, long seq, boolean forPrint, long delayMs) { partyCommandExecutor.schedule(() -> { try { - if (cycleRequestSeq.get() == seq) { - dispatchCycleLeaderboardRequest(cycleCode, seq); + long latest = forPrint ? cyclePrintSeq.get() : cycleGuiSeq.get(); + if (latest == seq) { + dispatchCycleLeaderboardRequest(cycleCode, seq, forPrint); } } catch (RuntimeException e) { LOGGER.error("Scheduled cycle leaderboard dispatch failed (seq={}, cycle={})", seq, cycleCode, e); @@ -2012,25 +2047,45 @@ private void requestCycleLeaderboard(String cycleCode, boolean forPrint) { }, delayMs, TimeUnit.MILLISECONDS); } - private void dispatchCycleLeaderboardRequest(String cycleCode, long seq) { + private void dispatchCycleLeaderboardRequest(String cycleCode, long seq, boolean forPrint) { BridgeWebSocketClient current = socket; if (!isFullMember() || current == null || !current.isConnected()) { - if (cycleRequestSeq.get() == seq) { + long latest = forPrint ? cyclePrintSeq.get() : cycleGuiSeq.get(); + if (latest == seq) { LOGGER.error("Cycle leaderboard deferred send aborted (seq={}, cycle={}, status={}, connected={})", seq, cycleCode, bridgeStatus, current != null && current.isConnected()); - failCycleLeaderboardRequest(); + failCycleLeaderboardRequest(forPrint); + } + return; + } + long remainingCooldownMs; + synchronized (cycleSendLock) { + long now = System.currentTimeMillis(); + remainingCooldownMs = (lastCycleQueryAtMs + 950L) - now; + if (remainingCooldownMs <= 0L) { + lastCycleQueryAtMs = now; + } + } + if (remainingCooldownMs > 0L) { + scheduleCycleLeaderboardDispatch(cycleCode, seq, forPrint, remainingCooldownMs); + return; + } + java.util.concurrent.atomic.AtomicLong pendingSlot = forPrint ? cyclePrintPendingId : cycleGuiPendingId; + pendingSlot.set(seq); + if (!forPrint) { + cycleLeaderboardError = ""; + cycleLeaderboardErrorAtMs = 0L; + } + if (!current.sendCycleLeaderboardRequest(cycleCode)) { + if (pendingSlot.compareAndSet(seq, 0)) { + failCycleLeaderboardRequest(forPrint); } return; } - cycleRequestPendingId.set(seq); - lastCycleQueryAtMs = System.currentTimeMillis(); - cycleLeaderboardError = ""; - cycleLeaderboardErrorAtMs = 0L; - current.sendCycleLeaderboardRequest(cycleCode); partyCommandExecutor.schedule(() -> { try { - if (cycleRequestPendingId.compareAndSet(seq, 0)) { - LOGGER.error("Cycle leaderboard request timed out after {}s (seq={}, cycle={}, status={}, connected={}) — no reply from backend", LEADERBOARD_TIMEOUT_SECONDS, seq, cycleCode, bridgeStatus, socket != null && socket.isConnected()); - failCycleLeaderboardRequest(); + if (pendingSlot.compareAndSet(seq, 0)) { + LOGGER.error("Cycle leaderboard request timed out after {}s (seq={}, cycle={}, forPrint={}, status={}, connected={}) — no reply from backend", LEADERBOARD_TIMEOUT_SECONDS, seq, cycleCode, forPrint, bridgeStatus, socket != null && socket.isConnected()); + failCycleLeaderboardRequest(forPrint); } } catch (RuntimeException e) { LOGGER.error("Cycle leaderboard timeout task failed (seq={}, cycle={})", seq, cycleCode, e); @@ -2038,20 +2093,26 @@ private void dispatchCycleLeaderboardRequest(String cycleCode, long seq) { }, LEADERBOARD_TIMEOUT_SECONDS, TimeUnit.SECONDS); } - private void failCycleLeaderboardRequest() { - cycleRequestPendingId.set(0); + private void failCycleLeaderboardRequest(boolean forPrint) { + if (forPrint) { + cyclePrintPendingId.set(0); + if (pendingCyclePrintCode != null) { + pendingCyclePrintCode = null; + display(() -> DiscordChatFormatter.systemLine("Failed to fetch cycle leaderboard", ChatFormatting.RED)); + } + return; + } + cycleGuiPendingId.set(0); + pendingCycleGuiCode = null; cycleLeaderboardError = "Failed to fetch cycle leaderboard"; cycleLeaderboardErrorAtMs = System.currentTimeMillis(); cycleLeaderboardGeneration.incrementAndGet(); - if (pendingCyclePrintCode != null) { - pendingCyclePrintCode = null; - display(() -> DiscordChatFormatter.systemLine("Failed to fetch cycle leaderboard", ChatFormatting.RED)); - } } /** Request lifetime or interval Raids/Wars leaderboards, debounced safely above server throttle. */ public void requestLifetimeLeaderboard(Double fromDays, Double toDays) { long seq = lifetimeRequestSeq.incrementAndGet(); + pendingLifetimeFilter = new LifetimeFilter(fromDays, toDays); BridgeWebSocketClient current = socket; if (!isFullMember() || current == null || !current.isConnected()) { LOGGER.error("Lifetime leaderboard request aborted before send (fromDays={}, toDays={}, status={}, connected={})", fromDays, toDays, bridgeStatus, current != null && current.isConnected()); @@ -2087,7 +2148,12 @@ private void dispatchLifetimeLeaderboardRequest(Double fromDays, Double toDays, lastLifetimeQueryAtMs = System.currentTimeMillis(); lifetimeLeaderboardError = ""; lifetimeLeaderboardErrorAtMs = 0L; - current.sendLifetimeLeaderboardRequest(fromDays, toDays); + if (!current.sendLifetimeLeaderboardRequest(fromDays, toDays)) { + if (lifetimeRequestPendingId.compareAndSet(seq, 0)) { + failLifetimeLeaderboardRequest(); + } + return; + } partyCommandExecutor.schedule(() -> { try { if (lifetimeRequestPendingId.compareAndSet(seq, 0)) { @@ -2102,6 +2168,7 @@ private void dispatchLifetimeLeaderboardRequest(Double fromDays, Double toDays, private void failLifetimeLeaderboardRequest() { lifetimeRequestPendingId.set(0); + pendingLifetimeFilter = null; lifetimeLeaderboardError = "Failed to fetch leaderboard stats"; lifetimeLeaderboardErrorAtMs = System.currentTimeMillis(); lifetimeLeaderboardGeneration.incrementAndGet(); @@ -3269,8 +3336,10 @@ private synchronized void disconnect() { longEventGeneration.set(0); longEventError = ""; longEventErrorAtMs = 0L; - cycleRequestSeq.incrementAndGet(); - cycleRequestPendingId.set(0); + cycleGuiSeq.incrementAndGet(); + cycleGuiPendingId.set(0); + cyclePrintSeq.incrementAndGet(); + cyclePrintPendingId.set(0); lifetimeRequestSeq.incrementAndGet(); lifetimeRequestPendingId.set(0); knownCycleLeaderboard = null; @@ -3283,6 +3352,8 @@ private synchronized void disconnect() { lifetimeLeaderboardErrorAtMs = 0L; concludedCyclesByCode.clear(); pendingCyclePrintCode = null; + pendingCycleGuiCode = null; + pendingLifetimeFilter = null; lastCycleQueryAtMs = 0L; lastLifetimeQueryAtMs = 0L; tel.eden.mod.chat.ImagePreviewManager.clear(); diff --git a/src/tel/eden/mod/gui/PromotionCycleScreen.java b/src/tel/eden/mod/gui/PromotionCycleScreen.java index 6e7ec0c..e368c64 100644 --- a/src/tel/eden/mod/gui/PromotionCycleScreen.java +++ b/src/tel/eden/mod/gui/PromotionCycleScreen.java @@ -41,6 +41,8 @@ private enum Tab { private final EdenModClient mod; private final String initialCycleCode; private EdenPanelLayout layout; + private int closeButtonX = 12; + private int toLabelX = 126; private Tab activeTab = Tab.CYCLE; private boolean archiveOpen; @@ -85,10 +87,7 @@ public PromotionCycleScreen(Screen parent, EdenModClient mod, String initialCycl @Override protected void init() { super.init(); - layout = centeredLayout(200, 120); - uiScale = 1.0f; - virtualWidth = this.width; - virtualHeight = this.height; + layout = centeredLayout(560, 320); if (fromBox != null) { fromDraft = fromBox.getValue(); @@ -104,32 +103,49 @@ protected void init() { this.addRenderableWidget(cycleTabButton); this.addRenderableWidget(lifetimeTabButton); - int closeX = bottomCloseX(); - Button closeButton = Button.builder(Component.literal("Close"), b -> onClose()).bounds(closeX, this.height - 24, 100, 18).build(); + int archiveW = 92; + int nextW = 56; + int prevW = 68; + int archiveX = virtualWidth - 12 - archiveW; + int nextX = archiveX - 4 - nextW; + int prevX = nextX - 4 - prevW; + int closeW = Math.min(100, Math.max(52, prevX - 20)); + closeButtonX = Math.min(Math.max(12, virtualWidth / 2 - closeW / 2), Math.max(12, prevX - closeW - 8)); + int bottomY = virtualHeight - 24; + Button closeButton = Button.builder(Component.literal("Close"), b -> onClose()).bounds(closeButtonX, bottomY, closeW, 18).build(); this.addRenderableWidget(closeButton); // Cycle tab archive controls - prevCycleButton = Button.builder(Component.literal("< Previous"), b -> navigateArchive(-1)).bounds(this.width - 236, this.height - 24, 68, 18).build(); - nextCycleButton = Button.builder(Component.literal("Next >"), b -> navigateArchive(1)).bounds(this.width - 164, this.height - 24, 56, 18).build(); - archiveButton = Button.builder(Component.literal("Cycle Archive"), b -> toggleArchive()).bounds(this.width - 104, this.height - 24, 92, 18).build(); + prevCycleButton = Button.builder(Component.literal("< Previous"), b -> navigateArchive(-1)).bounds(prevX, bottomY, prevW, 18).build(); + nextCycleButton = Button.builder(Component.literal("Next >"), b -> navigateArchive(1)).bounds(nextX, bottomY, nextW, 18).build(); + archiveButton = Button.builder(Component.literal("Cycle Archive"), b -> toggleArchive()).bounds(archiveX, bottomY, archiveW, 18).build(); this.addRenderableWidget(prevCycleButton); this.addRenderableWidget(nextCycleButton); this.addRenderableWidget(archiveButton); - // Lifetime tab controls - fromBox = new EditBox(this.font, 42, 48, 78, 18, Component.literal("From days ago")); + // Lifetime tab controls (keep toolbar non-overlapping even on compact viewports) + int finishesW = 106; + int finishesX = virtualWidth - 12 - finishesW; + int boxW = virtualWidth >= 460 ? 78 : Math.max(40, (finishesX - 180) / 2); + int fromX = 42; + toLabelX = fromX + boxW + 6; + int toX = toLabelX + 20; + int applyX = toX + boxW + 6; + int resetX = applyX + 50; + + fromBox = new EditBox(this.font, fromX, 48, boxW, 18, Component.literal("From days ago")); fromBox.setHint(Component.literal("-# days ago").withStyle(ChatFormatting.GRAY)); fromBox.setMaxLength(16); fromBox.setValue(fromDraft); - toBox = new EditBox(this.font, 146, 48, 78, 18, Component.literal("To days ago")); + toBox = new EditBox(this.font, toX, 48, boxW, 18, Component.literal("To days ago")); toBox.setHint(Component.literal("-# days ago").withStyle(ChatFormatting.GRAY)); toBox.setMaxLength(16); toBox.setValue(toDraft); - applyIntervalButton = Button.builder(Component.literal("Apply"), b -> applyInterval()).bounds(230, 48, 46, 18).build(); - resetIntervalButton = Button.builder(Component.literal("Reset"), b -> resetInterval()).bounds(280, 48, 46, 18).build(); - finishesToggleButton = Button.builder(Component.literal("Cycle Finishes"), b -> toggleFinishes()).bounds(this.width - 118, 48, 106, 18).build(); + applyIntervalButton = Button.builder(Component.literal("Apply"), b -> applyInterval()).bounds(applyX, 48, 46, 18).build(); + resetIntervalButton = Button.builder(Component.literal("Reset"), b -> resetInterval()).bounds(resetX, 48, 46, 18).build(); + finishesToggleButton = Button.builder(Component.literal("Cycle Finishes"), b -> toggleFinishes()).bounds(finishesX, 48, finishesW, 18).build(); this.addRenderableWidget(fromBox); this.addRenderableWidget(toBox); @@ -286,14 +302,11 @@ private int currentCycleIndex(List cycles, String activeCode) { @Override public void render(GuiGraphics g, int mouseX, int mouseY, float delta) { - if (uiScale != 1.0f || virtualWidth != this.width || virtualHeight != this.height) { - init(); - } int scaledMouseX = scaledMouseX(mouseX); int scaledMouseY = scaledMouseY(mouseY); pushReferencePose(g); - EdenPanelLayout.drawPanel(g, 0, 0, this.width, this.height); + EdenPanelLayout.drawPanel(g, 0, 0, virtualWidth, virtualHeight); if (activeTab == Tab.CYCLE) { renderCycleTab(g); @@ -303,7 +316,7 @@ public void render(GuiGraphics g, int mouseX, int mouseY, float delta) { super.render(g, scaledMouseX, scaledMouseY, delta); String heading = activeTab == Tab.CYCLE ? "Promotion Cycle" : "Lifetime Stats"; - g.drawCenteredString(this.font, heading, this.width / 2, 10, 0xFFFFFFFF); + g.drawCenteredString(this.font, heading, virtualWidth / 2, 10, 0xFFFFFFFF); popReferencePose(g); } @@ -312,14 +325,29 @@ private void renderCycleTab(GuiGraphics g) { String err = mod != null ? mod.recentCycleLeaderboardError() : ""; String cycleHeader = (snap != null && !snap.cycleCode().isEmpty()) ? "Cycle " + snap.cycleCode() : "Loading..."; - g.drawString(this.font, cycleHeader, 220, 29, 0xFFFFCC55); + String trimmedHeader = trimToWidth(cycleHeader, Math.max(40, virtualWidth - 232)); + g.drawString(this.font, trimmedHeader, 220, 29, 0xFFFFCC55); + if (snap != null && CycleLeaderboardData.countsPartyFinderRaids(snap.cycleCode())) { + int warnX = 220 + this.font.width(trimmedHeader) + 6; + int availW = virtualWidth - 12 - warnX; + if (availW >= 40) { + String warn = "ALL CYCLES BEFORE 2503B COUNTED BOTH PARTY FINDER AND GUILD RAIDS"; + float scale = Math.min(1.0f, availW / (float) Math.max(1, this.font.width(warn))); + int yOffset = Math.round(4.5f * (1.0f - scale)); + g.pose().pushMatrix(); + g.pose().translate(warnX, 29 + yOffset); + g.pose().scale(scale, scale); + g.drawString(this.font, warn, 0, 0, 0xFFFF5555); + g.pose().popMatrix(); + } + } if (!err.isEmpty()) { - g.drawCenteredString(this.font, err, this.width / 2, this.height / 2, 0xFFFF5555); + g.drawCenteredString(this.font, err, virtualWidth / 2, virtualHeight / 2, 0xFFFF5555); return; } if (snap == null) { - g.drawCenteredString(this.font, "Loading cycle leaderboard...", this.width / 2, this.height / 2, 0xFFAAAAAA); + g.drawCenteredString(this.font, "Loading cycle leaderboard...", virtualWidth / 2, virtualHeight / 2, 0xFFAAAAAA); return; } @@ -331,9 +359,8 @@ private void renderCycleTab(GuiGraphics g) { renderEntryList(g, true, snap.raids(), raidsScroll, true, true); renderEntryList(g, false, snap.wars(), warsScroll, true, true); - int maxFooterW = Math.max(60, bottomCloseX() - 20); String totals = "Totals: " + snap.totalRaids() + " raids | " + snap.totalWars() + " wars | " + snap.totalTickets() + " tickets"; - g.drawString(this.font, trimToWidth(totals, maxFooterW), 12, this.height - 36, 0xFFFFD966); + g.drawString(this.font, trimToWidth(totals, Math.max(60, virtualWidth - 24)), 12, virtualHeight - 36, 0xFFFFD966); if (!snap.raffleWinners().isEmpty()) { StringBuilder raffle = new StringBuilder("Raffle Top 3: "); List top = snap.raffleWinners().subList(0, Math.min(3, snap.raffleWinners().size())); @@ -343,26 +370,26 @@ private void renderCycleTab(GuiGraphics g) { } raffle.append("#").append(i + 1).append(" ").append(top.get(i).name()).append(" (").append(top.get(i).tickets()).append(")"); } - g.drawString(this.font, trimToWidth(raffle.toString(), maxFooterW), 12, this.height - 24, 0xFFD5A6FF); + int raffleMaxW = Math.max(40, closeButtonX - 20); + g.drawString(this.font, trimToWidth(raffle.toString(), raffleMaxW), 12, virtualHeight - 24, 0xFFD5A6FF); } } private void renderLifetimeTab(GuiGraphics g) { g.drawString(this.font, "From:", 12, 53, 0xFFCCCCCC); - g.drawString(this.font, "To:", 126, 53, 0xFFCCCCCC); + g.drawString(this.font, "To:", toLabelX, 53, 0xFFCCCCCC); if (!validationError.isEmpty()) { - int errMaxW = Math.max(40, (this.width - 126) - 332); - g.drawString(this.font, trimToWidth(validationError, errMaxW), 332, 53, 0xFFFF5555); + g.drawString(this.font, trimToWidth(validationError, Math.max(60, virtualWidth - 24)), 12, virtualHeight - 36, 0xFFFF5555); } CycleLeaderboardData.LifetimeSnapshot snap = mod != null ? mod.knownLifetimeLeaderboard() : null; String err = mod != null ? mod.recentLifetimeLeaderboardError() : ""; if (!err.isEmpty()) { - g.drawCenteredString(this.font, err, this.width / 2, this.height / 2 + 12, 0xFFFF5555); + g.drawCenteredString(this.font, err, virtualWidth / 2, virtualHeight / 2 + 12, 0xFFFF5555); return; } if (snap == null) { - g.drawCenteredString(this.font, "Loading leaderboard stats...", this.width / 2, this.height / 2 + 12, 0xFFAAAAAA); + g.drawCenteredString(this.font, "Loading leaderboard stats...", virtualWidth / 2, virtualHeight / 2 + 12, 0xFFAAAAAA); return; } @@ -392,17 +419,20 @@ private void renderPodium(GuiGraphics g, int x, int colW, List rawEntries) { int podiumTop = podiumTop(); int podiumH = podiumHeight(); g.fill(x, podiumTop, x + colW, podiumTop + podiumH, 0x22000000); + g.enableScissor(x, podiumTop, x + colW, podiumTop + podiumH); - int slotW = Math.clamp(colW / 3 - 4, 48, 96); + int slotW = Math.clamp(colW / 3 - 4, 34, 96); + int capW = Math.min(PODIUM_CAP_WIDTH, Math.max(18, slotW - 8)); + int headSize = Math.min(podiumH >= 118 ? PODIUM_HEAD_SIZE : 24, Math.max(16, slotW - 8)); int cx1 = x + colW / 2; int cx2 = cx1 - slotW; int cx3 = cx1 + slotW; - int maxStandH = Math.max(70, podiumH - 54); - int h2 = Math.max(52, maxStandH * 76 / 100); - int h3 = Math.max(38, maxStandH * 56 / 100); + int maxStandH = Math.max(24, podiumH - (headSize + 20)); + int h2 = Math.max(20, maxStandH * 76 / 100); + int h3 = Math.max(16, maxStandH * 56 / 100); int baseLineY = podiumTop + podiumH - 4; - int lineLeft = Math.max(x + 4, cx2 - PODIUM_CAP_WIDTH / 2 - 8); - int lineRight = Math.min(x + colW - 4, cx3 + PODIUM_CAP_WIDTH / 2 + 8); + int lineLeft = Math.max(x + 4, cx2 - capW / 2 - 8); + int lineRight = Math.min(x + colW - 4, cx3 + capW / 2 + 8); g.fill(lineLeft, baseLineY, lineRight, baseLineY + 2, 0xFF8E8E8E); g.fill(lineLeft, baseLineY + 2, lineRight, baseLineY + 3, 0xFF1E1E1E); @@ -411,7 +441,7 @@ private void renderPodium(GuiGraphics g, int x, int colW, List rawEntries) { int cx = slot == 0 ? cx2 : (slot == 1 ? cx1 : cx3); int standH = slot == 0 ? h2 : (slot == 1 ? maxStandH : h3); int standTopY = baseLineY - standH; - drawPillar(g, cx, baseLineY, PODIUM_CAP_WIDTH, standH); + drawPillar(g, cx, baseLineY, capW, standH); int entryIdx = rank - 1; if (entryIdx >= rawEntries.size()) { @@ -437,19 +467,20 @@ private void renderPodium(GuiGraphics g, int x, int colW, List rawEntries) { continue; } - int headStartX = cx - PODIUM_HEAD_SIZE / 2; - int headY = standTopY - PODIUM_HEAD_SIZE - 2; - drawPlayerFace(g, uuid, name, headStartX, headY, PODIUM_HEAD_SIZE); + int headStartX = cx - headSize / 2; + int headY = standTopY - headSize - 2; + drawPlayerFace(g, uuid, name, headStartX, headY, headSize); int halfBound = switch (rank) { - case 2 -> Math.min(cx - x - 3, slotW - PODIUM_HEAD_SIZE / 2 - 3); - case 3 -> Math.min((x + colW) - cx - 3, slotW - PODIUM_HEAD_SIZE / 2 - 3); + case 2 -> Math.min(cx - x - 3, slotW - headSize / 2 - 3); + case 3 -> Math.min((x + colW) - cx - 3, slotW - headSize / 2 - 3); default -> Math.min(colW / 2 - 4, (slotW + 28) / 2); }; int maxLabelW = Math.max(24, halfBound * 2); int maxNameW = Math.max(12, maxLabelW - this.font.width(suffix)); - g.drawCenteredString(this.font, trimToWidth(name, maxNameW) + suffix, cx, standTopY - PODIUM_HEAD_SIZE - 12, 0xFFFFFFFF); + g.drawCenteredString(this.font, trimToWidth(name, maxNameW) + suffix, cx, standTopY - headSize - 12, 0xFFFFFFFF); } + g.disableScissor(); } private void renderEntryList(GuiGraphics g, boolean left, List entries, int scrollOffset, boolean showMedals, boolean showDelta) { @@ -461,6 +492,7 @@ private void renderEntryList(GuiGraphics g, boolean left, List= 140 ? 3 : 2; + int maxPodium = Math.max(60, avail - (minRows * ROW_PITCH + 4)); + return Math.min(maxPodium, Math.clamp(avail * 56 / 100, 96, 184)); } private int listTopOffset() { @@ -601,9 +638,8 @@ private int listTopOffset() { } private int visibleRows() { - int top = listTopOffset(); - int listBottom = Math.max(top + ROW_PITCH * 4 + 4, this.height - footerReserve()); - return Math.max(4, (listBottom - top - 4) / ROW_PITCH); + int listAvail = Math.max(ROW_PITCH + 4, availableBodyHeight() - podiumHeight()); + return Math.max(1, (listAvail - 4) / ROW_PITCH); } private List leftEntries() { @@ -739,7 +775,7 @@ public boolean mouseDragged(MouseButtonEvent event, double d, double e) { updateScrollFromMouse(scaled.y(), draggingPane); return true; } - return super.mouseDragged(scaled, d, e); + return super.mouseDragged(scaled, d / uiScale, e / uiScale); } @Override diff --git a/src/tel/eden/mod/net/BridgeWebSocketClient.java b/src/tel/eden/mod/net/BridgeWebSocketClient.java index 3adc184..9efc1e1 100644 --- a/src/tel/eden/mod/net/BridgeWebSocketClient.java +++ b/src/tel/eden/mod/net/BridgeWebSocketClient.java @@ -1085,11 +1085,11 @@ public void sendLongEventStateRequest() { } /** Request a promotion-cycle leaderboard snapshot (null/blank means current cycle). */ - public void sendCycleLeaderboardRequest(String cycleCode) { + public boolean sendCycleLeaderboardRequest(String cycleCode) { WebSocket current = socket; if (current == null) { LOGGER.warn("Skipped cycleLeaderboardRequest (WebSocket disconnected)"); - return; + return false; } String target = (cycleCode != null && !cycleCode.isBlank()) ? cycleCode.trim() : ""; LOGGER.info("Sending cycleLeaderboardRequest (cycle={})", target); @@ -1098,15 +1098,15 @@ public void sendCycleLeaderboardRequest(String cycleCode) { if (cycleCode != null && !cycleCode.isBlank()) { obj.addProperty("cycleCode", cycleCode.trim()); } - enqueueSend(current, obj); + return enqueueSend(current, obj); } /** Request lifetime (or custom day-interval) Raids/Wars leaderboards and cycle finishes. */ - public void sendLifetimeLeaderboardRequest(Double fromDays, Double toDays) { + public boolean sendLifetimeLeaderboardRequest(Double fromDays, Double toDays) { WebSocket current = socket; if (current == null) { LOGGER.warn("Skipped lifetimeLeaderboardRequest (WebSocket disconnected)"); - return; + return false; } LOGGER.info("Sending lifetimeLeaderboardRequest (fromDays={}, toDays={})", fromDays, toDays); JsonObject obj = new JsonObject(); @@ -1117,7 +1117,7 @@ public void sendLifetimeLeaderboardRequest(Double fromDays, Double toDays) { if (toDays != null) { obj.addProperty("toDays", toDays); } - enqueueSend(current, obj); + return enqueueSend(current, obj); } /** Ask the backend to reroll a long-event mission slot ({@code "daily"}, {@code "weekly"}, or {@code "repeatable"}). */ diff --git a/src/tel/eden/mod/net/CycleLeaderboardData.java b/src/tel/eden/mod/net/CycleLeaderboardData.java index 819a0ab..9e120d5 100644 --- a/src/tel/eden/mod/net/CycleLeaderboardData.java +++ b/src/tel/eden/mod/net/CycleLeaderboardData.java @@ -8,6 +8,7 @@ /** Models and ranking/interval validation helpers for Promotion Cycle and Lifetime leaderboards. */ public final class CycleLeaderboardData { private static final Pattern POSITIVE_NUMBER = Pattern.compile("^\\d+(?:\\.\\d+)?$"); + private static final Pattern CYCLE_CODE = Pattern.compile("^\\d{4}[AB]$"); private CycleLeaderboardData() { } @@ -132,4 +133,45 @@ public static IntervalDays parseIntervalDays(String fromRaw, String toRaw) { } return new IntervalDays(fromVal, toVal); } + + /** Whether {@code snapshot} answers a request for {@code requestedCode} ({@code null}/empty means latest). */ + public static boolean matchesRequestedCycle(CycleSnapshot snapshot, String requestedCode) { + if (snapshot == null || !snapshot.error().isEmpty()) { + return false; + } + if (requestedCode == null || requestedCode.isBlank()) { + return snapshot.cycles().isEmpty() || snapshot.cycleCode().equals(snapshot.cycles().getLast()); + } + return requestedCode.trim().equals(snapshot.cycleCode()); + } + + /** Whether {@code snapshot} is an already-concluded historical cycle matching {@code cycleCode}. */ + public static boolean isHistoricalCycle(CycleSnapshot snapshot, String cycleCode) { + return cycleCode != null && !cycleCode.isBlank() && matchesRequestedCycle(snapshot, cycleCode) && !snapshot.cycles().isEmpty() && !cycleCode.trim().equals(snapshot.cycles().getLast()); + } + + /** Whether {@code snapshot} answers a lifetime/interval request for {@code (expectedFrom, expectedTo)}. */ + public static boolean matchesRequestedInterval(LifetimeSnapshot snapshot, Double expectedFrom, Double expectedTo) { + if (snapshot == null || !snapshot.error().isEmpty()) { + return false; + } + if (expectedFrom == null) { + return !snapshot.hasInterval(); + } + if (!snapshot.hasInterval() || snapshot.fromDays() == null) { + return false; + } + double expTo = expectedTo != null ? expectedTo : 0.0; + double actTo = snapshot.toDays() != null ? snapshot.toDays() : 0.0; + return Math.abs(expectedFrom - snapshot.fromDays()) < 1.0e-6 && Math.abs(expTo - actTo) < 1.0e-6; + } + + /** Cycles 2503A and earlier counted both Party Finder and guild raids in historical tracking. */ + public static boolean countsPartyFinderRaids(String cycleCode) { + if (cycleCode == null) { + return false; + } + String trimmed = cycleCode.trim(); + return CYCLE_CODE.matcher(trimmed).matches() && trimmed.compareTo("2503A") <= 0; + } } diff --git a/src/tel/eden/mod/util/PlayerSkinResolver.java b/src/tel/eden/mod/util/PlayerSkinResolver.java index 3c47d88..7c6062c 100644 --- a/src/tel/eden/mod/util/PlayerSkinResolver.java +++ b/src/tel/eden/mod/util/PlayerSkinResolver.java @@ -7,6 +7,7 @@ import java.util.concurrent.ConcurrentHashMap; import java.util.concurrent.ExecutorService; import java.util.concurrent.Executors; +import java.util.concurrent.atomic.AtomicInteger; import java.util.regex.Pattern; import net.minecraft.client.Minecraft; import net.minecraft.client.multiplayer.PlayerInfo; @@ -23,6 +24,8 @@ public final class PlayerSkinResolver { private static final Pattern DASHLESS_UUID = Pattern.compile("(\\p{XDigit}{8})(\\p{XDigit}{4})(\\p{XDigit}{4})(\\p{XDigit}{4})(\\p{XDigit}{12})"); private static final Map RESOLVED_SKINS = new ConcurrentHashMap<>(); private static final Map SKIN_NEXT_ATTEMPT = new ConcurrentHashMap<>(); + private static final Map IN_FLIGHT = new ConcurrentHashMap<>(); + private static final AtomicInteger SESSION_GEN = new AtomicInteger(); private static final long SKIN_RETRY_MS = 30_000L; private static final long SKIN_FAIL_RETRY_MS = 10_000L; private static final long WORKER_PACE_MS = 200L; @@ -99,7 +102,7 @@ private static PlayerSkin onlineSkin(Minecraft mc, UUID uuid, String name) { } private static void fetchSkin(Minecraft mc, UUID uuid, String name) { - if (mc == null) { + if (mc == null || IN_FLIGHT.containsKey(uuid)) { return; } long now = System.currentTimeMillis(); @@ -107,33 +110,65 @@ private static void fetchSkin(Minecraft mc, UUID uuid, String name) { if (next != null && now < next) { return; } + int gen = SESSION_GEN.get(); + if (IN_FLIGHT.putIfAbsent(uuid, gen) != null) { + return; + } + // Re-check after claiming in case reset() raced cleanly across threads. + if (gen != SESSION_GEN.get()) { + IN_FLIGHT.remove(uuid, gen); + return; + } SKIN_NEXT_ATTEMPT.put(uuid, now + SKIN_RETRY_MS); LOGGER.debug("Resolving skin for {} ({})", name, uuid); SKIN_WORKER.submit(() -> { + if (gen != SESSION_GEN.get()) { + IN_FLIGHT.remove(uuid, gen); + return; + } try { // requireSecure=true avoids Yggdrasil's 6h negative cache when rate-limited (HTTP 429). var result = mc.services().sessionService().fetchProfile(uuid, true); + if (gen != SESSION_GEN.get()) { + return; + } if (result != null && result.profile() != null) { GameProfile profile = result.profile(); - mc.execute(() -> mc.getSkinManager().get(profile).thenAccept(skin -> skin.ifPresent(value -> RESOLVED_SKINS.put(uuid, value)))); + mc.execute(() -> { + if (gen != SESSION_GEN.get()) { + return; + } + mc.getSkinManager().get(profile).thenAccept(skin -> { + if (gen == SESSION_GEN.get()) { + skin.ifPresent(value -> RESOLVED_SKINS.put(uuid, value)); + } + }); + }); } else { SKIN_NEXT_ATTEMPT.put(uuid, System.currentTimeMillis() + SKIN_FAIL_RETRY_MS); } } catch (RuntimeException e) { LOGGER.debug("Skin fetch failed for {}", uuid, e); - SKIN_NEXT_ATTEMPT.put(uuid, System.currentTimeMillis() + SKIN_FAIL_RETRY_MS); + if (gen == SESSION_GEN.get()) { + SKIN_NEXT_ATTEMPT.put(uuid, System.currentTimeMillis() + SKIN_FAIL_RETRY_MS); + } } finally { - try { - Thread.sleep(WORKER_PACE_MS); - } catch (InterruptedException ie) { - Thread.currentThread().interrupt(); + IN_FLIGHT.remove(uuid, gen); + if (gen == SESSION_GEN.get()) { + try { + Thread.sleep(WORKER_PACE_MS); + } catch (InterruptedException ie) { + Thread.currentThread().interrupt(); + } } } }); } public static void reset() { + SESSION_GEN.incrementAndGet(); RESOLVED_SKINS.clear(); SKIN_NEXT_ATTEMPT.clear(); + IN_FLIGHT.clear(); } } diff --git a/test/tel/eden/mod/net/CycleLeaderboardTest.java b/test/tel/eden/mod/net/CycleLeaderboardTest.java index 71146f3..a244950 100644 --- a/test/tel/eden/mod/net/CycleLeaderboardTest.java +++ b/test/tel/eden/mod/net/CycleLeaderboardTest.java @@ -97,4 +97,40 @@ void jsonParsersPreserveErrorStrings() { var lifeErr = BridgeWebSocketClient.parseLifetimeSnapshot(JsonParser.parseString("{\"type\":\"lifetimeLeaderboardReply\",\"error\":\"Failed to fetch leaderboard stats\"}").getAsJsonObject()); assertEquals("Failed to fetch leaderboard stats", lifeErr.error()); } + + @Test + void requestMatchingAndHistoricalCycleDetection() { + CycleLeaderboardData.CycleSnapshot archive = new CycleLeaderboardData.CycleSnapshot("2603B", List.of("2603A", "2603B", "2604A"), List.of(), List.of(), List.of(), 10, 5, 1, ""); + CycleLeaderboardData.CycleSnapshot current = new CycleLeaderboardData.CycleSnapshot("2604A", List.of("2603A", "2603B", "2604A"), List.of(), List.of(), List.of(), 20, 8, 2, ""); + + assertTrue(CycleLeaderboardData.matchesRequestedCycle(archive, "2603B")); + assertFalse(CycleLeaderboardData.matchesRequestedCycle(archive, "")); + assertFalse(CycleLeaderboardData.matchesRequestedCycle(archive, "2604A")); + assertTrue(CycleLeaderboardData.matchesRequestedCycle(current, "")); + assertTrue(CycleLeaderboardData.matchesRequestedCycle(current, "2604A")); + + assertTrue(CycleLeaderboardData.isHistoricalCycle(archive, "2603B")); + assertFalse(CycleLeaderboardData.isHistoricalCycle(archive, "")); + assertFalse(CycleLeaderboardData.isHistoricalCycle(current, "2604A")); + assertFalse(CycleLeaderboardData.isHistoricalCycle(CycleLeaderboardData.CycleSnapshot.error("err"), "2603B")); + + CycleLeaderboardData.LifetimeSnapshot interval = new CycleLeaderboardData.LifetimeSnapshot(true, 14.0, 0.0, List.of(), List.of(), List.of(), List.of(), ""); + CycleLeaderboardData.LifetimeSnapshot allTime = new CycleLeaderboardData.LifetimeSnapshot(false, null, null, List.of(), List.of(), List.of(), List.of(), ""); + assertTrue(CycleLeaderboardData.matchesRequestedInterval(interval, 14.0, 0.0)); + assertTrue(CycleLeaderboardData.matchesRequestedInterval(interval, 14.0, null)); + assertFalse(CycleLeaderboardData.matchesRequestedInterval(interval, null, null)); + assertTrue(CycleLeaderboardData.matchesRequestedInterval(allTime, null, null)); + assertFalse(CycleLeaderboardData.matchesRequestedInterval(allTime, 14.0, 0.0)); + } + + @Test + void countsPartyFinderRaidsFor2503AAndBelow() { + assertTrue(CycleLeaderboardData.countsPartyFinderRaids("2503A")); + assertTrue(CycleLeaderboardData.countsPartyFinderRaids("2501B")); + assertTrue(CycleLeaderboardData.countsPartyFinderRaids("2412B")); + assertFalse(CycleLeaderboardData.countsPartyFinderRaids("2503B")); + assertFalse(CycleLeaderboardData.countsPartyFinderRaids("2604A")); + assertFalse(CycleLeaderboardData.countsPartyFinderRaids("")); + assertFalse(CycleLeaderboardData.countsPartyFinderRaids(null)); + } } diff --git a/test/tel/eden/mod/util/PlayerSkinResolverTest.java b/test/tel/eden/mod/util/PlayerSkinResolverTest.java index 24e8e62..dc9c629 100644 --- a/test/tel/eden/mod/util/PlayerSkinResolverTest.java +++ b/test/tel/eden/mod/util/PlayerSkinResolverTest.java @@ -35,4 +35,13 @@ void parsesDashedAndDashlessUuids() { assertNull(PlayerSkinResolver.parseUuid("")); assertNull(PlayerSkinResolver.parseUuid(null)); } + + @Test + void resetSafelyBumpsGenerationAndKeepsFallbackSkinsAvailable() { + PlayerSkinResolver.reset(); + PlayerSkin skin = PlayerSkinResolver.skinFor(null, UUID.fromString("387c49fd-f06c-47b7-97a6-b97a5ecc0bd3"), "Hino1712"); + assertNotNull(skin); + PlayerSkinResolver.reset(); + assertSame(DefaultPlayerSkin.getDefaultSkin(), PlayerSkinResolver.skinFor(null, null, null)); + } } From 0b9cd53b01c0e97731467209bd4c3d4acee16a27 Mon Sep 17 00:00:00 2001 From: Good627 <193092356+Good627@users.noreply.github.com> Date: Thu, 19 Nov 2026 04:18:04 +0200 Subject: [PATCH 7/8] feat(cycle): show hover tooltip on truncated text in PromotionCycleScreen --- .../eden/mod/gui/PromotionCycleScreen.java | 47 ++++++++++++++++--- 1 file changed, 40 insertions(+), 7 deletions(-) diff --git a/src/tel/eden/mod/gui/PromotionCycleScreen.java b/src/tel/eden/mod/gui/PromotionCycleScreen.java index e368c64..8a17a76 100644 --- a/src/tel/eden/mod/gui/PromotionCycleScreen.java +++ b/src/tel/eden/mod/gui/PromotionCycleScreen.java @@ -43,6 +43,9 @@ private enum Tab { private EdenPanelLayout layout; private int closeButtonX = 12; private int toLabelX = 126; + private int hoveredMouseX; + private int hoveredMouseY; + private String hoveredCutoffText; private Tab activeTab = Tab.CYCLE; private boolean archiveOpen; @@ -304,6 +307,9 @@ private int currentCycleIndex(List cycles, String activeCode) { public void render(GuiGraphics g, int mouseX, int mouseY, float delta) { int scaledMouseX = scaledMouseX(mouseX); int scaledMouseY = scaledMouseY(mouseY); + hoveredMouseX = scaledMouseX; + hoveredMouseY = scaledMouseY; + hoveredCutoffText = null; pushReferencePose(g); EdenPanelLayout.drawPanel(g, 0, 0, virtualWidth, virtualHeight); @@ -318,6 +324,11 @@ public void render(GuiGraphics g, int mouseX, int mouseY, float delta) { String heading = activeTab == Tab.CYCLE ? "Promotion Cycle" : "Lifetime Stats"; g.drawCenteredString(this.font, heading, virtualWidth / 2, 10, 0xFFFFFFFF); popReferencePose(g); + + if (hoveredCutoffText != null) { + int tipWidth = Math.max(140, Math.min(280, this.width - 24)); + g.setTooltipForNextFrame(this.font, this.font.split(Component.literal(hoveredCutoffText), tipWidth), mouseX, mouseY); + } } private void renderCycleTab(GuiGraphics g) { @@ -326,7 +337,7 @@ private void renderCycleTab(GuiGraphics g) { String cycleHeader = (snap != null && !snap.cycleCode().isEmpty()) ? "Cycle " + snap.cycleCode() : "Loading..."; String trimmedHeader = trimToWidth(cycleHeader, Math.max(40, virtualWidth - 232)); - g.drawString(this.font, trimmedHeader, 220, 29, 0xFFFFCC55); + drawTrimmedWithHover(g, cycleHeader, 220, 29, Math.max(40, virtualWidth - 232), 0xFFFFCC55); if (snap != null && CycleLeaderboardData.countsPartyFinderRaids(snap.cycleCode())) { int warnX = 220 + this.font.width(trimmedHeader) + 6; int availW = virtualWidth - 12 - warnX; @@ -360,7 +371,7 @@ private void renderCycleTab(GuiGraphics g) { renderEntryList(g, false, snap.wars(), warsScroll, true, true); String totals = "Totals: " + snap.totalRaids() + " raids | " + snap.totalWars() + " wars | " + snap.totalTickets() + " tickets"; - g.drawString(this.font, trimToWidth(totals, Math.max(60, virtualWidth - 24)), 12, virtualHeight - 36, 0xFFFFD966); + drawTrimmedWithHover(g, totals, 12, virtualHeight - 36, Math.max(60, virtualWidth - 24), 0xFFFFD966); if (!snap.raffleWinners().isEmpty()) { StringBuilder raffle = new StringBuilder("Raffle Top 3: "); List top = snap.raffleWinners().subList(0, Math.min(3, snap.raffleWinners().size())); @@ -371,7 +382,7 @@ private void renderCycleTab(GuiGraphics g) { raffle.append("#").append(i + 1).append(" ").append(top.get(i).name()).append(" (").append(top.get(i).tickets()).append(")"); } int raffleMaxW = Math.max(40, closeButtonX - 20); - g.drawString(this.font, trimToWidth(raffle.toString(), raffleMaxW), 12, virtualHeight - 24, 0xFFD5A6FF); + drawTrimmedWithHover(g, raffle.toString(), 12, virtualHeight - 24, raffleMaxW, 0xFFD5A6FF); } } @@ -379,7 +390,7 @@ private void renderLifetimeTab(GuiGraphics g) { g.drawString(this.font, "From:", 12, 53, 0xFFCCCCCC); g.drawString(this.font, "To:", toLabelX, 53, 0xFFCCCCCC); if (!validationError.isEmpty()) { - g.drawString(this.font, trimToWidth(validationError, Math.max(60, virtualWidth - 24)), 12, virtualHeight - 36, 0xFFFF5555); + drawTrimmedWithHover(g, validationError, 12, virtualHeight - 36, Math.max(60, virtualWidth - 24), 0xFFFF5555); } CycleLeaderboardData.LifetimeSnapshot snap = mod != null ? mod.knownLifetimeLeaderboard() : null; @@ -478,7 +489,15 @@ private void renderPodium(GuiGraphics g, int x, int colW, List rawEntries) { }; int maxLabelW = Math.max(24, halfBound * 2); int maxNameW = Math.max(12, maxLabelW - this.font.width(suffix)); - g.drawCenteredString(this.font, trimToWidth(name, maxNameW) + suffix, cx, standTopY - headSize - 12, 0xFFFFFFFF); + String trimmedName = trimToWidth(name, maxNameW); + String label = trimmedName + suffix; + int labelY = standTopY - headSize - 12; + g.drawCenteredString(this.font, label, cx, labelY, 0xFFFFFFFF); + if (!trimmedName.equals(name)) { + int labelW = this.font.width(label); + int labelLeft = cx - labelW / 2; + recordCutoffHover(name + suffix, labelLeft, labelY, labelW); + } } g.disableScissor(); } @@ -538,7 +557,7 @@ private void renderEntryList(GuiGraphics g, boolean left, List= x && hoveredMouseX <= x + width && hoveredMouseY >= y - 1 && hoveredMouseY <= y + this.font.lineHeight) { + hoveredCutoffText = fullText; + } + } + private static void drawPillar(GuiGraphics g, int centerX, int baseLineY, int capW, int standH) { int evenCapW = capW & ~1; int clampedH = Math.max(24, standH); From d45885fc7c0526e178b1cfe922b3c8c7c3d41082 Mon Sep 17 00:00:00 2001 From: Good627 <193092356+Good627@users.noreply.github.com> Date: Thu, 19 Nov 2026 18:26:02 +0200 Subject: [PATCH 8/8] fix(cycle): drop diagnostic bridge logging and add cycle-end countdown timer --- src/tel/eden/mod/EdenModClient.java | 44 +++------------ .../eden/mod/gui/PromotionCycleScreen.java | 12 ++++ .../eden/mod/net/BridgeWebSocketClient.java | 22 ++------ .../eden/mod/net/CycleLeaderboardData.java | 56 ++++++++++++++++++- .../eden/mod/net/CycleLeaderboardTest.java | 15 +++++ 5 files changed, 93 insertions(+), 56 deletions(-) diff --git a/src/tel/eden/mod/EdenModClient.java b/src/tel/eden/mod/EdenModClient.java index 954d1ae..a9e831d 100644 --- a/src/tel/eden/mod/EdenModClient.java +++ b/src/tel/eden/mod/EdenModClient.java @@ -1537,7 +1537,6 @@ public void onLongEventRewards(int pendingLe, String error) { @Override public void onCycleLeaderboard(tel.eden.mod.net.CycleLeaderboardData.CycleSnapshot snapshot) { if (!isFullMember()) { - LOGGER.warn("Ignoring cycleLeaderboardReply while bridgeStatus={}", bridgeStatus); return; } if (snapshot.error() != null && !snapshot.error().isEmpty()) { @@ -1545,7 +1544,6 @@ public void onCycleLeaderboard(tel.eden.mod.net.CycleLeaderboardData.CycleSnapsh cyclePrintPendingId.set(0); pendingCycleGuiCode = null; String err = snapshot.error(); - LOGGER.error("Cycle leaderboard reply returned error: {}", err); cycleLeaderboardError = err; cycleLeaderboardErrorAtMs = System.currentTimeMillis(); cycleLeaderboardGeneration.incrementAndGet(); @@ -1580,13 +1578,11 @@ public void onCycleLeaderboard(tel.eden.mod.net.CycleLeaderboardData.CycleSnapsh @Override public void onLifetimeLeaderboard(tel.eden.mod.net.CycleLeaderboardData.LifetimeSnapshot snapshot) { if (!isFullMember()) { - LOGGER.warn("Ignoring lifetimeLeaderboardReply while bridgeStatus={}", bridgeStatus); return; } if (snapshot.error() != null && !snapshot.error().isEmpty()) { lifetimeRequestPendingId.set(0); pendingLifetimeFilter = null; - LOGGER.error("Lifetime leaderboard reply returned error: {}", snapshot.error()); lifetimeLeaderboardError = snapshot.error(); lifetimeLeaderboardErrorAtMs = System.currentTimeMillis(); lifetimeLeaderboardGeneration.incrementAndGet(); @@ -2024,7 +2020,6 @@ private void requestCycleLeaderboard(String cycleCode, boolean forPrint) { } BridgeWebSocketClient current = socket; if (!isFullMember() || current == null || !current.isConnected()) { - LOGGER.error("Cycle leaderboard request aborted before send (cycle={}, status={}, connected={})", target, bridgeStatus, current != null && current.isConnected()); failCycleLeaderboardRequest(forPrint); return; } @@ -2038,13 +2033,9 @@ private void requestCycleLeaderboard(String cycleCode, boolean forPrint) { private void scheduleCycleLeaderboardDispatch(String cycleCode, long seq, boolean forPrint, long delayMs) { partyCommandExecutor.schedule(() -> { - try { - long latest = forPrint ? cyclePrintSeq.get() : cycleGuiSeq.get(); - if (latest == seq) { - dispatchCycleLeaderboardRequest(cycleCode, seq, forPrint); - } - } catch (RuntimeException e) { - LOGGER.error("Scheduled cycle leaderboard dispatch failed (seq={}, cycle={})", seq, cycleCode, e); + long latest = forPrint ? cyclePrintSeq.get() : cycleGuiSeq.get(); + if (latest == seq) { + dispatchCycleLeaderboardRequest(cycleCode, seq, forPrint); } }, delayMs, TimeUnit.MILLISECONDS); } @@ -2054,7 +2045,6 @@ private void dispatchCycleLeaderboardRequest(String cycleCode, long seq, boolean if (!isFullMember() || current == null || !current.isConnected()) { long latest = forPrint ? cyclePrintSeq.get() : cycleGuiSeq.get(); if (latest == seq) { - LOGGER.error("Cycle leaderboard deferred send aborted (seq={}, cycle={}, status={}, connected={})", seq, cycleCode, bridgeStatus, current != null && current.isConnected()); failCycleLeaderboardRequest(forPrint); } return; @@ -2084,13 +2074,8 @@ private void dispatchCycleLeaderboardRequest(String cycleCode, long seq, boolean return; } partyCommandExecutor.schedule(() -> { - try { - if (pendingSlot.compareAndSet(seq, 0)) { - LOGGER.error("Cycle leaderboard request timed out after {}s (seq={}, cycle={}, forPrint={}, status={}, connected={}) — no reply from backend", LEADERBOARD_TIMEOUT_SECONDS, seq, cycleCode, forPrint, bridgeStatus, socket != null && socket.isConnected()); - failCycleLeaderboardRequest(forPrint); - } - } catch (RuntimeException e) { - LOGGER.error("Cycle leaderboard timeout task failed (seq={}, cycle={})", seq, cycleCode, e); + if (pendingSlot.compareAndSet(seq, 0)) { + failCycleLeaderboardRequest(forPrint); } }, LEADERBOARD_TIMEOUT_SECONDS, TimeUnit.SECONDS); } @@ -2117,7 +2102,6 @@ public void requestLifetimeLeaderboard(Double fromDays, Double toDays) { pendingLifetimeFilter = new LifetimeFilter(fromDays, toDays); BridgeWebSocketClient current = socket; if (!isFullMember() || current == null || !current.isConnected()) { - LOGGER.error("Lifetime leaderboard request aborted before send (fromDays={}, toDays={}, status={}, connected={})", fromDays, toDays, bridgeStatus, current != null && current.isConnected()); failLifetimeLeaderboardRequest(); return; } @@ -2127,12 +2111,8 @@ public void requestLifetimeLeaderboard(Double fromDays, Double toDays) { return; } partyCommandExecutor.schedule(() -> { - try { - if (lifetimeRequestSeq.get() == seq) { - dispatchLifetimeLeaderboardRequest(fromDays, toDays, seq); - } - } catch (RuntimeException e) { - LOGGER.error("Scheduled lifetime leaderboard dispatch failed (seq={}, fromDays={}, toDays={})", seq, fromDays, toDays, e); + if (lifetimeRequestSeq.get() == seq) { + dispatchLifetimeLeaderboardRequest(fromDays, toDays, seq); } }, delayMs, TimeUnit.MILLISECONDS); } @@ -2141,7 +2121,6 @@ private void dispatchLifetimeLeaderboardRequest(Double fromDays, Double toDays, BridgeWebSocketClient current = socket; if (!isFullMember() || current == null || !current.isConnected()) { if (lifetimeRequestSeq.get() == seq) { - LOGGER.error("Lifetime leaderboard deferred send aborted (seq={}, fromDays={}, toDays={}, status={}, connected={})", seq, fromDays, toDays, bridgeStatus, current != null && current.isConnected()); failLifetimeLeaderboardRequest(); } return; @@ -2157,13 +2136,8 @@ private void dispatchLifetimeLeaderboardRequest(Double fromDays, Double toDays, return; } partyCommandExecutor.schedule(() -> { - try { - if (lifetimeRequestPendingId.compareAndSet(seq, 0)) { - LOGGER.error("Lifetime leaderboard request timed out after {}s (seq={}, fromDays={}, toDays={}, status={}, connected={}) — no reply from backend", LEADERBOARD_TIMEOUT_SECONDS, seq, fromDays, toDays, bridgeStatus, socket != null && socket.isConnected()); - failLifetimeLeaderboardRequest(); - } - } catch (RuntimeException e) { - LOGGER.error("Lifetime leaderboard timeout task failed (seq={}, fromDays={}, toDays={})", seq, fromDays, toDays, e); + if (lifetimeRequestPendingId.compareAndSet(seq, 0)) { + failLifetimeLeaderboardRequest(); } }, LEADERBOARD_TIMEOUT_SECONDS, TimeUnit.SECONDS); } diff --git a/src/tel/eden/mod/gui/PromotionCycleScreen.java b/src/tel/eden/mod/gui/PromotionCycleScreen.java index 8a17a76..0d8a64e 100644 --- a/src/tel/eden/mod/gui/PromotionCycleScreen.java +++ b/src/tel/eden/mod/gui/PromotionCycleScreen.java @@ -362,6 +362,18 @@ private void renderCycleTab(GuiGraphics g) { return; } + String endsText = CycleLeaderboardData.cycleEndText(snap, System.currentTimeMillis()); + if (!endsText.isEmpty()) { + int headingRight = virtualWidth / 2 + this.font.width("Promotion Cycle") / 2 + 8; + int maxTimerW = virtualWidth - 12 - headingRight; + if (maxTimerW >= 40) { + int textW = Math.min(maxTimerW, this.font.width(endsText)); + int timerX = Math.max(headingRight, virtualWidth - 12 - textW); + int timerColor = endsText.startsWith("Ends in ") ? 0xFFCCCCCC : 0xFFAAAAAA; + drawTrimmedWithHover(g, endsText, timerX, 10, maxTimerW, timerColor); + } + } + int colW = colWidth(); int titleY = titleY(); g.drawCenteredString(this.font, "Raids", colX(true) + colW / 2, titleY, 0xFF55FFFF); diff --git a/src/tel/eden/mod/net/BridgeWebSocketClient.java b/src/tel/eden/mod/net/BridgeWebSocketClient.java index 490fcee..2438d16 100644 --- a/src/tel/eden/mod/net/BridgeWebSocketClient.java +++ b/src/tel/eden/mod/net/BridgeWebSocketClient.java @@ -338,17 +338,11 @@ public boolean isConnected() { * swallows a prior failure so one bad send can't wedge every send after it. */ private synchronized boolean enqueueSend(WebSocket ws, JsonObject obj) { - String type = get(obj, "type"); - if (!OutboundPolicy.allowed(standing, type)) { - LOGGER.warn("Blocked outbound {} frame under standing={} (authenticated={})", type, standing, authenticated); + if (!OutboundPolicy.allowed(standing, get(obj, "type"))) { return false; } String text = obj.toString(); - sendChain = sendChain.handle((v, ex) -> null).thenCompose(ignored -> ws.sendText(text, true)).whenComplete((v, err) -> { - if (err != null) { - LOGGER.error("Failed to send {} WebSocket frame: {}", type, err.toString(), err); - } - }); + sendChain = sendChain.handle((v, ex) -> null).thenCompose(ignored -> ws.sendText(text, true)); return true; } @@ -1088,11 +1082,8 @@ public void sendLongEventStateRequest() { public boolean sendCycleLeaderboardRequest(String cycleCode) { WebSocket current = socket; if (current == null) { - LOGGER.warn("Skipped cycleLeaderboardRequest (WebSocket disconnected)"); return false; } - String target = (cycleCode != null && !cycleCode.isBlank()) ? cycleCode.trim() : ""; - LOGGER.info("Sending cycleLeaderboardRequest (cycle={})", target); JsonObject obj = new JsonObject(); obj.addProperty("type", "cycleLeaderboardRequest"); if (cycleCode != null && !cycleCode.isBlank()) { @@ -1105,10 +1096,8 @@ public boolean sendCycleLeaderboardRequest(String cycleCode) { public boolean sendLifetimeLeaderboardRequest(Double fromDays, Double toDays) { WebSocket current = socket; if (current == null) { - LOGGER.warn("Skipped lifetimeLeaderboardRequest (WebSocket disconnected)"); return false; } - LOGGER.info("Sending lifetimeLeaderboardRequest (fromDays={}, toDays={})", fromDays, toDays); JsonObject obj = new JsonObject(); obj.addProperty("type", "lifetimeLeaderboardRequest"); if (fromDays != null) { @@ -1583,7 +1572,6 @@ private void handlePayload(String payload) { JsonObject obj = JsonParser.parseString(payload).getAsJsonObject(); String inboundType = get(obj, "type"); if (!OutboundPolicy.inboundAllowed(standing, inboundType)) { - LOGGER.warn("Dropped inbound {} frame under standing={}", inboundType, standing); return; } switch (inboundType) { @@ -1672,7 +1660,7 @@ private void handlePayload(String payload) { /* ignore unknown types */ } } } catch (RuntimeException e) { - LOGGER.error("Failed to handle inbound bridge payload: {}", e.toString(), e); + LOGGER.debug("Ignoring malformed inbound payload", e); } } @@ -1990,7 +1978,6 @@ private static Integer getOptionalInt(JsonObject obj, String key) { try { return obj.has(key) && !obj.get(key).isJsonNull() ? obj.get(key).getAsInt() : null; } catch (RuntimeException e) { - LOGGER.warn("Ignoring malformed integer field {}: {}", key, e.toString()); return null; } } @@ -1999,7 +1986,6 @@ private static Double getOptionalDouble(JsonObject obj, String key) { try { return obj.has(key) && !obj.get(key).isJsonNull() ? obj.get(key).getAsDouble() : null; } catch (RuntimeException e) { - LOGGER.warn("Ignoring malformed double field {}: {}", key, e.toString()); return null; } } @@ -2048,7 +2034,7 @@ static CycleLeaderboardData.CycleSnapshot parseCycleSnapshot(JsonObject obj) { if (!error.isEmpty()) { return CycleLeaderboardData.CycleSnapshot.error(error); } - return new CycleLeaderboardData.CycleSnapshot(get(obj, "cycleCode"), getStringArray(obj, "cycles"), parseLeaderboardEntries(obj, "raids"), parseLeaderboardEntries(obj, "wars"), parseRaffleWinners(obj), getInt(obj, "totalRaids", 0), getInt(obj, "totalWars", 0), getInt(obj, "totalTickets", 0), ""); + return new CycleLeaderboardData.CycleSnapshot(get(obj, "cycleCode"), getStringArray(obj, "cycles"), parseLeaderboardEntries(obj, "raids"), parseLeaderboardEntries(obj, "wars"), parseRaffleWinners(obj), getInt(obj, "totalRaids", 0), getInt(obj, "totalWars", 0), getInt(obj, "totalTickets", 0), getLong(obj, "endedAtMs", 0L), getBool(obj, "finalized"), ""); } static CycleLeaderboardData.LifetimeSnapshot parseLifetimeSnapshot(JsonObject obj) { diff --git a/src/tel/eden/mod/net/CycleLeaderboardData.java b/src/tel/eden/mod/net/CycleLeaderboardData.java index 9e120d5..9d998f8 100644 --- a/src/tel/eden/mod/net/CycleLeaderboardData.java +++ b/src/tel/eden/mod/net/CycleLeaderboardData.java @@ -1,14 +1,18 @@ package tel.eden.mod.net; +import java.time.DateTimeException; +import java.time.LocalDate; +import java.time.ZoneOffset; import java.util.ArrayList; import java.util.Comparator; import java.util.List; +import java.util.regex.Matcher; import java.util.regex.Pattern; /** Models and ranking/interval validation helpers for Promotion Cycle and Lifetime leaderboards. */ public final class CycleLeaderboardData { private static final Pattern POSITIVE_NUMBER = Pattern.compile("^\\d+(?:\\.\\d+)?$"); - private static final Pattern CYCLE_CODE = Pattern.compile("^\\d{4}[AB]$"); + private static final Pattern CYCLE_CODE = Pattern.compile("^(\\d{2})(\\d{2})([AB])$"); private CycleLeaderboardData() { } @@ -30,9 +34,13 @@ public record IntervalDays(double fromDays, double toDays) { } /** Snapshot returned by {@code cycleLeaderboardReply}. */ - public record CycleSnapshot(String cycleCode, List cycles, List raids, List wars, List raffleWinners, int totalRaids, int totalWars, int totalTickets, String error) { + public record CycleSnapshot(String cycleCode, List cycles, List raids, List wars, List raffleWinners, int totalRaids, int totalWars, int totalTickets, long endedAtMs, boolean finalized, String error) { + public CycleSnapshot(String cycleCode, List cycles, List raids, List wars, List raffleWinners, int totalRaids, int totalWars, int totalTickets, String error) { + this(cycleCode, cycles, raids, wars, raffleWinners, totalRaids, totalWars, totalTickets, 0L, false, error); + } + public static CycleSnapshot error(String message) { - return new CycleSnapshot("", List.of(), List.of(), List.of(), List.of(), 0, 0, 0, message); + return new CycleSnapshot("", List.of(), List.of(), List.of(), List.of(), 0, 0, 0, 0L, false, message); } } @@ -174,4 +182,46 @@ public static boolean countsPartyFinderRaids(String cycleCode) { String trimmed = cycleCode.trim(); return CYCLE_CODE.matcher(trimmed).matches() && trimmed.compareTo("2503A") <= 0; } + + /** Resolve the cycle's end timestamp in epoch ms (falling back to UTC half-month boundaries from {@code cycleCode}). */ + public static long cycleEndEpochMs(CycleSnapshot snapshot) { + if (snapshot == null) { + return 0L; + } + if (snapshot.endedAtMs() > 0L) { + return snapshot.endedAtMs(); + } + String code = snapshot.cycleCode(); + if (code == null) { + return 0L; + } + Matcher m = CYCLE_CODE.matcher(code.trim()); + if (!m.matches()) { + return 0L; + } + int year = 2000 + Integer.parseInt(m.group(1)); + int month = Integer.parseInt(m.group(2)); + try { + LocalDate endDate = "A".equals(m.group(3)) ? LocalDate.of(year, month, 15) : LocalDate.of(year, month, 1).plusMonths(1); + return endDate.atStartOfDay(ZoneOffset.UTC).toInstant().toEpochMilli(); + } catch (DateTimeException e) { + return 0L; + } + } + + /** Format the cycle-end countdown (or {@code "Ended"} once concluded), or empty if unknown. */ + public static String cycleEndText(CycleSnapshot snapshot, long nowMs) { + if (snapshot == null) { + return ""; + } + long endMs = cycleEndEpochMs(snapshot); + if (endMs <= 0L) { + return snapshot.finalized() ? "Ended" : ""; + } + if (snapshot.finalized() || isHistoricalCycle(snapshot, snapshot.cycleCode())) { + return "Ended"; + } + long remainingMs = endMs - nowMs; + return remainingMs > 0L ? "Ends in " + LongEventState.formatCountdown(remainingMs, true) : "Ended"; + } } diff --git a/test/tel/eden/mod/net/CycleLeaderboardTest.java b/test/tel/eden/mod/net/CycleLeaderboardTest.java index a244950..c131419 100644 --- a/test/tel/eden/mod/net/CycleLeaderboardTest.java +++ b/test/tel/eden/mod/net/CycleLeaderboardTest.java @@ -133,4 +133,19 @@ void countsPartyFinderRaidsFor2503AAndBelow() { assertFalse(CycleLeaderboardData.countsPartyFinderRaids("")); assertFalse(CycleLeaderboardData.countsPartyFinderRaids(null)); } + + @Test + void cycleEndTimerUsesPayloadAndUtcFallback() { + long explicitEnd = java.time.Instant.parse("2026-12-01T00:00:00Z").toEpochMilli(); + var parsed = BridgeWebSocketClient.parseCycleSnapshot(JsonParser.parseString("{\"type\":\"cycleLeaderboardReply\",\"cycleCode\":\"2611B\",\"cycles\":[\"2611A\",\"2611B\"],\"endedAtMs\":" + explicitEnd + ",\"finalized\":false}").getAsJsonObject()); + assertEquals(explicitEnd, CycleLeaderboardData.cycleEndEpochMs(parsed)); + assertEquals("Ends in 1d 02:03:04", CycleLeaderboardData.cycleEndText(parsed, explicitEnd - ((86_400L + 7_200L + 180L + 4L) * 1000L))); + assertEquals("Ended", CycleLeaderboardData.cycleEndText(parsed, explicitEnd)); + + CycleLeaderboardData.CycleSnapshot decFallback = new CycleLeaderboardData.CycleSnapshot("2612B", List.of("2612A", "2612B"), List.of(), List.of(), List.of(), 0, 0, 0, ""); + assertEquals(java.time.Instant.parse("2027-01-01T00:00:00Z").toEpochMilli(), CycleLeaderboardData.cycleEndEpochMs(decFallback)); + + CycleLeaderboardData.CycleSnapshot finalized = new CycleLeaderboardData.CycleSnapshot("2611B", List.of("2611B"), List.of(), List.of(), List.of(), 0, 0, 0, explicitEnd, true, ""); + assertEquals("Ended", CycleLeaderboardData.cycleEndText(finalized, explicitEnd - 60_000L)); + } }