From 7e526e9fd982c62ae2b0002bb7f2775008f3c87d Mon Sep 17 00:00:00 2001 From: Diogo Esteves Date: Mon, 16 Nov 2026 13:40:33 +0000 Subject: [PATCH 1/3] test(corpus): record the installed corpus with 0.10.0's token readers The weekly installed-types corpus job has failed every Monday since 2026-10-26 with the same counts. ee231a8 (in 0.10.0) changed what onsystem reads, regenerated corpus/snapshot.json, and left corpus/snapshot-installed.json as 0.7.0 wrote it, since the installed job does not run on pull requests. Run at ee231a8's parent, the installed corpus matches the old snapshot; at ee231a8, at 6425861 and at d00ccad it gives the same counts as the failing runs. The new counts are the ones snapshot.json has had since ee231a8 for the same repositories: - Dub (Tailwind 3, no borderRadius in its config) gets Tailwind's default radius scale, 7 tokens, so off-scale radii such as rounded-[10px] are reported as warnings: 47 in apps/web, 5 in packages/ui, 52 from the root. - saas-starter has 32 color tokens instead of 40: the codemod's `@theme { --color-x: hsl(var(--x)) }` entries are now aliases of the variables they wrap. Written with `node scripts/corpus.mjs --installed --update` at d00ccad. --- corpus/snapshot-installed.json | 45 ++++++++++++++++++++++++++-------- 1 file changed, 35 insertions(+), 10 deletions(-) diff --git a/corpus/snapshot-installed.json b/corpus/snapshot-installed.json index 0ce7123a..a4fd77ab 100644 --- a/corpus/snapshot-installed.json +++ b/corpus/snapshot-installed.json @@ -1,6 +1,6 @@ { "$comment": "Written by `node scripts/corpus.mjs --installed --update`. Counts per run and rule with the dependencies installed from each repository's lockfile, as bench/v2 installs them; `labels` records which labelled findings were reported.", - "version": "0.7.0", + "version": "0.12.1", "runs": { "saas-starter-installed": { "inspect": { @@ -9,7 +9,7 @@ "components": 7, "parts": 23, "tokens": { - "color": 40, + "color": 32, "radius": 8, "spacing": 1 }, @@ -336,12 +336,13 @@ "components": 430, "parts": 17, "tokens": { - "color": 24 + "color": 24, + "radius": 7 }, "warnings": 1 }, "files": 1484, - "flagged": 1009, + "flagged": 1011, "rules": { "icon-button-accessible-name": { "errors": 52, @@ -353,6 +354,11 @@ "warnings": 245, "fixes": 6726 }, + "no-hardcoded-radius": { + "errors": 0, + "warnings": 47, + "fixes": 47 + }, "no-unknown-prop": { "errors": 4, "warnings": 0, @@ -372,7 +378,8 @@ "components": 430, "parts": 17, "tokens": { - "color": 24 + "color": 24, + "radius": 7 }, "warnings": 1 }, @@ -389,6 +396,11 @@ "warnings": 11, "fixes": 137 }, + "no-hardcoded-radius": { + "errors": 0, + "warnings": 5, + "fixes": 5 + }, "prefer-design-system-component": { "errors": 15, "warnings": 0, @@ -403,12 +415,13 @@ "components": 108, "parts": 17, "tokens": { - "color": 24 + "color": 24, + "radius": 7 }, "warnings": 0 }, "files": 1422, - "flagged": 989, + "flagged": 991, "rules": { "icon-button-accessible-name": { "errors": 56, @@ -420,6 +433,11 @@ "warnings": 215, "fixes": 6726 }, + "no-hardcoded-radius": { + "errors": 0, + "warnings": 47, + "fixes": 47 + }, "no-unknown-prop": { "errors": 4, "warnings": 0, @@ -442,7 +460,8 @@ "components": 430, "parts": 17, "tokens": { - "color": 24 + "color": 24, + "radius": 7 }, "warnings": 1 }, @@ -460,7 +479,8 @@ "components": 430, "parts": 17, "tokens": { - "color": 24 + "color": 24, + "radius": 7 }, "warnings": 1 } @@ -468,7 +488,7 @@ "others": 8 }, "files": 1521, - "flagged": 1029, + "flagged": 1031, "rules": { "icon-button-accessible-name": { "errors": 54, @@ -480,6 +500,11 @@ "warnings": 256, "fixes": 6863 }, + "no-hardcoded-radius": { + "errors": 0, + "warnings": 52, + "fixes": 52 + }, "no-unknown-prop": { "errors": 4, "warnings": 0, From 321c8a2c7f2f43b8c665dc8ade43020774944649 Mon Sep 17 00:00:00 2001 From: Diogo Esteves Date: Mon, 16 Nov 2026 13:40:33 +0000 Subject: [PATCH 2/3] chore(deps): take minimatch 11 for the lint, and drop unused release-age exclusions Dependabot alert #19, GHSA-g3hv-75wg-m249 (moderate, dev): minimatch 7 to 11.0.0 amplifies patterns with **/.. portions, and only 11.0.1 fixes it. ESLint 10, its @eslint/config-array and typescript-eslint's typescript-estree ask for ^10, so an override in pnpm-workspace.yaml takes 11.0.8, with a comment on why it is safe and when to remove it. They use minimatch(), new Minimatch(), match() and pattern, which 11 keeps. ESLint reports the same, file for file, for the root and the site with it. ESLint 9's minimatch 3 is outside the advisory. minimumReleaseAgeExclude loses the entries for typescript-eslint 8.71.1 and ondocs 0.10.0, which are no longer in the lockfile. The Radix entries stay: those versions still are. --- pnpm-lock.yaml | 23 ++++++++++++++++------- pnpm-workspace.yaml | 21 +++++++++------------ 2 files changed, 25 insertions(+), 19 deletions(-) diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 0ddb4e4d..885714ab 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -4,6 +4,9 @@ settings: autoInstallPeers: true excludeLinksFromLockfile: false +overrides: + minimatch@>=7 <11.0.1: ^11.0.1 + importers: .: @@ -772,6 +775,9 @@ packages: '@internationalized/string@3.2.10': resolution: {integrity: sha512-PDx6//vHSpRnHfxqMqto11zQvhsaU74O3mKv2F/0eicGZcl9NLjQmGlbHz/LsJh5tLKp4A4L7ZVTzN1/MmMTvA==} + '@isaacs/nonrecursive-glob-match@1.1.0': + resolution: {integrity: sha512-GPm/Dbvk5RLmhRnxXIa7nTpK0xtl4E0wj0MslsuNiJ1FIROU+2+9lgUC/dgF7Ey4QCWhfEsgxilMRMCdHPfDfw==} + '@istanbuljs/schema@0.1.6': resolution: {integrity: sha512-+Sg6GCR/wy1oSmQDFq4LQDAhm3ETKnorxN+y5nbLULOR3P0c14f2Wurzj3/xqPXtasLFfHd5iRFQ7AJt4KH2cw==} engines: {node: '>=8'} @@ -2789,9 +2795,9 @@ packages: resolution: {integrity: sha512-Lbgzdk0h4juoQ9fCKXW4by0UJqj+nOOrI9MJ1sSj4nI8aI2eo1qmvQEie4VD1glsS250n15LsWsYtCugiStS5A==} engines: {node: '>=18'} - minimatch@10.2.6: - resolution: {integrity: sha512-vpLQEs+VLCr1nU0BXS07maYoFwlDAH0gngQuuttxIwutDFEMHq2blX+8vpgxDdK3J1PwjCJiep77OitTZ4Ll1A==} - engines: {node: 18 || 20 || >=22} + minimatch@11.0.8: + resolution: {integrity: sha512-nFQuYSTVrGvysVBps5Ih+0BdnYFN/Cj3C816r6+p7yK+FHrVLGE4O4N9AFwykrlNlvM2HYt+Rad1Uiro6h88Ig==} + engines: {node: 20 || >=22} minimatch@3.1.5: resolution: {integrity: sha512-VgjWUsnnT6n+NUk6eZq77zeFdpW2LWDzP6zFGrCbHXiYNul5Dzqk2HHQ5uFH2DNW5Xbp8+jVzaeNt94ssEEl4w==} @@ -4109,7 +4115,7 @@ snapshots: dependencies: '@eslint/object-schema': 3.0.5 debug: 4.4.3 - minimatch: 10.2.6 + minimatch: 11.0.8 transitivePeerDependencies: - supports-color @@ -4302,6 +4308,8 @@ snapshots: dependencies: '@swc/helpers': 0.5.23 + '@isaacs/nonrecursive-glob-match@1.1.0': {} + '@istanbuljs/schema@0.1.6': {} '@jridgewell/gen-mapping@0.3.13': @@ -4924,7 +4932,7 @@ snapshots: '@typescript-eslint/types': 8.72.2 '@typescript-eslint/visitor-keys': 8.72.2 debug: 4.4.3 - minimatch: 10.2.6 + minimatch: 11.0.8 semver: 7.8.5 tinyglobby: 0.2.17 ts-api-utils: 2.5.0(typescript@6.0.3) @@ -5563,7 +5571,7 @@ snapshots: imurmurhash: 0.1.4 is-glob: 4.0.3 json-stable-stringify-without-jsonify: 1.0.1 - minimatch: 10.2.6 + minimatch: 11.0.8 natural-compare: 1.4.0 optionator: 0.9.4 optionalDependencies: @@ -6275,8 +6283,9 @@ snapshots: dependencies: mime-db: 1.54.0 - minimatch@10.2.6: + minimatch@11.0.8: dependencies: + '@isaacs/nonrecursive-glob-match': 1.1.0 brace-expansion: 5.0.12 minimatch@3.1.5: diff --git a/pnpm-workspace.yaml b/pnpm-workspace.yaml index f69601b9..1d9c82ae 100644 --- a/pnpm-workspace.yaml +++ b/pnpm-workspace.yaml @@ -3,17 +3,6 @@ packages: - examples/* - site minimumReleaseAgeExclude: - - '@typescript-eslint/eslint-plugin@8.71.1' - - '@typescript-eslint/parser@8.71.1' - - '@typescript-eslint/project-service@8.71.1' - - '@typescript-eslint/scope-manager@8.71.1' - - '@typescript-eslint/tsconfig-utils@8.71.1' - - '@typescript-eslint/type-utils@8.71.1' - - '@typescript-eslint/types@8.71.1' - - '@typescript-eslint/typescript-estree@8.71.1' - - '@typescript-eslint/utils@8.71.1' - - '@typescript-eslint/visitor-keys@8.71.1' - - typescript-eslint@8.71.1 - '@radix-ui/react-dialog@1.2.0' - '@radix-ui/react-dismissable-layer@1.1.20' - '@radix-ui/react-focus-scope@1.2.0' @@ -21,4 +10,12 @@ minimumReleaseAgeExclude: - '@radix-ui/react-presence@1.1.11' - '@radix-ui/react-primitive@2.1.11' - '@radix-ui/react-slot@1.4.0' - - ondocs@0.10.0 +overrides: + # Moderate GHSA-g3hv-75wg-m249: a pattern with **/.. portions makes minimatch 7 to 11.0.0 build + # an amplified set of patterns and compare them in pairs, and only 11.0.1 fixes it. The lint's + # dependencies ask for ^10: ESLint 10 and its @eslint/config-array, and typescript-eslint's + # typescript-estree (only for allowDefaultProject, which neither ESLint config sets). They call + # minimatch(), new Minimatch(), its match() and its pattern, which 11 keeps (it removes makeRe(), + # the regexp property and the AST class), and `pnpm lint` reports the same with it. Take it out + # once ESLint and typescript-eslint ask for 11. ESLint 9's minimatch 3 is not affected. + 'minimatch@>=7 <11.0.1': ^11.0.1 From b5991e02d8c4f41f523ba3633b725a38cfd3c1a7 Mon Sep 17 00:00:00 2001 From: Diogo Esteves Date: Mon, 16 Nov 2026 13:42:50 +0000 Subject: [PATCH 3/3] chore(deps): say when the minimatch override can go: ESLint 10.15 already asks for 11 --- pnpm-workspace.yaml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pnpm-workspace.yaml b/pnpm-workspace.yaml index 1d9c82ae..6d1d22ea 100644 --- a/pnpm-workspace.yaml +++ b/pnpm-workspace.yaml @@ -16,6 +16,7 @@ overrides: # dependencies ask for ^10: ESLint 10 and its @eslint/config-array, and typescript-eslint's # typescript-estree (only for allowDefaultProject, which neither ESLint config sets). They call # minimatch(), new Minimatch(), its match() and its pattern, which 11 keeps (it removes makeRe(), - # the regexp property and the AST class), and `pnpm lint` reports the same with it. Take it out - # once ESLint and typescript-eslint ask for 11. ESLint 9's minimatch 3 is not affected. + # the regexp property and the AST class), and `pnpm lint` reports the same with it. ESLint 10.15 + # and config-array 0.23.6 ask for ^11.0.5: take it out once the lockfile has them and + # typescript-eslint asks for 11 too. ESLint 9's minimatch 3 is not affected. 'minimatch@>=7 <11.0.1': ^11.0.1