Skip to content

Commit 36d3df1

Browse files
committed
fix(ci): collapse setup.py formatting for current ruff; pure-python protobuf for train
CI's ruff (latest) collapses the short find_namespace_packages call that older local ruff accepted multi-line. train (3.9) hit the tensorboard-vs-protobuf>=4 'Descriptors cannot be created directly' clash — PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION=python on the train job avoids it without pinning protobuf in packaging.
1 parent 5e0e6aa commit 36d3df1

3 files changed

Lines changed: 6 additions & 6 deletions

File tree

‎.github/workflows/python-arabic.yml‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,10 @@ jobs:
5050
5151
train:
5252
runs-on: ubuntu-latest
53+
env:
54+
# tensorboard's generated descriptors predate protobuf 4; the pure-python
55+
# implementation tolerates them without pinning protobuf
56+
PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION: python
5357
strategy:
5458
fail-fast: false
5559
matrix:

‎python/arabic/setup.py‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,7 @@
2121
author_email="[email protected]",
2222
license="MIT",
2323
description="Rababa for Arabic diacriticization",
24-
packages=setuptools.find_namespace_packages(
25-
include=["util*", "modules*"]
26-
),
24+
packages=setuptools.find_namespace_packages(include=["util*", "modules*"]),
2725
url="https://www.interscript.org",
2826
python_requires=">=3.6, <4",
2927
project_urls={

‎python/hebrew/setup.py‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,7 @@
2121
author_email="[email protected]",
2222
license="MIT",
2323
description="Rababa for Arabic diacriticization",
24-
packages=setuptools.find_namespace_packages(
25-
include=["util*", "modules*"]
26-
),
24+
packages=setuptools.find_namespace_packages(include=["util*", "modules*"]),
2725
url="https://www.interscript.org",
2826
python_requires=">=3.6, <4",
2927
project_urls={

0 commit comments

Comments
 (0)