diff --git a/newsfragments/+readlink-unc.bugfix.rst b/newsfragments/+readlink-unc.bugfix.rst new file mode 100644 index 0000000..246d756 --- /dev/null +++ b/newsfragments/+readlink-unc.bugfix.rst @@ -0,0 +1 @@ +Preserve the leading double backslash when normalizing extended UNC targets in ``Path.readlink()``. diff --git a/path/__init__.py b/path/__init__.py index 731e88e..77ac21b 100644 --- a/path/__init__.py +++ b/path/__init__.py @@ -1480,7 +1480,12 @@ def readlink(self) -> Self: .. seealso:: :meth:`readlinkabs`, :func:`os.readlink` """ - return self._next_class(os.readlink(self).removeprefix('\\\\?\\')) + target = os.readlink(self) + if target.startswith('\\\\?\\UNC\\'): + target = '\\\\' + target.removeprefix('\\\\?\\UNC\\') + else: + target = target.removeprefix('\\\\?\\') + return self._next_class(target) def readlinkabs(self) -> Self: """Return the path to which this symbolic link points. diff --git a/tests/test_path.py b/tests/test_path.py index 55d733c..207db77 100644 --- a/tests/test_path.py +++ b/tests/test_path.py @@ -348,6 +348,21 @@ def test_get_owner(self): class TestLinks: + @pytest.mark.parametrize( + ('target', 'expected'), + [ + (r'\\?\UNC\server\share\file', r'\\server\share\file'), + (r'\\?\C:\folder\file', r'C:\folder\file'), + (r'\\server\share\file', r'\\server\share\file'), + ('relative-file', 'relative-file'), + ], + ) + def test_readlink_windows_prefixes(self, monkeypatch, target, expected): + monkeypatch.setattr(os, 'readlink', lambda _: target) + result = Path('link').readlink() + assert result == expected + assert isinstance(result, Path) + def test_hardlink_to(self, tmpdir): target = Path(tmpdir) / 'target' target.write_text('hello', encoding='utf-8')