From 551ed5a5fbab32916129bf68504c657e883a6283 Mon Sep 17 00:00:00 2001
From: IanHollow <72767437+IanHollow@users.noreply.github.com>
Date: Fri, 16 Oct 2026 21:27:32 -0700
Subject: [PATCH] Fix pytest completion list separators

Semicolons silently omit the second choice on Nu 0.115.1 and fail parsing on Nu 0.116.1. Use comma-separated lists and cover both providers and actual command-line completion values.

Validated module parsing, standalone assertions and toolkit check pr on both Nushell versions.
---
 custom-completions/pytest/pytest-completions.nu       | 4 ++--
 custom-completions/pytest/tests/pytest-completions.nu | 9 +++++++++
 2 files changed, 11 insertions(+), 2 deletions(-)
 create mode 100644 custom-completions/pytest/tests/pytest-completions.nu

diff --git a/custom-completions/pytest/pytest-completions.nu b/custom-completions/pytest/pytest-completions.nu
index 84bdd4446..8a7624a64 100644
--- a/custom-completions/pytest/pytest-completions.nu
+++ b/custom-completions/pytest/pytest-completions.nu
@@ -7,8 +7,8 @@ def "nu-complete --code-highlight" [] { ["yes", "no"] }
 def "nu-complete --pastebin" [] { ["failed", "all"] }
 def "nu-complete --import-mode" [] { ["prepend", "append", "importlib"] }
 def "nu-complete --doctest-report" [] { ["none", "cdiff", "ndiff", "udiff", "only_first_failure"] }
-def "nu-complete --log-file-mode" [] { ["w"; "a"] }
-def "nu-complete --assert" [] { ["plain"; "rewrite"] }
+def "nu-complete --log-file-mode" [] { ["w", "a"] }
+def "nu-complete --assert" [] { ["plain", "rewrite"] }
 def "nu-complete --log-level" [] { ["DEBUG", "INFO", "WARNING", "ERROR", "CRITICAL"] }
 
 export extern pytest [
diff --git a/custom-completions/pytest/tests/pytest-completions.nu b/custom-completions/pytest/tests/pytest-completions.nu
new file mode 100644
index 000000000..8f8f3b382
--- /dev/null
+++ b/custom-completions/pytest/tests/pytest-completions.nu
@@ -0,0 +1,9 @@
+# Run with `nu custom-completions/pytest/tests/pytest-completions.nu`.
+use std/assert
+source ../pytest-completions.nu
+
+assert equal (nu-complete --log-file-mode) ["w", "a"]
+assert equal (nu-complete --assert) ["plain", "rewrite"]
+
+assert equal ('pytest --log-file-mode ' | commandline complete --detailed | get value | sort) ["a", "w"]
+assert equal ('pytest --assert ' | commandline complete --detailed | get value | sort) ["plain", "rewrite"]