From 236db68ad15907172879a43a45e658137f1071a6 Mon Sep 17 00:00:00 2001 From: Adambomb210 Date: Thu, 19 Nov 2026 16:44:31 -0500 Subject: [PATCH] Build top-up and update redirects from the loaded project The updates router used the shared project redirect helpers with the raw path parameter, which kept CodeQL's py/url-redirection alert #5 open after #95. Co-Authored-By: Claude Opus 5.5 --- krater/web/routers/updates.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/krater/web/routers/updates.py b/krater/web/routers/updates.py index d7febf9..c0be576 100644 --- a/krater/web/routers/updates.py +++ b/krater/web/routers/updates.py @@ -126,12 +126,12 @@ def _refuse(errors: dict[str, str], demographics_url: str | None = None): except ValidationFailed as exc: return _refuse(exc.errors) except InvalidState as exc: - return _invalid_state_redirect(db_session, request, project_id, exc) + return _invalid_state_redirect(db_session, request, project.id, exc) update_id = update.id return _success_redirect( db_session, request, - project_id, + project.id, "Update posted. It's on the project page and in the project's Slack channel.", after_commit=lambda: slack_post_project_update.defer(update_id=str(update_id)), ) @@ -153,7 +153,7 @@ def _refuse(errors: dict[str, str], demographics_url: str | None = None): back = f"{get_settings().base_url.rstrip('/')}/projects/{project.id}/updates/new?topup=1" return _refuse({"form": exc.message, "demographics": "1"}, demographics_url=demographics_form_url(back)) except DemographicsCheckUnavailable as exc: - return _invalid_state_redirect(db_session, request, project_id, exc) + return _invalid_state_redirect(db_session, request, project.id, exc) try: update = project_updates.request_topup( db_session, @@ -170,7 +170,7 @@ def _refuse(errors: dict[str, str], demographics_url: str | None = None): errors["amount"] = amount_error return _refuse(errors) except InvalidState as exc: - return _invalid_state_redirect(db_session, request, project_id, exc) + return _invalid_state_redirect(db_session, request, project.id, exc) # (An amount that didn't parse reached the service as None, which refused it above.) update_id, revision_id = update.id, update.revision_id @@ -181,7 +181,7 @@ def _notify() -> None: return _success_redirect( db_session, request, - project_id, + project.id, "Top-up requested. Reviewers decide it like an amendment; your current budget keeps working meanwhile.", after_commit=_notify, )