From 8ef2c46db64a5f2f77c70b65b35772052f48c774 Mon Sep 17 00:00:00 2001 From: Markus Staab Date: Thu, 1 Oct 2026 12:25:57 +0200 Subject: [PATCH 1/4] AssertEmptyIsDiscouragedRule: use unique error identifier --- src/Rules/PHPUnit/AssertEmptyIsDiscouragedRule.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Rules/PHPUnit/AssertEmptyIsDiscouragedRule.php b/src/Rules/PHPUnit/AssertEmptyIsDiscouragedRule.php index 61ab735..631efed 100644 --- a/src/Rules/PHPUnit/AssertEmptyIsDiscouragedRule.php +++ b/src/Rules/PHPUnit/AssertEmptyIsDiscouragedRule.php @@ -45,7 +45,7 @@ public function processNode(Node $node, Scope $scope): array return [ RuleErrorBuilder::message(sprintf('%s() is not allowed. Use more strict assertion.', $node->name->toString())) - ->identifier('empty.notAllowed') + ->identifier('phpunit.notEmpty') ->build(), ]; } From 0218358a5efab07ab2504e2199c92cbb1a4b8004 Mon Sep 17 00:00:00 2001 From: Markus Staab Date: Thu, 1 Oct 2026 12:31:48 +0200 Subject: [PATCH 2/4] Update AssertEqualsIsDiscouragedRule.php --- src/Rules/PHPUnit/AssertEqualsIsDiscouragedRule.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Rules/PHPUnit/AssertEqualsIsDiscouragedRule.php b/src/Rules/PHPUnit/AssertEqualsIsDiscouragedRule.php index ed6470e..890b392 100644 --- a/src/Rules/PHPUnit/AssertEqualsIsDiscouragedRule.php +++ b/src/Rules/PHPUnit/AssertEqualsIsDiscouragedRule.php @@ -71,7 +71,7 @@ public function processNode(Node $node, Scope $scope): array $correctName, $node->name->name, ), - )->identifier('phpunit.assertEquals') + )->identifier('phpunit.assertEmpty') ->fixNode($node, static function (CallLike $node) use ($correctName) { $node->name = new Node\Identifier($correctName); From 6315e54ed9a0fd1d3dc0f214804af93d862123aa Mon Sep 17 00:00:00 2001 From: Markus Staab Date: Thu, 1 Oct 2026 12:32:25 +0200 Subject: [PATCH 3/4] Revert "Update AssertEqualsIsDiscouragedRule.php" This reverts commit 0218358a5efab07ab2504e2199c92cbb1a4b8004. --- src/Rules/PHPUnit/AssertEqualsIsDiscouragedRule.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Rules/PHPUnit/AssertEqualsIsDiscouragedRule.php b/src/Rules/PHPUnit/AssertEqualsIsDiscouragedRule.php index 890b392..ed6470e 100644 --- a/src/Rules/PHPUnit/AssertEqualsIsDiscouragedRule.php +++ b/src/Rules/PHPUnit/AssertEqualsIsDiscouragedRule.php @@ -71,7 +71,7 @@ public function processNode(Node $node, Scope $scope): array $correctName, $node->name->name, ), - )->identifier('phpunit.assertEmpty') + )->identifier('phpunit.assertEquals') ->fixNode($node, static function (CallLike $node) use ($correctName) { $node->name = new Node\Identifier($correctName); From 4d62ecee2e2d6a71b3cf7751155b1b13ffaf2133 Mon Sep 17 00:00:00 2001 From: Markus Staab Date: Thu, 1 Oct 2026 12:32:32 +0200 Subject: [PATCH 4/4] Update AssertEmptyIsDiscouragedRule.php --- src/Rules/PHPUnit/AssertEmptyIsDiscouragedRule.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Rules/PHPUnit/AssertEmptyIsDiscouragedRule.php b/src/Rules/PHPUnit/AssertEmptyIsDiscouragedRule.php index 631efed..5459e26 100644 --- a/src/Rules/PHPUnit/AssertEmptyIsDiscouragedRule.php +++ b/src/Rules/PHPUnit/AssertEmptyIsDiscouragedRule.php @@ -45,7 +45,7 @@ public function processNode(Node $node, Scope $scope): array return [ RuleErrorBuilder::message(sprintf('%s() is not allowed. Use more strict assertion.', $node->name->toString())) - ->identifier('phpunit.notEmpty') + ->identifier('phpunit.assertEmpty') ->build(), ]; }