From 63196ad703d0ee9acbf96aed21cd48b3cf3ce924 Mon Sep 17 00:00:00 2001 From: Juan Cruz Viotti Date: Fri, 2 Oct 2026 11:43:49 -0300 Subject: [PATCH 1/2] WIP This reverts commit 7de0a97957415395cbd4971cbd2e017eb11b31b4. --- jsonschema.json | 1 + rules/identifiers.json | 8 ++++++++ 2 files changed, 9 insertions(+) create mode 100644 rules/identifiers.json diff --git a/jsonschema.json b/jsonschema.json index 9275a554..b9ec1817 100644 --- a/jsonschema.json +++ b/jsonschema.json @@ -13,6 +13,7 @@ "rules": [ "./rules/comment.json", "./rules/dialect.json", + "./rules/identifiers.json", "./rules/jsonld-bare-override.json", "./rules/jsonld-constants-iri-literal.json", "./rules/jsonld-constants-lexical.json", diff --git a/rules/identifiers.json b/rules/identifiers.json new file mode 100644 index 00000000..bb60ec32 --- /dev/null +++ b/rules/identifiers.json @@ -0,0 +1,8 @@ +{ + "$schema": "https://json-schema.org/draft/2020-12/schema", + "title": "std/identifiers", + "description": "Schemas must not declare identifiers, as the registry derives them from file paths", + "properties": { + "$id": false + } +} From 65af6aeb5b1ed590451251c4d2c006f077e56ec3 Mon Sep 17 00:00:00 2001 From: Juan Cruz Viotti Date: Fri, 2 Oct 2026 11:45:08 -0300 Subject: [PATCH 2/2] Pass lint rules not applicable to One in the Makefile Signed-off-by: Juan Cruz Viotti --- Makefile | 4 +++- jsonschema.json | 2 -- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index 608cde6e..470aa8e1 100644 --- a/Makefile +++ b/Makefile @@ -14,7 +14,9 @@ all: common test node_modules .PHONY: common common: $(GENERATED) node_modules $(TIME) $(NODE) $(JSONSCHEMA) metaschema schemas examples rules - $(TIME) $(NODE) $(JSONSCHEMA) lint schemas examples + $(TIME) $(NODE) $(JSONSCHEMA) lint schemas examples \ + --rule ./rules/identifiers.json \ + --rule ./rules/dialect.json $(SHELLCHECK) scripts/*.sh ./scripts/quality-schemas-tests-mirror.sh JQ="$(JQ)" ./scripts/quality-templates-xbrl-utr-mirror.sh diff --git a/jsonschema.json b/jsonschema.json index b9ec1817..eb683627 100644 --- a/jsonschema.json +++ b/jsonschema.json @@ -12,8 +12,6 @@ "lint": { "rules": [ "./rules/comment.json", - "./rules/dialect.json", - "./rules/identifiers.json", "./rules/jsonld-bare-override.json", "./rules/jsonld-constants-iri-literal.json", "./rules/jsonld-constants-lexical.json",