Skip to content

Fix the 404 page and add a skip link - #31

Merged
2SikNinja merged 3 commits into
masterfrom
accessibility-pass
Nov 17, 2026
Merged

2SikNinja merged 3 commits into
masterfrom
accessibility-pass

Conversation

@2SikNinja

@2SikNinja 2SikNinja commented Nov 17, 2026 •

Copy link
Copy Markdown
Owner

Results of an accessibility pass over every page.

How it was checked:

  • axe-core with the WCAG 2.2 AA and best-practice rules on the home page (empty and with search results), a round with a pick, the playlist, the playlist with the player open, and the 404 page, at desktop and phone sizes.
  • Tabbing through the home, round and playlist pages: every stop has a name and a visible focus ring, in a sensible order.
  • Contrast worked out from the theme colors: primary text and secondary text (6.1:1) pass AA.
  • Reduced motion was already handled in globals.css.

What was wrong and is fixed here:

  • The 404 page was unreadable. Next.js's built-in 404 forces a white background, so the header's light text was nearly invisible (1.09:1 contrast) and the page looked broken. Added src/app/not-found.tsx in the app's theme, with a way back home.
  • No skip link. Added Skip to content as the first Tab stop on every page. It's hidden until focused, and jumps to the main content.

Also adds an Accessibility section to the README.

Found in other open PRs and fixed there: the new song reason line in #28 used secondary text at 80% opacity (4.3:1, under AA for small text), so it now uses full secondary text. Once #30 (CI) is merged, I'll add the axe check to the browser tests so this stays clean.

Testing: axe reports no issues on any page after these changes. Checked the 404 page and the skip link in a local production build. Typecheck, lint and all 174 tests pass.


Generated by Claude Code

@2SikNinja
2SikNinja merged commit c1b65fd into master Nov 17, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant