Skip to content

Fix the browser test mock after song reasons - #32

Merged
2SikNinja merged 1 commit into
masterfrom
fix-mock-reason
Nov 17, 2026
Merged

2SikNinja merged 1 commit into
masterfrom
fix-mock-reason

Conversation

@2SikNinja

Copy link
Copy Markdown
Owner

#28 (song reasons) and #30 (CI and browser tests) each passed on their own, but #28 made reason a required field on playlist songs, and the fake API in the browser tests was written without it. With both merged, master's typecheck fails.

  • The mock playlist now gives each song a reason (the first song is the seed, the rest have none, like an older playlist).
  • New browser test: the first song shows "Your starting song".

Testing: typecheck and lint pass, all 183 unit tests pass, and all 17 browser tests pass (one skipped on phones) against a local production build of master.


Generated by Claude Code

@2SikNinja
2SikNinja merged commit 686314d into master Nov 17, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant