Repository navigation
Use compiler-specific range-loop suppression flags - #2075
Closed
dajiaohuang wants to merge 2 commits into
Closed
dajiaohuang wants to merge 2 commits into
dajiaohuang wants to merge 2 commits into
Conversation
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2075 +/- ##
=======================================
Coverage 83.61% 83.61%
=======================================
Files 183 183
Lines 13580 13580
Branches 1261 1261
=======================================
Hits 11355 11355
Misses 2052 2052
Partials 173 173
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Collaborator
|
Hi @dajiaohuang - thanks for the contribution! Would you mind doing the CLA authorization and making sure the contribution is commit with --signoff? |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2036.
Use Clang's
-Wno-range-loop-analysisonly for Clang and AppleClang, and use GCC's-Wno-range-loop-constructfor GNU compiler versions 11 and newer in both Python binding targets. The version guard preserves older documented VFX-platform compiler support, including GCC 9.3.1 for CY2022. Other warning suppressions and MSVC options are unchanged.Validation:
git diff --checkpassed.