Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2086 +/- ##
==========================================
- Coverage 83.62% 83.47% -0.16%
==========================================
Files 184 184
Lines 13627 13993 +366
Branches 1270 1274 +4
==========================================
+ Hits 11395 11680 +285
- Misses 2059 2140 +81
Partials 173 173
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 63 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Assisted-by: OpenAI Codex / GPT-6 Signed-off-by: Jeff Hodges <[email protected]>
jhodges10
force-pushed
the
codex/reject-json-nul
branch
from
October 30, 2026 19:49
d4f0ad3 to
0f03940
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RapidJSON treats a raw NUL byte as end-of-input. Both JSON entry points could therefore accept a valid prefix such as
{"x":1}\0{"y":2}while silently ignoring the rest. Reject these inputs so callers cannot disagree about what was parsed.Changes
MemoryStreamand reject a successful parse that consumed fewer bytes than the supplied string.FileReadStream's synthetic end-of-file marker after file parsing; open files in binary mode so Windows text-mode EOF translation cannot truncate input.\u0000with trailing whitespace.Validation
ValueErrorfor the crafted input, while escaped\u0000remains valid.Assisted-by: OpenAI Codex / GPT-6 Daybreak (cyber-security model)