Repository navigation
Add WebGPU FSR upscaling and compatible Swan/JavaScriptKit dependencies - #202
Merged
Merged
Conversation
Implement EASU and RCAS with cached WebGPU resources and GPU readback coverage. Use the AdaEngine Swan fork with JavaScriptKit 0.59 and compatible SwiftSyntax constraints, including the WASM WebSocket API adjustment. Validated with 225 WebGPU tests, a full AdaWebPlayer WASM export without local Swan overrides, and a browser render of the exported 3D scene.
SpectralDragon
marked this pull request as ready for review
October 23, 2026 16:17
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WebGPU previously reported spatial upscaling as unsupported, so
.renderUpscaling(.spatial(renderScale: 0.75))kept rendering at native resolution. It now encodes FSR 1 EASU followed by RCAS through the existing spatial-upscale API, with cached pipelines and size-dependent resources. Metal continues to select MetalFX.Use the pinned
AdaEngine/swanrevision790df787281e9cf1c2358a11bb42b2ec2df01029with JavaScriptKit 0.59.0 so checked-in BridgeJS and its runtime share the same ABI. Allow SwiftSyntax 602–603 in the engine and bundled Gravity, preserve Editor's 602 compatibility, and adapt the WASM WebSocket data conversion.This is stacked on #198 and targets
codex/shader-graph; its diff contains only commitf5f20fd70. Retarget tomainafter the Shader Graph dependency lands. The diff is 502 reviewable lines, or 601 lines including documentation and lockfiles.Validation on Swift 6.3.2 / Xcode 26.6:
script/validate_webgpu.sh: 225 tests in 46 suites passed using the remote Swan fork and Dawn 148, including golden frames and FSR GPU readback for edges, alpha, RGBA/BGRA, resizing, cache eviction and queued views.export-web --product AdaWebPlayer --swift-sdk swift-6.3.2-RELEASE_wasm --debugpassed withADAENGINE_SWAN_PACKAGE_PATHandSWAN_LOCAL_DAWNunset; verified reactor ABI and all bundled resource entries.git diff --checkpassed.The FSR path supports single-sample 2D RGBA8/BGRA8 UNORM targets. HDR/sRGB, equal-size images and downscaling retain the existing presentation fallback; pixel-perfect presentation keeps its dedicated path.