Repository navigation
simd: re-export checked i64 arithmetic through the facade - #407
Merged
Merged
Conversation
checked_binary_i64, checked_i64, range_i64, range_len_i64, I64Op and I64ArithError were reachable only as ndarray::hpc::checked_i64, so a consumer (the DT64 bind store binding XLOG's count, ONNX int64 Mul) had to name hpc. Plain re-exports: same functions, same refusal policy. The test imports through the facade path, so dropping the re-export fails to build. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01XAqKMPh2Seh2WLccCksAdY
The in-crate test sees a private use; the doctest is a consumer, so it fails to build if the re-export is not public. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01XAqKMPh2Seh2WLccCksAdY
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
checked_binary_i64,checked_i64,range_i64,range_len_i64,I64OpandI64ArithErrorcould only be reached asndarray::hpc::checked_i64. A consumer must never namehpc, so the DT64 bind store (lance-graphlance-graph-dt64) had no legal facade word for the int64 multiply in XLOG's count or in an ONNXMul(int64)node.This PR adds plain
pub usere-exports tondarray::simd: the same functions with the same refusal policy (overflow, division by zero and length mismatch are refused, and nothing is written on refusal).Tests:
ndarray::simd::{checked_binary_i64, I64ArithError, I64Op}from outside the crate.usefails both doctests withE0603(private item).usein its parent. I checked: that disable stayed green with the unit test alone.-D warningsand fmt are clean.Generated by Claude Code