Repository navigation
Handle multiple levels of catalog element representation - #1689
Open
iTerminate wants to merge 14 commits into
Open
iTerminate wants to merge 14 commits into
iTerminate wants to merge 14 commits into
Conversation
Contributor
Author
|
I investigated the implications of removing the one-level representation constraint. Multilevel resolution appears structurally supported, but this change exposes several integrity risks that should be addressed or explicitly tested before merge:
At minimum, I recommend blocking unlink of a represented node with represented children, validating REST promotion against the parent's available elements, and adding tests for three-level hierarchies with/without templates, middle-node unlink, catalog element removal/replacement, assembly swap, and circular references. |
… was missing from prior functioantliy.
…hildren representing in machine.
…alidate represented elements
- Catalog promotion
- Old: Any catalog element could be promoted, even if the parent
machine was not assigned its assembly.
- New: The element must belong to the parent machine’s assigned
assembly.
- Inventory promotion
- Old: Any inventory element could be promoted and normalized to
its catalog element.
- New: It must belong to the parent’s assigned inventory/catalog
assembly before normalization and promotion.
- Unsupported-domain promotion
- Old: Rejected with a domain-specific error.
- New: Still rejected, but currently fails the parent-assembly
availability check first; validation should be reordered to preserve the
old error.
- Nested representation
- Old: Always rejected when the parent machine already represented
an element.
- New: Allowed when the child represents an element from the
parent’s effective represented assembly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…. Closes #1688