Repository navigation
MathUtils: make getMean()'s ternary unambiguous for an emulated double - #15947
Merged
Merged
Conversation
On Metal the double keyword names a class that converts to float and back
implicitly, so the conditional operator has to form an implicit conversion
sequence from each arm to the type of the other. Both directions succeed and the
standard has no tie-break, which makes wsum > 0. ? sum / wsum : 0. ill-formed
there. With a builtin double the arms go through the usual arithmetic
conversions instead, and those are ranked, so nothing has to be resolved.
double{} gives both arms the declared type on every backend: zero for the
builtin, and, since the emulated type's default constructor is not user-provided,
an all-bits-zero +0.0 on Metal.
davidrohr
reviewed
Oct 12, 2026
Co-authored-by: David Rohr <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Metal the double keyword names a class that converts to float and back
implicitly, so the conditional operator has to form an implicit conversion
sequence from each arm to the type of the other. Both directions succeed and the
standard has no tie-break, which makes wsum > 0. ? sum / wsum : 0. ill-formed
there. With a builtin double the arms go through the usual arithmetic
conversions instead, and those are ranked, so nothing has to be resolved.
double{} gives both arms the declared type on every backend: zero for the
builtin, and, since the emulated type's default constructor is not user-provided,
an all-bits-zero +0.0 on Metal.