Repository navigation
OCTRL-1107: [shmcleaner] Read process names from /proc instead of ps - #870
Merged
Merged
Conversation
The o2-alf exclusion compares the output of `ps -ho %c <pid>` with the literal string `o2-alf`. On RHEL 10 that command pads the name to 15 columns, so the comparison never matches and the cleanup SIGTERMs ALF before every DEPLOY. `systemd` treats SIGTERM as a clean exit and `Restart=on-failure` leaves the service down. EL9 prints the bare name, which is why production was not affected. Read `/proc/<pid>/comm` directly: same kernel field, not intermediate.
Collaborator
|
oh, wow... good catch. |
justonedev1
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The o2-alf exclusion compares the output of
ps -ho %c <pid>with the literal stringo2-alf. On RHEL 10 that command pads the name to 15 columns, so the comparison never matches and the cleanup SIGTERMs ALF before every DEPLOY.systemdtreats SIGTERM as a clean exit andRestart=on-failureleaves the service down. EL9 prints the bare name, which is why production was not affected.Read
/proc/<pid>/commdirectly: same kernel field, no dependency from ps invocation and params combination.On rhel9:
On rhel10: