Repository navigation
Conversation
lubynets
requested review from
alibuild,
deepathoms,
fcatalan92,
fcolamar,
fgrosa,
mfaggin,
mmazzilli and
vkucera
as code owners
October 29, 2026 22:45
lubynets
requested review from
NicoleBastid,
apalasciano,
gluparel,
hahassan7,
jpxrk,
singhra1994,
stefanopolitano,
xinyepeng and
zhangbiao-phy
as code owners
October 29, 2026 22:45
github-actions
Bot
changed the title
|
O2 linter results: ❌ 0 errors, |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some collisions in MC have abnormally large number of PV contributors, O(1000) instead of O(10) in pp collisions (for the reasons which are not clear yet). It brings to increasing of combinatorics of 3-prong triplets by 2 orders of magnitude, leading to OOM fail when processing the problematic dataframe.$10^6$ , so the observable behavior won't change unless the user intentionally changes this configurable.
This PR provides a workaround:
nPvContributorsMaxconfigurable, allowing for skipping the affected collision.The default value of the configurable is set to
Tagging @fgrosa