Skip to content

Preserve zero blur when serializing box-shadow spread - #250

Merged
FlorianRappl merged 1 commit into
AngleSharp:develfrom
EvotecIT:fix/shadow-zero-blur
Oct 15, 2026
Merged

FlorianRappl merged 1 commit into
AngleSharp:develfrom
EvotecIT:fix/shadow-zero-blur

Conversation

@PrzemyslawKlys

Copy link
Copy Markdown
Contributor

Types of Changes

Prerequisites

  • I have read the CONTRIBUTING document
  • My code follows the code style of this project

Contribution Type

  • Bug fix (non-breaking change which fixes an issue, please reference the issue id)
  • New feature (non-breaking change which adds functionality, make sure to open an associated issue first)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Description

Fixes #249.

Serializing box-shadow: 0 0 0 5px red drops the zero blur, moving the spread into the blur position. This retains zero blur when a nonzero spread follows it. The regression test covers positive and negative spread through serialization and reparsing.

OfficeIMO consumes these serialized values and can adopt the correction through an AngleSharp.Css package release.

All 2,344 tests pass locally, and the library builds for netstandard2.0, .NET 8, and .NET 10.

@CLAassistant

CLAassistant commented Oct 15, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@FlorianRappl FlorianRappl added this to the v1.1.3 milestone Oct 15, 2026

@FlorianRappl FlorianRappl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@FlorianRappl
FlorianRappl merged commit 99cb6b3 into AngleSharp:devel Oct 15, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

box-shadow serialization drops zero blur before nonzero spread

3 participants