Create Jint engines through a configuration service - #142
Merged
FlorianRappl merged 7 commits intoOct 4, 2026
Merged
Conversation
FlorianRappl
reviewed
Oct 4, 2026
FlorianRappl
left a comment
FlorianRappl
left a comment
Contributor
There was a problem hiding this comment.
I'd keep everything readonly. An instance, once created, stays that way.
What we can have is that there is an EngineCreator, which can be configured. The default just creates a new Engine object. This way, one can configure / create the Engine instance in whatever way. The creator will be called within the constructor of an EngineInstance.
PrzemyslawKlys
changed the title
FlorianRappl
reviewed
Oct 4, 2026
PrzemyslawKlys
changed the title
FlorianRappl
reviewed
Oct 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hosts cannot configure Jint options before the first inline script runs.
Add an
EngineCreatorconfiguration service, called from theEngineInstanceconstructor with the current window and existing DOM options. Keep instance fields readonly. Workers inherit the same service registrations, including context factories, and receive their own window.HtmlTinkerX uses this hook to install execution limits before loading markup; its adoption follows an AngleSharp.Js release.
Validation: 308 net10.0 tests, 12 focused engine/worker tests on net472, and all shipping targets pass. Independent review covered the service and worker propagation; the window argument is verified in both paths.