Fix background thread leaks from rejected worker construction - #143
Merged
FlorianRappl merged 1 commit intoOct 4, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating a
Workerin a context without a document loader throwsNotSupportedError, but the constructor previously started a background event loop before checking that requirement. Catching repeated construction failures therefore left one unreachable thread per attempt.Validate the parent's loader and resolve the source before allocating the worker loop. Dispose the partially created context and loop if subsequent construction or scheduling fails. Successful startup and message delivery keep their existing behavior.
Validation: the regression fails against the original code with 32 surviving threads; the complete .NET 10 suite passes (302 tests), and all six worker tests pass on .NET Framework 4.7.2.