Skip to content

portable_option(): fix buffer overflows of portable_dir and fullpath #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gianlucarenzi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

portable_option(): fix buffer overflows of portable_dir and fullpath #155

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/runtime/runtime.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -724,14 +724,17 @@ void portable_option(const char* arg, const char* appimage_path, const char* nam
char portable_dir[PATH_MAX];
char fullpath[PATH_MAX];

ssize_t length = readlink(appimage_path, fullpath, sizeof(fullpath));
ssize_t length = readlink(appimage_path, fullpath, sizeof(fullpath) - 1);
if (length < 0) {
fprintf(stderr, "Error getting realpath for %s\n", appimage_path);
exit(EXIT_FAILURE);
}
fullpath[length] = '\0';

sprintf(portable_dir, "%s.%s", fullpath, name);
if (snprintf(portable_dir, sizeof(portable_dir), "%s.%s", fullpath, name) >= (int) sizeof(portable_dir)) {
fprintf(stderr, "Path of the portable %s directory too long: %s.%s\n", name, fullpath, name);
exit(EXIT_FAILURE);
}
if (!mkdir(portable_dir, S_IRWXU))
fprintf(stderr, "Portable %s directory created at %s\n", name, portable_dir);
else
Expand Down Expand Up @@ -1511,7 +1514,7 @@ int main(int argc, char* argv[]) {
if (arg && strcmp(arg, "appimage-help") == 0) {
char fullpath[PATH_MAX];

ssize_t length = readlink(appimage_path, fullpath, sizeof(fullpath));
ssize_t length = readlink(appimage_path, fullpath, sizeof(fullpath) - 1);
if (length < 0) {
fprintf(stderr, "Error getting realpath for %s\n", appimage_path);
exit(EXIT_EXECERROR);
Expand Down Expand Up @@ -1561,7 +1564,7 @@ int main(int argc, char* argv[]) {

if (getenv("TARGET_APPIMAGE") == NULL) {
// If we are operating on this file itself
ssize_t len = readlink(appimage_path, fullpath, sizeof(fullpath));
ssize_t len = readlink(appimage_path, fullpath, sizeof(fullpath) - 1);
if (len < 0) {
perror("Failed to obtain absolute path");
exit(EXIT_EXECERROR);
Expand Down
Loading