Repository navigation
Release 7.0.4 - #480
Merged
Merged
Release 7.0.4#480
Conversation
workflow_run events only expose head_sha/head_branch for the ref rc-release.yml was dispatched WITH (e.g. development), never the releases/** branch its own prepare-branch job creates during the run. Trusting those fields meant every automatic smoke run checked out development (still at the last real release's version), saw a non-RC pubspec version, and silently skipped — since rc-smoke.yml was added in #446 (Apr 26, 2026), the automatic path has never actually smoke-tested a real RC. Fix: resolve the actual RC from the GitHub prerelease that create-prerelease just published (tag_name + created_at, sanity checked against the triggering run's completion time within 30 min), derive the release branch from that tag using the same naming convention rc-release.yml computes, and check that branch out instead. Manual workflow_dispatch path (rc_version/release_branch inputs) is unaffected — it already worked correctly, as verified by manually running it for 6.18.1-rc1/rc2. No new secrets needed — reading releases via the API only requires the default GITHUB_TOKEN's existing read access. Co-Authored-By: Claude Sonnet 5 <[email protected]>
…-resolution Fix rc-smoke.yml resolving the wrong branch on automatic trigger
…tecture. (#466) [DELIVERY-125863] Migrate Flutter plugin to AppsFlyer SDK 7 RPC architecture. Route core APIs through af-api/af-events RPC bridges on Android and iOS, adopt the SDK 7 init + session-ready start model, remove SDK 6 APIs that no longer exist natively, bump native dependencies to 7.0.1, raise iOS minimum to 13.0, and reorganize public documentation.
# Conflicts: # test/appsflyer_sdk_test.dart
Version rewriting was spread across rc-release.yml and promote-release.yml as inline sed calls. The two implementations drifted: rc-release guarded each rewrite and staged lib/, promote did neither, so 7.0.2 was nearly published reporting 7.0.2-rc1 from the public pluginVersion getter. Every silent version bug this cycle had the same shape -- a pattern that stopped matching while sed still exited 0. Add scripts/set-version.sh as the single writer for pubspec.yaml, the three plugin constants, the podspec and the SPM manifest, with native pins rewritten only when passed. Each rewrite asserts its pattern matched first. Both workflows now call it, and scripts/verify-version-consistency.sh reads the same surfaces back in rc-release, promote and production. This also closes the SPM gap: rc-release rewrote only the podspec's AppsFlyerFramework dependency, so a bumped ios_sdk_version left Package.swift behind and SPM and CocoaPods consumers linked different native SDKs. The AppsFlyerRPC binary target stays manual because its checksum cannot be derived from a version; the consistency check still compares its version. Two gates could not stop a release. create-github-release ran under always() without checking the publish job, so a tag and release could be created for a version that never reached pub.dev. The duplicate-tag check looked up tags before fetching them and matched origin/$VERSION, which resolves branches and never a remote tag, so it never fired.
# Conflicts: # .github/workflows/rc-release.yml
af-dudka
self-requested a review
October 29, 2026 11:13
af-dudka
previously approved these changes
Oct 29, 2026
Contributor
Author
|
🛑 Promote blocked. No Run rc-smoke.yml manually with the RC version, or wait for the auto-trigger from the RC-release workflow, then re-apply the label. |
Contributor
Author
🚀 Ready for Production ReleaseThe release branch has been updated:
Next Steps
|
af-dudka
self-requested a review
October 29, 2026 11:38
af-dudka
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Production Release 7.0.4
Status: ✅ Ready for manual merge
Version updated: 7.0.4-rc1 → 7.0.4
Release 7.0.4
This PR was opened by the RC workflow.
Next steps: