Skip to content

fix(dashboard): keep content frame fixed and remove sidebar customization - #10480

Merged
Soulter merged 2 commits into
masterfrom
codex/dashboard-scroll-and-sidebar-cleanup
Oct 9, 2026
Merged

Soulter merged 2 commits into
masterfrom
codex/dashboard-scroll-and-sidebar-cleanup

Conversation

@Soulter

@Soulter Soulter commented Oct 9, 2026 •

Copy link
Copy Markdown
Member

Scrollable WebUI pages currently move the content card's rounded corners and borders with the page. Keep the frame fixed to the available viewport and scroll page content inside it. Desktop gets 12px corners, visible right/bottom borders, and 6px right/bottom gaps; mobile stays full width with square corners and temporary drawers above the content.

On Config, keep the profile selector, search toolbar, and section navigation fixed while only the right configuration form scrolls. Apply the same layout to Settings, keeping its title and navigation outside the scrolling content pane. Narrow screens keep their navigation row above the independently scrolling form. Embedded configuration drawers use the same height chain.

Remove the obsolete System Settings → Appearance → Customize Sidebar control, its component/storage utility, unused menu constant, and translations. The current sidebar already uses the default layout; extension collapsing, pinning, and plugin grouping remain available. Match the active sidebar Settings button to the primary-colored navigation items. Update English/Chinese documentation and the unreleased changelog.

Extracted from #10320 onto current master. Theme color customization and card shadows remain outside this PR. #10320 is unchanged.

Fixes #10479.

Validation

  • cd dashboard && pnpm build (vue-tsc and Vite): passed.
  • cd docs && pnpm run docs:build: passed.
  • ruff format . and ruff check .: passed; 515 Python files unchanged.
  • Browser checks used in-browser API fixtures without a running backend. Verified the ordinary-page card stays fixed during scrolling, its desktop borders are 1px with 6px right/bottom gaps, and mobile has zero gaps and no side/bottom borders.
  • Verified Config and Settings on desktop and at 390 × 844: right-pane scroll positions change while toolbar/title and navigation bounds remain unchanged, and the outer content scroller stays at zero.
  • Verified the active Settings button's primary-colored background/text in expanded and collapsed sidebars. Also checked Providers, Platforms, ChatUI, theme styling, and mobile drawer stacking/navigation dismissal.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path="dashboard/src/layouts/full/FullLayout.vue" line_range="235" />
<code_context>
+  width: 100%;
+  padding: 8px;
+  overflow-x: hidden;
+  overflow-y: auto;
+  scrollbar-width: none;
 }
</code_context>
<issue_to_address>
**Settings navigation sticks too low**

When a user scrolls a long Settings section until its navigation becomes sticky, `.settings-nav` keeps its `top: 76px` offset, but `page-content` is now its scroll container, so that offset is measured from below the toolbar rather than from the viewport. The sticky navigation therefore sits about 40px lower than before while scrolling Settings.

Reduce the Settings navigation sticky offset by the toolbar height so it is measured from the content scroll area's top.
</issue_to_address>

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

Comment thread dashboard/src/layouts/full/FullLayout.vue
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
astrbot-docs 508c4ee Commit Preview URL

Branch Preview URL
Oct 09 2026, 03:03 PM

@Soulter
Soulter merged commit 9fa4908 into master Oct 9, 2026
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Web UI 界面的圆角和横线在滚动后不会固定

1 participant