Repository navigation
fix(dashboard): keep content frame fixed and remove sidebar customization - #10480
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="dashboard/src/layouts/full/FullLayout.vue" line_range="235" />
<code_context>
+ width: 100%;
+ padding: 8px;
+ overflow-x: hidden;
+ overflow-y: auto;
+ scrollbar-width: none;
}
</code_context>
<issue_to_address>
**Settings navigation sticks too low**
When a user scrolls a long Settings section until its navigation becomes sticky, `.settings-nav` keeps its `top: 76px` offset, but `page-content` is now its scroll container, so that offset is measured from below the toolbar rather than from the viewport. The sticky navigation therefore sits about 40px lower than before while scrolling Settings.
Reduce the Settings navigation sticky offset by the toolbar height so it is measured from the content scroll area's top.
</issue_to_address>Sourcery assessment
Approved.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
astrbot-docs | 508c4ee | Commit Preview URL Branch Preview URL |
Oct 09 2026, 03:03 PM |
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scrollable WebUI pages currently move the content card's rounded corners and borders with the page. Keep the frame fixed to the available viewport and scroll page content inside it. Desktop gets 12px corners, visible right/bottom borders, and 6px right/bottom gaps; mobile stays full width with square corners and temporary drawers above the content.
On Config, keep the profile selector, search toolbar, and section navigation fixed while only the right configuration form scrolls. Apply the same layout to Settings, keeping its title and navigation outside the scrolling content pane. Narrow screens keep their navigation row above the independently scrolling form. Embedded configuration drawers use the same height chain.
Remove the obsolete System Settings → Appearance → Customize Sidebar control, its component/storage utility, unused menu constant, and translations. The current sidebar already uses the default layout; extension collapsing, pinning, and plugin grouping remain available. Match the active sidebar Settings button to the primary-colored navigation items. Update English/Chinese documentation and the unreleased changelog.
Extracted from #10320 onto current
master. Theme color customization and card shadows remain outside this PR. #10320 is unchanged.Fixes #10479.
Validation
cd dashboard && pnpm build(vue-tsc and Vite): passed.cd docs && pnpm run docs:build: passed.ruff format .andruff check .: passed; 515 Python files unchanged.