Repository navigation
fix: restore Ctrl-click link activation - #663
Merged
Merged
Conversation
Azganoth
force-pushed
the
bug/ctrl-click-link-activation
branch
from
October 10, 2026 13:27
923e98a to
59cc4a2
Compare
Another file in the shared fixture folder pushes later rows out of the virtualized article navigator, where tree-item lookups in other scenarios no longer find them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ctrl-click (Cmd-click on macOS) on a rendered link, wiki link, or footnote reference did nothing. A real press moves the native caret into the target on mousedown; the editor reads that selection, source projection replaces the rendered target with its Markdown, and no click reaches it. In a table cell, ProseMirror's modifier node selection also outlined the cell's paragraph.
Related Issue
Closes #650
Verification
pnpm exec vitest runon the link activation, wiki link, footnote navigation, block selection (Windows and simulated macOS), and source projection suites passed. The full-sequence cases cover web and local Markdown targets, mixed-format labels, reference links, links in lists, blockquotes, and table cells, wiki links, footnote references, and Meta-click on macOS; they fail onmainand pass with the fix.pnpm check:frontendandgit diff --checkpassed.Manually verified in headless Edge on Windows, with trusted CDP mouse input against the editor mounted at a temporary Vite route and a stubbed Tauri
invoke:mainand, with the fix, activated each target without projecting its source or selecting a node.mainand passed with the fix.Not verified: the updated
block-selectionandwiki-linksdesktop scenarios were not run locally and are left to CI, and the helper's later switch tocaretPositionFromPointis type-checked only. No hardware mouse input in the Tauri app and no native macOS run.Notes
Footnote-reference
Mod+clicknavigation shared the cause and is fixed here although #650 names only links. Help describes where links open but not the gesture, so it is unchanged.