Repository navigation
fix: show opened documents before their folder finishes scanning - #666
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Opening a file waited for a full recursive scan of its parent folder before showing anything, while the window already showed the welcome screen. In a large folder the document looked as if it had not opened. The installed
0.1.0-alpha.2diagnostic log shows this is what happened behind #656. File Explorer launches intoDocuments(about 12,000 files in 2,000 directories) waited around 10 s on the folder scan; one was logged at 10,053 ms. The windows reported as empty were closed 2–6 s after starting, before their scan finished. No logged launch lost its path or failed to open.Related Issue
Closes #656
Verification
openSessiontests cover four cases: the document showing before the scan resolves, a second open during loading keeping the folder, an opened folder replacing a load, and a failed scan keeping the document while showing the scan error. The replacement case fails when the stale-load check is removed.Apptest delays preference loading and launches a path containing spaces and Unicode. It confirms the launch path is read only after startup finishes, the document opens while the scan is pending with the skeleton shown, and the folder context arrives afterward.documentWorkflowsand command-state tests cover Save As keeping a loading folder, and which commands are available while a folder loads.pnpm check:frontendpassed.Not verified: File Explorer launches with an installed build of this branch, from a cold start or with another Leafdown window open. The
launch-documentdesktop scenario is unchanged; it already launches a Unicode path containing spaces and checks the folder tree and recents, and was not run locally. The skeleton's appearance was not checked visually.Notes