Repository navigation
Replace DBA XQuery editor with REx-based implementation - #2782
Open
GuntherRademacher wants to merge 1 commit into
Open
GuntherRademacher wants to merge 1 commit into
GuntherRademacher wants to merge 1 commit into
Conversation
Member
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the DBA editor’s existing Lezer-based XQuery support with the REx-based implementation from the local
basex-lspproject. It preserves the existing DBA editor interface, but includes richer language support:Static analysis
The new bundle reports, with XQuery error codes:
XPST0008)XPST0017)XPST0051)XPST0081)XQST0034)XQST0148)It also gives hints for unused variables, functions, types and namespace prefixes, and warnings for potentially undefined context-value references in function bodies.
Smarter completion
/,@,<and inside a start tag.Features the old bundle did not have
Better XML + Markdown handling (
xml-markdownmode)<in the code, such ascount(.) < 10, no longer disrupts highlighting of subsequent fenced blocks.Other remarks
cm6.jsabout 0.89 MB. Out of this, about 600KB are REx parser tables (lists of integers), which the script contains in uncompressed form. By turning on transfer-level gzip compression, this can be greatly reduced.