Repository navigation
Conversation
…ction
CosmosCoin.verifyTransaction compared txParams.recipients, which encode
the memo as `address?memoId=X`, against explainTransaction() outputs
(plain address plus a separate memo field) as raw strings. Any
memo-tagged TIA recipient therefore failed local validation with
"Tx outputs does not match with expected txParams recipients", even
when the transaction was built correctly.
Override verifyTransaction in Tia to split the recipient address via
getAddressDetails() so both sides are compared as {address, amount,
memo?}. This also rejects a recipient missing its memoId when the tx
carries a memo, which the base implementation let through silently.
Mirrors the ZETA fix (51d997c). Scoped to sdk-coin-tia only.
Ticket: COINS-1760
Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_0197EizfQXpRL29XyEsyVJ4k
Contributor
Contributor
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TIA withdrawals to a memo-tagged recipient fail local validation with
Tx outputs does not match with expected txParams recipients(reported on testnet, wallet6ac4da81…).CosmosCoin.verifyTransactioncomparestxParams.recipients, which carry the memo asaddress?memoId=X, againstexplainTransaction()outputs, which have a plain address plus a separatememofield, as raw strings. The built tx is correct (its memo0matches?memoId=0), but the two sides never match, so every memo-tagged recipient is rejected.Fix: override
verifyTransactioninTiato split the recipient withgetAddressDetails()and compare{address, amount, memo?}on both sides. This mirrors the ZETA fix (51d997c). It also rejects a recipient missing its memoId when the tx has a memo, which the base class previously let through.Scoped to
sdk-coin-tiaonly.abstract-cosmosand the other Cosmos coins are untouched and have the same gap.lodashis added todependenciessince it is now imported at runtime (it was already in the lockfile).Issue Number
COINS-1760
Type of change
How Has This Been Tested?
sdk-coin-tia: memo-suffixed recipient passes, mismatched memoId is rejected, missing memoId is rejected. Without the fix, the first and third fail.BITGOJS_TEST_PASSWORD=test mochainmodules/sdk-coin-tia: 80 passing.eslintclean and the module builds withtsc.🤖 Generated with Claude Code
https://claude.ai/code/session_0197EizfQXpRL29XyEsyVJ4k
Generated by Claude Code