Repository navigation
test(sdk-coin-stx): document v2 fixture regeneration steps - #9996
Draft
Doddanna17 wants to merge 1 commit into
Draft
Doddanna17 wants to merge 1 commit into
Doddanna17 wants to merge 1 commit into
Conversation
Record how UNCOMPRESSED_MULTISIG_UNSIGNED_TRANSFER and
UNCOMPRESSED_MULTISIG_SIGNED_TRANSFER were produced (scratch install of
@stacks/transactions 2.0.1 + @stacks/network 4.3.0, makeUnsignedSTXTokenTransfer
with the uncompressed pubkeys of prv1/prv2/prv3, TransactionSigner
signOrigin/appendOrigin, then serialize().toString('hex')) so the v2 oracle used
by the multisig parity test is reproducible without guessing.
Comment-only: no assertions or fixtures change.
Ticket: SI-2024
Contributor
Contributor
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Comment-only follow-up to #9994 (the
@stacks/transactionsv7 migration). It records how the two v2-generated fixtures used by the multisig parity test were produced, so the oracle can be reproduced without reverse-engineering it.UNCOMPRESSED_MULTISIG_UNSIGNED_TRANSFER/UNCOMPRESSED_MULTISIG_SIGNED_TRANSFER(modules/sdk-coin-stx/test/unit/resources.ts) were generated with@stacks/[email protected]+@stacks/[email protected], from the uncompressed pubkeys ofprv1/prv2/prv3:makeUnsignedSTXTokenTransfer(opts)→TransactionSigner.signOrigin(prv1),signOrigin(prv2),appendOrigin(U[2])→serialize().toString('hex').The comment now inlines those steps (install, key derivation, options, unsigned vs signed variant). No assertions, fixtures or source change — every added line is a comment.
Issue Number
SI-2024
Type of change
Please delete options that are not relevant.
Comment-only test change documenting fixture provenance — none of the above apply.
How Has This Been Tested?
modules/sdk-coin-stx:npx mocha— 328 passing / 0 failing, includingbuilds an uncompressed-key multisig transfer byte-identically to the v2 fixture, which asserts bothfixtures byte-for-byte (unsigned build +
appendOrigin, and the 2-of-3 signed build).npx tsc --build .— 0 errors ·npx eslint --quiet .— 0 errors ·prettier --check— clean.master(91eeaace57, the merge of feat(sdk-coin-stx): migrate @stacks/transactions to v7.6.0 #9994); the diff is 11 added linesin one test file.
Checklist:
Commits
63c57affb3test(sdk-coin-stx): document v2 fixture regeneration stepsRelated