Skip to content

test(sdk-coin-stx): document v2 fixture regeneration steps - #9996

Draft
Doddanna17 wants to merge 1 commit into
masterfrom
SI-2024-stx-v2-fixture-provenance
Draft

Doddanna17 wants to merge 1 commit into
masterfrom
SI-2024-stx-v2-fixture-provenance

Conversation

@Doddanna17

Copy link
Copy Markdown
Contributor

Description

Comment-only follow-up to #9994 (the @stacks/transactions v7 migration). It records how the two v2-generated fixtures used by the multisig parity test were produced, so the oracle can be reproduced without reverse-engineering it.

  • UNCOMPRESSED_MULTISIG_UNSIGNED_TRANSFER / UNCOMPRESSED_MULTISIG_SIGNED_TRANSFER (modules/sdk-coin-stx/test/unit/resources.ts) were generated with @stacks/[email protected] + @stacks/[email protected], from the uncompressed pubkeys of prv1/prv2/prv3:
    makeUnsignedSTXTokenTransfer(opts) → TransactionSigner.signOrigin(prv1), signOrigin(prv2), appendOrigin(U[2]) → serialize().toString('hex').

The comment now inlines those steps (install, key derivation, options, unsigned vs signed variant). No assertions, fixtures or source change — every added line is a comment.

Issue Number

SI-2024

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Comment-only test change documenting fixture provenance — none of the above apply.

How Has This Been Tested?

  • modules/sdk-coin-stx: npx mocha — 328 passing / 0 failing, including
    builds an uncompressed-key multisig transfer byte-identically to the v2 fixture, which asserts both
    fixtures byte-for-byte (unsigned build + appendOrigin, and the 2-of-3 signed build).
  • npx tsc --build . — 0 errors · npx eslint --quiet . — 0 errors · prettier --check — clean.
  • Branch is rebased directly on master (91eeaace57, the merge of feat(sdk-coin-stx): migrate @stacks/transactions to v7.6.0 #9994); the diff is 11 added lines
    in one test file.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My code compiles correctly for both Node and Browser environments
  • I have commented my code, particularly in hard-to-understand areas
  • My commits follow Conventional Commits and I have properly described any BREAKING CHANGES
  • The ticket or github issue was included in the commit message as a reference
  • I have made corresponding changes to the documentation and on any new/updated functions and/or methods — N/A, comment-only; no API/docs change
  • I have added tests that prove my fix is effective or that my feature works — N/A, no behaviour change (the fixtures themselves were added in feat(sdk-coin-stx): migrate @stacks/transactions to v7.6.0 #9994)
  • New and existing unit tests pass locally with my changes

Commits

SHA subject contents
63c57affb3 test(sdk-coin-stx): document v2 fixture regeneration steps comment-only provenance for the two v2-generated multisig fixtures

Related

Record how UNCOMPRESSED_MULTISIG_UNSIGNED_TRANSFER and
UNCOMPRESSED_MULTISIG_SIGNED_TRANSFER were produced (scratch install of
@stacks/transactions 2.0.1 + @stacks/network 4.3.0, makeUnsignedSTXTokenTransfer
with the uncompressed pubkeys of prv1/prv2/prv3, TransactionSigner
signOrigin/appendOrigin, then serialize().toString('hex')) so the v2 oracle used
by the multisig parity test is reproducible without guessing.

Comment-only: no assertions or fixtures change.

Ticket: SI-2024
@linear-code

linear-code Bot commented Oct 17, 2026

Copy link
Copy Markdown
Contributor

SI-2024

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Unit tests are failing on Node 26.x (Current release line, non-blocking). This is not an LTS version yet, so it does not block merge, but it signals an incompatibility to fix before Node 26.x becomes LTS.

View run

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant