Repository navigation
i18n(he): translate the text direction to rtl - #690
Merged
Merged
Conversation
lang/he.po had an empty msgstr for "ltr", so t`ltr` stayed "ltr" in Hebrew and <body dir> (index.pug, and the language switch in app.js) was left-to-right. The RTL stylesheet already lays the page out right-to-left; this fixes the dir attribute that screen readers, bidi ordering of mixed Hebrew/Latin text (addresses, txids) and form inputs rely on. he.json gets only the new key; it is not regenerated, so the hand-fixed "in %s blocks (%s from tip)" string stays as it is.
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The PO and JSON updates are consistent with the existing Hebrew RTL stylesheet configuration.
Review effort: Balanced
Findings: None
What changed in this PR
Sets Hebrew text direction to RTL for accessibility and bidirectional text handling.
Changes:
- Translates the
ltrdirection marker tortl. - Synchronizes the PO and runtime JSON translations.
| File | Description |
|---|---|
lang/he.po |
Defines Hebrew text direction as RTL. |
lang/he.json |
Adds the runtime RTL direction mapping. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Randy808
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lang/he.pohas an emptymsgstrforltr, sot`ltr`staysltrin Hebrew.<body dir>(set inclient/index.pugand by the language switch inclient/src/app.js) is therefore left-to-right.The RTL stylesheet already lays the page out right-to-left, so the page looks the same. The
dirattribute is still what screen readers, the bidi ordering of mixed Hebrew/Latin text (addresses, txids) and form inputs rely on.lang/he.po:msgid "ltr"→msgstr "rtl".lang/he.json: adds only"ltr": "rtl". The file is not regenerated, becausepo2jsonwould undo the hand-fixed"in %s blocks (%s from tip)"string.Checked in a local build with headless Chromium: switching to Hebrew sets
dir="rtl"(computedrtl) and loadsstyle-rtl; English and German stayltr; no page errors. Unit tests pass.Note: the translation should also be set in Transifex, otherwise the next
l10n:fetchresets it.