Repository navigation
Conversation
…ision update_jets.sh only warned when the libsimplicity checkout running GenRustJets was at a different revision from the vendored one, or had local changes, so the jets could silently come from a different generator than the vendored C. Add update_jets.sh --check, which recomputes the lock file contents for the vendored revision and fails unless they match update_jets.lock, and run it in the Vendored libsimplicity job. This catches jets generated from a different libsimplicity revision as well as hand edits to the generated files, without needing a Haskell toolchain in CI. The update_jets.lock here was written by running this script at the vendored revision ba967b1a. It regenerated the jets byte-for-byte, confirming that the committed jets match that revision. Assisted by Claude.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update_jets.sh only warned when the libsimplicity checkout running GenRustJets was at a different revision from the vendored one, or had local changes, so the jets could silently come from a different generator than the vendored C. This
has been changed to an error.
Add update_jets.sh --check, which recomputes the lock file contents for the vendored revision and fails unless they match update_jets.lock, and run it in the Vendored libsimplicity job. This catches jets generated from a different libsimplicity revision as well as hand edits to the generated files, without needing a Haskell toolchain in CI.
The update_jets.lock here was written by running this script at the vendored revision ba967b1a. It regenerated the jets byte-for-byte, confirming that the committed jets match that revision.
Assisted by Claude.