Repository navigation
Take the metrics an accept-when line reads on every case; say what best-on-the-evals and cost mean - #43
Merged
Conversation
…st-on-the-evals and cost mean evals.check returned at a case's first failed rule, so a metric an accept-when line holds a model to was averaged over the easier cases a model got past, favouring the model that failed more. check now takes taken_on_every_case (resolve.evaluate passes selection.metrics_read of the agent's lines) and takes those metrics on a failed case too; the case still fails for the same reason. The schema help says best-on-the-evals is the largest share of cases passed (cheaper wins a tie), that prefer chooses only when model: is left out, and that cost is the agent's own spend, not grading.
…antics # Conflicts: # CHANGELOG.md # adapters/python/src/pact_adapters/selection.py
jithinAB
marked this pull request as ready for review
November 17, 2026 03:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A metric a model is held to is taken on every case, and
prefer:says what "best" meansaccept-when:reads are taken on every case.evals.checkreturns at a case's first failed rule, sorefund-tone.score >= 0.8was held to the mean over only the cases a model got past their first failure. That is an easier subset, and it favours the model that failed more.checktakes a newtaken_on_every_case, andresolve.evaluatepasses it from the agent's lines (selection.metrics_read). Each of those metrics is taken on a failed case too; the case still fails, for the reason it failed before.<metric>.score,.pass-rateand.casestherefore cover the whole suite. Any other metric still stops at the first failure, so a suite nobody holds a model to costs no more grading. A failed outcome now keeps the scores it took (CaseOutcome.scores), as a passed one does.best-on-the-evalsis defined as the largest share of the suite's cases passed, with the cheaper model winning a tie. This is what_cheapest_passingalready does. The help said "the highest score", which could be read as a metric mean.prefer:chooses only whenmodel:is left out, asresolvealready behaves. The help now says so.costis the agent's own spend per case, not what grading cost. The help now says so. A runtime that meters the judge (Bud Meta Harness does) reports that spend apart fromcost.Proof
test_a_metric_an_accept_line_reads_is_taken_on_every_case: two cases, one of which failsexpect:first. Withouttaken_on_every_case,brevity.scoreis 1.0 over one case andbrevity.score >= 0.8holds. With it, the score covers two cases and the line does not hold. Pass and fail and the failure's reason are unchanged.test_an_accept_line_means_one_thing.py,test_metrics_an_expert_brings.py,test_a_host_supplies_what_grades_a_case.pyandtest_judged_rules.py: 101 passed, 2 skipped (opt-in live judge). The full adapter suite is running and the result will be posted here.Purpose checklist (BMH PACT v97 §0.2)
accept-when:lines.check) and reports the difference from the pinned reference until a re-pin includes this change.measured,held_after).🤖 Generated with Claude Code