Repository navigation
A runtime may serve a workspace without its broken agents (--leave-out-broken-agents) - #44
Merged
Merged
Conversation
pact show and pact discover take --leave-out-broken-agents: when every error of a workspace lies in some agents' own folders, the workspace is validated again without those agents and served if it then loads, each left-out agent named (loader/agent-left-out, and a left-out list in discover's inventory). Without the flag nothing changes, since a session's door and a sealed plan read pact show's exit code. pact check still refuses the tree. Co-Authored-By: Claude Opus 5.5 <[email protected]>
jithinAB
marked this pull request as ready for review
November 16, 2026 19:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A runtime that serves a PACT tree edited while it runs (Bud Meta Harness publishes every agent of a watched tree and keeps serving them) lost every agent of a workspace the moment one agent was edited badly:
pact discoverprintedskipping <root>: N problem(s)andpact showexited 1. Agents nobody had touched went out of service with the broken one. This was found live (BMH tier 8t8-pact-hot-edit: one agent'ssteps-at-most:set below the floor withdrew its sibling too).What changes
pact showandpact discovertake--leave-out-broken-agents. With it, when every error of a workspace lies in some agents' own folders (agents/<key>/…), the workspace is validated again without those agents and served if it then loads (exit 0). Each left-out agent is named on stderr (loader/agent-left-out) with its own errors shown as warnings, anddiscoveradds"left-out": [{ "id": "pact:<key>", "problems": N }]to the workspace's inventory, so a runtime can keep serving the version it last had of them.pact show's exit code is how PACT Core: a language the checker reads, a workspace that changes while it runs, and a sealed plan #39's session door (session._checked) andcompile_plandecide a document loads; neither may lose an agent quietly, so isolation is asked for, never implied. (The first version of this change made it the default; rebasing onto PACT Core: a language the checker reads, a workspace that changes while it runs, and a sealed plan #39 showed that would let a proposal that breaks one agent through the door with that agent silently dropped.)pact check <root>still refuses the tree.pact check <agent>for a clean agent beside broken siblings now saysloader/other-agents-left-out(a runtime that leaves them out runs this agent) instead ofloader/the-workspace-around-it-is-broken.site-docs/reference/cli.md(show,discover), USAGE, CHANGELOG; headline test counts.Tests
crates/pact-cli/tests/one_broken_agent_leaves_its_workspace_served.rs: with the flag, the broken agent is left out and its sibling is served bydiscoverandshow; without it,discoverskips andshowexits 1;pact checkrefuses the tree andpact check agents/clerksaysloader/other-agents-left-out; a teammate naming the broken agent keeps the workspace refused even with the flag.cargo build, wasm build,cargo test, clippy (both targets,-D warnings), TypeScripttsc --noEmit, and the Python adapter suite (3560 passed, 31 skipped) all pass.Purpose (PACT for BMH)
checkstill tells the author.left-outlist.🤖 Generated with Claude Code