Repository navigation
boards: add support for usbcan_iso, usbcanfd solo/dual,canbridge_g473 - #219
AlekseyMamontov wants to merge 5 commits into
Conversation
henrikbrixandersen
left a comment
There was a problem hiding this comment.
Please address the review comments below and split into three commits, one for each board.
There was a problem hiding this comment.
Please remove this change.
|
Hello Brix (@henrikbrixandersen), thanks for the review! )) |
… and boot animation Signed-off-by: Oleksii <[email protected]>
|
Hi @henrikbrixandersen, I've addressed your feedback. Or is there still something off? )) |
You have addressed some of it. I cannot stress this enough: When proposing changes to open source software it is crucial that you review your own proposed changes before burdening anybody with that task. |
|
ok |
a3fd80b to
791ee4d
Compare
|
Closing due to unresponsive submitter. |
|
Well, you could say that)) 'cause I was already out of ideas on what else needed fixing ) |
Hello Brix, @henrikbrixandersen ,
This pull request adds support for the following hardware targets:
usbcan_iso (STM32F072XB)
usbcanfd_solo (STM32G431XX)
usbcanfd_dual and canbridge_g473 (STM32G473XX)
Signed-off-by: Oleksii Mamontov [email protected]