Repository navigation
Conversation
Due to the way how the tests runners and linters are set up, when `test_a.py` imported `test_b`, it would pass during regular test execution and fail with pylint. That ain't good. Signed-off-by: Jan Kundrát <[email protected]> Co-authored-by: Claude Sonnet 5 <[email protected]>
Upstream libyang now unconditionally needs certain core YANG modules, and they are not available as builtins in the library. Load them via the usual lookups from disk instead. Since context creation without access to on-disk data is now broken, the tests which excercie this path have to first change to loading "a minimal context" with file lookup enabled, and then disable this feature via a newly wrapped function. Signed-off-by: Jan Kundrát <[email protected]> Co-authored-by: Claude Sonnet 5 <[email protected]>
...to the latest that we're testing against. Signed-off-by: Jan Kundrát <[email protected]>
And I have to add this line here just to make the CI happy, even though everything is in the first line. Oh well. Signed-off-by: Jan Kundrát <[email protected]>
And I have to type stuff here just to make CI happy, even though the subject oneliner above has all the required info. Oh well. Co-authored-by: Claude Sonnet 5 <[email protected]> Signed-off-by: Jan Kundrát <[email protected]>
And a placeholder sentence to make the linter happy. Signed-off-by: Jan Kundrát <[email protected]>
Since upstream commit CESNET/libyang@b6ccfc9, `libyang.h` no longer pulls in `plugins.h`, and therefore `lyplg_add_extension_plugin` was not declared properly. Co-authored-by: Claude Sonnet 5 <[email protected]> Signed-off-by: Jan Kundrát <[email protected]>
I do not think that this test tests much, but hey, it's there, so let's adapt to how the upstream libyang actually behaves and to what it calls now. Signed-off-by: Jan Kundrát <[email protected]>
...so that we actually enforce something that we test against. Signed-off-by: Jan Kundrát <[email protected]>
jktjkt
force-pushed
the
fix/build-with-develop
branch
from
September 23, 2026 19:03
e773ef3 to
685a471
Compare
Collaborator
|
Hi, thanks a lot for your work. Sorry for the delay in reviewing; as usual, I don't have much time allocated for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This needs #173 and #174.