Repository navigation
[DO NOT MERGE until backend #235 is deployed] Saved analysis says which engine made it - #336
Draft
ashtonanderson wants to merge 2 commits into
Draft
ashtonanderson wants to merge 2 commits into
ashtonanderson wants to merge 2 commits into
Conversation
…vals are redone Saved analysis had no engine, and the backend replaces an eval only at a greater depth, so a game analysed before Stockfish 19 kept Stockfish 17's evals and marks for good, under a label saying Stockfish 19, and later saves couldn't change them. Every search now records its engine and saves it. A saved eval from another engine, or without one, shows at once, and is searched again when its position is visited; it stays on show until that search finishes, then is replaced and saved with its engine. Evals from the server's own analysis aren't affected. Needs the backend to store the engine first: without it, saved analysis comes back unlabelled, and every saved position would be searched on every visit. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
DO NOT MERGE until CSSLab/maia-platform-backend#235 is merged AND deployed.
Without it, saved analysis comes back unlabelled, so every saved position would be searched again on every visit, for every visitor. Being merged isn't enough: check that the live
get_engine_analysisreturns anenginefield first.Saved analysis now says which engine made it, and evals from an older engine get redone when their position is visited. Today a game analysed before #334 keeps Stockfish 17's evals and move marks for good, under a label saying Stockfish 19.
What changes
stockfishSearchIsDone(src/lib/analysis.ts) is now the one definition of "done", used by the analysis page, full-game analysis and drills.Things to know
human-bar-2ignores cached evals for now, and could useolder_engineinstead.Testing
npm test(97),npx tsc --noEmitandnpm run lintpass.🤖 Generated with Claude Code