Repository navigation
Android: touch timeline editor and timeline export - #1099
Merged
Merged
Conversation
Adds a single-track clip timeline page to the mobile shell (scene card button). Scene and template clips can be added at the playhead, dragged, trimmed, split, duplicated and deleted with snap to bars/beats, undo/redo, BPM and tempo-from-audio. Playback applies a clip's scene when the playhead enters it. The data is the desktop timeline model (cfg.timeline), so it also opens on the computer. Export gets a "With the timeline" toggle that sets cfg.export.includeTimeline/timelineId, so the video is drawn from the timeline with transitions. Probe: new `timeline` command (real drag, ruler taps, export frame diff); the document picker now scrolls when the file is below the fold and only opens the roots drawer when it is not in Downloads. Co-authored-by: caganturgut <[email protected]>
…gle is off Co-authored-by: caganturgut <[email protected]>
Co-authored-by: caganturgut <[email protected]>
… timeline button Co-authored-by: caganturgut <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #1054 (Faz 5 MVP).
What
cfg.timeline), so the same timeline opens on the computer.cfg.export.includeTimeline/timelineId, so the video follows the timeline, transitions included.Not in this MVP
Single track only; no automation lanes, markers, tempo changes, loop region or video clips.
Verification (API 36 emulator)
node android/tools/probe.js timeline: two template scenes, two clips, real adb drag (snapped to bars), ruler taps fire the right clip, export with the timeline gives 600 frames and the frame at 1s differs clearly from the frame at 7s (diff 338 > 30).npm test: 4570 pass, 0 fail.node --test android/js-tests/*.test.js: 72 pass.