Repository navigation
Android: export codec and quality, embedded lyrics, logo cover - #1101
Merged
Merged
Conversation
- Export: quality preset (bitrate) and codec. H.265 is offered only when the device has an encoder for it (`exportCaps`); otherwise H.264. - Embedded lyrics (ID3 SYLT/USLT) for the in-app player and for export: src/shared/id3-lyrics.js, with a parity test against the desktop parser. - Logo layer: "auto"/"track" show the playing track's cover on Android. Mode thumbnails regenerated (layers.js is part of their key). - Fix: saving failed after 32 exports of the same song (MediaStore tries 32 numbers per name when a pending file is published); the file is then published with the date and time added. - Probe: exportui --codec/--quality and gallery rows by date; new `embedded` command. For #1054 Co-authored-by: caganturgut <[email protected]>
- The cue (hold) marker drew a pause emoji on the ruler and in the marker list, and a locked track showed a lock emoji in the narrow header. They now use the app's own icons (the canvas draws two bars), as the rest of the interface does (src/shared/icons.js). - The full transport row (previous/next, "Use timeline" label) needs about 640 px; in the landscape phone's side panel (~575 px) GO overlapped the "Use timeline" button. The full row now starts at 700 px; below that previous/next stay in the toolbar. - The lane paints as soon as its size is known instead of waiting for the next animation frame (on a heavy scene the canvas stayed empty for over a second on the emulator). - Debug state (`_state`) also reports the song wait, for probes. For #1054 Co-authored-by: caganturgut <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #1054 (Phase 4/5 leftovers that do not need a phone).
Export: codec and quality (PLAN Phase 5 lists both)
ExportHubalready took abitrate; the export page now sends it.MediaCodecListhas an encoder for 1080p (exportCaps). With H.265 the bitrate is 0.6× for the same quality. If the device lacks the encoder, the app falls back to H.264.Fix: saving failed after 32 exports of the same song
MediaStore gives a pending file its final name when it is published (
IS_PENDING=0). It tries at most 32 numbers for the same name ("name (1)" … "name (31)"), then refuses ("Failed to build unique file", fromMediaProvider.update). A user who exported the same song 32 times saw "Could not save" from then on. Found on the emulator, whose gallery had reachedsv-test-song (31).mp4. In that caseExportFlow.savenow publishes with the date and time added (sv-test-song 2026-11-18 00-47-56.mp4). It also returns the name the gallery actually used.Embedded lyrics (desktop's automatic lyrics, "embedded" step, #937)
src/shared/id3-lyrics.js: the desktop parser (src/main/lyrics-lookup.jsparseId3Lyrics,syltToLrc,findEmbedded) rewritten onUint8Array/TextDecoder, so it loads in the engine page. The desktop file is unchanged.android/js-tests/id3-lyrics.test.jsrequires the desktop module and compares both on 26 generated tags (v2.3/v2.4, extended header, USLT in latin1, UTF-16 with either BOM, UTF-16BE without BOM and UTF-8, SYLT in milliseconds with and without line breaks, both frames together, non-ID3, v2.2), plus the selection rule and tag size.embeddednot off) and the scene has a lyrics layer, the song's embedded lyrics go into the job aslyricsAuto. This is the same field the desktop export fills.playerHeadrequest reads only the ID3 tag of the playing file (≤ 4 MB) on the lyrics worker. If that tag has no lyrics, the app's cache and provider lookup runs as before.Logo layer cover on Android
resolveLogoSrctreated every non-Windows platform as "cannot read album art". Android can (in-app player and media session), so "auto"/"track" now show the playing track's cover there. The change is inlayers.js, which is part of the mode-thumbnail key, so the 121 thumbnails were regenerated (node scripts/gen-mode-thumbs.js).bg:solidhas no thumbnail, the same as before (--checkreports 1 missing on dev/android too).Timeline UI fixes (found while taking the layout screenshots)
src/shared/icons.js).wm size 2560x1600.Verification (API 36 emulator, SwiftShader)
exportui: H.264 Low 2210 kbps, High 8244 kbps, AAC audio. Asking for H.265 + High on the emulator:exportCapsreports no HEVC encoder, so it fell back to H.264 at 8244 kbps. H.265 itself is unverified until a phone with an encoder.sv-test-song (n).mp4already there, the export was saved assv-test-song 2026-11-18 01-35-30.mp4(before the fix: "Could not save").embedded: an MP3 with SYLT lyrics, played in the in-app player, gives lyrics withauto: "embedded"and text starting[00:00.50]Gömülü söz bir.resolveLogoSrcon Android gives the player's artwork for "track" and "auto"; "manual" keeps its own image.node scripts/gen-mode-thumbs.js --check: 122 total, 1 missing (bg:solid, same as before). Spot-checked 8 regenerated ones.node --test android/js-tests/*.test.js: 100 pass (28 inid3-lyrics.test.js).npm test: 4570 pass, 1 skipped.