Skip to content

Theme the syslog severity legends as rounded, solid-colour chips #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheWitness merged 7 commits into from
Oct 6, 2026
Merged

Theme the syslog severity legends as rounded, solid-colour chips #385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
495b135
Theme the syslog severity legends as rounded, solid-colour chips
Oct 6, 2026
5cf1d83
Move functions.php into includes/ and update coverage
Oct 6, 2026
fb353cd
Keep functions.php out of setup.php's global scope
Oct 6, 2026
b0efa27
Address legend review: contrast, scoped fallback, GPL headers
Oct 6, 2026
fa353ad
Use the full GPL v2 header in SyslogLegendTest
Oct 6, 2026
6b5b787
Drop Ruby from the CodeQL language matrix
Oct 6, 2026
2459db7
Move database.php into includes/
Oct 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/codeql.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
strategy:
fail-fast: false
matrix:
language: ["javascript-typescript", "python", "ruby"]
language: ["javascript-typescript", "python"]
steps:
- name: Checkout repository
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
Expand Down
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

--- develop ---

* ci: Drop Ruby from the CodeQL language matrix; the plugin ships no Ruby source, so the Ruby database build failed with "no source code seen"
* dev: Move the shared function and database libraries to includes/ and point the entry-point includes, coverage source, and tests at the new path
* feature: Restyle the System Logs and Alert Logs severity legends as rounded, evenly spaced, solid-colour chips that line up with the Thold status legends, with theme-appropriate backgrounds loaded from a per-theme css/<theme>.css file (falling back to a theme-neutral css/legend.css)
* dev: Measure CI coverage with xdebug instead of pcov so the plugin's own sources are instrumented (pcov auto-scopes to the Composer root and skipped cacti/plugins/, leaving the patch-coverage gate with nothing to measure)
* dev: Enforce patch coverage of changed lines in CI and remove the inert COMPOSER_ROOT_VERSION env from the Pest step
* feature: Add Device Alert Rules for device-wide alert handling: administrators can pause a device's non-exempt alerts until a selected time or indefinitely, choose a priority threshold that always passes through device pauses and maintenance windows, and allow all device alerts during maintenance for critical devices
Expand Down
50 changes: 50 additions & 0 deletions css/classic.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
/*
+-------------------------------------------------------------------------+
| Copyright (C) 2004-2026 The Cacti Group |
| |
| This program is free software; you can redistribute it and/or |
| modify it under the terms of the GNU General Public License |
| as published by the Free Software Foundation; either version 2 |
| of the License, or (at your option) any later version. |
| |
| This program is distributed in the hope that it will be useful, |
| but WITHOUT ANY WARRANTY; without even the implied warranty of |
| MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
| GNU General Public License for more details. |
+-------------------------------------------------------------------------+
| Cacti: The Complete RRDtool-based Graphing Solution |
+-------------------------------------------------------------------------+
| This code is designed, written, and maintained by the Cacti Group. See |
| about.php and/or the AUTHORS file for specific developer information. |
+-------------------------------------------------------------------------+
| http://www.cacti.net/ |
+-------------------------------------------------------------------------+
*/

/* Syslog status-legend palette for the classic (light surface) theme. */

.syslogLegend {
display: flex;
flex-wrap: wrap;
gap: 4px;
width: 100%;
}

.syslogLegend .syslogLegendItem {
flex: 1 1 0;
text-align: center;
white-space: nowrap;
padding: 4px 6px;
border-radius: 3px;
color: #ffffff;
font-size: 11px;
Comment thread
TheWitness marked this conversation as resolved.
}

.syslogLegend .logEmergency { background-color: #8e1f18; }
.syslogLegend .logCritical { background-color: #a5281f; }
.syslogLegend .logAlert { background-color: #b23a2f; }
.syslogLegend .logError { background-color: #c0483c; }
.syslogLegend .logWarning { background-color: #9c5d0a; }
.syslogLegend .logNotice { background-color: #2f6fa8; }
.syslogLegend .logInfo { background-color: #2f7d3a; }
.syslogLegend .logDebug { background-color: #6c7a72; }
50 changes: 50 additions & 0 deletions css/dark.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
/*
+-------------------------------------------------------------------------+
| Copyright (C) 2004-2026 The Cacti Group |
| |
| This program is free software; you can redistribute it and/or |
| modify it under the terms of the GNU General Public License |
| as published by the Free Software Foundation; either version 2 |
| of the License, or (at your option) any later version. |
| |
| This program is distributed in the hope that it will be useful, |
| but WITHOUT ANY WARRANTY; without even the implied warranty of |
| MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
| GNU General Public License for more details. |
+-------------------------------------------------------------------------+
| Cacti: The Complete RRDtool-based Graphing Solution |
+-------------------------------------------------------------------------+
| This code is designed, written, and maintained by the Cacti Group. See |
| about.php and/or the AUTHORS file for specific developer information. |
+-------------------------------------------------------------------------+
| http://www.cacti.net/ |
+-------------------------------------------------------------------------+
*/

/* Syslog status-legend palette for the dark (dark surface) theme. */

.syslogLegend {
display: flex;
flex-wrap: wrap;
gap: 4px;
width: 100%;
}

.syslogLegend .syslogLegendItem {
flex: 1 1 0;
text-align: center;
white-space: nowrap;
padding: 4px 6px;
border-radius: 3px;
color: #edf3ef;
font-size: 11px;
}

.syslogLegend .logEmergency { background-color: #8a2f2f; }
.syslogLegend .logCritical { background-color: #863a3c; }
.syslogLegend .logAlert { background-color: #8f4339; }
.syslogLegend .logError { background-color: #8a5244; }
.syslogLegend .logWarning { background-color: #86682f; }
.syslogLegend .logNotice { background-color: #35607f; }
.syslogLegend .logInfo { background-color: #3a6e46; }
.syslogLegend .logDebug { background-color: #4a534e; }
50 changes: 50 additions & 0 deletions css/legend.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
/*
+-------------------------------------------------------------------------+
| Copyright (C) 2004-2026 The Cacti Group |
| |
| This program is free software; you can redistribute it and/or |
| modify it under the terms of the GNU General Public License |
| as published by the Free Software Foundation; either version 2 |
| of the License, or (at your option) any later version. |
| |
| This program is distributed in the hope that it will be useful, |
| but WITHOUT ANY WARRANTY; without even the implied warranty of |
| MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
| GNU General Public License for more details. |
+-------------------------------------------------------------------------+
| Cacti: The Complete RRDtool-based Graphing Solution |
+-------------------------------------------------------------------------+
| This code is designed, written, and maintained by the Cacti Group. See |
| about.php and/or the AUTHORS file for specific developer information. |
+-------------------------------------------------------------------------+
| http://www.cacti.net/ |
+-------------------------------------------------------------------------+
*/

/* Theme-neutral Syslog status-legend palette; the fallback loaded by syslog_include_js() when the active theme ships no dedicated css/<theme>.css file. */

.syslogLegend {
display: flex;
flex-wrap: wrap;
gap: 4px;
width: 100%;
}

.syslogLegend .syslogLegendItem {
flex: 1 1 0;
text-align: center;
white-space: nowrap;
padding: 4px 6px;
border-radius: 3px;
color: #ffffff;
font-size: 11px;
}

.syslogLegend .logEmergency { background-color: #8e1f18; }
.syslogLegend .logCritical { background-color: #a5281f; }
.syslogLegend .logAlert { background-color: #b23a2f; }
.syslogLegend .logError { background-color: #c0483c; }
.syslogLegend .logWarning { background-color: #9c5d0a; }
.syslogLegend .logNotice { background-color: #2f6fa8; }
.syslogLegend .logInfo { background-color: #2f7d3a; }
.syslogLegend .logDebug { background-color: #6c7a72; }
50 changes: 50 additions & 0 deletions css/midwinter.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
/*
+-------------------------------------------------------------------------+
| Copyright (C) 2004-2026 The Cacti Group |
| |
| This program is free software; you can redistribute it and/or |
| modify it under the terms of the GNU General Public License |
| as published by the Free Software Foundation; either version 2 |
| of the License, or (at your option) any later version. |
| |
| This program is distributed in the hope that it will be useful, |
| but WITHOUT ANY WARRANTY; without even the implied warranty of |
| MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
| GNU General Public License for more details. |
+-------------------------------------------------------------------------+
| Cacti: The Complete RRDtool-based Graphing Solution |
+-------------------------------------------------------------------------+
| This code is designed, written, and maintained by the Cacti Group. See |
| about.php and/or the AUTHORS file for specific developer information. |
+-------------------------------------------------------------------------+
| http://www.cacti.net/ |
+-------------------------------------------------------------------------+
*/

/* Syslog status-legend palette for the midwinter (dark surface) theme. */

.syslogLegend {
display: flex;
flex-wrap: wrap;
gap: 4px;
width: 100%;
}

.syslogLegend .syslogLegendItem {
flex: 1 1 0;
text-align: center;
white-space: nowrap;
padding: 4px 6px;
border-radius: 3px;
color: #edf3ef;
font-size: 11px;
}

.syslogLegend .logEmergency { background-color: #8a2f2f; }
.syslogLegend .logCritical { background-color: #863a3c; }
.syslogLegend .logAlert { background-color: #8f4339; }
.syslogLegend .logError { background-color: #8a5244; }
.syslogLegend .logWarning { background-color: #86682f; }
.syslogLegend .logNotice { background-color: #35607f; }
.syslogLegend .logInfo { background-color: #3a6e46; }
.syslogLegend .logDebug { background-color: #4a534e; }
50 changes: 50 additions & 0 deletions css/modern.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
/*
+-------------------------------------------------------------------------+
| Copyright (C) 2004-2026 The Cacti Group |
| |
| This program is free software; you can redistribute it and/or |
| modify it under the terms of the GNU General Public License |
| as published by the Free Software Foundation; either version 2 |
| of the License, or (at your option) any later version. |
| |
| This program is distributed in the hope that it will be useful, |
| but WITHOUT ANY WARRANTY; without even the implied warranty of |
| MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
| GNU General Public License for more details. |
+-------------------------------------------------------------------------+
| Cacti: The Complete RRDtool-based Graphing Solution |
+-------------------------------------------------------------------------+
| This code is designed, written, and maintained by the Cacti Group. See |
| about.php and/or the AUTHORS file for specific developer information. |
+-------------------------------------------------------------------------+
| http://www.cacti.net/ |
+-------------------------------------------------------------------------+
*/

/* Syslog status-legend palette for the modern (light surface) theme. */

.syslogLegend {
display: flex;
flex-wrap: wrap;
gap: 4px;
width: 100%;
}

.syslogLegend .syslogLegendItem {
flex: 1 1 0;
text-align: center;
white-space: nowrap;
padding: 4px 6px;
border-radius: 3px;
color: #ffffff;
font-size: 11px;
Comment thread
TheWitness marked this conversation as resolved.
}

.syslogLegend .logEmergency { background-color: #8e1f18; }
.syslogLegend .logCritical { background-color: #a5281f; }
.syslogLegend .logAlert { background-color: #b23a2f; }
.syslogLegend .logError { background-color: #c0483c; }
.syslogLegend .logWarning { background-color: #9c5d0a; }
.syslogLegend .logNotice { background-color: #2f6fa8; }
.syslogLegend .logInfo { background-color: #2f7d3a; }
.syslogLegend .logDebug { background-color: #6c7a72; }
50 changes: 50 additions & 0 deletions css/paper-plane.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
/*
+-------------------------------------------------------------------------+
| Copyright (C) 2004-2026 The Cacti Group |
| |
| This program is free software; you can redistribute it and/or |
| modify it under the terms of the GNU General Public License |
| as published by the Free Software Foundation; either version 2 |
| of the License, or (at your option) any later version. |
| |
| This program is distributed in the hope that it will be useful, |
| but WITHOUT ANY WARRANTY; without even the implied warranty of |
| MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
| GNU General Public License for more details. |
+-------------------------------------------------------------------------+
| Cacti: The Complete RRDtool-based Graphing Solution |
+-------------------------------------------------------------------------+
| This code is designed, written, and maintained by the Cacti Group. See |
| about.php and/or the AUTHORS file for specific developer information. |
+-------------------------------------------------------------------------+
| http://www.cacti.net/ |
+-------------------------------------------------------------------------+
*/

/* Syslog status-legend palette for the paper-plane (dark surface) theme. */

.syslogLegend {
display: flex;
flex-wrap: wrap;
gap: 4px;
width: 100%;
}

.syslogLegend .syslogLegendItem {
flex: 1 1 0;
text-align: center;
white-space: nowrap;
padding: 4px 6px;
border-radius: 3px;
color: #edf3ef;
font-size: 11px;
}

.syslogLegend .logEmergency { background-color: #8a2f2f; }
.syslogLegend .logCritical { background-color: #863a3c; }
.syslogLegend .logAlert { background-color: #8f4339; }
.syslogLegend .logError { background-color: #8a5244; }
.syslogLegend .logWarning { background-color: #86682f; }
.syslogLegend .logNotice { background-color: #35607f; }
.syslogLegend .logInfo { background-color: #3a6e46; }
.syslogLegend .logDebug { background-color: #4a534e; }
50 changes: 50 additions & 0 deletions css/paw.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
/*
+-------------------------------------------------------------------------+
| Copyright (C) 2004-2026 The Cacti Group |
| |
| This program is free software; you can redistribute it and/or |
| modify it under the terms of the GNU General Public License |
| as published by the Free Software Foundation; either version 2 |
| of the License, or (at your option) any later version. |
| |
| This program is distributed in the hope that it will be useful, |
| but WITHOUT ANY WARRANTY; without even the implied warranty of |
| MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
| GNU General Public License for more details. |
+-------------------------------------------------------------------------+
| Cacti: The Complete RRDtool-based Graphing Solution |
+-------------------------------------------------------------------------+
| This code is designed, written, and maintained by the Cacti Group. See |
| about.php and/or the AUTHORS file for specific developer information. |
+-------------------------------------------------------------------------+
| http://www.cacti.net/ |
+-------------------------------------------------------------------------+
*/

/* Syslog status-legend palette for the paw (light surface) theme. */

.syslogLegend {
display: flex;
flex-wrap: wrap;
gap: 4px;
width: 100%;
}

.syslogLegend .syslogLegendItem {
flex: 1 1 0;
text-align: center;
white-space: nowrap;
padding: 4px 6px;
border-radius: 3px;
color: #ffffff;
font-size: 11px;
Comment thread
TheWitness marked this conversation as resolved.
}

.syslogLegend .logEmergency { background-color: #8e1f18; }
.syslogLegend .logCritical { background-color: #a5281f; }
.syslogLegend .logAlert { background-color: #b23a2f; }
.syslogLegend .logError { background-color: #c0483c; }
.syslogLegend .logWarning { background-color: #9c5d0a; }
.syslogLegend .logNotice { background-color: #2f6fa8; }
.syslogLegend .logInfo { background-color: #2f7d3a; }
.syslogLegend .logDebug { background-color: #6c7a72; }
Loading
Loading