Repository navigation
Firefly-2110 ESLint identified error fixes - #2029
Merged
Merged
Conversation
aventura121
force-pushed
the
FIREFLY-2110-eslint-error-fixes
branch
from
October 1, 2026 15:40
e49ae91 to
26feee6
Compare
aventura121
marked this pull request as ready for review
October 1, 2026 21:56
robyww
reviewed
Oct 1, 2026
jaladh-singhal
approved these changes
Oct 6, 2026
jaladh-singhal
left a comment
jaladh-singhal
left a comment
Member
There was a problem hiding this comment.
Looks good - thanks for the cleanup!
aventura121
force-pushed
the
FIREFLY-2110-eslint-error-fixes
branch
from
October 6, 2026 21:26
c0b5158 to
f34a34c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firefly-2110: "Scope ESLint/Fix Error Messages"
Description
Fixes ESLint violations that can be checked by reading the fix, then removes those rules from the warn list in
eslint.config.mjsso they are errors again. We set missing semicolons back to error too.Most fixes are mechanical: extra
Boolean()casts, useless escapes, unreachablebreaks, andobj.hasOwnProperty()calls.Deletes
util/expr/__test__/Expression-test.js, an old mocha test that Jest never ran, and a related comment that mentioned it.Rules that still have violations stay at warn.
Build
https://firefly-2110-eslint-error-fixes-2.irsakubedev.ipac.caltech.edu/firefly
Testing
npx eslint .reports 0 errors on this branch.