Repository navigation
Merge upstream v0.8.1 - #14
Merged
Merged
Conversation
Closes: #487 ## Summary Charge the base gas and the message gas before the PQ precompile copies its three `bytes` arguments out of the input. The work that a call does is then limited by the gas that it pays. Co-authored-by: Zhiyu Zhang <[email protected]> Co-authored-by: Milap Sheth <[email protected]>
Upstream v0.8.1 contains circlefin/arc-node#486 (pq-precompile: reserve base gas before decoding input). No conflicts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Merge upstream
circlefin/arc-nodev0.8.1intomain.v0.8.1 contains one change, circlefin/arc-node#486: the PQ (SLH-DSA-SHA2-128s) precompile now charges base gas and message gas before copying its three
bytesarguments out of the input. In v0.8.0 a call with zero gas and calldata whose offsets alias one large array forced the full copy before running out of gas. Upstream adds a differential proptest against the old implementation, so gas used and outputs are unchanged; this is not a consensus change. The PQ precompile has no hardfork gate and is active on mainnet.malachite stays at
v0.8.0; upstream v0.8.1 still pins it.Merge
git merge v0.8.1: no conflictsCargo.lock: upstream addsproptesttoarc-pq-precompiledev-dependencies (one line)Validation
cargo check --workspace --all-targets --locked: passcargo test -p arc-pq-precompile -p arc-precompiles --locked: pass (arc-pq-precompile14/14 including the upstream differential test,arc-precompiles68 passed, 1 ignored)public.ecr.aws/b2h7a5c4/chaintable/arc-node:9a4fe718andarc-consensus:9a4fe718, amd64 + arm64)trace_debankBlockagainst production): pending, report will be committed to this branch atdocs/debank/merge-v0.8.1.md