Repository navigation
fix(op-reth): normalize CREATE2 DeBank traces - #16
Open
littlehand26 wants to merge 1 commit into
Open
littlehand26 wants to merge 1 commit into
littlehand26 wants to merge 1 commit into
Conversation
recursion128
approved these changes
Sep 1, 2026
There was a problem hiding this comment.
LGTM,改动 approve。
与 Go 侧规范实现一致(Chaintable/pipeline tracer/call_tracer.go:118-128、Chaintable/erigon debank/tracer/tracer.go:193-203):vm.CREATE, vm.CREATE2 统一映射为 CallCreateType = "create",CallType 留空。pipeline/docs/protocol.md:307 也是这么定义的。原来发 "create2" 是移植偏差,这里是在恢复与 geth/erigon 节点的一致性。
debank_id() 只用 tx_id/parent_trace_id/pos 计算,trace id 不受影响。新增的 tests 模块依赖(revm-inspectors 为正式 dependency、CallTrace/CallTraceNode 均有 Default)没问题,格式也是干净的。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
type=createvaluecall_typeempty for contract creation tracesTest
cargo test -p reth-optimism-rpc -F reth-optimism-chainspec/superchain-configs create2_is_normalized_to_create --lib