Repository navigation
fix(client): quote table names in Insert queries - #573
Tyagiquamar wants to merge 1 commit into
Conversation
Client::Insert() now quotes bare and qualified table identifiers so hyphenated or reserved names work without manual backticks. Fixes ClickHouse#560
|
Thanks for looking at #560, but I'm going to close this PR. Two of the problems are blocking and together they indicate the change wasn't tested or reviewed before submission. 1. It breaks an existing test in the same file you edited. client_->Insert(R"sql("test_clickhouse_cpp_col_escape_""name_test")sql", block);
Running 2. It is a silent breaking change to a public API. Please also read
We're happy to take AI-assisted contributions, but the author is expected to have read the diff, understood how the touched code is used elsewhere in the repo, and run the test suite. This PR doesn't meet that bar, so I'm closing it. If you'd like to pick #560 up again, please open a new PR that (a) passes the full |
Summary
Client::Insert()via newTableNameToQueryString()helperdatabase.tableseparatelyFixes #560
Test plan
ubuntu:24.04, clang-18,cmake -DBUILD_TESTS=ON,make -j1) — exit 0Client/ClientCase.InsertQuotesBareTableName/*(2 cases, ClickHouse server on :9000) — PASSED