Skip to content

chore(deps): lock file maintenance and sentry-javascript v11 - #146

Merged
lewisjared merged 4 commits into
mainfrom
chore/lockfile-maintenance
Oct 23, 2026
Merged

lewisjared merged 4 commits into
mainfrom
chore/lockfile-maintenance

Conversation

@lewisjared

@lewisjared lewisjared commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Refreshes the backend and frontend lock files and updates sentry-javascript to v11. This supersedes #125, #129 and #143 (vite is now 8.3.5).

  • climate-ref goes from 0.19.0 to 0.19.2, which adds a migration, so the test database is migrated with scripts/update-test-data.sh.
  • Sentry v11 removes sendDefaultPii. instrument.ts now sets dataCollection with user info, cookies, headers and HTTP bodies off, because the new defaults collect them.
  • Biome 2.6 formats Markdown and adds noComponentHookFactories, so frontend/README.md is reformatted and a test component moves to module level.
  • The Radix bump fixes the Tabs typing, so the stale @ts-expect-error is gone.

Backend has 320 tests passing with ruff and mypy clean. Frontend has 630 tests passing with tsc, Biome and vite build clean. Python 3.15 (#142), recharts v3 (#78) and tanstack table v9 (#75) are left out because each needs real migration work or upstream wheels.

Summary by CodeRabbit

  • Privacy
    • Error reporting is configured not to collect user information, cookies, or HTTP headers.
  • Tests
    • Updated coverage for retrying failed queries; expected retry behaviour is unchanged.
  • Maintenance
    • Updated the error-reporting integration and recorded a climate-ref update.

Bumps climate-ref to 0.19.2 and migrates the test database for its new migration.
- Replaces Sentry's removed `sendDefaultPii` with `dataCollection` so user info, cookies and headers stay off.
- Fixes lint and type errors from the Biome and Radix bumps.
@coderabbitai

coderabbitai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 53 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: eb300acb-7123-4613-a11f-a959523eef65
📥 Commits

Reviewing files that changed from the base of the PR and between 6aebe98 and 24712c0.

📒 Files selected for processing: 1
  • frontend/src/instrument.ts
📝 Walkthrough

The pull request updates Sentry packages and data collection settings. It also refactors an error-boundary test, removes a TypeScript suppression comment, and includes changelog and README edits.

Changes: Sentry dependency update

Layer / File(s) Summary
Sentry packages and configuration
frontend/package.json, frontend/src/instrument.ts, changelog/146.trivial.md
The Sentry React package and Vite plugin change to ^11.8.0. Sentry configuration disables collection of user information, cookies, and HTTP headers. The changelog records the dependency updates.

Frontend test and documentation edits

Layer / File(s) Summary
Error-boundary test and adjacent edits
frontend/src/components/app/errorBoundary.test.tsx, frontend/src/components/ui/tabs.tsx, frontend/README.md, changelog/132.improvement.md
The failed-query reset test uses a shared component that accepts the query function; retry assertions remain unchanged. A TypeScript suppression comment is removed. The README content and log endpoint description are unchanged.

Possibly related issues

  • Climate-REF/ref-app#54 — The issue tracks the Sentry v11 and frontend dependency updates recorded in this pull request.

Priority: ⬇️ Low

Change: Other

Merge Risk: 🔵 Low · up to 6aebe

The Sentry v11 upgrade may collect more browser telemetry than the previous setting did, because categories not listed in the new dataCollection object use v11 defaults. Confirm which categories apply to the browser SDK and set them explicitly, or document the intended policy. The remaining changes are low risk.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (4 skipped: 4… Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title accurately identifies the dependency maintenance and Sentry v11 upgrade, which are the main changes in the pull request.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (4 skipped: 4 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

✨ Finishing Touches: 💡 1
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lewisjared
lewisjared marked this pull request as ready for review October 23, 2026 05:49

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d9c286cd-ce37-41e9-86b0-4eaef6e29dfc
📥 Commits

Reviewing files that changed from the base of the PR and between d472f1c and 6aebe98.

⛔ Files ignored due to path filters: 3
  • backend/tests/test-data/tests.integration.test_cmip7_aft/test_solve_cmip7_aft/db/climate_ref.db is excluded by !**/*.db
  • backend/uv.lock is excluded by !**/*.lock
  • frontend/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing: 7
  • changelog/132.improvement.md
  • changelog/146.trivial.md
  • frontend/README.md
  • frontend/package.json
  • frontend/src/components/app/errorBoundary.test.tsx
  • frontend/src/components/ui/tabs.tsx
  • frontend/src/instrument.ts
💤 Files with no reviewable changes: 1
  • frontend/src/components/ui/tabs.tsx

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Comment thread frontend/src/instrument.ts Resolved
@lewisjared

Copy link
Copy Markdown
Contributor Author

@coderabbitai approve

@coderabbitai

coderabbitai Bot commented Oct 23, 2026

Copy link
Copy Markdown
✅ Action performed

Comments resolved and changes approved.

@lewisjared
lewisjared merged commit 877a9cc into main Oct 23, 2026
5 checks passed
@lewisjared
lewisjared deleted the chore/lockfile-maintenance branch October 23, 2026 10:12
lewisjared added a commit that referenced this pull request Oct 23, 2026
* origin/main:
  fix: stop Sentry collecting HTTP bodies, matching v10 behaviour
  docs: add changelog for #146
  chore(deps): frontend lock file maintenance and sentry-javascript v11
  chore(deps): backend lock file maintenance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant