Skip to content

fix(failures): error paths from #159 and updating dots - #161

Merged
lewisjared merged 3 commits into
mainfrom
fix/failures-review-follow-up
Oct 25, 2026
Merged

lewisjared merged 3 commits into
mainfrom
fix/failures-review-follow-up

Conversation

@lewisjared

@lewisjared lewisjared commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

Fixes two error paths from #159, found in review after it merged, and stops the diagnostic dots showing stale health while new counts load.

  • A failed "Load More" on a diagnostic's passing groups no longer replaces the groups already loaded. The error shows above the button, which retries the page.
  • A failed models request now shows through the page's error alert and "Try again", instead of silently dropping the models without failures from the picker. It does not hide the failures already loaded.
  • Changing the model keeps the previous catalog on screen until the new one arrives, so the dots showed the old filters' health. They now go grey and swell, staggered along each row, and the tooltip says "Updating…". prefers-reduced-motion keeps them still.

Dots grey and swelling while the counts for MIROC6 load

Dots once the counts arrive

A failed Load More now keeps the groups already loaded and shows the error above the button. A failed models request reports through the page's error alert and retry, without hiding the failures.
@coderabbitai

coderabbitai Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 54 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a7221a31-1e7a-4491-82d6-a55ae5fc7a55
Commits

Reviewing files that changed from the base of the PR and between 0d0f43d and fbde286.

Files selected for processing: 9
  • changelog/161.fix.md
  • changelog/161.improvement.md
  • frontend/src/components/failures/health.test.tsx
  • frontend/src/components/failures/health.tsx
  • frontend/src/components/failures/passingGroups.tsx
  • frontend/src/components/failures/providerHealthOverview.tsx
  • frontend/src/components/failures/useFailures.ts
  • frontend/src/routes/_app/executions.failures.tsx
  • frontend/src/styles/global.css
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lewisjared
lewisjared marked this pull request as ready for review October 25, 2026 22:52
Changing the model keeps the previous catalog on screen until the new one arrives, so the dots showed the old filters' health. They now go grey and swell, staggered along each row, until the counts land.
@lewisjared lewisjared changed the title fix(failures): keep loaded passing groups and report model list errors fix(failures): error paths from #159 and updating dots Oct 25, 2026
@lewisjared
lewisjared merged commit 9c480e5 into main Oct 25, 2026
6 checks passed
@lewisjared
lewisjared deleted the fix/failures-review-follow-up branch October 25, 2026 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant