Repository navigation
Fetch error bounds using compression-recommendations - #82
Conversation
a52d57c to
a3e5735
Compare
juntyr
changed the title
treigerm
left a comment
treigerm
left a comment
There was a problem hiding this comment.
Just have two small nits but otherwise LGTM!
| get_agb_bound(datasets, percentiles=[1.00, 0.99, 0.95]) | ||
| get_error_bounds( | ||
| Recommendations( | ||
| recommendations=compute_agb_recommendations( |
There was a problem hiding this comment.
It would be cleaner to let compute_agb_recommendations and compute_no2_recommendations directly return a Recommendations object so that main loop is more concise. Also makes it nicely consistent with the function names.
| else: | ||
| raise ValueError(f"Unknown error bound type: {error_bound_type}") | ||
| try: | ||
| requirements = [ |
There was a problem hiding this comment.
So if I understand correctly this effectively checks whether the variable is available on pressure levels and a KeyError is raised when there is no variable with era5_var on pressure levels? I think a short comment here would be helpful to clarify that the try-except block is used for this purpose.
There was a problem hiding this comment.
I've made it even more explicit by passing into the function whether we need single-level or pressure level requirements
|
@treigerm Thanks for the review, please feel free to squash and merge |
Uh oh!
There was an error while loading. Please reload this page.