London | 26-Sept | Hugh Mills | Sprint 2 | Implement and rewrite tests by HM-127BTY · Pull Request #1670 · CodeYourFuture/Module-Structuring-and-Testing-Data

HM-127BTY · 2026-10-09T19:06:05Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Task code

CYF-1059.

Changelist

I built code while writing tests for the code using node and jest to test.

added in code for checks for J Q K and A

valid single digit card Arbitrary non-card string Incorrect suit

Copied test code for other angles.

Added in test for Basic proper fraction: Numerator < Denominator

Added code for Number cards 2-10

fixed error on numbered cards.

…g () => in my thrown error tests

hackertainment · 2026-10-13T21:23:38Z

Good fixes. You are almost there and just remain the following to do:

https://github.com/CodeYourFuture/Module-Structuring-and-Testing-Data/pull/1670/changes/876923e6e11255836cab2f49b8c08c289a94d51c..ba66435dd5a02031e47416433f8d4d8221886a18#r4261805571
London | 26-Sept | Hugh Mills | Sprint 2 | Implement and rewrite tests #1670 (comment)
London | 26-Sept | Hugh Mills | Sprint 2 | Implement and rewrite tests #1670 (comment)

…itive tests. Changed to to.Throw (...) to ensure test is correct.

… attempt to cover all bases. 17 tests now.

letter for suite - incorrect Lower case - incorrect No input

hackertainment · 2026-10-16T22:08:29Z

About card test cases, the design process could be:

for valid case:

any of 2-9 (single digit number) with valid suit
number 10 (double digit number) with valid suit
J/Q/K with valid suit (because they should return 10)
A with valid suit (because it should specially return 11)

for invalid case:

1 (single digit number) with valid suit
11 (special double digit number) with valid suit
any of 12-99 (double digit number) with valid suit
any B-Z except J/Q/K with valid suit
any invalid face with valid suit
valid suit with valid face (e.g. "♠9")
any invalid face with any invalid suit
any of 2-9 (valid single digit number) with invalid suit
number 10 (valid double digit number) with invalid suit
J/Q/K with invalid suit
A with invalid suit

If you have the above planning before actual coding the test cases, then you can make sure that all combinations would be covered. Similar to my previous comment on #1670 (comment) , draft the test plan in English first, then write the test in code. Once again, please feel free to book a mentored coding session with a volunteer.

I think after you tidy up the test cases in implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js and implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js, this PR should be completed. Thank you for your effort.

…nvalid tests.

…d string. Checking each test to ensure accurate.

…ut. 20 tests in total now.

hackertainment · 2026-10-19T16:22:33Z

+// any B-Z except J/Q/K with valid suit
+test("Incorrect royal face given: 7L", () => {
+  assert.throws(
+    () => getCardValue("7L"),


This should be () => getCardValue("L♦"), I think. I will let you pass this time but please pay attention to detail in the future. Thank you.

hackertainment · 2026-10-19T16:24:03Z

+
+// number 10 (double digit number) with valid suit
+test(`Should return 10 value when given an 10 face card`, () => {
+  expect(getCardValue("2♠")).toEqual(2);


This should be expect(getCardValue("10♠")).toEqual(10);, I think. I will let you pass this time but please pay attention to detail in the future. Thank you.

Woops, thanks and I thought I went through it with a microscope.

hackertainment · 2026-10-19T16:26:52Z

I would mark this PR as completed. Please book a mentored coding session with volunteer if you would like to learn better. Thank you.

HM-127BTY added 30 commits October 7, 2026 18:07

Work on "Right angle"

e8606f9

Added tests for all the angles, next working on code

53621cd

Added code for Acute angle

5721c8b

Added code for Obtuse angle

5e692d8

Added code for Straight angle

b61b4b4

Added code for Reflex angles

7ccf911

Added code for Invalid angle

426aabb

fixed errors and rearranged code to be easier to read

1c3277f

Set up testing requirements for the fractions

c4786d8

Done the code for fractions coving test requests.

707ac48

cleaned up the code

16f4f20

added basic tests needed and non - card string.

e3a8f17

added in code for checks for J Q K and A

working on code and trying to fix errors

ae7ef77

finished code and tests for 3 types:

d4db679

valid single digit card Arbitrary non-card string Incorrect suit

cleaned up errors i encountered .

9970ef6

Added in test for Right angle.

2830bf3

Copied test code for other angles.

Added test for Obtuse angles

c7af1dd

Added test for Straight angles

2fc4cd2

Added tests for Right angles

8662c14

Added tests for Invalid angles

6ae03b0

Added in commented tests to update as I progress though tests.

3727932

Added in test for Basic proper fraction: Numerator < Denominator

Added code for Improper fraction: Numerator = Denominator

5d6c6ef

Added code for Improper fraction: Numerator > Denominator

b155253

Added code for -Numerator > Denominator

6f64f2e

Setup code for more tests.

b37a765

Added code for Number cards 2-10

Added code for return 10 for J, Q, K.

9770764

fixed error on numbered cards.

Added code for throw error invalid card

67f4dd7

Added in testing code for Incorrect Suit and fixed errors with lackin…

77cf05b

…g () => in my thrown error tests

fixing erros in code and including "Incorrect card number" test

3f42554

fixed errors and put in more test code for Incorrect card given

328f3c1

HM-127BTY added 2 commits October 13, 2026 01:34

fixed bug with having two tests doing - numerators.

1a20c17

added both as negative test

ba66435

HM-127BTY added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 13, 2026

hackertainment removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 13, 2026

HM-127BTY added 6 commits October 14, 2026 12:59

Added test for both being 0

cdd5f00

Added tests missing from requests

8b09c49

Fixed spelling error in thrown error.

f78ab0d

Found bug in all toThrow tests, had toThrow; so was getting false pos…

7046cb7

…itive tests. Changed to to.Throw (...) to ensure test is correct.

Organized order of tests to be easier to follow, added extra tests to…

57ae03a

… attempt to cover all bases. 17 tests now.

Added tests for:

9154abe

letter for suite - incorrect Lower case - incorrect No input

HM-127BTY added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 16, 2026

HM-127BTY added 11 commits October 19, 2026 13:28

Making adjustments of tests in order as suggested. Added in missing i…

6d9296b

…nvalid tests.

Made changes to first error so it throws Invalid on Arbitrary non-car…

a2ea421

…d string. Checking each test to ensure accurate.

Valid cards testing completed

bf56576

changed "incorrect card number given" to "Incorrect face given"

4a80e95

Done all tests for node-test

105d594

Started organizing jest tests

c54a4c1

Tests done for valid cards

b5f439a

Working on adding in invalid case tests.

5ad5c2a

Adding more tests to Invalid options.

0ab03d7

Done adding in new tests, now cleaning up older ones.

d32864f

All done adding in new tests and cleaning up older ones with nwe layo…

951e3a0

…ut. 20 tests in total now.

hackertainment reviewed Oct 19, 2026

View reviewed changes

Navigation Menu

Repository navigation

London | 26-Sept | Hugh Mills | Sprint 2 | Implement and rewrite tests - #1670

London | 26-Sept | Hugh Mills | Sprint 2 | Implement and rewrite tests#1670
HM-127BTY wants to merge 60 commits into
CodeYourFuture:mainfrom
HM-127BTY:coursework/sprint-2-implement-and-rewrite

HM-127BTY commented Oct 9, 2026

Uh oh!

hackertainment commented Oct 13, 2026

Uh oh!

hackertainment commented Oct 16, 2026

Uh oh!

hackertainment Oct 19, 2026

Uh oh!

hackertainment Oct 19, 2026

Uh oh!

HM-127BTY Oct 19, 2026

Uh oh!

hackertainment commented Oct 19, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

HM-127BTY commented Oct 9, 2026

Learners, PR Template

Task code

Changelist

Uh oh!

hackertainment commented Oct 13, 2026

Uh oh!

hackertainment commented Oct 16, 2026

Uh oh!

hackertainment Oct 19, 2026

Choose a reason for hiding this comment

Uh oh!

hackertainment Oct 19, 2026

Choose a reason for hiding this comment

Uh oh!

HM-127BTY Oct 19, 2026

Choose a reason for hiding this comment

Uh oh!

hackertainment commented Oct 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

hackertainment commented Oct 19, 2026 •

edited

Loading