Skip to content

Manchester | 26-ITP-Sep | Gustarv Nchitu | Sprint 1 | Format Clock Edge Cases #1671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jestavo1 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Manchester | 26-ITP-Sep | Gustarv Nchitu | Sprint 1 | Format Clock Edge Cases #1671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions format-clock-edge-cases/timeConverter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,21 @@
function formatAs12HourClock(time) {

const hours = Number(time.slice(0, 2));
const minutes = time.slice(3);

if (hours === 0) {
return `12:${minutes} am`;
}

if (hours === 12) {
return `${time} pm`;
}

if (hours > 12) {
return `${hours - 12}:00 pm`;
return `${hours - 12}:${minutes} pm`;
}

return `${time} am`;
}

export {formatAs12HourClock};
export {formatAs12HourClock};
22 changes: 22 additions & 0 deletions format-clock-edge-cases/timeConverter.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,25 @@ test("correctly convert time after 12:00", function(){
test("can correctly convert morning time", function() {
assert.equal(formatAs12HourClock("08:00"), "08:00 am");
});

test("correctly convert midnight", function() {
assert.equal(formatAs12HourClock("00:00"), "12:00 am");
});
test("correctly convert noon", function() {
assert.equal(formatAs12HourClock("12:00"), "12:00 pm");
});
test("correctly convert 13:00", function() {
assert.equal(formatAs12HourClock("13:00"), "1:00 pm");
});
test("correctly keep the minutes", function() {
assert.equal(formatAs12HourClock("13:45"), "1:45 pm");
});
Comment on lines +19 to +24

@hackertainment hackertainment Oct 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the test case in lines 9-11 provided by the question, there should be leading 0 for the hours with single digit. So please fix your code and test cases as well. Thank you.

test("correctly convert 12:30", function() {
assert.equal(formatAs12HourClock("12:30"), "12:30 pm");
});
test("correctly convert the last minute of the day", function() {
assert.equal(formatAs12HourClock("23:59"), "11:59 pm");
});
test("correctly convert 00:30", function() {
assert.equal(formatAs12HourClock("00:30"), "12:30 am");
});
Loading