Skip to content

Manchester | 26-ITP-Sep | Mathew Shaibu | Sprint 2 | Coursework/sprint 2 implement and rewrite - #1673

Open
MattCarolus10 wants to merge 105 commits into
CodeYourFuture:mainfrom
MattCarolus10:coursework/sprint-3-implement-and-rewrite
Open

Manchester | 26-ITP-Sep | Mathew Shaibu | Sprint 2 | Coursework/sprint 2 implement and rewrite#1673
MattCarolus10 wants to merge 105 commits into
CodeYourFuture:mainfrom
MattCarolus10:coursework/sprint-3-implement-and-rewrite

Conversation

@MattCarolus10

@MattCarolus10 MattCarolus10 commented Oct 10, 2026 •
edited
Loading

Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Task code

CYF-1059

Changelist

-implement isValidPassword function with checks for length, previous passwords array, uppercase, lowercase, numbers, and allowed symbols

  • add unit tests covering each password validation rule using jest
  • ensure test cases use fully compliant passwords so all individual rule assertions pass

@MattCarolus10
add empty lines for better readability in angle type tests
ce76c0b
@MattCarolus10
implement getAngleType function to return "Right angle" for 90°
eb2d17d
@MattCarolus10
add test case for classifying acute angles in getAngleType function
56c856c
@MattCarolus10
implement getAngleType function to return "Acute angle" for angles be…
2e4e5e1 
…tween 0° and 90°
@MattCarolus10
add test case for classifying obtuse angles in getAngleType function
fd1f878
@MattCarolus10
implement getAngleType function to return "Obtuse angle" for angles b…
67bf79b 
…etween 90° and 180°
@MattCarolus10
add test case for classifying straight angles in getAngleType function
b1a6630
@MattCarolus10
fix: correct expected output for straight angle classification test
db4a27e
@MattCarolus10
fix: return "Straight angle" for angle equal to 180°
7e8ad2f
@MattCarolus10
add test case for classifying reflex angles in getAngleType function
eeb2846
@MattCarolus10
fix: add missing semicolons in getAngleType function
1807a2d
@MattCarolus10
fix: add missing semicolons and correct test syntax in angle classifi…
ad85b14 
…cation tests
@MattCarolus10
fix: add missing semicolons and format test cases in angle classifica…
325a7ee 
…tion tests
@MattCarolus10
fix: update invalid angle classification in getAngleType function
2d57566
@MattCarolus10
fix: update invalid angle test case in getAngleType function
69af44c
@MattCarolus10
feat: implement isProperFraction function to evaluate proper fractions
3eb0813
@MattCarolus10
fix: correct isProperFraction logic to return boolean values
41d025e
@MattCarolus10
fix: correct assertion in isProperFraction test to match expected boo…
115eb01 
…lean value
@MattCarolus10
fix: correct return value in isProperFraction function to return bool…
e029b5a 
…ean true
@MattCarolus10
fix: return boolean true in isProperFraction function instead of string
55d9b0f
@MattCarolus10
fix: update isProperFraction logic to correctly evaluate proper fract…
09732da 
…ions
@MattCarolus10
test: add assertion for improper fraction case in isProperFraction test
268b7e4
@MattCarolus10
test: add additional test cases for isProperFraction function
f02a167
@MattCarolus10
test: add assertion for negative numerator case in isProperFraction test
f423445
@MattCarolus10
test: add assertion for negative denominator case in isProperFraction…
3f5bc58 
… test
@MattCarolus10
fix: refine isProperFraction logic to handle negative numerator and d…
388bb92 
…enominator cases
@MattCarolus10
refactor: remove unnecessary blank line in isProperFraction test
addec7e
@MattCarolus10
refactor: improve formatting and consistency in isProperFraction func…
7b32fd3 
…tion
@MattCarolus10
refactor: remove unnecessary comments from isProperFraction implement…
3007cee 
…ation
@MattCarolus10
refactor: remove TODO comments from isProperFraction test file
7335f61
@MattCarolus10
refactor: remove redundant comments from repeatStr test cases
171b264
@MattCarolus10
refactor: remove redundant comments from getOrdinalNumber test file
a4b8f77
@MattCarolus10
refactor: remove redundant comments from countChar test file
b7bd710
@MattCarolus10
refactor: remove TODO comments and suggestions from getCardValue test…
5de7ae0 
… file
@MattCarolus10
refactor: remove TODO comment and clean up test formatting in isPrope…
a2cb8ad 
…rFraction test file
@MattCarolus10
refactor: remove TODO comments and clean up test cases in getAngleTyp…
f97fa01 
…e test file
@MattCarolus10
refactor: remove TODO comments from getAngleType test file
208e10a
@MattCarolus10
refactor: remove unnecessary comments from getAngleType function
a13105a
@MattCarolus10
refactor: add test case for password containing at least one uppercas…
d8e8974 
…e letter
@MattCarolus10
refactor: add test case for password containing at least one lowercas…
8b50775 
…e letter
@MattCarolus10
refactor: add test case for password containing at least one number
34edfce
@MattCarolus10
refactor: add test case for password containing at least one special …
a0fc1e8 
…non-alphanumeric symbol
@MattCarolus10
refactor: clean up test case formatting for password validation
4b5f2f7
@MattCarolus10
refactor: add test case to ensure password is not a previous password
88908c7
@MattCarolus10
refactor: update isValidPassword function to accept an additional par…
36105df 
…ameter for password history
@MattCarolus10
refactor: fix isValidPassword function to correctly check for previou…
5337940 
…s passwords
@MattCarolus10
refactor: fix parameter name in isValidPassword function for clarity
8849988
@MattCarolus10
refactor: fix condition in isValidPassword function to check against …
570fb97 
…password history
@MattCarolus10
refactor: improve readability by adjusting whitespace in isValidPassw…
3cabf33 
…ord function
@MattCarolus10
refactor: fix formatting issues in isValidPassword function for consi…
7fec32a 
…stency
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@MattCarolus10 MattCarolus10 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 10, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 10, 2026
@MattCarolus10 MattCarolus10 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 10, 2026
@MattCarolus10 MattCarolus10 changed the title Manchester | 26-ITP-Sep | Mathew Shaibu | Sprint 3 | Coursework/sprint 3 implement and rewrite Manchester | 26-ITP-Sep | Mathew Shaibu | Sprint 2 | Coursework/sprint 2 implement and rewrite Oct 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@MattCarolus10