Skip to content

Manchester | 26-ITP-Sept | Aklilu Mihtsun | Sprint 2 | Implement and rewrite tests - #1690

Open
AkliluMihtsun wants to merge 19 commits into
CodeYourFuture:mainfrom
AkliluMihtsun:coursework/sprint-3-implement-and-rewrite
Open

Manchester | 26-ITP-Sept | Aklilu Mihtsun | Sprint 2 | Implement and rewrite tests#1690
AkliluMihtsun wants to merge 19 commits into
CodeYourFuture:mainfrom
AkliluMihtsun:coursework/sprint-3-implement-and-rewrite

Conversation

@AkliluMihtsun

@AkliluMihtsun AkliluMihtsun commented Oct 12, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Task code

CYF-1059

Changelist

I have implemented node and jest tests for different cases

@github-actions

This comment has been minimized.

Sign in to view
@AkliluMihtsun AkliluMihtsun added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 12, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 12, 2026
@AkliluMihtsun AkliluMihtsun added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 12, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 12, 2026
@AkliluMihtsun AkliluMihtsun added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 12, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 12, 2026
@AkliluMihtsun AkliluMihtsun added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 12, 2026
@hackertainment hackertainment added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 18, 2026
hackertainment
hackertainment reviewed Oct 18, 2026
View reviewed changes

@hackertainment hackertainment left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In summary, while you may have a couple of issues here and there to fix, your code is really very clean and your programming logic is so clear as well. Keep this up and you will be an excellent developer.

Comment thread implement-and-rewrite-tests/implement/1-get-angle-type.js
Comment thread implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js Outdated
Comment thread implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js Outdated
Comment thread implement-and-rewrite-tests/implement/2-is-proper-fraction.js
Comment thread implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js
Comment thread implement-and-rewrite-tests/implement-tests-with-node-test/2-is-proper-fraction.test.js
Comment thread implement-and-rewrite-tests/implement/3-get-card-value.js
Comment thread implement-and-rewrite-tests/implement/3-get-card-value.js
Comment thread implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js
Comment thread implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js
@hackertainment hackertainment mentioned this pull request Oct 18, 2026
Open
@hackertainment hackertainment added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Oct 19, 2026
@AkliluMihtsun AkliluMihtsun added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 20, 2026
@hackertainment

hackertainment commented Oct 20, 2026 •
edited
Loading

Copy link
Copy Markdown

I did not see any code updates. Can you confirm whether your updates were staged and committed? Thank you.

@hackertainment hackertainment removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 20, 2026
@AkliluMihtsun

AkliluMihtsun commented Oct 20, 2026

Copy link
Copy Markdown
Author

I did not see any code updates Can you confirm whether your updates were staged and committed? Thank you.

my bad.... I have pushed it now

@AkliluMihtsun AkliluMihtsun added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 20, 2026
@hackertainment

hackertainment commented Oct 20, 2026

Copy link
Copy Markdown

Congratulation, you have completed this PR successfully.

@hackertainment hackertainment added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@hackertainment hackertainment hackertainment left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AkliluMihtsun @hackertainment